All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtd: spi-nor: add Macronix mx25u25635f to list of known devices.
@ 2016-11-18 10:12 Ash Benz
  2016-11-18 11:03 ` Rafał Miłecki
  0 siblings, 1 reply; 3+ messages in thread
From: Ash Benz @ 2016-11-18 10:12 UTC (permalink / raw)
  To: linux-mtd; +Cc: Ash Benz

Signed-off-by: Ash Benz <ash.benz@bk.ru>
---
 drivers/mtd/spi-nor/spi-nor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d0fc165..171adb3 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -872,6 +872,7 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
 	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
 	{ "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
+	{ "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, 0) },
 	{ "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
 	{ "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
 	{ "mx66l1g55g",  INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: spi-nor: add Macronix mx25u25635f to list of known devices.
  2016-11-18 10:12 [PATCH] mtd: spi-nor: add Macronix mx25u25635f to list of known devices Ash Benz
@ 2016-11-18 11:03 ` Rafał Miłecki
  2016-11-18 23:54   ` A. Benz
  0 siblings, 1 reply; 3+ messages in thread
From: Rafał Miłecki @ 2016-11-18 11:03 UTC (permalink / raw)
  To: Ash Benz; +Cc: linux-mtd

On 18 November 2016 at 11:12, Ash Benz <ash.benz@bk.ru> wrote:
> Signed-off-by: Ash Benz <ash.benz@bk.ru>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index d0fc165..171adb3 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -872,6 +872,7 @@ static const struct flash_info spi_nor_ids[] = {
>         { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>         { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
>         { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
> +       { "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, 0) },
>         { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
>         { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
>         { "mx66l1g55g",  INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },

Please keep this list sorted.

Are you sure this chip doesn't support 4 k sections? Datasheets says:
"Equal Sectors with 4K byte each, or Equal Blocks with 32K byte each
or Equal Blocks with 64K byte each "

-- 
Rafał

On 18 November 2016 at 11:12, Ash Benz <ash.benz@bk.ru> wrote:
> Signed-off-by: Ash Benz <ash.benz@bk.ru>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index d0fc165..171adb3 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -872,6 +872,7 @@ static const struct flash_info spi_nor_ids[] = {
>         { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>         { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
>         { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
> +       { "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, 0) },
>         { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
>         { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
>         { "mx66l1g55g",  INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },
> --
> 2.10.2
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/



-- 
Rafał

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: spi-nor: add Macronix mx25u25635f to list of known devices.
  2016-11-18 11:03 ` Rafał Miłecki
@ 2016-11-18 23:54   ` A. Benz
  0 siblings, 0 replies; 3+ messages in thread
From: A. Benz @ 2016-11-18 23:54 UTC (permalink / raw)
  To: Rafał Miłecki; +Cc: linux-mtd

Hi Rafał,

I sent a v2 with 4k sect.
Regarding sort, the list is already unsorted, it seems models that are 
very similar are put next to each other.

Regards,
A. Benz

On 11/18/16 19:03, Rafał Miłecki wrote:
> On 18 November 2016 at 11:12, Ash Benz <ash.benz@bk.ru> wrote:
>> Signed-off-by: Ash Benz <ash.benz@bk.ru>
>> ---
>>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index d0fc165..171adb3 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -872,6 +872,7 @@ static const struct flash_info spi_nor_ids[] = {
>>         { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>>         { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
>>         { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
>> +       { "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, 0) },
>>         { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
>>         { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
>>         { "mx66l1g55g",  INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },
>
> Please keep this list sorted.
>
> Are you sure this chip doesn't support 4 k sections? Datasheets says:
> "Equal Sectors with 4K byte each, or Equal Blocks with 32K byte each
> or Equal Blocks with 64K byte each "
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-18 23:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-18 10:12 [PATCH] mtd: spi-nor: add Macronix mx25u25635f to list of known devices Ash Benz
2016-11-18 11:03 ` Rafał Miłecki
2016-11-18 23:54   ` A. Benz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.