* [PATCH] drm/i915: Try to group more logically in intel_dump_pipe_config
@ 2016-11-18 11:19 Tvrtko Ursulin
2016-11-18 12:56 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-11-21 10:44 ` [PATCH] " Tvrtko Ursulin
0 siblings, 2 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2016-11-18 11:19 UTC (permalink / raw)
To: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Keep parameters relating to the pipe and crtc respectively together.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 200f09778776..155910c93896 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12739,9 +12739,14 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
DRM_DEBUG_KMS("[CRTC:%d:%s]%s\n",
crtc->base.base.id, crtc->base.name, context);
- DRM_DEBUG_KMS("cpu_transcoder: %s, pipe bpp: %i, dithering: %i\n",
+ DRM_DEBUG_KMS("cpu_transcoder: %s, port clock: %d, ips: %i\n",
transcoder_name(pipe_config->cpu_transcoder),
- pipe_config->pipe_bpp, pipe_config->dither);
+ pipe_config->port_clock, pipe_config->ips_enabled);
+
+ DRM_DEBUG_KMS("pipe src size: %dx%d, bpp: %i, dithering: %i, double wide: %i\n",
+ pipe_config->pipe_src_w, pipe_config->pipe_src_h,
+ pipe_config->pipe_bpp, pipe_config->dither,
+ pipe_config->double_wide);
if (pipe_config->has_pch_encoder)
intel_dump_m_n_config(pipe_config, "fdi",
@@ -12765,9 +12770,6 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
DRM_DEBUG_KMS("adjusted mode:\n");
drm_mode_debug_printmodeline(&pipe_config->base.adjusted_mode);
intel_dump_crtc_timings(&pipe_config->base.adjusted_mode);
- DRM_DEBUG_KMS("port clock: %d, pipe src size: %dx%d\n",
- pipe_config->port_clock,
- pipe_config->pipe_src_w, pipe_config->pipe_src_h);
if (INTEL_GEN(dev_priv) >= 9)
DRM_DEBUG_KMS("num_scalers: %d, scaler_users: 0x%x, scaler_id: %d\n",
@@ -12786,9 +12788,6 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
pipe_config->pch_pfit.size,
enableddisabled(pipe_config->pch_pfit.enabled));
- DRM_DEBUG_KMS("ips: %i, double wide: %i\n",
- pipe_config->ips_enabled, pipe_config->double_wide);
-
if (IS_BROXTON(dev_priv)) {
DRM_DEBUG_KMS("dpll_hw_state: ebb0: 0x%x, ebb4: 0x%x,"
"pll0: 0x%x, pll1: 0x%x, pll2: 0x%x, pll3: 0x%x, "
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ Fi.CI.BAT: failure for drm/i915: Try to group more logically in intel_dump_pipe_config
2016-11-18 11:19 [PATCH] drm/i915: Try to group more logically in intel_dump_pipe_config Tvrtko Ursulin
@ 2016-11-18 12:56 ` Patchwork
2016-11-21 10:44 ` [PATCH] " Tvrtko Ursulin
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-11-18 12:56 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Try to group more logically in intel_dump_pipe_config
URL : https://patchwork.freedesktop.org/series/15547/
State : failure
== Summary ==
Series 15547v1 drm/i915: Try to group more logically in intel_dump_pipe_config
https://patchwork.freedesktop.org/api/1.0/series/15547/revisions/1/mbox/
Test gem_ringfill:
Subgroup basic-default-hang:
pass -> INCOMPLETE (fi-ivb-3520m)
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40
fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53
fi-ivb-3520m total:115 pass:101 dwarn:0 dfail:0 fail:0 skip:13
fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21
fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21
fi-skl-6770hq total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-snb-2520m total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33
9debbae8dd870123be84e5501dbc9c88cbe32c68 drm-intel-nightly: 2016y-11m-18d-11h-48m-38s UTC integration manifest
c05b1fb drm/i915: Try to group more logically in intel_dump_pipe_config
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3052/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Try to group more logically in intel_dump_pipe_config
2016-11-18 11:19 [PATCH] drm/i915: Try to group more logically in intel_dump_pipe_config Tvrtko Ursulin
2016-11-18 12:56 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-11-21 10:44 ` Tvrtko Ursulin
2016-11-21 15:11 ` Ville Syrjälä
1 sibling, 1 reply; 4+ messages in thread
From: Tvrtko Ursulin @ 2016-11-21 10:44 UTC (permalink / raw)
To: Tvrtko Ursulin, Intel-gfx, Ville Syrjälä
On 18/11/2016 11:19, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Keep parameters relating to the pipe and crtc respectively together.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 200f09778776..155910c93896 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12739,9 +12739,14 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
> DRM_DEBUG_KMS("[CRTC:%d:%s]%s\n",
> crtc->base.base.id, crtc->base.name, context);
>
> - DRM_DEBUG_KMS("cpu_transcoder: %s, pipe bpp: %i, dithering: %i\n",
> + DRM_DEBUG_KMS("cpu_transcoder: %s, port clock: %d, ips: %i\n",
> transcoder_name(pipe_config->cpu_transcoder),
> - pipe_config->pipe_bpp, pipe_config->dither);
> + pipe_config->port_clock, pipe_config->ips_enabled);
> +
> + DRM_DEBUG_KMS("pipe src size: %dx%d, bpp: %i, dithering: %i, double wide: %i\n",
> + pipe_config->pipe_src_w, pipe_config->pipe_src_h,
> + pipe_config->pipe_bpp, pipe_config->dither,
> + pipe_config->double_wide);
Better grouping yay/nay? :)
Regards,
Tvrtko
>
> if (pipe_config->has_pch_encoder)
> intel_dump_m_n_config(pipe_config, "fdi",
> @@ -12765,9 +12770,6 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
> DRM_DEBUG_KMS("adjusted mode:\n");
> drm_mode_debug_printmodeline(&pipe_config->base.adjusted_mode);
> intel_dump_crtc_timings(&pipe_config->base.adjusted_mode);
> - DRM_DEBUG_KMS("port clock: %d, pipe src size: %dx%d\n",
> - pipe_config->port_clock,
> - pipe_config->pipe_src_w, pipe_config->pipe_src_h);
>
> if (INTEL_GEN(dev_priv) >= 9)
> DRM_DEBUG_KMS("num_scalers: %d, scaler_users: 0x%x, scaler_id: %d\n",
> @@ -12786,9 +12788,6 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
> pipe_config->pch_pfit.size,
> enableddisabled(pipe_config->pch_pfit.enabled));
>
> - DRM_DEBUG_KMS("ips: %i, double wide: %i\n",
> - pipe_config->ips_enabled, pipe_config->double_wide);
> -
> if (IS_BROXTON(dev_priv)) {
> DRM_DEBUG_KMS("dpll_hw_state: ebb0: 0x%x, ebb4: 0x%x,"
> "pll0: 0x%x, pll1: 0x%x, pll2: 0x%x, pll3: 0x%x, "
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Try to group more logically in intel_dump_pipe_config
2016-11-21 10:44 ` [PATCH] " Tvrtko Ursulin
@ 2016-11-21 15:11 ` Ville Syrjälä
0 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2016-11-21 15:11 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: Intel-gfx
On Mon, Nov 21, 2016 at 10:44:46AM +0000, Tvrtko Ursulin wrote:
>
>
> On 18/11/2016 11:19, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > Keep parameters relating to the pipe and crtc respectively together.
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 15 +++++++--------
> > 1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 200f09778776..155910c93896 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -12739,9 +12739,14 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
> > DRM_DEBUG_KMS("[CRTC:%d:%s]%s\n",
> > crtc->base.base.id, crtc->base.name, context);
> >
> > - DRM_DEBUG_KMS("cpu_transcoder: %s, pipe bpp: %i, dithering: %i\n",
> > + DRM_DEBUG_KMS("cpu_transcoder: %s, port clock: %d, ips: %i\n",
> > transcoder_name(pipe_config->cpu_transcoder),
> > - pipe_config->pipe_bpp, pipe_config->dither);
> > + pipe_config->port_clock, pipe_config->ips_enabled);
> > +
> > + DRM_DEBUG_KMS("pipe src size: %dx%d, bpp: %i, dithering: %i, double wide: %i\n",
> > + pipe_config->pipe_src_w, pipe_config->pipe_src_h,
> > + pipe_config->pipe_bpp, pipe_config->dither,
> > + pipe_config->double_wide);
>
>
> Better grouping yay/nay? :)
Looks a lot like random shuffling.
I would suggest we just leave it as is for now. If I get
sufficiently annoyed at it when looking at bugs, I might come
up with something more sensible.
>
> Regards,
>
> Tvrtko
>
> >
> > if (pipe_config->has_pch_encoder)
> > intel_dump_m_n_config(pipe_config, "fdi",
> > @@ -12765,9 +12770,6 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
> > DRM_DEBUG_KMS("adjusted mode:\n");
> > drm_mode_debug_printmodeline(&pipe_config->base.adjusted_mode);
> > intel_dump_crtc_timings(&pipe_config->base.adjusted_mode);
> > - DRM_DEBUG_KMS("port clock: %d, pipe src size: %dx%d\n",
> > - pipe_config->port_clock,
> > - pipe_config->pipe_src_w, pipe_config->pipe_src_h);
> >
> > if (INTEL_GEN(dev_priv) >= 9)
> > DRM_DEBUG_KMS("num_scalers: %d, scaler_users: 0x%x, scaler_id: %d\n",
> > @@ -12786,9 +12788,6 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
> > pipe_config->pch_pfit.size,
> > enableddisabled(pipe_config->pch_pfit.enabled));
> >
> > - DRM_DEBUG_KMS("ips: %i, double wide: %i\n",
> > - pipe_config->ips_enabled, pipe_config->double_wide);
> > -
> > if (IS_BROXTON(dev_priv)) {
> > DRM_DEBUG_KMS("dpll_hw_state: ebb0: 0x%x, ebb4: 0x%x,"
> > "pll0: 0x%x, pll1: 0x%x, pll2: 0x%x, pll3: 0x%x, "
> >
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-21 15:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-18 11:19 [PATCH] drm/i915: Try to group more logically in intel_dump_pipe_config Tvrtko Ursulin
2016-11-18 12:56 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-11-21 10:44 ` [PATCH] " Tvrtko Ursulin
2016-11-21 15:11 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.