From: Rob Herring <robh@kernel.org> To: c_traja@qti.qualcomm.com Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, tamizhchelvam@codeaurora.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt Date: Fri, 18 Nov 2016 08:44:06 -0600 [thread overview] Message-ID: <20161118144406.3se7gnckhcmwqytp@rob-hp-laptop> (raw) In-Reply-To: <1479383064-25718-4-git-send-email-c_traja@qti.qualcomm.com> On Thu, Nov 17, 2016 at 05:14:23PM +0530, c_traja@qti.qualcomm.com wrote: > From: Tamizh chelvam <tamizhchelvam@codeaurora.org> > > There two things done in this patch. > > 1) 'btcoex_support' flag for BTCOEX feature support by the hardware. > 2) 'wlan_btcoex_gpio' is used to fill wlan priority pin number for > BTCOEX priority feature support. > > Signed-off-by: Tamizh chelvam <tamizhchelvam@codeaurora.org> > --- > .../bindings/net/wireless/qcom,ath10k.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > index 74d7f0a..08150e2d 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > @@ -46,6 +46,10 @@ Optional properties: > hw versions. > - qcom,ath10k-pre-calibration-data : pre calibration data as an array, > the length can vary between hw versions. > +- btcoex_support : should contain eithr "0" or "1" to indicate btcoex > + support by the hardware. This is BT coexistence? Make this boolean and n > +- btcoex_gpio_pin : btcoex gpio pin number for the device which > + supports BTCOEX. This is a pin number on the chip, not any pin number Linux GPIO subsys cares about, right? Is there a connection to the host too, or this is internal between BT and WiFi? Do you really need 2 properties? Does supporting this feature require the GPIO? If so, then the first property is redundant. Needs vendor prefix and don't use '_'. Should be something like 'qcom,bt-coexist-gpio-pin'. Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: c_traja@qti.qualcomm.com Cc: tamizhchelvam@codeaurora.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt Date: Fri, 18 Nov 2016 08:44:06 -0600 [thread overview] Message-ID: <20161118144406.3se7gnckhcmwqytp@rob-hp-laptop> (raw) In-Reply-To: <1479383064-25718-4-git-send-email-c_traja@qti.qualcomm.com> On Thu, Nov 17, 2016 at 05:14:23PM +0530, c_traja@qti.qualcomm.com wrote: > From: Tamizh chelvam <tamizhchelvam@codeaurora.org> > > There two things done in this patch. > > 1) 'btcoex_support' flag for BTCOEX feature support by the hardware. > 2) 'wlan_btcoex_gpio' is used to fill wlan priority pin number for > BTCOEX priority feature support. > > Signed-off-by: Tamizh chelvam <tamizhchelvam@codeaurora.org> > --- > .../bindings/net/wireless/qcom,ath10k.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > index 74d7f0a..08150e2d 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > @@ -46,6 +46,10 @@ Optional properties: > hw versions. > - qcom,ath10k-pre-calibration-data : pre calibration data as an array, > the length can vary between hw versions. > +- btcoex_support : should contain eithr "0" or "1" to indicate btcoex > + support by the hardware. This is BT coexistence? Make this boolean and n > +- btcoex_gpio_pin : btcoex gpio pin number for the device which > + supports BTCOEX. This is a pin number on the chip, not any pin number Linux GPIO subsys cares about, right? Is there a connection to the host too, or this is internal between BT and WiFi? Do you really need 2 properties? Does supporting this feature require the GPIO? If so, then the first property is redundant. Needs vendor prefix and don't use '_'. Should be something like 'qcom,bt-coexist-gpio-pin'. Rob _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-11-18 14:44 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-17 11:44 [PATCHv2 0/4] ath10k: Add support for BTCOEX feature c_traja 2016-11-17 11:44 ` c_traja 2016-11-17 11:44 ` c_traja 2016-11-17 11:44 ` [PATCHv2 1/4] ath10k: Add support to enable or disable btcoex via nl80211 c_traja 2016-11-17 11:44 ` c_traja 2016-11-17 11:44 ` c_traja 2016-11-17 13:51 ` kbuild test robot 2016-11-17 13:51 ` kbuild test robot 2016-11-17 13:51 ` kbuild test robot 2016-11-17 11:44 ` [PATCHv2 2/4] ath10k: Add support to update btcoex priority value " c_traja 2016-11-17 11:44 ` c_traja 2016-11-17 11:44 ` c_traja 2016-11-17 14:36 ` kbuild test robot 2016-11-17 14:36 ` kbuild test robot 2016-11-17 14:36 ` kbuild test robot 2016-11-17 11:44 ` [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt c_traja 2016-11-17 11:44 ` [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom, ath10k.txt c_traja 2016-11-17 11:44 ` [PATCHv2 3/4] dt: bindings: add new dt entry for BTCOEX feature in qcom,ath10k.txt c_traja-Rm6X0d1/PG5y9aJCnZT0Uw 2016-11-18 14:44 ` Rob Herring [this message] 2016-11-18 14:44 ` Rob Herring 2016-11-23 10:20 ` Tamizh chelvam 2016-11-23 10:20 ` Tamizh chelvam 2016-11-23 10:20 ` Tamizh chelvam 2016-11-17 11:44 ` [PATCHv2 4/4] ath10k: Add support to read btcoex related data from DT c_traja 2016-11-17 11:44 ` c_traja 2016-11-17 11:44 ` c_traja-Rm6X0d1/PG5y9aJCnZT0Uw
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161118144406.3se7gnckhcmwqytp@rob-hp-laptop \ --to=robh@kernel.org \ --cc=ath10k@lists.infradead.org \ --cc=c_traja@qti.qualcomm.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=tamizhchelvam@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.