All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cantarell-fonts: add inherit pkgconfig to get pkgconfig dependency
@ 2016-11-18 19:37 Cody P Schafer
  2016-11-18 20:12 ` Burton, Ross
  0 siblings, 1 reply; 2+ messages in thread
From: Cody P Schafer @ 2016-11-18 19:37 UTC (permalink / raw)
  To: openembedded-core

Without this, do_configure can fail with:

	| ../git/configure: line 2381: syntax error near unexpected token `0.19'
	| ../git/configure: line 2381: `PKG_PROG_PKG_CONFIG(0.19)'

If pkgconfig-native happens to be added to the sysroot too late.

Signed-off-by: Cody P Schafer <dev@codyps.com>
---
 meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
index e3e4cde..c71ab11 100644
--- a/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
+++ b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
@@ -18,7 +18,7 @@ UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(?!0\.13)(?!0\.10\.1)\d+\.\d+(\.\d+)+)"
 
 S = "${WORKDIR}/git"
 
-inherit autotools allarch fontcache
+inherit autotools allarch fontcache pkgconfig
 
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[fontforge] = "--enable-source-rebuild=yes,--enable-source-rebuild=no,fontforge-native"
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cantarell-fonts: add inherit pkgconfig to get pkgconfig dependency
  2016-11-18 19:37 [PATCH] cantarell-fonts: add inherit pkgconfig to get pkgconfig dependency Cody P Schafer
@ 2016-11-18 20:12 ` Burton, Ross
  0 siblings, 0 replies; 2+ messages in thread
From: Burton, Ross @ 2016-11-18 20:12 UTC (permalink / raw)
  To: Cody P Schafer; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

On 18 November 2016 at 19:37, Cody P Schafer <dev@codyps.com> wrote:

> Without this, do_configure can fail with:
>
>         | ../git/configure: line 2381: syntax error near unexpected token
> `0.19'
>         | ../git/configure: line 2381: `PKG_PROG_PKG_CONFIG(0.19)'
>
> If pkgconfig-native happens to be added to the sysroot too late.
>

Looking at upstream's configure there's no reason why it calls that macro,
so you could submit a patch to remove that line upstream and then just bump
the SRCREV.

Ross

[-- Attachment #2: Type: text/html, Size: 955 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-18 20:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-18 19:37 [PATCH] cantarell-fonts: add inherit pkgconfig to get pkgconfig dependency Cody P Schafer
2016-11-18 20:12 ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.