* [PATCH v2] dmaengine: sun6i: fix the uninitialized value for v_lli
@ 2016-11-19 16:43 Hao Zhang
2016-11-25 6:19 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Hao Zhang @ 2016-11-19 16:43 UTC (permalink / raw)
To: vinod.koul, dan.j.williams, wens, maxime.ripard
Cc: dmaengine, linux-kernel, kernel, hao5781286
dma_pool_alloc does not initialize the value of the newly allocated
block for the v_lli, and the uninitilize value make the tests failed
which is on pine64 with dmatest.
we can fix it just change the "|=" to "=" for the v_lli->cfg.
Signed-off-by: Hao Zhang <hao5781286@gmail.com>
---
v1: https://www.spinics.net/lists/arm-kernel/msg539966.html
Changes in v1:
-Remove ARM and add spaces after each tag in the title
drivers/dma/sun6i-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
index 8346199..a235878 100644
--- a/drivers/dma/sun6i-dma.c
+++ b/drivers/dma/sun6i-dma.c
@@ -578,7 +578,7 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_dma_memcpy(
burst = convert_burst(8);
width = convert_buswidth(DMA_SLAVE_BUSWIDTH_4_BYTES);
- v_lli->cfg |= DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) |
+ v_lli->cfg = DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) |
DMA_CHAN_CFG_DST_DRQ(DRQ_SDRAM) |
DMA_CHAN_CFG_DST_LINEAR_MODE |
DMA_CHAN_CFG_SRC_LINEAR_MODE |
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dmaengine: sun6i: fix the uninitialized value for v_lli
2016-11-19 16:43 [PATCH v2] dmaengine: sun6i: fix the uninitialized value for v_lli Hao Zhang
@ 2016-11-25 6:19 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2016-11-25 6:19 UTC (permalink / raw)
To: Hao Zhang
Cc: dan.j.williams, wens, maxime.ripard, dmaengine, linux-kernel, kernel
On Sun, Nov 20, 2016 at 12:43:56AM +0800, Hao Zhang wrote:
> dma_pool_alloc does not initialize the value of the newly allocated
> block for the v_lli, and the uninitilize value make the tests failed
> which is on pine64 with dmatest.
> we can fix it just change the "|=" to "=" for the v_lli->cfg.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-25 6:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-19 16:43 [PATCH v2] dmaengine: sun6i: fix the uninitialized value for v_lli Hao Zhang
2016-11-25 6:19 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.