[PATCH] cxgb4i: Add a missing call to neigh_release

[PATCH] cxgb4i: Add a missing call to neigh_release

[Quentin Lambert]

Most error branches following the call to dst_neigh_lookup contain
a call to neigh_release. This patch add these calls where they are
missing.

This issue was found with Hector.

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>

---
 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -1410,7 +1410,7 @@ static int init_act_open(struct cxgbi_so
 	csk->atid = cxgb4_alloc_atid(lldi->tids, csk);
 	if (csk->atid < 0) {
 		pr_err("%s, NO atid available.\n", ndev->name);
-		return -EINVAL;
+		goto rel_resource_without_clip;
 	}
 	cxgbi_sock_set_flag(csk, CTPF_HAS_ATID);
 	cxgbi_sock_get(csk);

[PATCH] cxgb4i: Add a missing call to neigh_release

[Quentin Lambert]

Most error branches following the call to dst_neigh_lookup contain
a call to neigh_release. This patch add these calls where they are
missing.

This issue was found with Hector.

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>

---
 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -1410,7 +1410,7 @@ static int init_act_open(struct cxgbi_so
 	csk->atid = cxgb4_alloc_atid(lldi->tids, csk);
 	if (csk->atid < 0) {
 		pr_err("%s, NO atid available.\n", ndev->name);
-		return -EINVAL;
+		goto rel_resource_without_clip;
 	}
 	cxgbi_sock_set_flag(csk, CTPF_HAS_ATID);
 	cxgbi_sock_get(csk);

Re: [PATCH] cxgb4i: Add a missing call to neigh_release

[Martin K. Petersen]

>>>>> "Quentin" == Quentin Lambert <lambert.quentin@gmail.com> writes:

Quentin> Most error branches following the call to dst_neigh_lookup
Quentin> contain a call to neigh_release. This patch add these calls
Quentin> where they are missing.

Varun: Please review!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] cxgb4i: Add a missing call to neigh_release

[Martin K. Petersen]

>>>>> "Quentin" = Quentin Lambert <lambert.quentin@gmail.com> writes:

Quentin> Most error branches following the call to dst_neigh_lookup
Quentin> contain a call to neigh_release. This patch add these calls
Quentin> where they are missing.

Varun: Please review!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] cxgb4i: Add a missing call to neigh_release

[Varun Prakash]

On Tue, Nov 29, 2016 at 10:18:09PM +0530, Martin K. Petersen wrote:
> >>>>> "Quentin" == Quentin Lambert <lambert.quentin@gmail.com> writes:
> 
> Quentin> Most error branches following the call to dst_neigh_lookup
> Quentin> contain a call to neigh_release. This patch add these calls
> Quentin> where they are missing.
> 
> Varun: Please review!
> 
Looks good.

Acked-by: Varun Prakash <varun@chelsio.com>

Re: [PATCH] cxgb4i: Add a missing call to neigh_release

[Varun Prakash]

On Tue, Nov 29, 2016 at 10:18:09PM +0530, Martin K. Petersen wrote:
> >>>>> "Quentin" = Quentin Lambert <lambert.quentin@gmail.com> writes:
> 
> Quentin> Most error branches following the call to dst_neigh_lookup
> Quentin> contain a call to neigh_release. This patch add these calls
> Quentin> where they are missing.
> 
> Varun: Please review!
> 
Looks good.

Acked-by: Varun Prakash <varun@chelsio.com>

Re: [PATCH] cxgb4i: Add a missing call to neigh_release

[Martin K. Petersen]

>>>>> "Quentin" == Quentin Lambert <lambert.quentin@gmail.com> writes:

Quentin> Most error branches following the call to dst_neigh_lookup
Quentin> contain a call to neigh_release. This patch add these calls
Quentin> where they are missing.

Applied to 4.10/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] cxgb4i: Add a missing call to neigh_release

[Martin K. Petersen]

>>>>> "Quentin" = Quentin Lambert <lambert.quentin@gmail.com> writes:

Quentin> Most error branches following the call to dst_neigh_lookup
Quentin> contain a call to neigh_release. This patch add these calls
Quentin> where they are missing.

Applied to 4.10/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering