* [Buildroot] [PATCH] openblas: disable OpenMP
@ 2016-11-20 16:04 Arnout Vandecappelle
2016-11-21 20:45 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Arnout Vandecappelle @ 2016-11-20 16:04 UTC (permalink / raw)
To: buildroot
For powerpc (and powerpc only), the openblas build system will enable
USE_OPENMP when threads are enabled. But the toolchain wasn't
necessarily built with OpenMP support. So explicitly disable OpenMP -
for all architectures, not just powerpc, just to keep things simple.
We could have autodetected whether OpenMP is available at configure
time, but that would be more of a feature patch, it's up to upstream
to do that.
Fixes:
http://autobuild.buildroot.net/results/423b5e79cd4342d6c160ed478054b294b0826c6a
http://autobuild.buildroot.net/results/c9e554c8f880b49b3c9203725ac5e6565b7e5c6f
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/openblas/openblas.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/openblas/openblas.mk b/package/openblas/openblas.mk
index 9583e0e..a26e10a 100644
--- a/package/openblas/openblas.mk
+++ b/package/openblas/openblas.mk
@@ -31,6 +31,9 @@ else
OPENBLAS_MAKE_OPTS += USE_THREAD=0
endif
+# We don't know if OpenMP is available or not, so disable
+OPENBLAS_MAKE_OPTS += USE_OPENMP=0
+
# Static-only/Shared-only toggle
ifeq ($(BR2_STATIC_LIBS),y)
OPENBLAS_MAKE_OPTS += NO_SHARED=1
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] openblas: disable OpenMP
2016-11-20 16:04 [Buildroot] [PATCH] openblas: disable OpenMP Arnout Vandecappelle
@ 2016-11-21 20:45 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-11-21 20:45 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 20 Nov 2016 17:04:41 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> For powerpc (and powerpc only), the openblas build system will enable
> USE_OPENMP when threads are enabled. But the toolchain wasn't
> necessarily built with OpenMP support. So explicitly disable OpenMP -
> for all architectures, not just powerpc, just to keep things simple.
>
> We could have autodetected whether OpenMP is available at configure
> time, but that would be more of a feature patch, it's up to upstream
> to do that.
>
> Fixes:
> http://autobuild.buildroot.net/results/423b5e79cd4342d6c160ed478054b294b0826c6a
> http://autobuild.buildroot.net/results/c9e554c8f880b49b3c9203725ac5e6565b7e5c6f
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> package/openblas/openblas.mk | 3 +++
> 1 file changed, 3 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-21 20:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-20 16:04 [Buildroot] [PATCH] openblas: disable OpenMP Arnout Vandecappelle
2016-11-21 20:45 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.