* [PATCH 1/2] ACPI / processor: Make acpi_processor_ppc_has_changed() void
2016-11-18 12:57 [PATCH 0/2] ACPI / processor / cpufreq: Function return value cleanups Rafael J. Wysocki
@ 2016-11-18 12:57 ` Rafael J. Wysocki
2016-11-18 12:59 ` [PATCH 2/2] cpufreq: Make cpufreq_update_policy() void Rafael J. Wysocki
2016-11-21 3:38 ` [PATCH 0/2] ACPI / processor / cpufreq: Function return value cleanups Viresh Kumar
2 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2016-11-18 12:57 UTC (permalink / raw)
To: ACPI Devel Maling List
Cc: Linux PM list, Linux Kernel Mailing List, Viresh Kumar,
Srinivas Pandruvada
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
The return value of acpi_processor_ppc_has_changed() is never used,
so make it void.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/processor_perflib.c | 10 ++++------
include/acpi/processor.h | 2 +-
2 files changed, 5 insertions(+), 7 deletions(-)
Index: linux-pm/drivers/acpi/processor_perflib.c
===================================================================
--- linux-pm.orig/drivers/acpi/processor_perflib.c
+++ linux-pm/drivers/acpi/processor_perflib.c
@@ -157,7 +157,7 @@ static void acpi_processor_ppc_ost(acpi_
status, NULL);
}
-int acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag)
+void acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag)
{
int ret;
@@ -168,7 +168,7 @@ int acpi_processor_ppc_has_changed(struc
*/
if (event_flag)
acpi_processor_ppc_ost(pr->handle, 1);
- return 0;
+ return;
}
ret = acpi_processor_get_platform_limit(pr);
@@ -182,10 +182,8 @@ int acpi_processor_ppc_has_changed(struc
else
acpi_processor_ppc_ost(pr->handle, 0);
}
- if (ret < 0)
- return (ret);
- else
- return cpufreq_update_policy(pr->id);
+ if (ret >= 0)
+ cpufreq_update_policy(pr->id);
}
int acpi_processor_get_bios_limit(int cpu, unsigned int *limit)
Index: linux-pm/include/acpi/processor.h
===================================================================
--- linux-pm.orig/include/acpi/processor.h
+++ linux-pm/include/acpi/processor.h
@@ -295,7 +295,7 @@ static inline void acpi_processor_ffh_cs
#ifdef CONFIG_CPU_FREQ
void acpi_processor_ppc_init(void);
void acpi_processor_ppc_exit(void);
-int acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag);
+void acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag);
extern int acpi_processor_get_bios_limit(int cpu, unsigned int *limit);
#else
static inline void acpi_processor_ppc_init(void)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] cpufreq: Make cpufreq_update_policy() void
2016-11-18 12:57 [PATCH 0/2] ACPI / processor / cpufreq: Function return value cleanups Rafael J. Wysocki
2016-11-18 12:57 ` [PATCH 1/2] ACPI / processor: Make acpi_processor_ppc_has_changed() void Rafael J. Wysocki
@ 2016-11-18 12:59 ` Rafael J. Wysocki
2016-11-21 3:38 ` [PATCH 0/2] ACPI / processor / cpufreq: Function return value cleanups Viresh Kumar
2 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2016-11-18 12:59 UTC (permalink / raw)
To: Linux PM list
Cc: ACPI Devel Maling List, Linux Kernel Mailing List, Viresh Kumar,
Srinivas Pandruvada
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
The return value of cpufreq_update_policy() is never used, so make
it void.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
On top of https://patchwork.kernel.org/patch/9436381/
---
drivers/cpufreq/cpufreq.c | 21 +++++++--------------
include/linux/cpufreq.h | 2 +-
2 files changed, 8 insertions(+), 15 deletions(-)
Index: linux-pm/drivers/cpufreq/cpufreq.c
===================================================================
--- linux-pm.orig/drivers/cpufreq/cpufreq.c
+++ linux-pm/drivers/cpufreq/cpufreq.c
@@ -2257,21 +2257,18 @@ static int cpufreq_set_policy(struct cpu
* Useful for policy notifiers which have different necessities
* at different times.
*/
-int cpufreq_update_policy(unsigned int cpu)
+void cpufreq_update_policy(unsigned int cpu)
{
struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
struct cpufreq_policy new_policy;
- int ret;
if (!policy)
- return -ENODEV;
+ return;
down_write(&policy->rwsem);
- if (policy_is_inactive(policy)) {
- ret = -ENODEV;
+ if (policy_is_inactive(policy))
goto unlock;
- }
pr_debug("updating policy for CPU %u\n", cpu);
memcpy(&new_policy, policy, sizeof(*policy));
@@ -2283,24 +2280,20 @@ int cpufreq_update_policy(unsigned int c
* -> ask driver for current freq and notify governors about a change
*/
if (cpufreq_driver->get && !cpufreq_driver->setpolicy) {
- if (cpufreq_suspended) {
- ret = -EAGAIN;
+ if (cpufreq_suspended)
goto unlock;
- }
+
new_policy.cur = cpufreq_update_current_freq(policy);
- if (WARN_ON(!new_policy.cur)) {
- ret = -EIO;
+ if (WARN_ON(!new_policy.cur))
goto unlock;
- }
}
- ret = cpufreq_set_policy(policy, &new_policy);
+ cpufreq_set_policy(policy, &new_policy);
unlock:
up_write(&policy->rwsem);
cpufreq_cpu_put(policy);
- return ret;
}
EXPORT_SYMBOL(cpufreq_update_policy);
Index: linux-pm/include/linux/cpufreq.h
===================================================================
--- linux-pm.orig/include/linux/cpufreq.h
+++ linux-pm/include/linux/cpufreq.h
@@ -175,7 +175,7 @@ void disable_cpufreq(void);
u64 get_cpu_idle_time(unsigned int cpu, u64 *wall, int io_busy);
int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu);
-int cpufreq_update_policy(unsigned int cpu);
+void cpufreq_update_policy(unsigned int cpu);
bool have_governor_per_policy(void);
struct kobject *get_governor_parent_kobj(struct cpufreq_policy *policy);
void cpufreq_enable_fast_switch(struct cpufreq_policy *policy);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] ACPI / processor / cpufreq: Function return value cleanups
2016-11-18 12:57 [PATCH 0/2] ACPI / processor / cpufreq: Function return value cleanups Rafael J. Wysocki
2016-11-18 12:57 ` [PATCH 1/2] ACPI / processor: Make acpi_processor_ppc_has_changed() void Rafael J. Wysocki
2016-11-18 12:59 ` [PATCH 2/2] cpufreq: Make cpufreq_update_policy() void Rafael J. Wysocki
@ 2016-11-21 3:38 ` Viresh Kumar
2 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2016-11-21 3:38 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux PM list, ACPI Devel Maling List, Linux Kernel Mailing List,
Srinivas Pandruvada
On 18-11-16, 13:57, Rafael J. Wysocki wrote:
> Hi,
>
> Two cleanups related to unused function return values, [1/2] in processor_perflib.c
> and [2/2] in cpufreq.c.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread