* [PATCH] net/phy: add trace events for mdio accesses @ 2016-11-14 11:03 Uwe Kleine-König 2016-11-14 15:22 ` Steven Rostedt 2016-11-22 10:01 ` [PATCH v2] " Uwe Kleine-König 0 siblings, 2 replies; 8+ messages in thread From: Uwe Kleine-König @ 2016-11-14 11:03 UTC (permalink / raw) To: Florian Fainelli, Steven Rostedt, Ingo Molnar; +Cc: netdev Make it possible to generate trace events for mdio read and write accesses. Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> --- drivers/net/phy/mdio_bus.c | 15 +++++++++++++++ include/trace/events/mdio.h | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 55 insertions(+) create mode 100644 include/trace/events/mdio.h diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 09deef4bed09..0f3f207419f6 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -38,6 +38,9 @@ #include <asm/irq.h> +#define CREATE_TRACE_POINTS +#include <trace/events/mdio.h> + int mdiobus_register_device(struct mdio_device *mdiodev) { if (mdiodev->bus->mdio_map[mdiodev->addr]) @@ -461,6 +464,9 @@ int mdiobus_read_nested(struct mii_bus *bus, int addr, u32 regnum) retval = bus->read(bus, addr, regnum); mutex_unlock(&bus->mdio_lock); + if (retval >= 0) + trace_mdio_access(bus, 1, addr, regnum, retval); + return retval; } EXPORT_SYMBOL(mdiobus_read_nested); @@ -485,6 +491,9 @@ int mdiobus_read(struct mii_bus *bus, int addr, u32 regnum) retval = bus->read(bus, addr, regnum); mutex_unlock(&bus->mdio_lock); + if (retval >= 0) + trace_mdio_access(bus, 1, addr, regnum, retval); + return retval; } EXPORT_SYMBOL(mdiobus_read); @@ -513,6 +522,9 @@ int mdiobus_write_nested(struct mii_bus *bus, int addr, u32 regnum, u16 val) err = bus->write(bus, addr, regnum, val); mutex_unlock(&bus->mdio_lock); + if (!err) + trace_mdio_access(bus, 0, addr, regnum, val); + return err; } EXPORT_SYMBOL(mdiobus_write_nested); @@ -538,6 +550,9 @@ int mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val) err = bus->write(bus, addr, regnum, val); mutex_unlock(&bus->mdio_lock); + if (!err) + trace_mdio_access(bus, 0, addr, regnum, val); + return err; } EXPORT_SYMBOL(mdiobus_write); diff --git a/include/trace/events/mdio.h b/include/trace/events/mdio.h new file mode 100644 index 000000000000..dcb2d456a346 --- /dev/null +++ b/include/trace/events/mdio.h @@ -0,0 +1,40 @@ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM mdio + +#if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_MDIO_H + +#include <linux/tracepoint.h> + +TRACE_EVENT(mdio_access, + + TP_PROTO(struct mii_bus *bus, int read, + unsigned addr, unsigned regnum, u16 val), + + TP_ARGS(bus, read, addr, regnum, val), + + TP_STRUCT__entry( + __array(char, busid, MII_BUS_ID_SIZE) + __field(int, read) + __field(unsigned, addr) + __field(unsigned, regnum) + __field(u16, val) + ), + + TP_fast_assign( + strncpy(__entry->busid, bus->id, MII_BUS_ID_SIZE); + __entry->read = read; + __entry->addr = addr; + __entry->regnum = regnum; + __entry->val = val; + ), + + TP_printk("%s %-5s phy:0x%02x reg:0x%02x val:0x%04hx", + __entry->busid, __entry->read ? "read" : "write", + __entry->addr, __entry->regnum, __entry->val) +); + +#endif /* if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) */ + +/* This part must be outside protection */ +#include <trace/define_trace.h> -- 2.10.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] net/phy: add trace events for mdio accesses 2016-11-14 11:03 [PATCH] net/phy: add trace events for mdio accesses Uwe Kleine-König @ 2016-11-14 15:22 ` Steven Rostedt 2016-11-22 10:01 ` [PATCH v2] " Uwe Kleine-König 1 sibling, 0 replies; 8+ messages in thread From: Steven Rostedt @ 2016-11-14 15:22 UTC (permalink / raw) To: Uwe Kleine-König; +Cc: Florian Fainelli, Ingo Molnar, netdev On Mon, 14 Nov 2016 12:03:35 +0100 Uwe Kleine-König <uwe@kleine-koenig.org> wrote: > Make it possible to generate trace events for mdio read and write accesses. > > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> > --- > drivers/net/phy/mdio_bus.c | 15 +++++++++++++++ > include/trace/events/mdio.h | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 55 insertions(+) > create mode 100644 include/trace/events/mdio.h > > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c > index 09deef4bed09..0f3f207419f6 100644 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -38,6 +38,9 @@ > > #include <asm/irq.h> > > +#define CREATE_TRACE_POINTS > +#include <trace/events/mdio.h> > + > int mdiobus_register_device(struct mdio_device *mdiodev) > { > if (mdiodev->bus->mdio_map[mdiodev->addr]) > @@ -461,6 +464,9 @@ int mdiobus_read_nested(struct mii_bus *bus, int addr, u32 regnum) > retval = bus->read(bus, addr, regnum); > mutex_unlock(&bus->mdio_lock); > > + if (retval >= 0) > + trace_mdio_access(bus, 1, addr, regnum, retval); These cause branches to be taken when tracing is disabled, breaking the zero overhead for disabled tracing guideline. As retval is passed to the tracepoint, please look at TRACE_EVENT_CONDITION() and use that. It will move the if statement into the enabling of the trace event and keep the overhead to a minimum when the tracepoint is disabled. Do the same for the below as well. -- Steve > + > return retval; > } > EXPORT_SYMBOL(mdiobus_read_nested); > @@ -485,6 +491,9 @@ int mdiobus_read(struct mii_bus *bus, int addr, u32 regnum) > retval = bus->read(bus, addr, regnum); > mutex_unlock(&bus->mdio_lock); > > + if (retval >= 0) > + trace_mdio_access(bus, 1, addr, regnum, retval); > + > return retval; > } > EXPORT_SYMBOL(mdiobus_read); > @@ -513,6 +522,9 @@ int mdiobus_write_nested(struct mii_bus *bus, int addr, u32 regnum, u16 val) > err = bus->write(bus, addr, regnum, val); > mutex_unlock(&bus->mdio_lock); > > + if (!err) > + trace_mdio_access(bus, 0, addr, regnum, val); > + > return err; > } > EXPORT_SYMBOL(mdiobus_write_nested); > @@ -538,6 +550,9 @@ int mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val) > err = bus->write(bus, addr, regnum, val); > mutex_unlock(&bus->mdio_lock); > > + if (!err) > + trace_mdio_access(bus, 0, addr, regnum, val); > + > return err; > } > EXPORT_SYMBOL(mdiobus_write); > diff --git a/include/trace/events/mdio.h b/include/trace/events/mdio.h > new file mode 100644 > index 000000000000..dcb2d456a346 > --- /dev/null > +++ b/include/trace/events/mdio.h > @@ -0,0 +1,40 @@ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM mdio > + > +#if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_MDIO_H > + > +#include <linux/tracepoint.h> > + > +TRACE_EVENT(mdio_access, > + > + TP_PROTO(struct mii_bus *bus, int read, > + unsigned addr, unsigned regnum, u16 val), > + > + TP_ARGS(bus, read, addr, regnum, val), > + > + TP_STRUCT__entry( > + __array(char, busid, MII_BUS_ID_SIZE) > + __field(int, read) > + __field(unsigned, addr) > + __field(unsigned, regnum) > + __field(u16, val) > + ), > + > + TP_fast_assign( > + strncpy(__entry->busid, bus->id, MII_BUS_ID_SIZE); > + __entry->read = read; > + __entry->addr = addr; > + __entry->regnum = regnum; > + __entry->val = val; > + ), > + > + TP_printk("%s %-5s phy:0x%02x reg:0x%02x val:0x%04hx", > + __entry->busid, __entry->read ? "read" : "write", > + __entry->addr, __entry->regnum, __entry->val) > +); > + > +#endif /* if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) */ > + > +/* This part must be outside protection */ > +#include <trace/define_trace.h> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] net/phy: add trace events for mdio accesses 2016-11-14 11:03 [PATCH] net/phy: add trace events for mdio accesses Uwe Kleine-König 2016-11-14 15:22 ` Steven Rostedt @ 2016-11-22 10:01 ` Uwe Kleine-König 2016-11-22 14:55 ` Steven Rostedt 2016-11-22 15:47 ` [PATCH v3] " Uwe Kleine-König 1 sibling, 2 replies; 8+ messages in thread From: Uwe Kleine-König @ 2016-11-22 10:01 UTC (permalink / raw) To: Florian Fainelli, Steven Rostedt, Ingo Molnar; +Cc: netdev Make it possible to generate trace events for mdio read and write accesses. Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> --- Changes since (implicit) v1: - make use of TRACE_EVENT_CONDITION Alternatively to this patch the condition could be + TP_CONDITION(err == 0), but then we'd need in the read callbacks: + trace_mdio_access(bus, 1, addr, regnum, retval, retval < 0 ? retval : 0); or at least + trace_mdio_access(bus, 1, addr, regnum, retval, retval < 0); which both looks more ugly IMHO. Best regards Uwe drivers/net/phy/mdio_bus.c | 11 +++++++++++ include/trace/events/mdio.h | 42 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+) create mode 100644 include/trace/events/mdio.h diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 09deef4bed09..653d076eafe5 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -38,6 +38,9 @@ #include <asm/irq.h> +#define CREATE_TRACE_POINTS +#include <trace/events/mdio.h> + int mdiobus_register_device(struct mdio_device *mdiodev) { if (mdiodev->bus->mdio_map[mdiodev->addr]) @@ -461,6 +464,8 @@ int mdiobus_read_nested(struct mii_bus *bus, int addr, u32 regnum) retval = bus->read(bus, addr, regnum); mutex_unlock(&bus->mdio_lock); + trace_mdio_access(bus, 1, addr, regnum, retval, retval); + return retval; } EXPORT_SYMBOL(mdiobus_read_nested); @@ -485,6 +490,8 @@ int mdiobus_read(struct mii_bus *bus, int addr, u32 regnum) retval = bus->read(bus, addr, regnum); mutex_unlock(&bus->mdio_lock); + trace_mdio_access(bus, 1, addr, regnum, retval, retval); + return retval; } EXPORT_SYMBOL(mdiobus_read); @@ -513,6 +520,8 @@ int mdiobus_write_nested(struct mii_bus *bus, int addr, u32 regnum, u16 val) err = bus->write(bus, addr, regnum, val); mutex_unlock(&bus->mdio_lock); + trace_mdio_access(bus, 0, addr, regnum, val, err); + return err; } EXPORT_SYMBOL(mdiobus_write_nested); @@ -538,6 +547,8 @@ int mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val) err = bus->write(bus, addr, regnum, val); mutex_unlock(&bus->mdio_lock); + trace_mdio_access(bus, 0, addr, regnum, val, err); + return err; } EXPORT_SYMBOL(mdiobus_write); diff --git a/include/trace/events/mdio.h b/include/trace/events/mdio.h new file mode 100644 index 000000000000..468e2d095d19 --- /dev/null +++ b/include/trace/events/mdio.h @@ -0,0 +1,42 @@ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM mdio + +#if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_MDIO_H + +#include <linux/tracepoint.h> + +TRACE_EVENT_CONDITION(mdio_access, + + TP_PROTO(struct mii_bus *bus, int read, + unsigned addr, unsigned regnum, u16 val, int err), + + TP_ARGS(bus, read, addr, regnum, val, err), + + TP_CONDITION(err >= 0), + + TP_STRUCT__entry( + __array(char, busid, MII_BUS_ID_SIZE) + __field(int, read) + __field(unsigned, addr) + __field(unsigned, regnum) + __field(u16, val) + ), + + TP_fast_assign( + strncpy(__entry->busid, bus->id, MII_BUS_ID_SIZE); + __entry->read = read; + __entry->addr = addr; + __entry->regnum = regnum; + __entry->val = val; + ), + + TP_printk("%s %-5s phy:0x%02x reg:0x%02x val:0x%04hx", + __entry->busid, __entry->read ? "read" : "write", + __entry->addr, __entry->regnum, __entry->val) +); + +#endif /* if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) */ + +/* This part must be outside protection */ +#include <trace/define_trace.h> -- 2.10.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net/phy: add trace events for mdio accesses 2016-11-22 10:01 ` [PATCH v2] " Uwe Kleine-König @ 2016-11-22 14:55 ` Steven Rostedt 2016-11-22 15:19 ` Andrew Lunn 2016-11-22 15:47 ` [PATCH v3] " Uwe Kleine-König 1 sibling, 1 reply; 8+ messages in thread From: Steven Rostedt @ 2016-11-22 14:55 UTC (permalink / raw) To: Uwe Kleine-König; +Cc: Florian Fainelli, Ingo Molnar, netdev On Tue, 22 Nov 2016 11:01:27 +0100 Uwe Kleine-König <uwe@kleine-koenig.org> wrote: > diff --git a/include/trace/events/mdio.h b/include/trace/events/mdio.h > new file mode 100644 > index 000000000000..468e2d095d19 > --- /dev/null > +++ b/include/trace/events/mdio.h > @@ -0,0 +1,42 @@ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM mdio > + > +#if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_MDIO_H > + > +#include <linux/tracepoint.h> > + > +TRACE_EVENT_CONDITION(mdio_access, > + > + TP_PROTO(struct mii_bus *bus, int read, > + unsigned addr, unsigned regnum, u16 val, int err), > + > + TP_ARGS(bus, read, addr, regnum, val, err), > + > + TP_CONDITION(err >= 0), > + > + TP_STRUCT__entry( > + __array(char, busid, MII_BUS_ID_SIZE) > + __field(int, read) read is just a 0 or 1. What about making it a char? That way we can pack this better. If I'm not mistaken, MII_BUS_ID_SIZE is (20 - 3) or 17. If read is just one byte, then it can fit in one of those three bytes, and you save 4 extra bytes (assuming addr will be 4 byte aligned). -- Steve > + __field(unsigned, addr) > + __field(unsigned, regnum) > + __field(u16, val) > + ), > + > + TP_fast_assign( > + strncpy(__entry->busid, bus->id, MII_BUS_ID_SIZE); > + __entry->read = read; > + __entry->addr = addr; > + __entry->regnum = regnum; > + __entry->val = val; > + ), > + > + TP_printk("%s %-5s phy:0x%02x reg:0x%02x val:0x%04hx", > + __entry->busid, __entry->read ? "read" : "write", > + __entry->addr, __entry->regnum, __entry->val) > +); > + > +#endif /* if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) */ > + > +/* This part must be outside protection */ > +#include <trace/define_trace.h> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] net/phy: add trace events for mdio accesses 2016-11-22 14:55 ` Steven Rostedt @ 2016-11-22 15:19 ` Andrew Lunn 0 siblings, 0 replies; 8+ messages in thread From: Andrew Lunn @ 2016-11-22 15:19 UTC (permalink / raw) To: Steven Rostedt Cc: Uwe Kleine-König, Florian Fainelli, Ingo Molnar, netdev On Tue, Nov 22, 2016 at 09:55:21AM -0500, Steven Rostedt wrote: > On Tue, 22 Nov 2016 11:01:27 +0100 > Uwe Kleine-König <uwe@kleine-koenig.org> wrote: > > > diff --git a/include/trace/events/mdio.h b/include/trace/events/mdio.h > > new file mode 100644 > > index 000000000000..468e2d095d19 > > --- /dev/null > > +++ b/include/trace/events/mdio.h > > @@ -0,0 +1,42 @@ > > +#undef TRACE_SYSTEM > > +#define TRACE_SYSTEM mdio > > + > > +#if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) > > +#define _TRACE_MDIO_H > > + > > +#include <linux/tracepoint.h> > > + > > +TRACE_EVENT_CONDITION(mdio_access, > > + > > + TP_PROTO(struct mii_bus *bus, int read, > > + unsigned addr, unsigned regnum, u16 val, int err), > > + > > + TP_ARGS(bus, read, addr, regnum, val, err), > > + > > + TP_CONDITION(err >= 0), > > + > > + TP_STRUCT__entry( > > + __array(char, busid, MII_BUS_ID_SIZE) > > + __field(int, read) > > read is just a 0 or 1. What about making it a char? That way we can > pack this better. If I'm not mistaken, MII_BUS_ID_SIZE is (20 - 3) or > 17. If read is just one byte, then it can fit in one of those three > bytes, and you save 4 extra bytes (assuming addr will be 4 byte > aligned). addr could also be cast into a u8. There are a maximum of 32 addresses on an MDIO bus. Because of clause 45 MDIO, regnum needs to remain a u32. Andrew ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] net/phy: add trace events for mdio accesses 2016-11-22 10:01 ` [PATCH v2] " Uwe Kleine-König 2016-11-22 14:55 ` Steven Rostedt @ 2016-11-22 15:47 ` Uwe Kleine-König 2016-11-22 15:58 ` Steven Rostedt 2016-11-24 16:56 ` David Miller 1 sibling, 2 replies; 8+ messages in thread From: Uwe Kleine-König @ 2016-11-22 15:47 UTC (permalink / raw) To: Florian Fainelli, Steven Rostedt, Ingo Molnar; +Cc: netdev Make it possible to generate trace events for mdio read and write accesses. Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> --- drivers/net/phy/mdio_bus.c | 11 +++++++++++ include/trace/events/mdio.h | 42 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 53 insertions(+) create mode 100644 include/trace/events/mdio.h diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 09deef4bed09..653d076eafe5 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -38,6 +38,9 @@ #include <asm/irq.h> +#define CREATE_TRACE_POINTS +#include <trace/events/mdio.h> + int mdiobus_register_device(struct mdio_device *mdiodev) { if (mdiodev->bus->mdio_map[mdiodev->addr]) @@ -461,6 +464,8 @@ int mdiobus_read_nested(struct mii_bus *bus, int addr, u32 regnum) retval = bus->read(bus, addr, regnum); mutex_unlock(&bus->mdio_lock); + trace_mdio_access(bus, 1, addr, regnum, retval, retval); + return retval; } EXPORT_SYMBOL(mdiobus_read_nested); @@ -485,6 +490,8 @@ int mdiobus_read(struct mii_bus *bus, int addr, u32 regnum) retval = bus->read(bus, addr, regnum); mutex_unlock(&bus->mdio_lock); + trace_mdio_access(bus, 1, addr, regnum, retval, retval); + return retval; } EXPORT_SYMBOL(mdiobus_read); @@ -513,6 +520,8 @@ int mdiobus_write_nested(struct mii_bus *bus, int addr, u32 regnum, u16 val) err = bus->write(bus, addr, regnum, val); mutex_unlock(&bus->mdio_lock); + trace_mdio_access(bus, 0, addr, regnum, val, err); + return err; } EXPORT_SYMBOL(mdiobus_write_nested); @@ -538,6 +547,8 @@ int mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val) err = bus->write(bus, addr, regnum, val); mutex_unlock(&bus->mdio_lock); + trace_mdio_access(bus, 0, addr, regnum, val, err); + return err; } EXPORT_SYMBOL(mdiobus_write); diff --git a/include/trace/events/mdio.h b/include/trace/events/mdio.h new file mode 100644 index 000000000000..00d85f5f54e4 --- /dev/null +++ b/include/trace/events/mdio.h @@ -0,0 +1,42 @@ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM mdio + +#if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_MDIO_H + +#include <linux/tracepoint.h> + +TRACE_EVENT_CONDITION(mdio_access, + + TP_PROTO(struct mii_bus *bus, char read, + u8 addr, unsigned regnum, u16 val, int err), + + TP_ARGS(bus, read, addr, regnum, val, err), + + TP_CONDITION(err >= 0), + + TP_STRUCT__entry( + __array(char, busid, MII_BUS_ID_SIZE) + __field(char, read) + __field(u8, addr) + __field(u16, val) + __field(unsigned, regnum) + ), + + TP_fast_assign( + strncpy(__entry->busid, bus->id, MII_BUS_ID_SIZE); + __entry->read = read; + __entry->addr = addr; + __entry->regnum = regnum; + __entry->val = val; + ), + + TP_printk("%s %-5s phy:0x%02hhx reg:0x%02x val:0x%04hx", + __entry->busid, __entry->read ? "read" : "write", + __entry->addr, __entry->regnum, __entry->val) +); + +#endif /* if !defined(_TRACE_MDIO_H) || defined(TRACE_HEADER_MULTI_READ) */ + +/* This part must be outside protection */ +#include <trace/define_trace.h> -- 2.10.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3] net/phy: add trace events for mdio accesses 2016-11-22 15:47 ` [PATCH v3] " Uwe Kleine-König @ 2016-11-22 15:58 ` Steven Rostedt 2016-11-24 16:56 ` David Miller 1 sibling, 0 replies; 8+ messages in thread From: Steven Rostedt @ 2016-11-22 15:58 UTC (permalink / raw) To: Uwe Kleine-König; +Cc: Florian Fainelli, Ingo Molnar, netdev On Tue, 22 Nov 2016 16:47:11 +0100 Uwe Kleine-König <uwe@kleine-koenig.org> wrote: > Make it possible to generate trace events for mdio read and write accesses. > > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> For the tracing side. Acked-by: Steven Rostedt <rostedt@goodmis.org> -- Steve ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] net/phy: add trace events for mdio accesses 2016-11-22 15:47 ` [PATCH v3] " Uwe Kleine-König 2016-11-22 15:58 ` Steven Rostedt @ 2016-11-24 16:56 ` David Miller 1 sibling, 0 replies; 8+ messages in thread From: David Miller @ 2016-11-24 16:56 UTC (permalink / raw) To: uwe; +Cc: f.fainelli, rostedt, mingo, netdev From: Uwe Kleine-König <uwe@kleine-koenig.org> Date: Tue, 22 Nov 2016 16:47:11 +0100 > Make it possible to generate trace events for mdio read and write accesses. > > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> Applied to net-next, thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-11-24 16:56 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-11-14 11:03 [PATCH] net/phy: add trace events for mdio accesses Uwe Kleine-König 2016-11-14 15:22 ` Steven Rostedt 2016-11-22 10:01 ` [PATCH v2] " Uwe Kleine-König 2016-11-22 14:55 ` Steven Rostedt 2016-11-22 15:19 ` Andrew Lunn 2016-11-22 15:47 ` [PATCH v3] " Uwe Kleine-König 2016-11-22 15:58 ` Steven Rostedt 2016-11-24 16:56 ` David Miller
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.