[PATCH] OP_SWITCH should use 'insn->cond' instead of 'insn->target'

[PATCH] OP_SWITCH should use 'insn->cond' instead of 'insn->target'

[Luc Van Oostenryck]

From: Luc Van Oostenryck <luc.vanoostenryck@looxix.net>

show_instruction() uses the field 'target' to display OP_SWITCH
instruction instead of 'cond' like OP_BR does.
It doesn't change anything since these two fields use the same
storage inside struct instruction but better to use the right field
to keep consistent.
---
 linearize.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linearize.c b/linearize.c
index c6ada1e8..31d2a6cd 100644
--- a/linearize.c
+++ b/linearize.c
@@ -357,7 +357,7 @@ const char *show_instruction(struct instruction *insn)
 	}
 	case OP_SWITCH: {
 		struct multijmp *jmp;
-		buf += sprintf(buf, "%s", show_pseudo(insn->target));
+		buf += sprintf(buf, "%s", show_pseudo(insn->cond));
 		FOR_EACH_PTR(insn->multijmp_list, jmp) {
 			if (jmp->begin == jmp->end)
 				buf += sprintf(buf, ", %d -> .L%p", jmp->begin, jmp->target);
-- 
2.10.2

Re: [PATCH] OP_SWITCH should use 'insn->cond' instead of 'insn->target'

[Christopher Li]

On Wed, Nov 23, 2016 at 12:32 AM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> From: Luc Van Oostenryck <luc.vanoostenryck@looxix.net>
>
> show_instruction() uses the field 'target' to display OP_SWITCH
> instruction instead of 'cond' like OP_BR does.
> It doesn't change anything since these two fields use the same
> storage inside struct instruction but better to use the right field
> to keep consistent.

Looks good to me. Will apply.

Chris

Re: [PATCH] OP_SWITCH should use 'insn->cond' instead of 'insn->target'

[Luc Van Oostenryck]

On Tue, Nov 22, 2016 at 05:32:33PM +0100, Luc Van Oostenryck wrote:
> From: Luc Van Oostenryck <luc.vanoostenryck@looxix.net>
> 
> show_instruction() uses the field 'target' to display OP_SWITCH
> instruction instead of 'cond' like OP_BR does.
> It doesn't change anything since these two fields use the same
> storage inside struct instruction but better to use the right field
> to keep consistent.
> ---
>  linearize.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is my s-o-b that I had forgot to add:
    Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

Re: [PATCH] OP_SWITCH should use 'insn->cond' instead of 'insn->target'

[Christopher Li]

On Tue, Feb 7, 2017 at 4:33 AM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> Here is my s-o-b that I had forgot to add:
>     Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

The sparse-next branch has been updated to include your s-o-b with other
two patches.

Thanks for all the patches.

Chris