All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: tomas.hlavacek-x+rMaJPWets@public.gmane.org
Cc: "Uwe Kleine-König"
	<uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	marex-ynQEQJNshbs@public.gmane.org,
	"Jason Cooper" <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Gregory Clement"
	<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Sebastian Hesselbarth"
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH RFC] ARM: dts: add support for Turris Omnia
Date: Wed, 23 Nov 2016 02:39:40 +0100	[thread overview]
Message-ID: <20161123013940.GM2691@lunn.ch> (raw)
In-Reply-To: <1479860851.10840.11-TAvD023jEQEN+BqQ9rBEUg@public.gmane.org>

On Wed, Nov 23, 2016 at 01:27:31AM +0100, tomas.hlavacek-x+rMaJPWets@public.gmane.org wrote:
> Hi Uwe!
> 
> On Tue, Nov 22, 2016 at 10:59 PM, tomas.hlavacek-x+rMaJPWets@public.gmane.org wrote:
> >Anyway I took your patch and tried few things:
> >- add pca9538 interrupt-controller
> >- add IRQ for 88E1514 PHY - and there is a problem:
> ...
> 
> I thought it over and if I am not mistaken this is not going to work
> anyway, because pca9538 driver causes the GPIO driver to set
> IRQ_NESTED_THREAD, so we can not simply use one of the GPIO expander
> pins as IRQ source for 88E1514, because request_irq() on it will
> fail ultimately.

Actually, the phylib now does uses threaded IRQs, since i implemented
interrupt support for the mv88e6xxx driver. Its interrupts require
MDIO transactions, so have to be threaded.

However, i don't think using interrupts on the pca9538 are
reliable. Interrupt support is compile time optional for that
driver. It is not clear to me if distributions do compile the driver
with interrupts enabled. So it could be the probe fails with OpenWRT,
Debian, etc...

	Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] ARM: dts: add support for Turris Omnia
Date: Wed, 23 Nov 2016 02:39:40 +0100	[thread overview]
Message-ID: <20161123013940.GM2691@lunn.ch> (raw)
In-Reply-To: <1479860851.10840.11@smtp.gmail.com>

On Wed, Nov 23, 2016 at 01:27:31AM +0100, tomas.hlavacek at nic.cz wrote:
> Hi Uwe!
> 
> On Tue, Nov 22, 2016 at 10:59 PM, tomas.hlavacek at nic.cz wrote:
> >Anyway I took your patch and tried few things:
> >- add pca9538 interrupt-controller
> >- add IRQ for 88E1514 PHY - and there is a problem:
> ...
> 
> I thought it over and if I am not mistaken this is not going to work
> anyway, because pca9538 driver causes the GPIO driver to set
> IRQ_NESTED_THREAD, so we can not simply use one of the GPIO expander
> pins as IRQ source for 88E1514, because request_irq() on it will
> fail ultimately.

Actually, the phylib now does uses threaded IRQs, since i implemented
interrupt support for the mv88e6xxx driver. Its interrupts require
MDIO transactions, so have to be threaded.

However, i don't think using interrupts on the pca9538 are
reliable. Interrupt support is compile time optional for that
driver. It is not clear to me if distributions do compile the driver
with interrupts enabled. So it could be the probe fails with OpenWRT,
Debian, etc...

	Andrew

  parent reply	other threads:[~2016-11-23  1:39 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-05 20:38 [PATCH RFC] ARM: dts: add support for Turris Omnia Uwe Kleine-König
2016-11-05 20:38 ` Uwe Kleine-König
     [not found] ` <20161105203841.9661-1-uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>
2016-11-05 21:04   ` Andrew Lunn
2016-11-05 21:04     ` Andrew Lunn
     [not found]     ` <20161105210441.GB1216-g2DYL2Zd6BY@public.gmane.org>
2016-11-05 22:08       ` Uwe Kleine-König
2016-11-05 22:08         ` Uwe Kleine-König
     [not found]         ` <20161105220848.k6rrjmvvhdaeduma-jgopVnDzZD+b0XQX99//ntPVjbGH4+40kFgPdswSElo@public.gmane.org>
2016-11-06 10:19           ` Andrew Lunn
2016-11-06 10:19             ` Andrew Lunn
2016-11-05 21:23   ` Andrew Lunn
2016-11-05 21:23     ` Andrew Lunn
     [not found]     ` <20161105212326.GC1216-g2DYL2Zd6BY@public.gmane.org>
2016-11-05 21:27       ` Uwe Kleine-König
2016-11-05 21:27         ` Uwe Kleine-König
     [not found]         ` <20161105212748.vtdprlxxismy5xmk-jgopVnDzZD+b0XQX99//ntPVjbGH4+40kFgPdswSElo@public.gmane.org>
2016-11-05 21:37           ` Andrew Lunn
2016-11-05 21:37             ` Andrew Lunn
     [not found]         ` <20161106104534.lsdyppz5qcnjcqe4@perseus.defre.kleine-koenig.org>
     [not found]           ` <20161106111109.GD9617@lunn.ch>
     [not found]             ` <20161106141716.fwgje74rhhixnixq@perseus.defre.kleine-koenig.org>
     [not found]               ` <20161106162809.GA14042@lunn.ch>
     [not found]                 ` <20161106162809.GA14042-g2DYL2Zd6BY@public.gmane.org>
2016-11-06 19:32                   ` Uwe Kleine-König
2016-11-06 19:32                     ` Uwe Kleine-König
2016-11-07  7:41         ` Martin Strbačka
2016-11-07  7:41           ` Martin Strbačka
2016-11-14 12:23   ` tomas.hlavacek-x+rMaJPWets
2016-11-14 12:23     ` tomas.hlavacek at nic.cz
     [not found]     ` <1479126185.15557.5-TAvD023jEQEN+BqQ9rBEUg@public.gmane.org>
2016-11-14 13:10       ` Andrew Lunn
2016-11-14 13:10         ` Andrew Lunn
2016-11-14 14:51         ` tomas.hlavacek
2016-11-14 14:59         ` tomas.hlavacek
2016-11-14 14:59           ` tomas.hlavacek at nic.cz
2016-11-14 20:16       ` Uwe Kleine-König
2016-11-14 20:16         ` Uwe Kleine-König
     [not found]         ` <20161114201640.rr32iyjf5a53v33t-jgopVnDzZD+b0XQX99//ntPVjbGH4+40kFgPdswSElo@public.gmane.org>
2016-11-14 20:28           ` Andrew Lunn
2016-11-14 20:28             ` Andrew Lunn
     [not found]             ` <20161114202832.GG24546-g2DYL2Zd6BY@public.gmane.org>
2016-11-19 20:09               ` tomas.hlavacek-x+rMaJPWets
2016-11-19 20:09                 ` tomas.hlavacek at nic.cz
     [not found]                 ` <1479586147.10840.0-TAvD023jEQEN+BqQ9rBEUg@public.gmane.org>
2016-11-20 20:30                   ` Uwe Kleine-König
2016-11-20 20:30                     ` Uwe Kleine-König
2016-11-22 21:59                     ` tomas.hlavacek
2016-11-22 21:59                       ` tomas.hlavacek at nic.cz
2016-11-23  0:09                       ` [RFC PATCH] ARM: dts: Add " Tomas Hlavacek
2016-11-23  0:09                         ` Tomas Hlavacek
2016-11-23  0:09                         ` Tomas Hlavacek
2016-11-23  0:35                         ` Andrew Lunn
2016-11-23  0:35                           ` Andrew Lunn
2016-11-24  8:37                           ` Uwe Kleine-König
2016-11-24  8:37                             ` Uwe Kleine-König
2016-11-24 15:07                             ` Andrew Lunn
2016-11-24 15:07                               ` Andrew Lunn
2016-11-25 12:49                               ` Tomas Hlavacek
2016-11-25 12:49                                 ` Tomas Hlavacek
2016-11-25 12:49                                 ` Tomas Hlavacek
2016-11-25 14:34                                 ` Uwe Kleine-König
2016-12-10  8:16                                 ` Pavel Machek
2016-12-10  8:16                                   ` Pavel Machek
2016-12-10  8:16                                   ` Pavel Machek
2016-11-23  8:19                         ` Uwe Kleine-König
2016-11-23  8:19                           ` Uwe Kleine-König
2016-11-23  8:19                           ` Uwe Kleine-König
     [not found]                       ` <1479851991.26813.2-TAvD023jEQEN+BqQ9rBEUg@public.gmane.org>
2016-11-23  0:27                         ` [PATCH RFC] ARM: dts: add " tomas.hlavacek-x+rMaJPWets
2016-11-23  0:27                           ` tomas.hlavacek at nic.cz
     [not found]                           ` <1479860851.10840.11-TAvD023jEQEN+BqQ9rBEUg@public.gmane.org>
2016-11-23  1:39                             ` Andrew Lunn [this message]
2016-11-23  1:39                               ` Andrew Lunn
2016-11-23 14:59                       ` Andrew Lunn
2016-11-23 14:59                         ` Andrew Lunn
     [not found]                         ` <20161123145916.GL14947-g2DYL2Zd6BY@public.gmane.org>
2016-11-23 18:36                           ` Uwe Kleine-König
2016-11-23 18:36                             ` Uwe Kleine-König
2016-11-23 22:45                         ` tomas.hlavacek
2016-11-23 22:45                           ` tomas.hlavacek at nic.cz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161123013940.GM2691@lunn.ch \
    --to=andrew-g2dyl2zd6by@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=marex-ynQEQJNshbs@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tomas.hlavacek-x+rMaJPWets@public.gmane.org \
    --cc=uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.