From: Liviu Dudau <Liviu.Dudau@arm.com> To: Eric Engestrom <eric@engestrom.ch> Cc: David Airlie <airlied@linux.ie>, DRI devel <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>, Rob Clark <robdclark@gmail.com>, Jani Nikula <jani.nikula@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch> Subject: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function. Date: Wed, 23 Nov 2016 10:52:13 +0000 [thread overview] Message-ID: <20161123105213.27674-1-Liviu.Dudau@arm.com> (raw) In-Reply-To: <CAF6AEGsU4Gksv3hGxXGJR-LiyZXKtevgf7chs0GDT4EfxLZajw@mail.gmail.com> drm_get_format_name() de-references the buf parameter without checking if the pointer was not NULL. Given that the function is EXPORT-ed, lets sanitise the parameters before proceeding. v2: Use BUG_ON() to annoy users that did not pass valid parameters to function. Fixes: b3c11ac267d461d3d5 ("drm: move allocation out of drm_get_format_name()) Cc: Eric Engestrom <eric@engestrom.ch> Cc: Rob Clark <robdclark@gmail.com> Cc: Jani Nikula <jani.nikula@intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> --- I still think sanity checking the parameters of an exported function is worth doing, even if the way one triggers the NULL pointer crash is priviledged. Not a big fan of the verbosity of BUG_ON() and would rather silently reject NULL buf pointer, but that is a matter of taste. drivers/gpu/drm/drm_fourcc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index 90d2cc8..6d80239 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -85,6 +85,8 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format); */ const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf) { + BUG_ON(!buf); + snprintf(buf->str, sizeof(buf->str), "%c%c%c%c %s-endian (0x%08x)", printable_char(format & 0xff), -- 2.10.2
WARNING: multiple messages have this Message-ID (diff)
From: Liviu Dudau <Liviu.Dudau@arm.com> To: Eric Engestrom <eric@engestrom.ch> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, LKML <linux-kernel@vger.kernel.org>, DRI devel <dri-devel@lists.freedesktop.org>, Jani Nikula <jani.nikula@intel.com> Subject: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function. Date: Wed, 23 Nov 2016 10:52:13 +0000 [thread overview] Message-ID: <20161123105213.27674-1-Liviu.Dudau@arm.com> (raw) In-Reply-To: <CAF6AEGsU4Gksv3hGxXGJR-LiyZXKtevgf7chs0GDT4EfxLZajw@mail.gmail.com> drm_get_format_name() de-references the buf parameter without checking if the pointer was not NULL. Given that the function is EXPORT-ed, lets sanitise the parameters before proceeding. v2: Use BUG_ON() to annoy users that did not pass valid parameters to function. Fixes: b3c11ac267d461d3d5 ("drm: move allocation out of drm_get_format_name()) Cc: Eric Engestrom <eric@engestrom.ch> Cc: Rob Clark <robdclark@gmail.com> Cc: Jani Nikula <jani.nikula@intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> --- I still think sanity checking the parameters of an exported function is worth doing, even if the way one triggers the NULL pointer crash is priviledged. Not a big fan of the verbosity of BUG_ON() and would rather silently reject NULL buf pointer, but that is a matter of taste. drivers/gpu/drm/drm_fourcc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index 90d2cc8..6d80239 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -85,6 +85,8 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format); */ const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf) { + BUG_ON(!buf); + snprintf(buf->str, sizeof(buf->str), "%c%c%c%c %s-endian (0x%08x)", printable_char(format & 0xff), -- 2.10.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-11-23 10:52 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-22 16:41 [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function Liviu Dudau 2016-11-22 16:41 ` Liviu Dudau 2016-11-22 16:50 ` Ville Syrjälä 2016-11-22 16:50 ` Ville Syrjälä 2016-11-22 17:23 ` Rob Clark 2016-11-22 17:23 ` Rob Clark 2016-11-22 17:31 ` Ville Syrjälä 2016-11-22 17:31 ` Ville Syrjälä 2016-11-22 17:35 ` Rob Clark 2016-11-22 17:35 ` Rob Clark 2016-11-22 18:06 ` Ville Syrjälä 2016-11-22 18:06 ` Ville Syrjälä 2016-11-22 18:15 ` Sean Paul 2016-11-22 18:15 ` Sean Paul 2016-11-22 18:47 ` Liviu Dudau 2016-11-22 18:47 ` Liviu Dudau 2016-11-22 21:46 ` Rob Clark 2016-11-22 21:46 ` Rob Clark 2016-11-23 10:52 ` Liviu Dudau [this message] 2016-11-23 10:52 ` [PATCH v2] " Liviu Dudau 2016-11-23 11:00 ` Jani Nikula 2016-11-23 11:00 ` Jani Nikula 2016-11-23 11:23 ` Liviu Dudau 2016-11-23 11:23 ` Liviu Dudau 2016-11-23 12:26 ` Daniel Vetter 2016-11-23 12:26 ` Daniel Vetter 2016-11-23 12:47 ` Jani Nikula 2016-11-23 12:47 ` Jani Nikula 2016-11-23 13:38 ` Liviu Dudau 2016-11-23 13:38 ` Liviu Dudau 2016-11-22 18:49 ` [PATCH] " Liviu Dudau 2016-11-22 18:49 ` Liviu Dudau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161123105213.27674-1-Liviu.Dudau@arm.com \ --to=liviu.dudau@arm.com \ --cc=airlied@linux.ie \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=eric@engestrom.ch \ --cc=jani.nikula@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.