All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] ASoC: sunxi: Uninitialized variable in probe()
@ 2016-11-23 22:29 ` Dan Carpenter
  0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-11-23 22:29 UTC (permalink / raw)
  To: Liam Girdwood, Chen-Yu Tsai
  Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Maxime Ripard,
	alsa-devel, kernel-janitors

Oddly enough, my version of GCC misses this uninitialized variable.

Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/sound/soc/sunxi/sun8i-codec-analog.c b/sound/soc/sunxi/sun8i-codec-analog.c
index 222bbd4..af02290 100644
--- a/sound/soc/sunxi/sun8i-codec-analog.c
+++ b/sound/soc/sunxi/sun8i-codec-analog.c
@@ -589,7 +589,7 @@ static int sun8i_codec_analog_cmpnt_probe(struct snd_soc_component *cmpnt)
 	}
 
 	if (quirks->has_hmic) {
-		sun8i_codec_add_hmic(cmpnt);
+		ret = sun8i_codec_add_hmic(cmpnt);
 		if (ret)
 			return ret;
 	}

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [patch] ASoC: sunxi: Uninitialized variable in probe()
@ 2016-11-23 22:29 ` Dan Carpenter
  0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-11-23 22:29 UTC (permalink / raw)
  To: Liam Girdwood, Chen-Yu Tsai
  Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Maxime Ripard,
	alsa-devel, kernel-janitors

Oddly enough, my version of GCC misses this uninitialized variable.

Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/sound/soc/sunxi/sun8i-codec-analog.c b/sound/soc/sunxi/sun8i-codec-analog.c
index 222bbd4..af02290 100644
--- a/sound/soc/sunxi/sun8i-codec-analog.c
+++ b/sound/soc/sunxi/sun8i-codec-analog.c
@@ -589,7 +589,7 @@ static int sun8i_codec_analog_cmpnt_probe(struct snd_soc_component *cmpnt)
 	}
 
 	if (quirks->has_hmic) {
-		sun8i_codec_add_hmic(cmpnt);
+		ret = sun8i_codec_add_hmic(cmpnt);
 		if (ret)
 			return ret;
 	}

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [patch] ASoC: sunxi: Uninitialized variable in probe()
  2016-11-23 22:29 ` Dan Carpenter
@ 2016-11-24  4:33   ` Chen-Yu Tsai
  -1 siblings, 0 replies; 8+ messages in thread
From: Chen-Yu Tsai @ 2016-11-24  4:33 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Liam Girdwood, Chen-Yu Tsai, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Maxime Ripard, Linux-ALSA, kernel-janitors

On Thu, Nov 24, 2016 at 6:29 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Oddly enough, my version of GCC misses this uninitialized variable.
>
> Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [patch] ASoC: sunxi: Uninitialized variable in probe()
@ 2016-11-24  4:33   ` Chen-Yu Tsai
  0 siblings, 0 replies; 8+ messages in thread
From: Chen-Yu Tsai @ 2016-11-24  4:33 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Liam Girdwood, Chen-Yu Tsai, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Maxime Ripard, Linux-ALSA, kernel-janitors

On Thu, Nov 24, 2016 at 6:29 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Oddly enough, my version of GCC misses this uninitialized variable.
>
> Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [patch] ASoC: sunxi: Uninitialized variable in probe()
  2016-11-23 22:29 ` Dan Carpenter
@ 2016-11-24 10:29   ` Maxime Ripard
  -1 siblings, 0 replies; 8+ messages in thread
From: Maxime Ripard @ 2016-11-24 10:29 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Liam Girdwood, Chen-Yu Tsai, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, alsa-devel, kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

On Thu, Nov 24, 2016 at 01:29:06AM +0300, Dan Carpenter wrote:
> Oddly enough, my version of GCC misses this uninitialized variable.
> 
> Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [patch] ASoC: sunxi: Uninitialized variable in probe()
@ 2016-11-24 10:29   ` Maxime Ripard
  0 siblings, 0 replies; 8+ messages in thread
From: Maxime Ripard @ 2016-11-24 10:29 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Liam Girdwood, Chen-Yu Tsai, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, alsa-devel, kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

On Thu, Nov 24, 2016 at 01:29:06AM +0300, Dan Carpenter wrote:
> Oddly enough, my version of GCC misses this uninitialized variable.
> 
> Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Applied "ASoC: sunxi: Uninitialized variable in probe()" to the asoc tree
  2016-11-23 22:29 ` Dan Carpenter
@ 2016-11-25 13:09   ` Mark Brown
  -1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2016-11-25 13:09 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Chen-Yu Tsai, Maxime Ripard, Mark Brown, Liam Girdwood

The patch

   ASoC: sunxi: Uninitialized variable in probe()

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 999982ef7c7f8aa131d32ef551897804443a40a1 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 24 Nov 2016 01:29:06 +0300
Subject: [PATCH] ASoC: sunxi: Uninitialized variable in probe()

Oddly enough, my version of GCC misses this uninitialized variable.

Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/sunxi/sun8i-codec-analog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sunxi/sun8i-codec-analog.c b/sound/soc/sunxi/sun8i-codec-analog.c
index 222bbd440b1e..af02290ebe49 100644
--- a/sound/soc/sunxi/sun8i-codec-analog.c
+++ b/sound/soc/sunxi/sun8i-codec-analog.c
@@ -589,7 +589,7 @@ static int sun8i_codec_analog_cmpnt_probe(struct snd_soc_component *cmpnt)
 	}
 
 	if (quirks->has_hmic) {
-		sun8i_codec_add_hmic(cmpnt);
+		ret = sun8i_codec_add_hmic(cmpnt);
 		if (ret)
 			return ret;
 	}
-- 
2.10.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Applied "ASoC: sunxi: Uninitialized variable in probe()" to the asoc tree
@ 2016-11-25 13:09   ` Mark Brown
  0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2016-11-25 13:09 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Chen-Yu Tsai, Maxime Ripard, Mark Brown, Liam Girdwood

The patch

   ASoC: sunxi: Uninitialized variable in probe()

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 999982ef7c7f8aa131d32ef551897804443a40a1 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 24 Nov 2016 01:29:06 +0300
Subject: [PATCH] ASoC: sunxi: Uninitialized variable in probe()

Oddly enough, my version of GCC misses this uninitialized variable.

Fixes: ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/sunxi/sun8i-codec-analog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sunxi/sun8i-codec-analog.c b/sound/soc/sunxi/sun8i-codec-analog.c
index 222bbd440b1e..af02290ebe49 100644
--- a/sound/soc/sunxi/sun8i-codec-analog.c
+++ b/sound/soc/sunxi/sun8i-codec-analog.c
@@ -589,7 +589,7 @@ static int sun8i_codec_analog_cmpnt_probe(struct snd_soc_component *cmpnt)
 	}
 
 	if (quirks->has_hmic) {
-		sun8i_codec_add_hmic(cmpnt);
+		ret = sun8i_codec_add_hmic(cmpnt);
 		if (ret)
 			return ret;
 	}
-- 
2.10.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-11-25 13:09 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-23 22:29 [patch] ASoC: sunxi: Uninitialized variable in probe() Dan Carpenter
2016-11-23 22:29 ` Dan Carpenter
2016-11-24  4:33 ` Chen-Yu Tsai
2016-11-24  4:33   ` Chen-Yu Tsai
2016-11-24 10:29 ` Maxime Ripard
2016-11-24 10:29   ` Maxime Ripard
2016-11-25 13:09 ` Applied "ASoC: sunxi: Uninitialized variable in probe()" to the asoc tree Mark Brown
2016-11-25 13:09   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.