All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Benc <jbenc@redhat.com>
To: Jarno Rajahalme <jarno@ovn.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.
Date: Thu, 24 Nov 2016 17:10:46 +0100	[thread overview]
Message-ID: <20161124171046.7eb0e287@griffin> (raw)
In-Reply-To: <1479874174-75329-2-git-send-email-jarno@ovn.org>

On Tue, 22 Nov 2016 20:09:34 -0800, Jarno Rajahalme wrote:
> Do not set skb->protocol to be the ethertype of the L3 header, unless
> the packet only has the L3 header.  For a non-hardware offloaded VLAN
> frame skb->protocol needs to be one of the VLAN ethertypes.
> 
> Any VLAN offloading is undone on the OVS netlink interface.  Due to
> this all VLAN packets sent to openvswitch module from userspace are
> non-offloaded.

This is exactly why I wanted to always accelerate the vlan tag, the
same way it is done in other parts of the networking stack: to prevent
all those weird corner cases.

Looks to me this is the only real way forward.

This patch is wrong, it would leave skb->protocol as ETH_P_TEB for L2
frames received via ARPHRD_NONE interface.

 Jiri

  reply	other threads:[~2016-11-24 16:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23  4:09 [PATCH net-next 1/2] openvswitch: Add a missing break statement Jarno Rajahalme
2016-11-23  4:09 ` [PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames Jarno Rajahalme
2016-11-24 16:10   ` Jiri Benc [this message]
2016-11-28 22:29     ` Jarno Rajahalme
2016-11-28 22:42       ` Jiri Benc
2016-11-28 22:58         ` Jarno Rajahalme
2016-11-23 19:23 ` [PATCH net-next 1/2] openvswitch: Add a missing break statement Pravin Shelar
2016-11-24 15:55 ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161124171046.7eb0e287@griffin \
    --to=jbenc@redhat.com \
    --cc=jarno@ovn.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.