All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Benc <jbenc@redhat.com>
To: Jarno Rajahalme <jarno@ovn.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.
Date: Mon, 28 Nov 2016 23:42:46 +0100	[thread overview]
Message-ID: <20161128234246.1a886246@griffin> (raw)
In-Reply-To: <76814927-D373-4C3A-BC85-5771304235A7@ovn.org>

On Mon, 28 Nov 2016 14:29:39 -0800, Jarno Rajahalme wrote:
> I’m not sure what you suggest here. Obviously the kernel ABI can not
> be changed as existing userspace code expects upcalled packets to be
> non-accelerated. Also, if userspace pushes vlan headers, the packet
> will actually have them.

The user space API needs to be preserved, of course. I'm talking about
what happens internally in the kernel.

See this patchset: https://www.spinics.net/lists/netdev/msg398827.html

> Would this incremental fix this:
> 
> diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
> index 9be9fda..37f1bb9 100644
> --- a/net/openvswitch/flow.c
> +++ b/net/openvswitch/flow.c
> @@ -354,6 +354,8 @@ static int parse_vlan(struct sk_buff *skb, struct
> sw_flow_key *key) res = parse_vlan_tag(skb, &key->eth.vlan);
>  		if (res <= 0)
>  			return res;
> +		if (skb->protocol == htons(ETH_P_TEB))
> +			skb->protocol = key->eth.vlan.tpid;
>  	}
>  
>  	/* Parse inner vlan tag. */

I'll look at this tomorrow. But it seems we're adding more and more
hacks instead of cleaning up the vlan handling.

 Jiri

  reply	other threads:[~2016-11-28 22:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23  4:09 [PATCH net-next 1/2] openvswitch: Add a missing break statement Jarno Rajahalme
2016-11-23  4:09 ` [PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames Jarno Rajahalme
2016-11-24 16:10   ` Jiri Benc
2016-11-28 22:29     ` Jarno Rajahalme
2016-11-28 22:42       ` Jiri Benc [this message]
2016-11-28 22:58         ` Jarno Rajahalme
2016-11-23 19:23 ` [PATCH net-next 1/2] openvswitch: Add a missing break statement Pravin Shelar
2016-11-24 15:55 ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161128234246.1a886246@griffin \
    --to=jbenc@redhat.com \
    --cc=jarno@ovn.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.