From: Christoph Hellwig <hch@lst.de>
To: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Julia Lawall <julia.lawall@lip6.fr>,
kbuild-all@01.org, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
target-devel <target-devel@vger.kernel.org>,
Joel Becker <jlbec@evilplan.org>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Subject: Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings
Date: Mon, 28 Nov 2016 09:28:19 +0100 [thread overview]
Message-ID: <20161128082819.GA31105@lst.de> (raw)
In-Reply-To: <3504c280-fe7f-9ec2-0f92-2b6aea290080@samsung.com>
On Wed, Nov 23, 2016 at 09:35:36AM +0100, Andrzej Pietrasiewicz wrote:
> The ->drop_item() is indeed a void function, the ->drop_link() is
> actually not. This, together with the fact that the value of ->drop_link()
> is silently ignored suggests, that it is the ->drop_link() return
> type that should be corrected and changed to void.
Please send a patch to change it.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings
Date: Mon, 28 Nov 2016 09:28:19 +0100 [thread overview]
Message-ID: <20161128082819.GA31105@lst.de> (raw)
In-Reply-To: <3504c280-fe7f-9ec2-0f92-2b6aea290080@samsung.com>
On Wed, Nov 23, 2016@09:35:36AM +0100, Andrzej Pietrasiewicz wrote:
> The ->drop_item() is indeed a void function, the ->drop_link() is
> actually not. This, together with the fact that the value of ->drop_link()
> is silently ignored suggests, that it is the ->drop_link() return
> type that should be corrected and changed to void.
Please send a patch to change it.
next prev parent reply other threads:[~2016-11-28 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201509170828.xv0cYNA5%fengguang.wu@intel.com>
[not found] ` <20150917000130.GA25134@lkp-ib04>
2015-09-17 8:57 ` [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings Julia Lawall
2015-09-17 11:18 ` Andrzej Pietrasiewicz
2015-09-17 11:30 ` SF Markus Elfring
2016-11-22 17:27 ` Laurent Pinchart
2016-11-23 8:35 ` Andrzej Pietrasiewicz
2016-11-23 8:35 ` Andrzej Pietrasiewicz
2016-11-28 8:28 ` Christoph Hellwig [this message]
2016-11-28 8:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128082819.GA31105@lst.de \
--to=hch@lst.de \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlbec@evilplan.org \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.