All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>, Arnd Bergmann <arnd@arndb.de>,
	Kirtika Ruchandani <kirtika@chromium.org>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable
Date: Mon, 28 Nov 2016 15:53:58 -0500	[thread overview]
Message-ID: <20161128205358.GA7363@htj.duckdns.org> (raw)
In-Reply-To: <20161128073709.GA14835@dhcp22.suse.cz>

Hello,

On Mon, Nov 28, 2016 at 08:37:09AM +0100, Michal Hocko wrote:
> I would disagree here. Randomly picking up fixes just because they are
> Fixing some commit is just too dangerous for the stable trees. Fixes tag
> should tell what was the culprit of the issue fixed by the patch,
> nothing more and nothing less.

Logically, I agree but then the only time I used the Fixes tag is when
I was tagging patches for stable and I can imagine people grepping for
the tag to backport.  Also, given that the offending commit is already
referenced in the description, the tag doesn't make much difference to
human beings.  I don't think it's a big deal either way but am more
inclined to follow Li's suggestion here given that he is maintaining
stable trees.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Kirtika Ruchandani
	<kirtika-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable
Date: Mon, 28 Nov 2016 15:53:58 -0500	[thread overview]
Message-ID: <20161128205358.GA7363@htj.duckdns.org> (raw)
In-Reply-To: <20161128073709.GA14835-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

Hello,

On Mon, Nov 28, 2016 at 08:37:09AM +0100, Michal Hocko wrote:
> I would disagree here. Randomly picking up fixes just because they are
> Fixing some commit is just too dangerous for the stable trees. Fixes tag
> should tell what was the culprit of the issue fixed by the patch,
> nothing more and nothing less.

Logically, I agree but then the only time I used the Fixes tag is when
I was tagging patches for stable and I can imagine people grepping for
the tag to backport.  Also, given that the offending commit is already
referenced in the description, the tag doesn't make much difference to
human beings.  I don't think it's a big deal either way but am more
inclined to follow Li's suggestion here given that he is maintaining
stable trees.

Thanks.

-- 
tejun

  reply	other threads:[~2016-11-28 20:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  4:55 [PATCH] cpuset: Remove unused 'struct cpuset*' variable Kirtika Ruchandani
2016-11-25  5:46 ` Zefan Li
2016-11-25  5:46   ` Zefan Li
2016-11-25  9:46   ` Arnd Bergmann
2016-11-25  9:46     ` Arnd Bergmann
2016-11-26  0:42     ` Zefan Li
2016-11-26  0:42       ` Zefan Li
2016-11-28  7:37       ` Michal Hocko
2016-11-28  7:37         ` Michal Hocko
2016-11-28 20:53         ` Tejun Heo [this message]
2016-11-28 20:53           ` Tejun Heo
2016-11-28 21:07 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161128205358.GA7363@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=arnd@arndb.de \
    --cc=cgroups@vger.kernel.org \
    --cc=kirtika@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.