All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-raspberrypi][PATCH] linux-raspberrypi-base.bbclass: allow -rt kernels
Date: Mon, 28 Nov 2016 20:37:09 -0500	[thread overview]
Message-ID: <20161129013709.GA30326@openSUSE-i7.site> (raw)
In-Reply-To: <2ACF0BDF-0A7B-4A0E-BC20-B6B222F1644A@gmail.com>

On Mon 2016-11-28 @ 03:16:11 PM, Khem Raj wrote:
> 
> > On Nov 28, 2016, at 11:07 AM, Trevor Woerner <twoerner@gmail.com> wrote:
> > 
> > If the PREEMPT_RT patch is applied, the kernel version becomes, say,
> > 4.4.32-rt43 (instead of 4.4.32). This confuses the version handling code in
> > this class. Update how the version string is processed so that trailing rt-
> > strings are properly handled, in addition to handling the existing cases.
> > 
> 
> This probably will solve the issue I see with 4.9-rcX recipes that are in my tree on kraj/master

I'm not familiar with the issue you're seeing, but the existing and new code
are looking for 3 int()s separated by periods. If your recipes have the string
"4.9-rcX" then I'm guessing there might still be an issue since the third
int() will be "-rcX" in your case. If this is true, you'll need to take a look
at where "int(min_ver[2])" is used further down in that bbclass file.

> 
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > ---
> > classes/linux-raspberrypi-base.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/classes/linux-raspberrypi-base.bbclass b/classes/linux-raspberrypi-base.bbclass
> > index 3a6e33d..fecac30 100644
> > --- a/classes/linux-raspberrypi-base.bbclass
> > +++ b/classes/linux-raspberrypi-base.bbclass
> > @@ -15,7 +15,7 @@ def get_dts(d, ver=None):
> >         ver = get_kernelversion_file(staging_dir)
> > 
> >     if ver is not None:
> > -        min_ver = ver.split('.', 3)
> > +        min_ver = re.split(r'[.-]+', ver, maxsplit=3)
> >     else:
> >         return dts
> > 
> > -- 
> > 2.10.2
> > 
> > -- 
> > _______________________________________________
> > yocto mailing list
> > yocto@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/yocto
> 


  reply	other threads:[~2016-11-29  1:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 19:07 [meta-raspberrypi][PATCH] linux-raspberrypi-base.bbclass: allow -rt kernels Trevor Woerner
2016-11-28 23:16 ` Khem Raj
2016-11-29  1:37   ` Trevor Woerner [this message]
2016-12-06 18:27     ` Andrei Gherzan
2016-12-06 18:37       ` Andrei Gherzan
2016-12-07  8:02         ` Andreas Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161129013709.GA30326@openSUSE-i7.site \
    --to=twoerner@gmail.com \
    --cc=raj.khem@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.