From: Andrei Gherzan <andrei@gherzan.ro>
To: Trevor Woerner <twoerner@gmail.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-raspberrypi][PATCH] linux-raspberrypi-base.bbclass: allow -rt kernels
Date: Tue, 6 Dec 2016 18:37:40 +0000 [thread overview]
Message-ID: <20161206183740.GJ1636@carbonA> (raw)
In-Reply-To: <20161206182732.GI1636@carbonA>
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
On Tue, Dec 06, 2016 at 06:27:32PM +0000, Andrei Gherzan wrote:
> On Mon, Nov 28, 2016 at 08:37:09PM -0500, Trevor Woerner wrote:
> > On Mon 2016-11-28 @ 03:16:11 PM, Khem Raj wrote:
> > >
> > > > On Nov 28, 2016, at 11:07 AM, Trevor Woerner <twoerner@gmail.com> wrote:
> > > >
> > > > If the PREEMPT_RT patch is applied, the kernel version becomes, say,
> > > > 4.4.32-rt43 (instead of 4.4.32). This confuses the version handling code in
> > > > this class. Update how the version string is processed so that trailing rt-
> > > > strings are properly handled, in addition to handling the existing cases.
> > > >
> > >
> > > This probably will solve the issue I see with 4.9-rcX recipes that are in my tree on kraj/master
> >
> > I'm not familiar with the issue you're seeing, but the existing and new code
> > are looking for 3 int()s separated by periods. If your recipes have the string
> > "4.9-rcX" then I'm guessing there might still be an issue since the third
> > int() will be "-rcX" in your case. If this is true, you'll need to take a look
> > at where "int(min_ver[2])" is used further down in that bbclass file.
>
> I agreed this is not the best implementation of this. We should only get
agree*
> the version using a regex that would get X.Y.Z-R with an optional Z and
> R.
>
> --
> Andrei Gherzan
--
Andrei Gherzan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 817 bytes --]
next prev parent reply other threads:[~2016-12-06 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 19:07 [meta-raspberrypi][PATCH] linux-raspberrypi-base.bbclass: allow -rt kernels Trevor Woerner
2016-11-28 23:16 ` Khem Raj
2016-11-29 1:37 ` Trevor Woerner
2016-12-06 18:27 ` Andrei Gherzan
2016-12-06 18:37 ` Andrei Gherzan [this message]
2016-12-07 8:02 ` Andreas Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206183740.GJ1636@carbonA \
--to=andrei@gherzan.ro \
--cc=twoerner@gmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.