* [cryptodev:master 109/113] drivers/crypto/caam/caamalg_desc.c:67:27: warning: cast to pointer from integer of different size
@ 2016-11-28 20:08 kbuild test robot
2016-11-29 8:22 ` [PATCH] crypto: caam - fix key pointer size warning Horia Geantă
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2016-11-28 20:08 UTC (permalink / raw)
To: Horia Geantă; +Cc: kbuild-all, linux-crypto, Herbert Xu
[-- Attachment #1: Type: text/plain, Size: 7019 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: eb0955935e2ae3aa1fc9c34ec684ffe086e81da7
commit: 8cea7b66b821fd914aa26a2af156604f9ef5f709 [109/113] crypto: caam - refactor encryption descriptors generation
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 8cea7b66b821fd914aa26a2af156604f9ef5f709
# save the attached .config to linux build tree
make.cross ARCH=arm
All warnings (new ones prefixed by >>):
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_aead_null_encap':
>> drivers/crypto/caam/caamalg_desc.c:67:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_aead_null_decap':
drivers/crypto/caam/caamalg_desc.c:143:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
^
drivers/crypto/caam/caamalg_desc.c: In function 'init_sh_desc_key_aead':
drivers/crypto/caam/caamalg_desc.c:228:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
^
drivers/crypto/caam/caamalg_desc.c:236:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, enckeylen,
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_gcm_encap':
drivers/crypto/caam/caamalg_desc.c:539:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_gcm_decap':
drivers/crypto/caam/caamalg_desc.c:629:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_rfc4106_encap':
drivers/crypto/caam/caamalg_desc.c:705:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_rfc4106_decap':
drivers/crypto/caam/caamalg_desc.c:776:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_rfc4543_encap':
drivers/crypto/caam/caamalg_desc.c:848:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_rfc4543_decap':
drivers/crypto/caam/caamalg_desc.c:918:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_ablkcipher_encap':
drivers/crypto/caam/caamalg_desc.c:1009:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c:1014:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
u8 *nonce = (u8 *)cdata->key + cdata->keylen;
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_ablkcipher_decap':
drivers/crypto/caam/caamalg_desc.c:1074:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c:1079:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
u8 *nonce = (u8 *)cdata->key + cdata->keylen;
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_ablkcipher_givencap':
drivers/crypto/caam/caamalg_desc.c:1143:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c:1148:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
u8 *nonce = (u8 *)cdata->key + cdata->keylen;
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_xts_ablkcipher_encap':
drivers/crypto/caam/caamalg_desc.c:1219:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_xts_ablkcipher_decap':
drivers/crypto/caam/caamalg_desc.c:1271:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
^
vim +67 drivers/crypto/caam/caamalg_desc.c
51 * SHA224, SHA256, SHA384, SHA512} ANDed with OP_ALG_AAI_HMAC_PRECOMP.
52 * @icvsize: integrity check value (ICV) size (truncated or full)
53 *
54 * Note: Requires an MDHA split key.
55 */
56 void cnstr_shdsc_aead_null_encap(u32 * const desc, struct alginfo *adata,
57 unsigned int icvsize)
58 {
59 u32 *key_jump_cmd, *read_move_cmd, *write_move_cmd;
60
61 init_sh_desc(desc, HDR_SHARE_SERIAL);
62
63 /* Skip if already shared */
64 key_jump_cmd = append_jump(desc, JUMP_JSL | JUMP_TEST_ALL |
65 JUMP_COND_SHRD);
66 if (adata->key_inline)
> 67 append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
68 adata->keylen, CLASS_2 | KEY_DEST_MDHA_SPLIT |
69 KEY_ENC);
70 else
71 append_key(desc, adata->key, adata->keylen, CLASS_2 |
72 KEY_DEST_MDHA_SPLIT | KEY_ENC);
73 set_jump_tgt_here(desc, key_jump_cmd);
74
75 /* assoclen + cryptlen = seqinlen */
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 59446 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] crypto: caam - fix key pointer size warning
2016-11-28 20:08 [cryptodev:master 109/113] drivers/crypto/caam/caamalg_desc.c:67:27: warning: cast to pointer from integer of different size kbuild test robot
@ 2016-11-29 8:22 ` Horia Geantă
2016-12-01 12:53 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Horia Geantă @ 2016-11-29 8:22 UTC (permalink / raw)
To: Herbert Xu; +Cc: David S. Miller, linux-crypto, Dan Douglass
When building on 32-bit, compiler issues [-Wint-to-pointer-cast] warnings:
drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_aead_null_encap':
drivers/crypto/caam/caamalg_desc.c:67:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
[...]
Since in all these cases the u64 "key" member of alginfo struct holds
a uintptr_t value, we can safely remove the warnings by explicitly casting
to uinptr_t (before any other existing cast).
Fixes: 8cea7b66b821 ("crypto: caam - refactor encryption descriptors generation")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
---
drivers/crypto/caam/caamalg_desc.c | 64 +++++++++++++++++++++-----------------
1 file changed, 35 insertions(+), 29 deletions(-)
diff --git a/drivers/crypto/caam/caamalg_desc.c b/drivers/crypto/caam/caamalg_desc.c
index fa2479d9da24..d4ccd164890d 100644
--- a/drivers/crypto/caam/caamalg_desc.c
+++ b/drivers/crypto/caam/caamalg_desc.c
@@ -64,9 +64,9 @@ void cnstr_shdsc_aead_null_encap(u32 * const desc, struct alginfo *adata,
key_jump_cmd = append_jump(desc, JUMP_JSL | JUMP_TEST_ALL |
JUMP_COND_SHRD);
if (adata->key_inline)
- append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
- adata->keylen, CLASS_2 | KEY_DEST_MDHA_SPLIT |
- KEY_ENC);
+ append_key_as_imm(desc, (void *)(uintptr_t)adata->key,
+ adata->keylen_pad, adata->keylen, CLASS_2 |
+ KEY_DEST_MDHA_SPLIT | KEY_ENC);
else
append_key(desc, adata->key, adata->keylen, CLASS_2 |
KEY_DEST_MDHA_SPLIT | KEY_ENC);
@@ -140,8 +140,8 @@ void cnstr_shdsc_aead_null_decap(u32 * const desc, struct alginfo *adata,
key_jump_cmd = append_jump(desc, JUMP_JSL | JUMP_TEST_ALL |
JUMP_COND_SHRD);
if (adata->key_inline)
- append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
- adata->keylen, CLASS_2 |
+ append_key_as_imm(desc, (void *)(uintptr_t)adata->key,
+ adata->keylen_pad, adata->keylen, CLASS_2 |
KEY_DEST_MDHA_SPLIT | KEY_ENC);
else
append_key(desc, adata->key, adata->keylen, CLASS_2 |
@@ -225,16 +225,17 @@ static void init_sh_desc_key_aead(u32 * const desc,
enckeylen -= CTR_RFC3686_NONCE_SIZE;
if (adata->key_inline)
- append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
- adata->keylen, CLASS_2 |
+ append_key_as_imm(desc, (void *)(uintptr_t)adata->key,
+ adata->keylen_pad, adata->keylen, CLASS_2 |
KEY_DEST_MDHA_SPLIT | KEY_ENC);
else
append_key(desc, adata->key, adata->keylen, CLASS_2 |
KEY_DEST_MDHA_SPLIT | KEY_ENC);
if (cdata->key_inline)
- append_key_as_imm(desc, (void *)cdata->key, enckeylen,
- enckeylen, CLASS_1 | KEY_DEST_CLASS_REG);
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key,
+ enckeylen, enckeylen, CLASS_1 |
+ KEY_DEST_CLASS_REG);
else
append_key(desc, cdata->key, enckeylen, CLASS_1 |
KEY_DEST_CLASS_REG);
@@ -536,8 +537,9 @@ void cnstr_shdsc_gcm_encap(u32 * const desc, struct alginfo *cdata,
key_jump_cmd = append_jump(desc, JUMP_JSL | JUMP_TEST_ALL |
JUMP_COND_SHRD | JUMP_COND_SELF);
if (cdata->key_inline)
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
- cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key,
+ cdata->keylen, cdata->keylen, CLASS_1 |
+ KEY_DEST_CLASS_REG);
else
append_key(desc, cdata->key, cdata->keylen, CLASS_1 |
KEY_DEST_CLASS_REG);
@@ -626,8 +628,9 @@ void cnstr_shdsc_gcm_decap(u32 * const desc, struct alginfo *cdata,
JUMP_TEST_ALL | JUMP_COND_SHRD |
JUMP_COND_SELF);
if (cdata->key_inline)
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
- cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key,
+ cdata->keylen, cdata->keylen, CLASS_1 |
+ KEY_DEST_CLASS_REG);
else
append_key(desc, cdata->key, cdata->keylen, CLASS_1 |
KEY_DEST_CLASS_REG);
@@ -702,8 +705,9 @@ void cnstr_shdsc_rfc4106_encap(u32 * const desc, struct alginfo *cdata,
key_jump_cmd = append_jump(desc, JUMP_JSL | JUMP_TEST_ALL |
JUMP_COND_SHRD);
if (cdata->key_inline)
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
- cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key,
+ cdata->keylen, cdata->keylen, CLASS_1 |
+ KEY_DEST_CLASS_REG);
else
append_key(desc, cdata->key, cdata->keylen, CLASS_1 |
KEY_DEST_CLASS_REG);
@@ -773,8 +777,8 @@ void cnstr_shdsc_rfc4106_decap(u32 * const desc, struct alginfo *cdata,
key_jump_cmd = append_jump(desc, JUMP_JSL | JUMP_TEST_ALL |
JUMP_COND_SHRD);
if (cdata->key_inline)
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
- cdata->keylen, CLASS_1 |
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key,
+ cdata->keylen, cdata->keylen, CLASS_1 |
KEY_DEST_CLASS_REG);
else
append_key(desc, cdata->key, cdata->keylen, CLASS_1 |
@@ -845,8 +849,9 @@ void cnstr_shdsc_rfc4543_encap(u32 * const desc, struct alginfo *cdata,
key_jump_cmd = append_jump(desc, JUMP_JSL | JUMP_TEST_ALL |
JUMP_COND_SHRD);
if (cdata->key_inline)
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
- cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key,
+ cdata->keylen, cdata->keylen, CLASS_1 |
+ KEY_DEST_CLASS_REG);
else
append_key(desc, cdata->key, cdata->keylen, CLASS_1 |
KEY_DEST_CLASS_REG);
@@ -915,8 +920,9 @@ void cnstr_shdsc_rfc4543_decap(u32 * const desc, struct alginfo *cdata,
key_jump_cmd = append_jump(desc, JUMP_JSL | JUMP_TEST_ALL |
JUMP_COND_SHRD);
if (cdata->key_inline)
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
- cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key,
+ cdata->keylen, cdata->keylen, CLASS_1 |
+ KEY_DEST_CLASS_REG);
else
append_key(desc, cdata->key, cdata->keylen, CLASS_1 |
KEY_DEST_CLASS_REG);
@@ -1006,12 +1012,12 @@ void cnstr_shdsc_ablkcipher_encap(u32 * const desc, struct alginfo *cdata,
JUMP_COND_SHRD);
/* Load class1 key only */
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key, cdata->keylen,
cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
/* Load nonce into CONTEXT1 reg */
if (is_rfc3686) {
- u8 *nonce = (u8 *)cdata->key + cdata->keylen;
+ u8 *nonce = (u8 *)(uintptr_t)cdata->key + cdata->keylen;
append_load_as_imm(desc, nonce, CTR_RFC3686_NONCE_SIZE,
LDST_CLASS_IND_CCB |
@@ -1071,12 +1077,12 @@ void cnstr_shdsc_ablkcipher_decap(u32 * const desc, struct alginfo *cdata,
JUMP_COND_SHRD);
/* Load class1 key only */
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key, cdata->keylen,
cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
/* Load nonce into CONTEXT1 reg */
if (is_rfc3686) {
- u8 *nonce = (u8 *)cdata->key + cdata->keylen;
+ u8 *nonce = (u8 *)(uintptr_t)cdata->key + cdata->keylen;
append_load_as_imm(desc, nonce, CTR_RFC3686_NONCE_SIZE,
LDST_CLASS_IND_CCB |
@@ -1140,12 +1146,12 @@ void cnstr_shdsc_ablkcipher_givencap(u32 * const desc, struct alginfo *cdata,
JUMP_COND_SHRD);
/* Load class1 key only */
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key, cdata->keylen,
cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
/* Load Nonce into CONTEXT1 reg */
if (is_rfc3686) {
- u8 *nonce = (u8 *)cdata->key + cdata->keylen;
+ u8 *nonce = (u8 *)(uintptr_t)cdata->key + cdata->keylen;
append_load_as_imm(desc, nonce, CTR_RFC3686_NONCE_SIZE,
LDST_CLASS_IND_CCB |
@@ -1216,7 +1222,7 @@ void cnstr_shdsc_xts_ablkcipher_encap(u32 * const desc, struct alginfo *cdata)
JUMP_COND_SHRD);
/* Load class1 keys only */
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key, cdata->keylen,
cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
/* Load sector size with index 40 bytes (0x28) */
@@ -1268,7 +1274,7 @@ void cnstr_shdsc_xts_ablkcipher_decap(u32 * const desc, struct alginfo *cdata)
JUMP_COND_SHRD);
/* Load class1 key only */
- append_key_as_imm(desc, (void *)cdata->key, cdata->keylen,
+ append_key_as_imm(desc, (void *)(uintptr_t)cdata->key, cdata->keylen,
cdata->keylen, CLASS_1 | KEY_DEST_CLASS_REG);
/* Load sector size with index 40 bytes (0x28) */
--
2.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: caam - fix key pointer size warning
2016-11-29 8:22 ` [PATCH] crypto: caam - fix key pointer size warning Horia Geantă
@ 2016-12-01 12:53 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2016-12-01 12:53 UTC (permalink / raw)
To: Horia Geantă; +Cc: David S. Miller, linux-crypto, Dan Douglass
On Tue, Nov 29, 2016 at 10:22:49AM +0200, Horia Geantă wrote:
> When building on 32-bit, compiler issues [-Wint-to-pointer-cast] warnings:
>
> drivers/crypto/caam/caamalg_desc.c: In function 'cnstr_shdsc_aead_null_encap':
> drivers/crypto/caam/caamalg_desc.c:67:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> append_key_as_imm(desc, (void *)adata->key, adata->keylen_pad,
> [...]
>
> Since in all these cases the u64 "key" member of alginfo struct holds
> a uintptr_t value, we can safely remove the warnings by explicitly casting
> to uinptr_t (before any other existing cast).
>
> Fixes: 8cea7b66b821 ("crypto: caam - refactor encryption descriptors generation")
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Thanks for the patch. I think Arnd's version is cleaner though
so I'll take that instead.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-01 12:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-28 20:08 [cryptodev:master 109/113] drivers/crypto/caam/caamalg_desc.c:67:27: warning: cast to pointer from integer of different size kbuild test robot
2016-11-29 8:22 ` [PATCH] crypto: caam - fix key pointer size warning Horia Geantă
2016-12-01 12:53 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.