All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-qt5][PATCH] gdb: Fix QA Warning
@ 2016-12-02  9:20 Gordan Markuš
  2016-12-02  9:45 ` Burton, Ross
  2016-12-02  9:54 ` Martin Jansa
  0 siblings, 2 replies; 6+ messages in thread
From: Gordan Markuš @ 2016-12-02  9:20 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Gordan Markuš

WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline [invalid-packageconfig]

Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
---
 recipes-devtools/gdb/gdb_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-devtools/gdb/gdb_%.bbappend b/recipes-devtools/gdb/gdb_%.bbappend
index 3e663e7..41592c4 100644
--- a/recipes-devtools/gdb/gdb_%.bbappend
+++ b/recipes-devtools/gdb/gdb_%.bbappend
@@ -1 +1 @@
-PACKAGECONFIG ??= "readline python"
+PACKAGECONFIG ??= "python"
-- 
2.9.3



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [meta-qt5][PATCH] gdb: Fix QA Warning
  2016-12-02  9:20 [meta-qt5][PATCH] gdb: Fix QA Warning Gordan Markuš
@ 2016-12-02  9:45 ` Burton, Ross
  2016-12-02  9:54 ` Martin Jansa
  1 sibling, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2016-12-02  9:45 UTC (permalink / raw)
  To: OpenEmbedded Devel List; +Cc: Gordan Markuš

On 2 December 2016 at 09:20, Gordan Markuš <gordan.markus@pelagicore.com>
wrote:

> diff --git a/recipes-devtools/gdb/gdb_%.bbappend
> b/recipes-devtools/gdb/gdb_%.bbappend
> index 3e663e7..41592c4 100644
> --- a/recipes-devtools/gdb/gdb_%.bbappend
> +++ b/recipes-devtools/gdb/gdb_%.bbappend
> @@ -1 +1 @@
> -PACKAGECONFIG ??= "readline python"
> +PACKAGECONFIG ??= "python"
>

This should be PACKAGECONFIG_append = " python", surely.

Ross


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-qt5][PATCH] gdb: Fix QA Warning
  2016-12-02  9:20 [meta-qt5][PATCH] gdb: Fix QA Warning Gordan Markuš
  2016-12-02  9:45 ` Burton, Ross
@ 2016-12-02  9:54 ` Martin Jansa
  2016-12-02 10:21   ` Gordan Markuš
  1 sibling, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2016-12-02  9:54 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Gordan Markuš

[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]

On Fri, Dec 02, 2016 at 10:20:11AM +0100, Gordan Markuš wrote:
> WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline [invalid-packageconfig]
> 
> Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
> ---
>  recipes-devtools/gdb/gdb_%.bbappend | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-devtools/gdb/gdb_%.bbappend b/recipes-devtools/gdb/gdb_%.bbappend
> index 3e663e7..41592c4 100644
> --- a/recipes-devtools/gdb/gdb_%.bbappend
> +++ b/recipes-devtools/gdb/gdb_%.bbappend
> @@ -1 +1 @@
> -PACKAGECONFIG ??= "readline python"
> +PACKAGECONFIG ??= "python"

What gdb are you using? The version in oe-core has readline
PACKAGECONFIG

meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG ??= "readline"
meta/recipes-devtools/gdb/gdb-common.inc:# Use --without-system-readline to compile with readline 5.
meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,readline"

> -- 
> 2.9.3
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-qt5][PATCH] gdb: Fix QA Warning
  2016-12-02  9:54 ` Martin Jansa
@ 2016-12-02 10:21   ` Gordan Markuš
  2016-12-02 10:31     ` Martin Jansa
  0 siblings, 1 reply; 6+ messages in thread
From: Gordan Markuš @ 2016-12-02 10:21 UTC (permalink / raw)
  To: Martin Jansa, openembedded-devel

On Fri, 2016-12-02 at 10:54 +0100, Martin Jansa wrote:
> On Fri, Dec 02, 2016 at 10:20:11AM +0100, Gordan Markuš wrote:
> > WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline [invalid-
> > packageconfig]
> > 
> > Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
> > ---
> >  recipes-devtools/gdb/gdb_%.bbappend | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/recipes-devtools/gdb/gdb_%.bbappend b/recipes-
> > devtools/gdb/gdb_%.bbappend
> > index 3e663e7..41592c4 100644
> > --- a/recipes-devtools/gdb/gdb_%.bbappend
> > +++ b/recipes-devtools/gdb/gdb_%.bbappend
> > @@ -1 +1 @@
> > -PACKAGECONFIG ??= "readline python"
> > +PACKAGECONFIG ??= "python"
> 
> What gdb are you using? The version in oe-core has readline
> PACKAGECONFIG
> 
> meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG ??= "readline"
> meta/recipes-devtools/gdb/gdb-common.inc:# Use --without-system-
> readline to compile with readline 5.
> meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG[readline] = "-
> -with-system-readline,--without-system-readline,readline"
> 
We are using the gdb from poky and it's a similar case there. Though, 
the gdb itself doesn't have the readline PACKAGECONFIG. It is enabled
by default in the *.inc files. 

gdb-cross-canadian.inc:PACKAGECONFIG ??= "python readline"
gdb-cross-canadian.inc:PACKAGECONFIG[readline] = "--with-system-
readline,--without-system-readline,nativesdk-readline"
gdb-common.inc:PACKAGECONFIG ??= "readline"
gdb-common.inc:PACKAGECONFIG[readline] = "--with-system-readline,
--without-system-readline,readline"
gdb-cross.inc:PACKAGECONFIG ??= "python readline"
gdb-cross.inc:PACKAGECONFIG[readline] = "--with-system-readline,
--without-system-readline,readline-native"

> > -- 
> > 2.9.3
> > 
> > -- 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-qt5][PATCH] gdb: Fix QA Warning
  2016-12-02 10:21   ` Gordan Markuš
@ 2016-12-02 10:31     ` Martin Jansa
  2016-12-02 13:19       ` Gordan Markuš
  0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2016-12-02 10:31 UTC (permalink / raw)
  To: Gordan Markuš; +Cc: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]

On Fri, Dec 02, 2016 at 11:21:13AM +0100, Gordan Markuš wrote:
> On Fri, 2016-12-02 at 10:54 +0100, Martin Jansa wrote:
> > On Fri, Dec 02, 2016 at 10:20:11AM +0100, Gordan Markuš wrote:
> > > WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline [invalid-
> > > packageconfig]
> > > 
> > > Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
> > > ---
> > >  recipes-devtools/gdb/gdb_%.bbappend | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/recipes-devtools/gdb/gdb_%.bbappend b/recipes-
> > > devtools/gdb/gdb_%.bbappend
> > > index 3e663e7..41592c4 100644
> > > --- a/recipes-devtools/gdb/gdb_%.bbappend
> > > +++ b/recipes-devtools/gdb/gdb_%.bbappend
> > > @@ -1 +1 @@
> > > -PACKAGECONFIG ??= "readline python"
> > > +PACKAGECONFIG ??= "python"
> > 
> > What gdb are you using? The version in oe-core has readline
> > PACKAGECONFIG
> > 
> > meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG ??= "readline"
> > meta/recipes-devtools/gdb/gdb-common.inc:# Use --without-system-
> > readline to compile with readline 5.
> > meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG[readline] = "-
> > -with-system-readline,--without-system-readline,readline"
> > 
> We are using the gdb from poky and it's a similar case there. Though, 
> the gdb itself doesn't have the readline PACKAGECONFIG. It is enabled
> by default in the *.inc files. 

No, it isn't, read:
https://patchwork.openembedded.org/patch/116843/
discussion.

> gdb-cross-canadian.inc:PACKAGECONFIG ??= "python readline"
> gdb-cross-canadian.inc:PACKAGECONFIG[readline] = "--with-system-
> readline,--without-system-readline,nativesdk-readline"
> gdb-common.inc:PACKAGECONFIG ??= "readline"
> gdb-common.inc:PACKAGECONFIG[readline] = "--with-system-readline,
> --without-system-readline,readline"
> gdb-cross.inc:PACKAGECONFIG ??= "python readline"
> gdb-cross.inc:PACKAGECONFIG[readline] = "--with-system-readline,
> --without-system-readline,readline-native"
> 
> > > -- 
> > > 2.9.3
> > > 
> > > -- 
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > 
> > 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-qt5][PATCH] gdb: Fix QA Warning
  2016-12-02 10:31     ` Martin Jansa
@ 2016-12-02 13:19       ` Gordan Markuš
  0 siblings, 0 replies; 6+ messages in thread
From: Gordan Markuš @ 2016-12-02 13:19 UTC (permalink / raw)
  To: Martin Jansa; +Cc: openembedded-devel

On Fri, 2016-12-02 at 11:31 +0100, Martin Jansa wrote:
> On Fri, Dec 02, 2016 at 11:21:13AM +0100, Gordan Markuš wrote:
> > On Fri, 2016-12-02 at 10:54 +0100, Martin Jansa wrote:
> > > On Fri, Dec 02, 2016 at 10:20:11AM +0100, Gordan Markuš wrote:
> > > > WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline
> > > > [invalid-
> > > > packageconfig]
> > > > 
> > > > Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
> > > > ---
> > > >  recipes-devtools/gdb/gdb_%.bbappend | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/recipes-devtools/gdb/gdb_%.bbappend b/recipes-
> > > > devtools/gdb/gdb_%.bbappend
> > > > index 3e663e7..41592c4 100644
> > > > --- a/recipes-devtools/gdb/gdb_%.bbappend
> > > > +++ b/recipes-devtools/gdb/gdb_%.bbappend
> > > > @@ -1 +1 @@
> > > > -PACKAGECONFIG ??= "readline python"
> > > > +PACKAGECONFIG ??= "python"
> > > 
> > > What gdb are you using? The version in oe-core has readline
> > > PACKAGECONFIG
> > > 
> > > meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG ??=
> > > "readline"
> > > meta/recipes-devtools/gdb/gdb-common.inc:# Use --without-system-
> > > readline to compile with readline 5.
> > > meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG[readline]
> > > = "-
> > > -with-system-readline,--without-system-readline,readline"
> > > 
> > 
> > We are using the gdb from poky and it's a similar case there.
> > Though, 
> > the gdb itself doesn't have the readline PACKAGECONFIG. It is
> > enabled
> > by default in the *.inc files. 
> 
> No, it isn't, read:
> https://patchwork.openembedded.org/patch/116843/
> discussion.
In that case the patch can be discarded.
Thank you for sharing this Martin!
> 
> > gdb-cross-canadian.inc:PACKAGECONFIG ??= "python readline"
> > gdb-cross-canadian.inc:PACKAGECONFIG[readline] = "--with-system-
> > readline,--without-system-readline,nativesdk-readline"
> > gdb-common.inc:PACKAGECONFIG ??= "readline"
> > gdb-common.inc:PACKAGECONFIG[readline] = "--with-system-readline,
> > --without-system-readline,readline"
> > gdb-cross.inc:PACKAGECONFIG ??= "python readline"
> > gdb-cross.inc:PACKAGECONFIG[readline] = "--with-system-readline,
> > --without-system-readline,readline-native"
> > 
> > > > -- 
> > > > 2.9.3
> > > > 
> > > > -- 
> > > > _______________________________________________
> > > > Openembedded-devel mailing list
> > > > Openembedded-devel@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-dev
> > > > el
> > > 
> > > 
> 
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-12-02 13:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-02  9:20 [meta-qt5][PATCH] gdb: Fix QA Warning Gordan Markuš
2016-12-02  9:45 ` Burton, Ross
2016-12-02  9:54 ` Martin Jansa
2016-12-02 10:21   ` Gordan Markuš
2016-12-02 10:31     ` Martin Jansa
2016-12-02 13:19       ` Gordan Markuš

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.