* [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge
@ 2016-12-02 21:23 Dinh Nguyen
2016-12-03 16:41 ` Moritz Fischer
0 siblings, 1 reply; 3+ messages in thread
From: Dinh Nguyen @ 2016-12-02 21:23 UTC (permalink / raw)
To: atull; +Cc: dinguyen, moritz.fischer, linux-fpga, linux-kernel, Dinh Nguyen
Fix up these sparse warnings:
drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not
declared. Should it be static?
drivers/fpga/fpga-bridge.c:30:12: warning: symbol 'bridge_list_lock' was
not declared. Should it be static?
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
drivers/fpga/fpga-bridge.c | 2 +-
drivers/fpga/fpga-mgr.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
index 33ee83e..e04a899 100644
--- a/drivers/fpga/fpga-bridge.c
+++ b/drivers/fpga/fpga-bridge.c
@@ -27,7 +27,7 @@ static DEFINE_IDA(fpga_bridge_ida);
static struct class *fpga_bridge_class;
/* Lock for adding/removing bridges to linked lists*/
-spinlock_t bridge_list_lock;
+static spinlock_t bridge_list_lock;
static int fpga_bridge_of_node_match(struct device *dev, const void *data)
{
diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
index f0a69d3..32860dd 100644
--- a/drivers/fpga/fpga-mgr.c
+++ b/drivers/fpga/fpga-mgr.c
@@ -186,7 +186,7 @@ static struct attribute *fpga_mgr_attrs[] = {
};
ATTRIBUTE_GROUPS(fpga_mgr);
-struct fpga_manager *__fpga_mgr_get(struct device *dev)
+static struct fpga_manager *__fpga_mgr_get(struct device *dev)
{
struct fpga_manager *mgr;
int ret = -ENODEV;
--
2.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge
2016-12-02 21:23 [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge Dinh Nguyen
@ 2016-12-03 16:41 ` Moritz Fischer
2016-12-04 1:34 ` atull
0 siblings, 1 reply; 3+ messages in thread
From: Moritz Fischer @ 2016-12-03 16:41 UTC (permalink / raw)
To: Dinh Nguyen; +Cc: Alan Tull, dinguyen, linux-fpga, Linux Kernel Mailing List
On Fri, Dec 2, 2016 at 1:23 PM, Dinh Nguyen <dinguyen@kernel.org> wrote:
> Fix up these sparse warnings:
>
> drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not
> declared. Should it be static?
> drivers/fpga/fpga-bridge.c:30:12: warning: symbol 'bridge_list_lock' was
> not declared. Should it be static?
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
Acked-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/fpga-bridge.c | 2 +-
> drivers/fpga/fpga-mgr.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
> index 33ee83e..e04a899 100644
> --- a/drivers/fpga/fpga-bridge.c
> +++ b/drivers/fpga/fpga-bridge.c
> @@ -27,7 +27,7 @@ static DEFINE_IDA(fpga_bridge_ida);
> static struct class *fpga_bridge_class;
>
> /* Lock for adding/removing bridges to linked lists*/
> -spinlock_t bridge_list_lock;
> +static spinlock_t bridge_list_lock;
>
> static int fpga_bridge_of_node_match(struct device *dev, const void *data)
> {
> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> index f0a69d3..32860dd 100644
> --- a/drivers/fpga/fpga-mgr.c
> +++ b/drivers/fpga/fpga-mgr.c
> @@ -186,7 +186,7 @@ static struct attribute *fpga_mgr_attrs[] = {
> };
> ATTRIBUTE_GROUPS(fpga_mgr);
>
> -struct fpga_manager *__fpga_mgr_get(struct device *dev)
> +static struct fpga_manager *__fpga_mgr_get(struct device *dev)
> {
> struct fpga_manager *mgr;
> int ret = -ENODEV;
> --
> 2.8.3
>
Thanks,
Moritz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge
2016-12-03 16:41 ` Moritz Fischer
@ 2016-12-04 1:34 ` atull
0 siblings, 0 replies; 3+ messages in thread
From: atull @ 2016-12-04 1:34 UTC (permalink / raw)
To: Moritz Fischer
Cc: Dinh Nguyen, dinguyen, linux-fpga, Linux Kernel Mailing List
On Sat, 3 Dec 2016, Moritz Fischer wrote:
> On Fri, Dec 2, 2016 at 1:23 PM, Dinh Nguyen <dinguyen@kernel.org> wrote:
> > Fix up these sparse warnings:
> >
> > drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not
> > declared. Should it be static?
> > drivers/fpga/fpga-bridge.c:30:12: warning: symbol 'bridge_list_lock' was
> > not declared. Should it be static?
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> Acked-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@opensource.altera.com>
>
> > ---
> > drivers/fpga/fpga-bridge.c | 2 +-
> > drivers/fpga/fpga-mgr.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c
> > index 33ee83e..e04a899 100644
> > --- a/drivers/fpga/fpga-bridge.c
> > +++ b/drivers/fpga/fpga-bridge.c
> > @@ -27,7 +27,7 @@ static DEFINE_IDA(fpga_bridge_ida);
> > static struct class *fpga_bridge_class;
> >
> > /* Lock for adding/removing bridges to linked lists*/
> > -spinlock_t bridge_list_lock;
> > +static spinlock_t bridge_list_lock;
> >
> > static int fpga_bridge_of_node_match(struct device *dev, const void *data)
> > {
> > diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> > index f0a69d3..32860dd 100644
> > --- a/drivers/fpga/fpga-mgr.c
> > +++ b/drivers/fpga/fpga-mgr.c
> > @@ -186,7 +186,7 @@ static struct attribute *fpga_mgr_attrs[] = {
> > };
> > ATTRIBUTE_GROUPS(fpga_mgr);
> >
> > -struct fpga_manager *__fpga_mgr_get(struct device *dev)
> > +static struct fpga_manager *__fpga_mgr_get(struct device *dev)
> > {
> > struct fpga_manager *mgr;
> > int ret = -ENODEV;
> > --
> > 2.8.3
> >
>
> Thanks,
> Moritz
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-04 1:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-02 21:23 [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge Dinh Nguyen
2016-12-03 16:41 ` Moritz Fischer
2016-12-04 1:34 ` atull
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.