* [PATCH] staging : i4l : Remove blank lines
@ 2016-12-14 20:08 Tabrez Khan
2016-12-14 20:23 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Tabrez Khan @ 2016-12-14 20:08 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Tabrez khan
From: Tabrez khan <khan.tabrez21@gmail.com>
Remove blank lines.
Signed-off-by: Tabrez khan <khan.tabrez21@gmail.com>
---
drivers/staging/i4l/act2000/module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
index fc14de4..b2ebaf0 100644
--- a/drivers/staging/i4l/act2000/module.c
+++ b/drivers/staging/i4l/act2000/module.c
@@ -563,7 +563,6 @@ if_sendbuf(int id, int channel, int ack, struct sk_buff *skb)
return -ENODEV;
}
-
/*
* Allocate a new card-struct, initialize it
* link it into cards-list.
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging : i4l : Remove blank lines
2016-12-14 20:08 [PATCH] staging : i4l : Remove blank lines Tabrez Khan
@ 2016-12-14 20:23 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-12-14 20:23 UTC (permalink / raw)
To: Tabrez Khan; +Cc: devel, linux-kernel
On Thu, Dec 15, 2016 at 01:38:18AM +0530, Tabrez Khan wrote:
> From: Tabrez khan <khan.tabrez21@gmail.com>
>
> Remove blank lines.
That says what you do, but you did not describe _why_ you did it, which
is more important (hint, we can read the change and see what you did...)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging : i4l : Remove blank lines
2016-12-14 21:19 Tabrez khan
@ 2016-12-14 22:23 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-12-14 22:23 UTC (permalink / raw)
To: Tabrez khan; +Cc: devel, linux-kernel
On Thu, Dec 15, 2016 at 02:49:49AM +0530, Tabrez khan wrote:
> Remove unnecessary blank lines.
> This warning was found using checkpatch.pl.
>
> Signed-off-by: Tabrez khan <khan.tabrez21@gmail.com>
> ---
> drivers/staging/i4l/act2000/module.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
> index fc14de4..b2ebaf0 100644
> --- a/drivers/staging/i4l/act2000/module.c
> +++ b/drivers/staging/i4l/act2000/module.c
> @@ -563,7 +563,6 @@ if_sendbuf(int id, int channel, int ack, struct sk_buff *skb)
> return -ENODEV;
> }
>
> -
> /*
> * Allocate a new card-struct, initialize it
> * link it into cards-list.
Your description, and subject: do not match what the patch did :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging : i4l : Remove blank lines
@ 2016-12-14 21:19 Tabrez khan
2016-12-14 22:23 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Tabrez khan @ 2016-12-14 21:19 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
Remove unnecessary blank lines.
This warning was found using checkpatch.pl.
Signed-off-by: Tabrez khan <khan.tabrez21@gmail.com>
---
drivers/staging/i4l/act2000/module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
index fc14de4..b2ebaf0 100644
--- a/drivers/staging/i4l/act2000/module.c
+++ b/drivers/staging/i4l/act2000/module.c
@@ -563,7 +563,6 @@ if_sendbuf(int id, int channel, int ack, struct sk_buff *skb)
return -ENODEV;
}
-
/*
* Allocate a new card-struct, initialize it
* link it into cards-list.
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-14 22:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-14 20:08 [PATCH] staging : i4l : Remove blank lines Tabrez Khan
2016-12-14 20:23 ` Greg KH
2016-12-14 21:19 Tabrez khan
2016-12-14 22:23 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.