From: Andrew Lunn <andrew@lunn.ch>
To: Romain Perier <romain.perier@free-electrons.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <pawel.moll@arm.com>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Nadav Haklai <nadavh@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Gregory Clement <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/4] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports
Date: Mon, 19 Dec 2016 15:56:06 +0100 [thread overview]
Message-ID: <20161219145606.GD10048@lunn.ch> (raw)
In-Reply-To: <20161219141610.30934-3-romain.perier@free-electrons.com>
On Mon, Dec 19, 2016 at 03:16:07PM +0100, Romain Perier wrote:
> Some Marvell ethernet switches have internal ethernet transceivers with
> hardcoded phy addresses. These addresses can be grearer than the number
> of ports or its value might be different than the associated port number.
> This is for example the case for MV88E6341 that has 6 ports and internal
> Port 1 to Port4 PHYs mapped at SMI addresses from 0x11 to 0x14.
>
> This commits fixes the issue by removing the condition in MDIO callbacks.
>
> Signed-off-by: Romain Perier <romain.perier@free-electrons.com>
So it is not quite compatible with the 6352. Thanks Marvell :-(
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports
Date: Mon, 19 Dec 2016 15:56:06 +0100 [thread overview]
Message-ID: <20161219145606.GD10048@lunn.ch> (raw)
In-Reply-To: <20161219141610.30934-3-romain.perier@free-electrons.com>
On Mon, Dec 19, 2016 at 03:16:07PM +0100, Romain Perier wrote:
> Some Marvell ethernet switches have internal ethernet transceivers with
> hardcoded phy addresses. These addresses can be grearer than the number
> of ports or its value might be different than the associated port number.
> This is for example the case for MV88E6341 that has 6 ports and internal
> Port 1 to Port4 PHYs mapped at SMI addresses from 0x11 to 0x14.
>
> This commits fixes the issue by removing the condition in MDIO callbacks.
>
> Signed-off-by: Romain Perier <romain.perier@free-electrons.com>
So it is not quite compatible with the 6352. Thanks Marvell :-(
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2016-12-19 14:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 14:16 [PATCH 0/4] Add support for the ethernet switch on the EXPRESSObin Romain Perier
2016-12-19 14:16 ` Romain Perier
2016-12-19 14:16 ` [PATCH 1/4] net: dsa: mv88e6xxx: Allow mv88e6xxx_smi_init() to be used at address 0x1 Romain Perier
2016-12-19 14:16 ` Romain Perier
2016-12-19 14:38 ` Andrew Lunn
2016-12-19 14:38 ` Andrew Lunn
2016-12-19 14:56 ` Romain Perier
2016-12-19 14:56 ` Romain Perier
2016-12-19 15:00 ` Andrew Lunn
2016-12-19 15:00 ` Andrew Lunn
2016-12-19 15:04 ` Volodymyr Bendiuga
2016-12-19 15:07 ` Andrew Lunn
2016-12-19 15:07 ` Andrew Lunn
2016-12-19 15:14 ` Volodymyr Bendiuga
2016-12-19 14:16 ` [PATCH 2/4] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports Romain Perier
2016-12-19 14:16 ` Romain Perier
2016-12-19 14:56 ` Andrew Lunn [this message]
2016-12-19 14:56 ` Andrew Lunn
2016-12-19 14:16 ` [PATCH 3/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141 Romain Perier
2016-12-19 14:16 ` Romain Perier
2016-12-19 14:52 ` Andrew Lunn
2016-12-19 14:52 ` Andrew Lunn
2016-12-19 14:58 ` Romain Perier
2016-12-19 14:58 ` Romain Perier
2016-12-19 14:16 ` [PATCH 4/4] arm64: dts: marvell: Add ethernet switch definition for the EXPRESSObin Romain Perier
2016-12-19 14:16 ` Romain Perier
2016-12-19 14:44 ` Andrew Lunn
2016-12-19 14:44 ` Andrew Lunn
2016-12-19 14:58 ` Thomas Petazzoni
2016-12-19 14:58 ` Thomas Petazzoni
2016-12-19 15:03 ` Romain Perier
2016-12-19 15:03 ` Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219145606.GD10048@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=romain.perier@free-electrons.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.