All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] rapidjson: add initial recipe
@ 2016-12-19 12:01 Andre McCurdy
  2016-12-19 13:11 ` Martin Jansa
  0 siblings, 1 reply; 9+ messages in thread
From: Andre McCurdy @ 2016-12-19 12:01 UTC (permalink / raw)
  To: openembedded-devel

A fast JSON parser/generator for C++ with both SAX/DOM style API.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 .../Fix-gcc-strict-overflow-warning.patch          | 30 ++++++++++++++++++++
 .../remove-march-native-from-CMAKE_CXX_FLAGS.patch | 33 ++++++++++++++++++++++
 .../recipes-devtools/rapidjson/rapidjson_1.0.2.bb  | 23 +++++++++++++++
 3 files changed, 86 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-strict-overflow-warning.patch
 create mode 100644 meta-oe/recipes-devtools/rapidjson/rapidjson/remove-march-native-from-CMAKE_CXX_FLAGS.patch
 create mode 100644 meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb

diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-strict-overflow-warning.patch b/meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-strict-overflow-warning.patch
new file mode 100644
index 0000000..6ce3933
--- /dev/null
+++ b/meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-strict-overflow-warning.patch
@@ -0,0 +1,30 @@
+From f5560d9557ee48fb79810180ddfd3ec386e2a7b5 Mon Sep 17 00:00:00 2001
+From: Milo Yip <miloyip@gmail.com>
+Date: Wed, 2 Mar 2016 01:01:17 +0800
+Subject: [PATCH] Fix gcc strict-overflow warning
+
+Fix #566 #568
+
+Upstream-Status: Backport [Partial merge of upstream commit 928caf92e]
+
+Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
+---
+ include/rapidjson/internal/dtoa.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/include/rapidjson/internal/dtoa.h b/include/rapidjson/internal/dtoa.h
+index 2d8d2e4..15571e1 100644
+--- a/include/rapidjson/internal/dtoa.h
++++ b/include/rapidjson/internal/dtoa.h
+@@ -148,7 +148,7 @@ inline char* WriteExponent(int K, char* buffer) {
+ inline char* Prettify(char* buffer, int length, int k) {
+     const int kk = length + k;  // 10^(kk-1) <= v < 10^kk
+ 
+-    if (length <= kk && kk <= 21) {
++    if (0 <= k && kk <= 21) {
+         // 1234e7 -> 12340000000
+         for (int i = length; i < kk; i++)
+             buffer[i] = '0';
+-- 
+1.9.1
+
diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson/remove-march-native-from-CMAKE_CXX_FLAGS.patch b/meta-oe/recipes-devtools/rapidjson/rapidjson/remove-march-native-from-CMAKE_CXX_FLAGS.patch
new file mode 100644
index 0000000..1716428
--- /dev/null
+++ b/meta-oe/recipes-devtools/rapidjson/rapidjson/remove-march-native-from-CMAKE_CXX_FLAGS.patch
@@ -0,0 +1,33 @@
+From 827155e5e659b2a5065b00d701bc59b57feab2bf Mon Sep 17 00:00:00 2001
+From: Andre McCurdy <armccurdy@gmail.com>
+Date: Mon, 19 Dec 2016 01:37:11 -0800
+Subject: [PATCH] remove -march=native from CMAKE_CXX_FLAGS
+
+Not appropriate when cross compiling.
+
+Upstream-Status: Inappropriate [configuration]
+
+Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
+---
+ CMakeLists.txt | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 68139ba..cae7c9b 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -26,9 +26,9 @@ if(RAPIDJSON_HAS_STDSTRING)
+ endif()
+ 
+ if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=native -Wall -Wextra")
++    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
+ elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=native -Wall -Wextra")
++    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
+ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
+     add_definitions(-D_CRT_SECURE_NO_WARNINGS=1)
+ endif()
+-- 
+1.9.1
+
diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb b/meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
new file mode 100644
index 0000000..1dcd8e0
--- /dev/null
+++ b/meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
@@ -0,0 +1,23 @@
+SUMMARY = "A fast JSON parser/generator for C++ with both SAX/DOM style API"
+HOMEPAGE = "http://rapidjson.org/"
+SECTION = "libs"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://license.txt;md5=cff54e417a17b4b77465198254970cd2"
+
+SRC_URI = "https://github.com/miloyip/rapidjson/archive/v${PV}.tar.gz \
+           file://remove-march-native-from-CMAKE_CXX_FLAGS.patch \
+           file://Fix-gcc-strict-overflow-warning.patch \
+"
+
+SRC_URI[md5sum] = "97cc60d01282a968474c97f60714828c"
+SRC_URI[sha256sum] = "c3711ed2b3c76a5565ee9f0128bb4ec6753dbcc23450b713842df8f236d08666"
+
+inherit cmake
+
+EXTRA_OECMAKE += "-DRAPIDJSON_BUILD_DOC=OFF"
+
+# RapidJSON is a header-only C++ library, so the main package will be empty.
+
+FILES_${PN}-dev += "${libdir}/cmake"
+
+BBCLASSEXTEND = "native nativesdk"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [meta-oe][PATCH] rapidjson: add initial recipe
  2016-12-19 12:01 [meta-oe][PATCH] rapidjson: add initial recipe Andre McCurdy
@ 2016-12-19 13:11 ` Martin Jansa
  2016-12-19 14:08   ` Andre McCurdy
  0 siblings, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2016-12-19 13:11 UTC (permalink / raw)
  To: openembedded-devel

Please don't use github archives.

On Mon, Dec 19, 2016 at 1:01 PM, Andre McCurdy <armccurdy@gmail.com> wrote:

> A fast JSON parser/generator for C++ with both SAX/DOM style API.
>
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  .../Fix-gcc-strict-overflow-warning.patch          | 30
> ++++++++++++++++++++
>  .../remove-march-native-from-CMAKE_CXX_FLAGS.patch | 33
> ++++++++++++++++++++++
>  .../recipes-devtools/rapidjson/rapidjson_1.0.2.bb  | 23 +++++++++++++++
>  3 files changed, 86 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-
> strict-overflow-warning.patch
>  create mode 100644 meta-oe/recipes-devtools/rapidjson/rapidjson/remove-
> march-native-from-CMAKE_CXX_FLAGS.patch
>  create mode 100644 meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
>
> diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-strict-overflow-warning.patch
> b/meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-
> strict-overflow-warning.patch
> new file mode 100644
> index 0000000..6ce3933
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-
> strict-overflow-warning.patch
> @@ -0,0 +1,30 @@
> +From f5560d9557ee48fb79810180ddfd3ec386e2a7b5 Mon Sep 17 00:00:00 2001
> +From: Milo Yip <miloyip@gmail.com>
> +Date: Wed, 2 Mar 2016 01:01:17 +0800
> +Subject: [PATCH] Fix gcc strict-overflow warning
> +
> +Fix #566 #568
> +
> +Upstream-Status: Backport [Partial merge of upstream commit 928caf92e]
> +
> +Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> +---
> + include/rapidjson/internal/dtoa.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/include/rapidjson/internal/dtoa.h
> b/include/rapidjson/internal/dtoa.h
> +index 2d8d2e4..15571e1 100644
> +--- a/include/rapidjson/internal/dtoa.h
> ++++ b/include/rapidjson/internal/dtoa.h
> +@@ -148,7 +148,7 @@ inline char* WriteExponent(int K, char* buffer) {
> + inline char* Prettify(char* buffer, int length, int k) {
> +     const int kk = length + k;  // 10^(kk-1) <= v < 10^kk
> +
> +-    if (length <= kk && kk <= 21) {
> ++    if (0 <= k && kk <= 21) {
> +         // 1234e7 -> 12340000000
> +         for (int i = length; i < kk; i++)
> +             buffer[i] = '0';
> +--
> +1.9.1
> +
> diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson/remove-
> march-native-from-CMAKE_CXX_FLAGS.patch b/meta-oe/recipes-devtools/
> rapidjson/rapidjson/remove-march-native-from-CMAKE_CXX_FLAGS.patch
> new file mode 100644
> index 0000000..1716428
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/rapidjson/rapidjson/remove-
> march-native-from-CMAKE_CXX_FLAGS.patch
> @@ -0,0 +1,33 @@
> +From 827155e5e659b2a5065b00d701bc59b57feab2bf Mon Sep 17 00:00:00 2001
> +From: Andre McCurdy <armccurdy@gmail.com>
> +Date: Mon, 19 Dec 2016 01:37:11 -0800
> +Subject: [PATCH] remove -march=native from CMAKE_CXX_FLAGS
> +
> +Not appropriate when cross compiling.
> +
> +Upstream-Status: Inappropriate [configuration]
> +
> +Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> +---
> + CMakeLists.txt | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index 68139ba..cae7c9b 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
> +@@ -26,9 +26,9 @@ if(RAPIDJSON_HAS_STDSTRING)
> + endif()
> +
> + if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
> +-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=native -Wall -Wextra")
> ++    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
> + elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
> +-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=native -Wall -Wextra")
> ++    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
> + elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
> +     add_definitions(-D_CRT_SECURE_NO_WARNINGS=1)
> + endif()
> +--
> +1.9.1
> +
> diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
> b/meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
> new file mode 100644
> index 0000000..1dcd8e0
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
> @@ -0,0 +1,23 @@
> +SUMMARY = "A fast JSON parser/generator for C++ with both SAX/DOM style
> API"
> +HOMEPAGE = "http://rapidjson.org/"
> +SECTION = "libs"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://license.txt;md5=cff54e417a17b4b77465198254970c
> d2"
> +
> +SRC_URI = "https://github.com/miloyip/rapidjson/archive/v${PV}.tar.gz \
> +           file://remove-march-native-from-CMAKE_CXX_FLAGS.patch \
> +           file://Fix-gcc-strict-overflow-warning.patch \
> +"
> +
> +SRC_URI[md5sum] = "97cc60d01282a968474c97f60714828c"
> +SRC_URI[sha256sum] = "c3711ed2b3c76a5565ee9f0128bb4e
> c6753dbcc23450b713842df8f236d08666"
> +
> +inherit cmake
> +
> +EXTRA_OECMAKE += "-DRAPIDJSON_BUILD_DOC=OFF"
> +
> +# RapidJSON is a header-only C++ library, so the main package will be
> empty.
> +
> +FILES_${PN}-dev += "${libdir}/cmake"
> +
> +BBCLASSEXTEND = "native nativesdk"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-oe][PATCH] rapidjson: add initial recipe
  2016-12-19 13:11 ` Martin Jansa
@ 2016-12-19 14:08   ` Andre McCurdy
  2016-12-19 14:11     ` Andre McCurdy
  0 siblings, 1 reply; 9+ messages in thread
From: Andre McCurdy @ 2016-12-19 14:08 UTC (permalink / raw)
  To: openembeded-devel

On Mon, Dec 19, 2016 at 5:11 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> Please don't use github archives.
>
> On Mon, Dec 19, 2016 at 1:01 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
>
>> A fast JSON parser/generator for C++ with both SAX/DOM style API.
>>
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  .../Fix-gcc-strict-overflow-warning.patch          | 30
>> ++++++++++++++++++++
>>  .../remove-march-native-from-CMAKE_CXX_FLAGS.patch | 33
>> ++++++++++++++++++++++
>>  .../recipes-devtools/rapidjson/rapidjson_1.0.2.bb  | 23 +++++++++++++++
>>  3 files changed, 86 insertions(+)
>>  create mode 100644 meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-
>> strict-overflow-warning.patch
>>  create mode 100644 meta-oe/recipes-devtools/rapidjson/rapidjson/remove-
>> march-native-from-CMAKE_CXX_FLAGS.patch
>>  create mode 100644 meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
>>
>> diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-strict-overflow-warning.patch
>> b/meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-
>> strict-overflow-warning.patch
>> new file mode 100644
>> index 0000000..6ce3933
>> --- /dev/null
>> +++ b/meta-oe/recipes-devtools/rapidjson/rapidjson/Fix-gcc-
>> strict-overflow-warning.patch
>> @@ -0,0 +1,30 @@
>> +From f5560d9557ee48fb79810180ddfd3ec386e2a7b5 Mon Sep 17 00:00:00 2001
>> +From: Milo Yip <miloyip@gmail.com>
>> +Date: Wed, 2 Mar 2016 01:01:17 +0800
>> +Subject: [PATCH] Fix gcc strict-overflow warning
>> +
>> +Fix #566 #568
>> +
>> +Upstream-Status: Backport [Partial merge of upstream commit 928caf92e]
>> +
>> +Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> +---
>> + include/rapidjson/internal/dtoa.h | 2 +-
>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>> +
>> +diff --git a/include/rapidjson/internal/dtoa.h
>> b/include/rapidjson/internal/dtoa.h
>> +index 2d8d2e4..15571e1 100644
>> +--- a/include/rapidjson/internal/dtoa.h
>> ++++ b/include/rapidjson/internal/dtoa.h
>> +@@ -148,7 +148,7 @@ inline char* WriteExponent(int K, char* buffer) {
>> + inline char* Prettify(char* buffer, int length, int k) {
>> +     const int kk = length + k;  // 10^(kk-1) <= v < 10^kk
>> +
>> +-    if (length <= kk && kk <= 21) {
>> ++    if (0 <= k && kk <= 21) {
>> +         // 1234e7 -> 12340000000
>> +         for (int i = length; i < kk; i++)
>> +             buffer[i] = '0';
>> +--
>> +1.9.1
>> +
>> diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson/remove-
>> march-native-from-CMAKE_CXX_FLAGS.patch b/meta-oe/recipes-devtools/
>> rapidjson/rapidjson/remove-march-native-from-CMAKE_CXX_FLAGS.patch
>> new file mode 100644
>> index 0000000..1716428
>> --- /dev/null
>> +++ b/meta-oe/recipes-devtools/rapidjson/rapidjson/remove-
>> march-native-from-CMAKE_CXX_FLAGS.patch
>> @@ -0,0 +1,33 @@
>> +From 827155e5e659b2a5065b00d701bc59b57feab2bf Mon Sep 17 00:00:00 2001
>> +From: Andre McCurdy <armccurdy@gmail.com>
>> +Date: Mon, 19 Dec 2016 01:37:11 -0800
>> +Subject: [PATCH] remove -march=native from CMAKE_CXX_FLAGS
>> +
>> +Not appropriate when cross compiling.
>> +
>> +Upstream-Status: Inappropriate [configuration]
>> +
>> +Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> +---
>> + CMakeLists.txt | 4 ++--
>> + 1 file changed, 2 insertions(+), 2 deletions(-)
>> +
>> +diff --git a/CMakeLists.txt b/CMakeLists.txt
>> +index 68139ba..cae7c9b 100644
>> +--- a/CMakeLists.txt
>> ++++ b/CMakeLists.txt
>> +@@ -26,9 +26,9 @@ if(RAPIDJSON_HAS_STDSTRING)
>> + endif()
>> +
>> + if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
>> +-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=native -Wall -Wextra")
>> ++    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
>> + elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
>> +-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=native -Wall -Wextra")
>> ++    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
>> + elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
>> +     add_definitions(-D_CRT_SECURE_NO_WARNINGS=1)
>> + endif()
>> +--
>> +1.9.1
>> +
>> diff --git a/meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
>> b/meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
>> new file mode 100644
>> index 0000000..1dcd8e0
>> --- /dev/null
>> +++ b/meta-oe/recipes-devtools/rapidjson/rapidjson_1.0.2.bb
>> @@ -0,0 +1,23 @@
>> +SUMMARY = "A fast JSON parser/generator for C++ with both SAX/DOM style
>> API"
>> +HOMEPAGE = "http://rapidjson.org/"
>> +SECTION = "libs"
>> +LICENSE = "MIT"
>> +LIC_FILES_CHKSUM = "file://license.txt;md5=cff54e417a17b4b77465198254970c
>> d2"
>> +
>> +SRC_URI = "https://github.com/miloyip/rapidjson/archive/v${PV}.tar.gz \
>> +           file://remove-march-native-from-CMAKE_CXX_FLAGS.patch \
>> +           file://Fix-gcc-strict-overflow-warning.patch \
>> +"
>> +
>> +SRC_URI[md5sum] = "97cc60d01282a968474c97f60714828c"
>> +SRC_URI[sha256sum] = "c3711ed2b3c76a5565ee9f0128bb4e
>> c6753dbcc23450b713842df8f236d08666"
>> +
>> +inherit cmake
>> +
>> +EXTRA_OECMAKE += "-DRAPIDJSON_BUILD_DOC=OFF"
>> +
>> +# RapidJSON is a header-only C++ library, so the main package will be
>> empty.
>> +
>> +FILES_${PN}-dev += "${libdir}/cmake"
>> +
>> +BBCLASSEXTEND = "native nativesdk"
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-oe][PATCH] rapidjson: add initial recipe
  2016-12-19 14:08   ` Andre McCurdy
@ 2016-12-19 14:11     ` Andre McCurdy
  2016-12-19 14:26       ` Anders Darander
  0 siblings, 1 reply; 9+ messages in thread
From: Andre McCurdy @ 2016-12-19 14:11 UTC (permalink / raw)
  To: openembeded-devel

On Mon, Dec 19, 2016 at 6:08 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Mon, Dec 19, 2016 at 5:11 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> Please don't use github archives.

What's the recommended way to fetch from a git tag which doesn't sit
on a branch?


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-oe][PATCH] rapidjson: add initial recipe
  2016-12-19 14:11     ` Andre McCurdy
@ 2016-12-19 14:26       ` Anders Darander
  2016-12-19 14:46         ` Andre McCurdy
  0 siblings, 1 reply; 9+ messages in thread
From: Anders Darander @ 2016-12-19 14:26 UTC (permalink / raw)
  To: openembedded-devel

* Andre McCurdy <armccurdy@gmail.com> [161219 15:12]:

> On Mon, Dec 19, 2016 at 6:08 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
> > On Mon, Dec 19, 2016 at 5:11 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> Please don't use github archives.

> What's the recommended way to fetch from a git tag which doesn't sit
> on a branch?

Use nobranch=1, see eg
meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb.

Cheers,
Anders

-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-oe][PATCH] rapidjson: add initial recipe
  2016-12-19 14:26       ` Anders Darander
@ 2016-12-19 14:46         ` Andre McCurdy
  2016-12-19 14:58           ` Anders Darander
  0 siblings, 1 reply; 9+ messages in thread
From: Andre McCurdy @ 2016-12-19 14:46 UTC (permalink / raw)
  To: openembeded-devel

On Mon, Dec 19, 2016 at 6:26 AM, Anders Darander <anders@chargestorm.se> wrote:
> * Andre McCurdy <armccurdy@gmail.com> [161219 15:12]:
>
>> On Mon, Dec 19, 2016 at 6:08 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> > On Mon, Dec 19, 2016 at 5:11 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> >> Please don't use github archives.
>
>> What's the recommended way to fetch from a git tag which doesn't sit
>> on a branch?
>
> Use nobranch=1, see eg
> meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb.

That seems to query the server on every do_fetch, so doesn't work so
well with BB_NO_NETWORK.

> Cheers,
> Anders
>
> --
> Anders Darander, Senior System Architect
> ChargeStorm AB / eStorm AB
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-oe][PATCH] rapidjson: add initial recipe
  2016-12-19 14:46         ` Andre McCurdy
@ 2016-12-19 14:58           ` Anders Darander
  2016-12-19 16:42             ` Andre McCurdy
  0 siblings, 1 reply; 9+ messages in thread
From: Anders Darander @ 2016-12-19 14:58 UTC (permalink / raw)
  To: openembedded-devel

* Andre McCurdy <armccurdy@gmail.com> [161219 15:46]:

> On Mon, Dec 19, 2016 at 6:26 AM, Anders Darander <anders@chargestorm.se> wrote:
> > * Andre McCurdy <armccurdy@gmail.com> [161219 15:12]:

> >> On Mon, Dec 19, 2016 at 6:08 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
> >> > On Mon, Dec 19, 2016 at 5:11 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> >> Please don't use github archives.

> >> What's the recommended way to fetch from a git tag which doesn't sit
> >> on a branch?

> > Use nobranch=1, see eg
> > meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb.

> That seems to query the server on every do_fetch, so doesn't work so
> well with BB_NO_NETWORK.

It shouldn't do that. The problem with android-tools_5.1.1.r37.bb is
that they're not checking out a SHA1, but a tag...

ANDROID_TAG = "android-5.1.1_r37"

That's not working without querying the server, due to how bitbake's git
fetcher is implemented.

Cheers,
Anders

-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-oe][PATCH] rapidjson: add initial recipe
  2016-12-19 14:58           ` Anders Darander
@ 2016-12-19 16:42             ` Andre McCurdy
  2016-12-19 16:51               ` Andre McCurdy
  0 siblings, 1 reply; 9+ messages in thread
From: Andre McCurdy @ 2016-12-19 16:42 UTC (permalink / raw)
  To: openembeded-devel

On Mon, Dec 19, 2016 at 6:58 AM, Anders Darander <anders@chargestorm.se> wrote:
> * Andre McCurdy <armccurdy@gmail.com> [161219 15:46]:
>
>> On Mon, Dec 19, 2016 at 6:26 AM, Anders Darander <anders@chargestorm.se> wrote:
>> > * Andre McCurdy <armccurdy@gmail.com> [161219 15:12]:
>
>> >> On Mon, Dec 19, 2016 at 6:08 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> >> > On Mon, Dec 19, 2016 at 5:11 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> >> >> Please don't use github archives.
>
>> >> What's the recommended way to fetch from a git tag which doesn't sit
>> >> on a branch?
>
>> > Use nobranch=1, see eg
>> > meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb.
>
>> That seems to query the server on every do_fetch, so doesn't work so
>> well with BB_NO_NETWORK.
>
> It shouldn't do that. The problem with android-tools_5.1.1.r37.bb is
> that they're not checking out a SHA1, but a tag...
>
> ANDROID_TAG = "android-5.1.1_r37"
>
> That's not working without querying the server, due to how bitbake's git
> fetcher is implemented.

Right. So is there a combination of tag, nobranch and SRCREV which can
fetch from a tag which doesn't sit on a branch without querying the
server on ever do_fetch? I didn't find one yet.

> Cheers,
> Anders
>
> --
> Anders Darander, Senior System Architect
> ChargeStorm AB / eStorm AB
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-oe][PATCH] rapidjson: add initial recipe
  2016-12-19 16:42             ` Andre McCurdy
@ 2016-12-19 16:51               ` Andre McCurdy
  0 siblings, 0 replies; 9+ messages in thread
From: Andre McCurdy @ 2016-12-19 16:51 UTC (permalink / raw)
  To: openembeded-devel

On Mon, Dec 19, 2016 at 8:42 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Mon, Dec 19, 2016 at 6:58 AM, Anders Darander <anders@chargestorm.se> wrote:
>> * Andre McCurdy <armccurdy@gmail.com> [161219 15:46]:
>>
>>> On Mon, Dec 19, 2016 at 6:26 AM, Anders Darander <anders@chargestorm.se> wrote:
>>> > * Andre McCurdy <armccurdy@gmail.com> [161219 15:12]:
>>
>>> >> On Mon, Dec 19, 2016 at 6:08 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
>>> >> > On Mon, Dec 19, 2016 at 5:11 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>>> >> >> Please don't use github archives.
>>
>>> >> What's the recommended way to fetch from a git tag which doesn't sit
>>> >> on a branch?
>>
>>> > Use nobranch=1, see eg
>>> > meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb.
>>
>>> That seems to query the server on every do_fetch, so doesn't work so
>>> well with BB_NO_NETWORK.
>>
>> It shouldn't do that. The problem with android-tools_5.1.1.r37.bb is
>> that they're not checking out a SHA1, but a tag...
>>
>> ANDROID_TAG = "android-5.1.1_r37"
>>
>> That's not working without querying the server, due to how bitbake's git
>> fetcher is implemented.
>
> Right. So is there a combination of tag, nobranch and SRCREV which can
> fetch from a tag which doesn't sit on a branch without querying the
> server on every do_fetch? I didn't find one yet.

Never mind. SRCREV with nobranch does seem to be working now.

>> Cheers,
>> Anders
>>
>> --
>> Anders Darander, Senior System Architect
>> ChargeStorm AB / eStorm AB
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-12-19 16:51 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-19 12:01 [meta-oe][PATCH] rapidjson: add initial recipe Andre McCurdy
2016-12-19 13:11 ` Martin Jansa
2016-12-19 14:08   ` Andre McCurdy
2016-12-19 14:11     ` Andre McCurdy
2016-12-19 14:26       ` Anders Darander
2016-12-19 14:46         ` Andre McCurdy
2016-12-19 14:58           ` Anders Darander
2016-12-19 16:42             ` Andre McCurdy
2016-12-19 16:51               ` Andre McCurdy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.