* [PATCH] genwqe: drop .link_reset()
@ 2016-12-19 7:23 Cao jin
2016-12-19 15:04 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Cao jin @ 2016-12-19 7:23 UTC (permalink / raw)
To: linux-kernel; +Cc: bhelgaas, gregkh, jthumshirn, haver
In AER recovery, pci_error_handlers.link_reset() is never called,
drop it now.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
drivers/misc/genwqe/card_base.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
index 6c1f49a85023..4fd21e86ad56 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -1336,7 +1336,6 @@ static int genwqe_sriov_configure(struct pci_dev *dev, int numvfs)
static struct pci_error_handlers genwqe_err_handler = {
.error_detected = genwqe_err_error_detected,
.mmio_enabled = genwqe_err_result_none,
- .link_reset = genwqe_err_result_none,
.slot_reset = genwqe_err_slot_reset,
.resume = genwqe_err_resume,
};
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] genwqe: drop .link_reset()
2016-12-19 7:23 [PATCH] genwqe: drop .link_reset() Cao jin
@ 2016-12-19 15:04 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2016-12-19 15:04 UTC (permalink / raw)
To: Cao jin
Cc: linux-kernel, bhelgaas, gregkh, jthumshirn, haver, linux-pci,
Linas Vepstas
[+cc linux-pci, Linas]
On Mon, Dec 19, 2016 at 03:23:56PM +0800, Cao jin wrote:
> In AER recovery, pci_error_handlers.link_reset() is never called,
> drop it now.
I think it's true that .link_reset() is never called. If that's the
case, why not remove it completely, i.e., remove it from struct
pci_error_handlers and from all the other drivers that supply it?
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> drivers/misc/genwqe/card_base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
> index 6c1f49a85023..4fd21e86ad56 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -1336,7 +1336,6 @@ static int genwqe_sriov_configure(struct pci_dev *dev, int numvfs)
> static struct pci_error_handlers genwqe_err_handler = {
> .error_detected = genwqe_err_error_detected,
> .mmio_enabled = genwqe_err_result_none,
> - .link_reset = genwqe_err_result_none,
> .slot_reset = genwqe_err_slot_reset,
> .resume = genwqe_err_resume,
> };
> --
> 2.1.0
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-19 15:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-19 7:23 [PATCH] genwqe: drop .link_reset() Cao jin
2016-12-19 15:04 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.