[PATCH 01/13] USB: serial: ch341: fix initial modem-control state

[PATCH 01/13] USB: serial: ch341: fix initial modem-control state

[Johan Hovold]

DTR and RST will be asserted by the tty-layer when the port is opened
and deasserted on close (if HUPCL is set). Make sure the initial state
is not-asserted before the port is first opened as well.

Fixes: 6ce76104781a ("USB: Driver for CH341 USB-serial adaptor")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/ch341.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 2597b83a8ae2..d133e72fe888 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -258,7 +258,6 @@ static int ch341_port_probe(struct usb_serial_port *port)
 
 	spin_lock_init(&priv->lock);
 	priv->baud_rate = DEFAULT_BAUD_RATE;
-	priv->line_control = CH341_BIT_RTS | CH341_BIT_DTR;
 
 	r = ch341_configure(port->serial->dev, priv);
 	if (r < 0)
-- 
2.10.2

[PATCH 02/13] USB: serial: ch341: fix open and resume after B0

[Johan Hovold]

The private baud_rate variable is used to configure the port at open and
reset-resume, which means it must never be set to (and left at) zero or
reset-resume and all further open attempts will fail.

Fixes: 664d5df92e88 ("USB: usb-serial ch341: support for DTR/RTS/CTS")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/ch341.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index d133e72fe888..6279df905c14 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -355,7 +355,6 @@ static void ch341_set_termios(struct tty_struct *tty,
 
 	baud_rate = tty_get_baud_rate(tty);
 
-	priv->baud_rate = baud_rate;
 	ctrl = CH341_LCR_ENABLE_RX | CH341_LCR_ENABLE_TX;
 
 	switch (C_CSIZE(tty)) {
@@ -388,6 +387,9 @@ static void ch341_set_termios(struct tty_struct *tty,
 		spin_lock_irqsave(&priv->lock, flags);
 		priv->line_control |= (CH341_BIT_DTR | CH341_BIT_RTS);
 		spin_unlock_irqrestore(&priv->lock, flags);
+
+		priv->baud_rate = baud_rate;
+
 		r = ch341_init_set_baudrate(port->serial->dev, priv, ctrl);
 		if (r < 0 && old_termios) {
 			priv->baud_rate = tty_termios_baud_rate(old_termios);
-- 
2.10.2

[PATCH 03/13] USB: serial: ch341: fix modem-control and B0 handling

[Johan Hovold]

The modem-control signals are managed by the tty-layer during open and
should not be asserted prematurely when set_termios is called from
driver open.

Also make sure that the signals are asserted only when changing speed
from B0.

Fixes: 664d5df92e88 ("USB: usb-serial ch341: support for DTR/RTS/CTS")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/ch341.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 6279df905c14..0cc5056b304d 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -384,10 +384,6 @@ static void ch341_set_termios(struct tty_struct *tty,
 		ctrl |= CH341_LCR_STOP_BITS_2;
 
 	if (baud_rate) {
-		spin_lock_irqsave(&priv->lock, flags);
-		priv->line_control |= (CH341_BIT_DTR | CH341_BIT_RTS);
-		spin_unlock_irqrestore(&priv->lock, flags);
-
 		priv->baud_rate = baud_rate;
 
 		r = ch341_init_set_baudrate(port->serial->dev, priv, ctrl);
@@ -395,14 +391,16 @@ static void ch341_set_termios(struct tty_struct *tty,
 			priv->baud_rate = tty_termios_baud_rate(old_termios);
 			tty_termios_copy_hw(&tty->termios, old_termios);
 		}
-	} else {
-		spin_lock_irqsave(&priv->lock, flags);
-		priv->line_control &= ~(CH341_BIT_DTR | CH341_BIT_RTS);
-		spin_unlock_irqrestore(&priv->lock, flags);
 	}
 
-	ch341_set_handshake(port->serial->dev, priv->line_control);
+	spin_lock_irqsave(&priv->lock, flags);
+	if (C_BAUD(tty) == B0)
+		priv->line_control &= ~(CH341_BIT_DTR | CH341_BIT_RTS);
+	else if (old_termios && (old_termios->c_cflag & CBAUD) == B0)
+		priv->line_control |= (CH341_BIT_DTR | CH341_BIT_RTS);
+	spin_unlock_irqrestore(&priv->lock, flags);
 
+	ch341_set_handshake(port->serial->dev, priv->line_control);
 }
 
 static void ch341_break_ctl(struct tty_struct *tty, int break_state)
-- 
2.10.2

[PATCH 04/13] USB: serial: ch341: fix open error handling

[Johan Hovold]

Make sure to stop the interrupt URB before returning on errors during
open.

Fixes: 664d5df92e88 ("USB: usb-serial ch341: support for DTR/RTS/CTS")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/ch341.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 0cc5056b304d..8f41d4385f1c 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -319,7 +319,7 @@ static int ch341_open(struct tty_struct *tty, struct usb_serial_port *port)
 
 	r = ch341_configure(serial->dev, priv);
 	if (r)
-		goto out;
+		return r;
 
 	if (tty)
 		ch341_set_termios(tty, port, NULL);
@@ -329,12 +329,19 @@ static int ch341_open(struct tty_struct *tty, struct usb_serial_port *port)
 	if (r) {
 		dev_err(&port->dev, "%s - failed to submit interrupt urb: %d\n",
 			__func__, r);
-		goto out;
+		return r;
 	}
 
 	r = usb_serial_generic_open(tty, port);
+	if (r)
+		goto err_kill_interrupt_urb;
+
+	return 0;
+
+err_kill_interrupt_urb:
+	usb_kill_urb(port->interrupt_in_urb);
 
-out:	return r;
+	return r;
 }
 
 /* Old_termios contains the original termios settings and
-- 
2.10.2

[PATCH 05/13] USB: serial: ch341: fix resume after reset

[Johan Hovold]

Fix reset-resume handling which failed to resubmit the read and
interrupt URBs, thereby leaving a port that was open before suspend in a
broken state until closed and reopened.

Fixes: 1ded7ea47b88 ("USB: ch341 serial: fix port number changed after
resume")
Fixes: 2bfd1c96a9fb ("USB: serial: ch341: remove reset_resume callback")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/ch341.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 8f41d4385f1c..cbe91b232828 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -582,14 +582,23 @@ static int ch341_tiocmget(struct tty_struct *tty)
 
 static int ch341_reset_resume(struct usb_serial *serial)
 {
-	struct ch341_private *priv;
-
-	priv = usb_get_serial_port_data(serial->port[0]);
+	struct usb_serial_port *port = serial->port[0];
+	struct ch341_private *priv = usb_get_serial_port_data(port);
+	int ret;
 
 	/* reconfigure ch341 serial port after bus-reset */
 	ch341_configure(serial->dev, priv);
 
-	return 0;
+	if (tty_port_initialized(&port->port)) {
+		ret = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
+		if (ret) {
+			dev_err(&port->dev, "failed to submit interrupt urb: %d\n",
+				ret);
+			return ret;
+		}
+	}
+
+	return usb_serial_generic_resume(serial);
 }
 
 static struct usb_serial_driver ch341_device = {
-- 
2.10.2

[PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

The ch341 driver is based on reverse-engineering and contains some bits
which appear to be redundant and some which appear incompatible which
certain devices.

Specifically, some CH340 devices seem unable to change the initial line
settings, which have so far been set to 5N1. Let's use a more reasonable
8N1 default instead.

Note that we also need to set the ENABLE_RX bit or receive will be
disabled after a reset during resume.

Also drop a redundant LCR-register read.

Fixes: 6ce76104781a ("USB: Driver for CH341 USB-serial adaptor")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/ch341.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index cbe91b232828..3d86272a4b31 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -203,6 +203,7 @@ static int ch341_configure(struct usb_device *dev, struct ch341_private *priv)
 	char *buffer;
 	int r;
 	const unsigned size = 8;
+	u8 lcr;
 
 	buffer = kmalloc(size, GFP_KERNEL);
 	if (!buffer)
@@ -218,12 +219,12 @@ static int ch341_configure(struct usb_device *dev, struct ch341_private *priv)
 	if (r < 0)
 		goto out;
 
-	/* expect two bytes 0x56 0x00 */
-	r = ch341_control_in(dev, CH341_REQ_READ_REG, 0x2518, 0, buffer, size);
-	if (r < 0)
-		goto out;
-
-	r = ch341_control_out(dev, CH341_REQ_WRITE_REG, 0x2518, 0x0050);
+	/*
+	 * Some CH340 devices appear unable to change the initial LCR
+	 * settings, so set a sane 8N1 default.
+	 */
+	lcr = CH341_LCR_ENABLE_RX | CH341_LCR_ENABLE_TX | CH341_LCR_CS8;
+	r = ch341_control_out(dev, CH341_REQ_WRITE_REG, 0x2518, lcr);
 	if (r < 0)
 		goto out;
 
@@ -232,7 +233,7 @@ static int ch341_configure(struct usb_device *dev, struct ch341_private *priv)
 	if (r < 0)
 		goto out;
 
-	r = ch341_init_set_baudrate(dev, priv, 0);
+	r = ch341_init_set_baudrate(dev, priv, lcr);
 	if (r < 0)
 		goto out;
 
-- 
2.10.2

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Aidan Thornton]

On Wed, Dec 14, 2016 at 3:28 PM, Johan Hovold <johan@kernel.org> wrote:
> The ch341 driver is based on reverse-engineering and contains some bits
> which appear to be redundant and some which appear incompatible which
> certain devices.
>
> Specifically, some CH340 devices seem unable to change the initial line
> settings, which have so far been set to 5N1. Let's use a more reasonable
> 8N1 default instead.
>
> Note that we also need to set the ENABLE_RX bit or receive will be
> disabled after a reset during resume.

Lost track a little of the testing, but I don't think you ever got
Russel to test whether this worked using a driver that tried to change
this through direct register writes which seem to be the only thing
that has any effect on this strange hardware variant. Would be a
little surprised if it didn't at this point - changing the line
settings that way after initialization certainly works well enough to
cause us all a headache.

If so, I suggest it might be clearer to drop this patch altogether in
favour of patch 10 in the series, since the underlying problem is that
setting the baudrate and LCR register didn't work and patch 10 fixes
that.

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Fri, Dec 16, 2016 at 01:19:05PM +0000, Aidan Thornton wrote:
> On Wed, Dec 14, 2016 at 3:28 PM, Johan Hovold <johan@kernel.org> wrote:
> > The ch341 driver is based on reverse-engineering and contains some bits
> > which appear to be redundant and some which appear incompatible which
> > certain devices.
> >
> > Specifically, some CH340 devices seem unable to change the initial line
> > settings, which have so far been set to 5N1. Let's use a more reasonable
> > 8N1 default instead.
> >
> > Note that we also need to set the ENABLE_RX bit or receive will be
> > disabled after a reset during resume.
> 
> Lost track a little of the testing, but I don't think you ever got
> Russel to test whether this worked using a driver that tried to change
> this through direct register writes which seem to be the only thing
> that has any effect on this strange hardware variant. Would be a
> little surprised if it didn't at this point - changing the line
> settings that way after initialization certainly works well enough to
> cause us all a headache.

I believe he did test this against my usb-linus branch, which did not
have your recent changes. IIRC both removing that first LCR write and
changing it to 0xc3 worked, but maybe you're right and we only verified
removing it.

In the same setup, changing the word size after successful
initialisation using direct register writes did not work however, and
the device appeared stuck at 5N1 or 8N1 depending on if the initial 0x50
LCR write was left in or not.

> If so, I suggest it might be clearer to drop this patch altogether in
> favour of patch 10 in the series, since the underlying problem is that
> setting the baudrate and LCR register didn't work and patch 10 fixes
> that.

These two patches are definitely related, and I struggled a bit about
how to order things as I wanted to find a way to backport this minimal
change (from 5N1 to 8N1) without having to depend on the upcoming
changes in 4.10 (your changes) as that may be enough to enable support
in older kernels.

I'll respin this, once we learn more about how those quirky devices
work.

Thanks,
Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Russell Senior]

Sorry, I got distracted.  I'm back now.  Do you want me to test your
13 patch series?  And what is that on top of?

Thanks

On Fri, Dec 16, 2016 at 6:46 AM, Johan Hovold <johan@kernel.org> wrote:
> On Fri, Dec 16, 2016 at 01:19:05PM +0000, Aidan Thornton wrote:
>> On Wed, Dec 14, 2016 at 3:28 PM, Johan Hovold <johan@kernel.org> wrote:
>> > The ch341 driver is based on reverse-engineering and contains some bits
>> > which appear to be redundant and some which appear incompatible which
>> > certain devices.
>> >
>> > Specifically, some CH340 devices seem unable to change the initial line
>> > settings, which have so far been set to 5N1. Let's use a more reasonable
>> > 8N1 default instead.
>> >
>> > Note that we also need to set the ENABLE_RX bit or receive will be
>> > disabled after a reset during resume.
>>
>> Lost track a little of the testing, but I don't think you ever got
>> Russel to test whether this worked using a driver that tried to change
>> this through direct register writes which seem to be the only thing
>> that has any effect on this strange hardware variant. Would be a
>> little surprised if it didn't at this point - changing the line
>> settings that way after initialization certainly works well enough to
>> cause us all a headache.
>
> I believe he did test this against my usb-linus branch, which did not
> have your recent changes. IIRC both removing that first LCR write and
> changing it to 0xc3 worked, but maybe you're right and we only verified
> removing it.
>
> In the same setup, changing the word size after successful
> initialisation using direct register writes did not work however, and
> the device appeared stuck at 5N1 or 8N1 depending on if the initial 0x50
> LCR write was left in or not.
>
>> If so, I suggest it might be clearer to drop this patch altogether in
>> favour of patch 10 in the series, since the underlying problem is that
>> setting the baudrate and LCR register didn't work and patch 10 fixes
>> that.
>
> These two patches are definitely related, and I struggled a bit about
> how to order things as I wanted to find a way to backport this minimal
> change (from 5N1 to 8N1) without having to depend on the upcoming
> changes in 4.10 (your changes) as that may be enough to enable support
> in older kernels.
>
> I'll respin this, once we learn more about how those quirky devices
> work.
>
> Thanks,
> Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Fri, Dec 16, 2016 at 08:04:18AM -0800, Russell Senior wrote:
> Sorry, I got distracted.  I'm back now.  Do you want me to test your
> 13 patch series?  And what is that on top of?

Yes, please. It's against my usb-next branch.

I'll send you a couple of diagnostics patches as well shortly.

Thanks,
Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Fri, Dec 16, 2016 at 05:13:50PM +0100, Johan Hovold wrote:
> On Fri, Dec 16, 2016 at 08:04:18AM -0800, Russell Senior wrote:
> > Sorry, I got distracted.  I'm back now.  Do you want me to test your
> > 13 patch series?  And what is that on top of?
> 
> Yes, please. It's against my usb-next branch.
> 
> I'll send you a couple of diagnostics patches as well shortly.

I ended up pushing a new branch, ch341 to my tree

	git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git

which contains the full series as well as four debug patches (on top of
usb-next).

Could you first try and see if the series works with some register dumps
enabled:

	79e475a77796 dbg: ch341: add divisor and lcr debugging

If that works, could you try the next commit and see if all still works

	ee5a27b51e95 dbg: ch341: enable rx timer

Either way, could you also try the next commit which again tries to use
the init-command for all devices:

	a06b45d910e3 dbg: ch341: use init for all devices

and if that does not work, the final commit tries to use the init
command but always use the chip default LCR:

	6edc2830abe1 dbg: ch341: always use default LCR

As you know there are, at least two levels of "working" here

	1. Your device works and you can change baud rate, but you're
	   stuck with 8N1

	2. Changing LCR also works (e.g. switching back and forth
	   between say 5N1 and 8N1 also works).

When testing a new commit, always make sure to disconnect and reconnect
the device first.

Logs from all tests would be helpful (e.g. to see what effects the
various commands has on the registers).

Just let me know if you have any questions.

Thanks,
Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Russell Senior]

All testing is with minicom.

Starting with 00013-gc510871:

  In 8-bit mode, interoperates correctly with pl2303.  Switching to
5-bit mode on both sides (I get unicode boxes of indeterminate
values).  Switching back to 8-bit mode on both sides, I get correct
text out both sides.  Switching just the ch341 side back to 5-bit
mode, I get 0xff's out on the pl2303 side (still in 8-bit mode).  This
would seem to imply that byte-size changes are working on this
version.  Changing baud rate also works.

00014-g79e475a:

  dmesg shows on insert:

[ 1430.504116] usb 6-2: new full-speed USB device number 3 using uhci_hcd
[ 1430.682143] usb 6-2: New USB device found, idVendor=1a86, idProduct=7523
[ 1430.682148] usb 6-2: New USB device strings: Mfr=0, Product=2, SerialNumber=0
[ 1430.682152] usb 6-2: Product: USB2.0-Ser!
[ 1430.686294] ch341 6-2:1.0: ch341-uart converter detected
[ 1430.689122] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(pre version)
[ 1430.693121] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init-0)
[ 1430.693124] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 1430.696120] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 1430.699119] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 1430.700501] usb 6-2: ch341-uart converter now attached to ttyUSB0

Changing baud rate and then byte-size:

[ 1621.189700] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 1621.193556] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 1621.196557] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 1621.199565] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 1621.202571] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 1621.205569] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 1621.207572] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 1621.210570] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 1621.213573] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 1644.117396] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 1644.120933] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 1644.123952] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 1666.950341] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c0, a = b202
[ 1666.954320] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 1666.957316] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
(post lcr)
[ 1700.500318] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 1700.503845] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
(post divisor)
[ 1700.506866] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)

It works in 8-bit mode, I can change to 5-bit mode and then back, as
before.  And I can change baud rate.

00015-gee5a27b:

  dmesg on insert:

[ 2047.116076] usb 6-2: new full-speed USB device number 4 using uhci_hcd
[ 2047.289208] usb 6-2: New USB device found, idVendor=1a86, idProduct=7523
[ 2047.289213] usb 6-2: New USB device strings: Mfr=0, Product=2, SerialNumber=0
[ 2047.289217] usb 6-2: Product: USB2.0-Ser!
[ 2047.291561] ch341 6-2:1.0: ch341-uart converter detected
[ 2047.294210] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(pre version)
[ 2047.298205] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init-0)
[ 2047.298211] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 2047.301210] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 2047.304187] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 2047.305285] usb 6-2: ch341-uart converter now attached to ttyUSB0

Changing baud rate and byte-size:

[ 2148.141851] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 2148.145537] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 2148.148536] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 2148.151553] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 2148.154535] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 2148.157561] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 2148.159536] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 2148.162554] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 2148.165562] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 2230.407595] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c0, a = cc03
[ 2230.410927] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 2230.413927] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
(post lcr)
[ 2243.757894] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 2243.761857] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
(post divisor)
[ 2243.764854] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 2285.091728] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c0, a = cc03
[ 2285.095680] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 2285.098694] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
(post lcr)
[ 2291.998763] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 2292.002652] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
(post divisor)
[ 2292.005654] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)
[ 2320.039252] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 2320.042603] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post divisor)
[ 2320.045602] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post lcr)

I can switch baud rate and byte size back and forth and it seems to
work.  In 5-bit mode, I guess minicom just doesn't know how to render
the values, so that makes sense, switching back to 8-bit mode and I
get readable text again.  So, this one is working too, afaict.

00016-ga06b45d:

  dmesg on insert:

[ 2588.016052] usb 6-2: new full-speed USB device number 5 using uhci_hcd
[ 2588.189182] usb 6-2: New USB device found, idVendor=1a86, idProduct=7523
[ 2588.189187] usb 6-2: New USB device strings: Mfr=0, Product=2, SerialNumber=0
[ 2588.189192] usb 6-2: Product: USB2.0-Ser!
[ 2588.193366] ch341 6-2:1.0: ch341-uart converter detected
[ 2588.196146] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(pre version)
[ 2588.200162] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init-0)
[ 2588.200165] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 2588.203182] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init)
[ 2588.204488] usb 6-2: ch341-uart converter now attached to ttyUSB0

This doesn't work.  Even when matching baud rate and byte size, the
best I get is 0xff's out on the ch341.  Nothing decodes as printable
anything at the pl2303 side.

[ 2659.459912] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 2659.463618] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init)
[ 2659.466629] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 2659.469617] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init)
[ 2659.471603] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 2659.474617] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init)
[ 2705.211020] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c0, a = cc03
[ 2705.214981] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init)
[ 2742.117334] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 2742.121289] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init)

00017-g6edc283:

  dmesg on insert:

[ 2981.092168] usb 6-2: new full-speed USB device number 6 using uhci_hcd
[ 2981.272177] usb 6-2: New USB device found, idVendor=1a86, idProduct=7523
[ 2981.272182] usb 6-2: New USB device strings: Mfr=0, Product=2, SerialNumber=0
[ 2981.272186] usb 6-2: Product: USB2.0-Ser!
[ 2981.275288] ch341 6-2:1.0: ch341-uart converter detected
[ 2981.278157] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(pre version)
[ 2981.282155] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init-0)
[ 2981.282158] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 2981.285157] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init - lcr reset)
[ 2981.286340] usb 6-2: ch341-uart converter now attached to ttyUSB0

This doesn't work either.  At 9600 8N1, I get 0xff's on the pl2303,
and some unicode on the ch341.

[ 3043.235776] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 3043.238999] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init - lcr reset)
[ 3043.241915] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 3043.244882] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init - lcr reset)
[ 3043.246899] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 3043.249890] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init - lcr reset)
[ 3060.100774] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c0, a = cc03
[ 3060.104407] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init - lcr reset)
[ 3066.121089] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
c3, a = cc03
[ 3066.124400] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init - lcr reset)
[ 3075.702374] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
c3, a = b202
[ 3075.706305] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
(post init - lcr reset)

Let me know if I can test anything else!


On Fri, Dec 16, 2016 at 9:30 AM, Johan Hovold <johan@kernel.org> wrote:
> On Fri, Dec 16, 2016 at 05:13:50PM +0100, Johan Hovold wrote:
>> On Fri, Dec 16, 2016 at 08:04:18AM -0800, Russell Senior wrote:
>> > Sorry, I got distracted.  I'm back now.  Do you want me to test your
>> > 13 patch series?  And what is that on top of?
>>
>> Yes, please. It's against my usb-next branch.
>>
>> I'll send you a couple of diagnostics patches as well shortly.
>
> I ended up pushing a new branch, ch341 to my tree
>
>         git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
>
> which contains the full series as well as four debug patches (on top of
> usb-next).
>
> Could you first try and see if the series works with some register dumps
> enabled:
>
>         79e475a77796 dbg: ch341: add divisor and lcr debugging
>
> If that works, could you try the next commit and see if all still works
>
>         ee5a27b51e95 dbg: ch341: enable rx timer
>
> Either way, could you also try the next commit which again tries to use
> the init-command for all devices:
>
>         a06b45d910e3 dbg: ch341: use init for all devices
>
> and if that does not work, the final commit tries to use the init
> command but always use the chip default LCR:
>
>         6edc2830abe1 dbg: ch341: always use default LCR
>
> As you know there are, at least two levels of "working" here
>
>         1. Your device works and you can change baud rate, but you're
>            stuck with 8N1
>
>         2. Changing LCR also works (e.g. switching back and forth
>            between say 5N1 and 8N1 also works).
>
> When testing a new commit, always make sure to disconnect and reconnect
> the device first.
>
> Logs from all tests would be helpful (e.g. to see what effects the
> various commands has on the registers).
>
> Just let me know if you have any questions.
>
> Thanks,
> Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Sat, Dec 17, 2016 at 03:27:43AM -0800, Russell Senior wrote:
> All testing is with minicom.

Thanks for this through report.

> Starting with 00013-gc510871:
> 
>   In 8-bit mode, interoperates correctly with pl2303.  Switching to
> 5-bit mode on both sides (I get unicode boxes of indeterminate
> values).  Switching back to 8-bit mode on both sides, I get correct
> text out both sides.  Switching just the ch341 side back to 5-bit
> mode, I get 0xff's out on the pl2303 side (still in 8-bit mode).  This
> would seem to imply that byte-size changes are working on this
> version.  Changing baud rate also works.

Can you verify also what comes through in 5-bit mode is indeed what's
expected (e.g. 'a' -> 0x01, 'b' -> 0x02, ...)?

You can enable usb-serial debugging to get a log of what is received:

	modprobe usbserial dyndbg==p

> 00014-g79e475a:
> 
>   dmesg shows on insert:
> 
> [ 1430.504116] usb 6-2: new full-speed USB device number 3 using uhci_hcd
> [ 1430.682143] usb 6-2: New USB device found, idVendor=1a86, idProduct=7523
> [ 1430.682148] usb 6-2: New USB device strings: Mfr=0, Product=2, SerialNumber=0
> [ 1430.682152] usb 6-2: Product: USB2.0-Ser!
> [ 1430.686294] ch341 6-2:1.0: ch341-uart converter detected
> [ 1430.689122] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (pre version)
> [ 1430.693121] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post init-0)
> [ 1430.693124] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
> c3, a = b202
> [ 1430.696120] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post divisor)
> [ 1430.699119] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post lcr)
> [ 1430.700501] usb 6-2: ch341-uart converter now attached to ttyUSB0
> 
> Changing baud rate and then byte-size:
> 
> [ 1621.189700] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
> c3, a = b202
> [ 1621.193556] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post divisor)
> [ 1621.196557] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post lcr)
> [ 1621.199565] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
> c3, a = cc03
> [ 1621.202571] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post divisor)
> [ 1621.205569] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post lcr)
> [ 1621.207572] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
> c3, a = cc03
> [ 1621.210570] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post divisor)
> [ 1621.213573] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post lcr)
> [ 1644.117396] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
> c3, a = b202
> [ 1644.120933] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post divisor)
> [ 1644.123952] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post lcr)
> [ 1666.950341] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
> c0, a = b202
> [ 1666.954320] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post divisor)
> [ 1666.957316] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
> (post lcr)
> [ 1700.500318] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
> c3, a = b202
> [ 1700.503845] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
> (post divisor)
> [ 1700.506866] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post lcr)
> 
> It works in 8-bit mode, I can change to 5-bit mode and then back, as
> before.  And I can change baud rate.

Note that you only need to test this commit, which simply adds the
debugging printks on top of the previous.

The log indicates that the LCR is updated correctly, but also reveals
that the divisor registers always read back as zero even if changing
speeds appear to work. Both my devices read back the values set either
through direct register write or using the init commmand.

We may be able to use this to detect these devices and fall back to
direct register writes.

> 00015-gee5a27b:

> I can switch baud rate and byte size back and forth and it seems to
> work.  In 5-bit mode, I guess minicom just doesn't know how to render
> the values, so that makes sense, switching back to 8-bit mode and I
> get readable text again.  So, this one is working too, afaict.

Good, this one only differs from the previous in that the 7th bit of the
divisor register is set, something which is required for CH341A. Good to
know it does not seem to have any negative effects for this device.

> 00016-ga06b45d:
> 
>   dmesg on insert:
> 
> [ 2588.016052] usb 6-2: new full-speed USB device number 5 using uhci_hcd
> [ 2588.189182] usb 6-2: New USB device found, idVendor=1a86, idProduct=7523
> [ 2588.189187] usb 6-2: New USB device strings: Mfr=0, Product=2, SerialNumber=0
> [ 2588.189192] usb 6-2: Product: USB2.0-Ser!
> [ 2588.193366] ch341 6-2:1.0: ch341-uart converter detected
> [ 2588.196146] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (pre version)
> [ 2588.200162] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post init-0)
> [ 2588.200165] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
> c3, a = b202
> [ 2588.203182] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
> (post init)
> [ 2588.204488] usb 6-2: ch341-uart converter now attached to ttyUSB0
> 
> This doesn't work.  Even when matching baud rate and byte size, the
> best I get is 0xff's out on the ch341.  Nothing decodes as printable
> anything at the pl2303 side.

Ok, so the init command cannot be used to switch baud rate for these
devices.

Could you see if you can communicate using 19200 baud (when using this
or the next commit), which is the default baud rate for the devices I
have (i.e. default settings are 19200 8N1).

> 00017-g6edc283:
 
> This doesn't work either.  At 9600 8N1, I get 0xff's on the pl2303,
> and some unicode on the ch341.

If the baud rate cannot be set using the init command, then this should
behave as the previous commit. 19200 baud might work.

> Let me know if I can test anything else!

Apart from the two additional tests mentioned above, can you also
provide a log from when connecting the device using the following commit
that I just pushed to the ch341 branch:

	f341ee36198d ("dbg: ch341: add register dumps to probe")

which provides dumps of the register settings during initialisation.
(Make sure ch341 dynamic debugging is not enabled to avoid cluttering
the log.)

Thanks,
Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Russell Senior]

On Mon, Dec 19, 2016 at 2:58 AM, Johan Hovold <johan@kernel.org> wrote:
> On Sat, Dec 17, 2016 at 03:27:43AM -0800, Russell Senior wrote:
>> All testing is with minicom.
>
> Thanks for this through report.
>
>> Starting with 00013-gc510871:
>>
>>   In 8-bit mode, interoperates correctly with pl2303.  Switching to
>> 5-bit mode on both sides (I get unicode boxes of indeterminate
>> values).  Switching back to 8-bit mode on both sides, I get correct
>> text out both sides.  Switching just the ch341 side back to 5-bit
>> mode, I get 0xff's out on the pl2303 side (still in 8-bit mode).  This
>> would seem to imply that byte-size changes are working on this
>> version.  Changing baud rate also works.
>
> Can you verify also what comes through in 5-bit mode is indeed what's
> expected (e.g. 'a' -> 0x01, 'b' -> 0x02, ...)?
>
> You can enable usb-serial debugging to get a log of what is received:
>
>         modprobe usbserial dyndbg==p
>

Yes, it does seem that I'm getting the 5-bit truncation.  Here is an
excerpt from the prodigious logs, in this case sending a 'Z' from
pl2303 and receiving an 0x5a on the ch341.  The same sort of thing,
e.g. 'A' (0x41) from the ch341 lands as an 0x01 on the pl2303, 0x42 ->
0x02, etc.

Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_chars_in_buffer
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_chars_in_buffer - returns 0
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_write_room
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_write_room - returns 4096
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_tiocmget
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_ioctl - cmd 0x5401
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_chars_in_buffer
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_chars_in_buffer - returns 0
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_write_room
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_write_room - returns 4096
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_chars_in_buffer
Dec 19 08:22:53 willard kernel: pl2303 ttyUSB1:
usb_serial_generic_chars_in_buffer - returns 0
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_write_room
Dec 19 08:22:53 willard kernel: pl2303 ttyUSB1:
usb_serial_generic_write_room - returns 4096
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_tiocmget
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_ioctl - cmd 0x5401
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_chars_in_buffer
Dec 19 08:22:53 willard kernel: pl2303 ttyUSB1:
usb_serial_generic_chars_in_buffer - returns 0
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_write_room
Dec 19 08:22:53 willard kernel: pl2303 ttyUSB1:
usb_serial_generic_write_room - returns 4096
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_chars_in_buffer
Dec 19 08:22:53 willard kernel: pl2303 ttyUSB1:
usb_serial_generic_chars_in_buffer - returns 0
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_write_room
Dec 19 08:22:53 willard kernel: pl2303 ttyUSB1:
usb_serial_generic_write_room - returns 4096
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_write - 1 byte(s)
Dec 19 08:22:53 willard kernel: pl2303 ttyUSB1:
usb_serial_generic_write_start - length = 1, data = 5a
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_tiocmget
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_ioctl - cmd 0x5401
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_chars_in_buffer
Dec 19 08:22:53 willard kernel: pl2303 ttyUSB1:
usb_serial_generic_chars_in_buffer - returns 1
Dec 19 08:22:53 willard kernel: tty ttyUSB1: serial_write_room
Dec 19 08:22:53 willard kernel: pl2303 ttyUSB1:
usb_serial_generic_write_room - returns 4096
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_read_bulk_callback - urb 1, len 1
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_read_bulk_callback - length = 1, data = 1a
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_submit_read_urb - urb 1
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_chars_in_buffer
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_chars_in_buffer - returns 0
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_write_room
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_write_room - returns 4096
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_tiocmget
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_ioctl - cmd 0x5401
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_chars_in_buffer
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_chars_in_buffer - returns 0
Dec 19 08:22:53 willard kernel: tty ttyUSB0: serial_write_room
Dec 19 08:22:53 willard kernel: ch341-uart ttyUSB0:
usb_serial_generic_write_room - returns 4096


>> 00014-g79e475a:
>>
>>   dmesg shows on insert:
>>
>> [ 1430.504116] usb 6-2: new full-speed USB device number 3 using uhci_hcd
>> [ 1430.682143] usb 6-2: New USB device found, idVendor=1a86, idProduct=7523
>> [ 1430.682148] usb 6-2: New USB device strings: Mfr=0, Product=2, SerialNumber=0
>> [ 1430.682152] usb 6-2: Product: USB2.0-Ser!
>> [ 1430.686294] ch341 6-2:1.0: ch341-uart converter detected
>> [ 1430.689122] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (pre version)
>> [ 1430.693121] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post init-0)
>> [ 1430.693124] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
>> c3, a = b202
>> [ 1430.696120] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post divisor)
>> [ 1430.699119] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post lcr)
>> [ 1430.700501] usb 6-2: ch341-uart converter now attached to ttyUSB0
>>
>> Changing baud rate and then byte-size:
>>
>> [ 1621.189700] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
>> c3, a = b202
>> [ 1621.193556] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post divisor)
>> [ 1621.196557] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post lcr)
>> [ 1621.199565] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
>> c3, a = cc03
>> [ 1621.202571] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post divisor)
>> [ 1621.205569] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post lcr)
>> [ 1621.207572] usb 6-2: ch341_set_baudrate_lcr - speed = 115200, lcr =
>> c3, a = cc03
>> [ 1621.210570] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post divisor)
>> [ 1621.213573] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post lcr)
>> [ 1644.117396] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
>> c3, a = b202
>> [ 1644.120933] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post divisor)
>> [ 1644.123952] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post lcr)
>> [ 1666.950341] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
>> c0, a = b202
>> [ 1666.954320] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post divisor)
>> [ 1666.957316] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
>> (post lcr)
>> [ 1700.500318] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
>> c3, a = b202
>> [ 1700.503845] usb 6-2: ch341_dbg - [0x2518] = c0 00, [0x1213] = 00 00
>> (post divisor)
>> [ 1700.506866] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post lcr)
>>
>> It works in 8-bit mode, I can change to 5-bit mode and then back, as
>> before.  And I can change baud rate.
>
> Note that you only need to test this commit, which simply adds the
> debugging printks on top of the previous.
>
> The log indicates that the LCR is updated correctly, but also reveals
> that the divisor registers always read back as zero even if changing
> speeds appear to work. Both my devices read back the values set either
> through direct register write or using the init commmand.
>
> We may be able to use this to detect these devices and fall back to
> direct register writes.
>
>> 00015-gee5a27b:
>
>> I can switch baud rate and byte size back and forth and it seems to
>> work.  In 5-bit mode, I guess minicom just doesn't know how to render
>> the values, so that makes sense, switching back to 8-bit mode and I
>> get readable text again.  So, this one is working too, afaict.
>
> Good, this one only differs from the previous in that the 7th bit of the
> divisor register is set, something which is required for CH341A. Good to
> know it does not seem to have any negative effects for this device.
>
>> 00016-ga06b45d:
>>
>>   dmesg on insert:
>>
>> [ 2588.016052] usb 6-2: new full-speed USB device number 5 using uhci_hcd
>> [ 2588.189182] usb 6-2: New USB device found, idVendor=1a86, idProduct=7523
>> [ 2588.189187] usb 6-2: New USB device strings: Mfr=0, Product=2, SerialNumber=0
>> [ 2588.189192] usb 6-2: Product: USB2.0-Ser!
>> [ 2588.193366] ch341 6-2:1.0: ch341-uart converter detected
>> [ 2588.196146] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (pre version)
>> [ 2588.200162] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post init-0)
>> [ 2588.200165] usb 6-2: ch341_set_baudrate_lcr - speed = 9600, lcr =
>> c3, a = b202
>> [ 2588.203182] usb 6-2: ch341_dbg - [0x2518] = c3 00, [0x1213] = 00 00
>> (post init)
>> [ 2588.204488] usb 6-2: ch341-uart converter now attached to ttyUSB0
>>
>> This doesn't work.  Even when matching baud rate and byte size, the
>> best I get is 0xff's out on the ch341.  Nothing decodes as printable
>> anything at the pl2303 side.
>
> Ok, so the init command cannot be used to switch baud rate for these
> devices.
>
> Could you see if you can communicate using 19200 baud (when using this
> or the next commit), which is the default baud rate for the devices I
> have (i.e. default settings are 19200 8N1).

19200 8N1 on this commit does not work.

>
>> 00017-g6edc283:
>
>> This doesn't work either.  At 9600 8N1, I get 0xff's on the pl2303,
>> and some unicode on the ch341.
>
> If the baud rate cannot be set using the init command, then this should
> behave as the previous commit. 19200 baud might work.
>
>> Let me know if I can test anything else!
>
> Apart from the two additional tests mentioned above, can you also
> provide a log from when connecting the device using the following commit
> that I just pushed to the ch341 branch:
>
>         f341ee36198d ("dbg: ch341: add register dumps to probe")
>
> which provides dumps of the register settings during initialisation.
> (Make sure ch341 dynamic debugging is not enabled to avoid cluttering
> the log.)

I'll send this in a followup, need to rebuild.

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Russell Senior]

>> Apart from the two additional tests mentioned above, can you also
>> provide a log from when connecting the device using the following commit
>> that I just pushed to the ch341 branch:
>>
>>         f341ee36198d ("dbg: ch341: add register dumps to probe")
>>
>> which provides dumps of the register settings during initialisation.
>> (Make sure ch341 dynamic debugging is not enabled to avoid cluttering
>> the log.)
>
> I'll send this in a followup, need to rebuild.

00018-gf341ee3:

Dec 19 13:51:13 willard kernel: usbcore: registered new interface driver ch341
Dec 19 13:51:13 willard kernel: usbserial: USB Serial support
registered for ch341-uart
Dec 19 13:51:23 willard kernel: usb 6-2: new full-speed USB device
number 10 using uhci_hcd
Dec 19 13:51:23 willard kernel: usb 6-2: New USB device found,
idVendor=1a86, idProduct=7523
Dec 19 13:51:23 willard kernel: usb 6-2: New USB device strings:
Mfr=0, Product=2, SerialNumber=0
Dec 19 13:51:23 willard kernel: usb 6-2: Product: USB2.0-Ser!
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: ch341-uart converter detected
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [00] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [01] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [02] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [03] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [04] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [05] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [06] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [07] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [08] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [09] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [10] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [11] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [12] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [13] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [14] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [15] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [16] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [17] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [18] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [19] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [20] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [21] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [22] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [23] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [24] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [25] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [26] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [27] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [28] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [29] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: init 0 0
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [00] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [01] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [02] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [03] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [04] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [05] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [06] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [07] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [08] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [09] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [10] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [11] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [12] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [13] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [14] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [15] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [16] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [17] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [18] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [19] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [20] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [21] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [22] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [23] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [24] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [25] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [26] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [27] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [28] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [29] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: write 0x31 0xb282
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [00] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [01] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [02] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [03] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [04] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [05] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [06] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [07] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [08] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [09] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [10] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [11] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [12] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [13] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [14] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [15] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [16] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [17] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [18] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [19] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [20] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [21] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [22] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [23] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [24] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [25] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [26] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [27] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [28] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [29] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2f] = 00
Dec 19 13:51:23 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (pre version)
Dec 19 13:51:23 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init-0)
Dec 19 13:51:23 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 9600, lcr = c3, a = b202
Dec 19 13:51:23 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [00] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [01] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [02] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [03] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [04] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [05] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [06] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [07] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [08] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [09] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [10] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [11] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [12] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [13] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [14] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [15] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [16] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [17] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [18] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [19] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1f] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [20] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [21] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [22] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [23] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [24] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [25] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [26] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [27] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [28] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [29] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2a] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2b] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2c] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2d] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2e] = 00
Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2f] = 00
Dec 19 13:51:23 willard kernel: usb 6-2: ch341-uart converter now
attached to ttyUSB0
Dec 19 13:51:36 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 19200, lcr = c3, a = d902
Dec 19 13:51:36 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 19 13:52:18 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 19200, lcr = c0, a = d902
Dec 19 13:52:18 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 19 13:52:40 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 19200, lcr = c3, a = d902
Dec 19 13:52:40 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 19 13:53:27 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 19200, lcr = c3, a = d902
Dec 19 13:53:27 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

[-- Attachment #1: Type: text/plain, Size: 5564 bytes --]

On Mon, Dec 19, 2016 at 02:12:05PM -0800, Russell Senior wrote:
> >> Apart from the two additional tests mentioned above, can you also
> >> provide a log from when connecting the device using the following commit
> >> that I just pushed to the ch341 branch:
> >>
> >>         f341ee36198d ("dbg: ch341: add register dumps to probe")
> >>
> >> which provides dumps of the register settings during initialisation.
> >> (Make sure ch341 dynamic debugging is not enabled to avoid cluttering
> >> the log.)
> >
> > I'll send this in a followup, need to rebuild.
> 
> 00018-gf341ee3:
> 
> Dec 19 13:51:13 willard kernel: usbcore: registered new interface driver ch341
> Dec 19 13:51:13 willard kernel: usbserial: USB Serial support
> registered for ch341-uart
> Dec 19 13:51:23 willard kernel: usb 6-2: new full-speed USB device
> number 10 using uhci_hcd
> Dec 19 13:51:23 willard kernel: usb 6-2: New USB device found,
> idVendor=1a86, idProduct=7523
> Dec 19 13:51:23 willard kernel: usb 6-2: New USB device strings:
> Mfr=0, Product=2, SerialNumber=0
> Dec 19 13:51:23 willard kernel: usb 6-2: Product: USB2.0-Ser!
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: ch341-uart converter detected
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [00] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [01] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [02] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [03] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [04] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [05] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [06] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [07] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [08] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [09] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0a] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0b] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0c] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0d] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0e] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [0f] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [10] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [11] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [12] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [13] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [14] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [15] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [16] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [17] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [18] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [19] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1a] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1b] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1c] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1d] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1e] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [1f] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [20] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [21] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [22] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [23] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [24] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [25] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [26] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [27] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [28] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [29] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2a] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2b] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2c] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2d] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2e] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: [2f] = 00
> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: init 0 0

> Dec 19 13:51:23 willard kernel: ch341 6-2:1.0: write 0x31 0xb282

Ok, so no direct register read works (as they do on CH340G and CH341A)
and instead always return zero. Except, when LCR is read back together
with register 0x25:

> Dec 19 13:51:23 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
> [0x1213] = 00 00 (pre version)

Note that the 0x31 LCR is read back as 0xf1, that is, with the tx and rx
enable bits set.

My CH341A behaves similarly and always has rx enabled.

> Dec 19 13:51:23 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
> [0x1213] = 00 00 (post init-0)
> Dec 19 13:51:23 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
> speed = 9600, lcr = c3, a = b202
> Dec 19 13:51:23 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
> [0x1213] = 00 00 (post init - lcr reset)

And the init command does not seem to have any effect on either LCR or
the divisors as previous tests also show.

I'm not sure what device we're dealing with here, but it seems it would
not be supported by the vendor (whose version of this driver also uses
the init-command).

Perhaps you could give the attached vendor driver a quick spin just to
confirm that? It's a rebased version against usb-next.

I've also pushed a commit that tries to dump the registers differently
(reading together with register 0x25):

	3baa1eff4245 ("dbg: ch341: dump registers differently")

Could you provide a log from when connecting the device with this commit
as well?

Thanks,
Johan

[-- Attachment #2: 0001-tmp-ch341-replace-with-vendor-driver.patch --]
[-- Type: text/x-diff, Size: 40602 bytes --]

>From 6d2bca3cda09fca9c0a2a2c84dbf64c6090b3da5 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Mon, 21 Nov 2016 16:28:22 +0100
Subject: [PATCH] tmp: ch341: replace with vendor driver

---
 drivers/usb/serial/ch341.c | 1238 ++++++++++++++++++++++++++++----------------
 1 file changed, 803 insertions(+), 435 deletions(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 2597b83a8ae2..b193b78c27bb 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -1,11 +1,15 @@
 /*
+ * Winchiphead CH34x USB to serial adaptor driver
+ *
  * Copyright 2007, Frank A Kingswood <frank@kingswood-consulting.co.uk>
  * Copyright 2007, Werner Cornelius <werner@cornelius-consult.de>
  * Copyright 2009, Boris Hajduk <boris@hajduk.org>
+ * Copyright 2016, WCH Tech Group <tech@winchiphead.com>
  *
- * ch341.c implements a serial port driver for the Winchiphead CH341.
+ * ch34x.c implements a serial port driver for the Winchiphead CH340 and
+ * CH341.
  *
- * The CH341 device can be used to implement an RS232 asynchronous
+ * The CH34x device can be used to implement an RS232 asynchronous
  * serial port, an IEEE-1284 parallel printer port or a memory-like
  * interface. In all cases the CH341 supports an I2C interface as well.
  * This driver only supports the asynchronous serial interface.
@@ -16,134 +20,270 @@
  */
 
 #include <linux/kernel.h>
+#include <linux/errno.h>
+#include <linux/init.h>
+#include <linux/slab.h>
 #include <linux/tty.h>
+#include <linux/tty_driver.h>
+#include <linux/tty_flip.h>
+#include <linux/serial.h>
 #include <linux/module.h>
-#include <linux/slab.h>
+#include <linux/moduleparam.h>
+#include <linux/spinlock.h>
+#include <linux/uaccess.h>
 #include <linux/usb.h>
 #include <linux/usb/serial.h>
-#include <linux/serial.h>
-#include <asm/unaligned.h>
-
-#define DEFAULT_BAUD_RATE 9600
-#define DEFAULT_TIMEOUT   1000
-
-/* flags for IO-Bits */
-#define CH341_BIT_RTS (1 << 6)
-#define CH341_BIT_DTR (1 << 5)
-
-/******************************/
-/* interrupt pipe definitions */
-/******************************/
-/* always 4 interrupt bytes */
-/* first irq byte normally 0x08 */
-/* second irq byte base 0x7d + below */
-/* third irq byte base 0x94 + below */
-/* fourth irq byte normally 0xee */
-
-/* second interrupt byte */
-#define CH341_MULT_STAT 0x04 /* multiple status since last interrupt event */
-
-/* status returned in third interrupt answer byte, inverted in data
-   from irq */
-#define CH341_BIT_CTS 0x01
-#define CH341_BIT_DSR 0x02
-#define CH341_BIT_RI  0x04
-#define CH341_BIT_DCD 0x08
-#define CH341_BITS_MODEM_STAT 0x0f /* all bits */
-
-/*******************************/
-/* baudrate calculation factor */
-/*******************************/
-#define CH341_BAUDBASE_FACTOR 1532620800
-#define CH341_BAUDBASE_DIVMAX 3
-
-/* Break support - the information used to implement this was gleaned from
- * the Net/FreeBSD uchcom.c driver by Takanori Watanabe.  Domo arigato.
- */
 
-#define CH341_REQ_READ_VERSION 0x5F
-#define CH341_REQ_WRITE_REG    0x9A
-#define CH341_REQ_READ_REG     0x95
-#define CH341_REQ_SERIAL_INIT  0xA1
-#define CH341_REQ_MODEM_CTRL   0xA4
-
-#define CH341_REG_BREAK        0x05
-#define CH341_REG_LCR          0x18
-#define CH341_NBREAK_BITS      0x01
-
-#define CH341_LCR_ENABLE_RX    0x80
-#define CH341_LCR_ENABLE_TX    0x40
-#define CH341_LCR_MARK_SPACE   0x20
-#define CH341_LCR_PAR_EVEN     0x10
-#define CH341_LCR_ENABLE_PAR   0x08
-#define CH341_LCR_STOP_BITS_2  0x04
-#define CH341_LCR_CS8          0x03
-#define CH341_LCR_CS7          0x02
-#define CH341_LCR_CS6          0x01
-#define CH341_LCR_CS5          0x00
-
-static const struct usb_device_id id_table[] = {
-	{ USB_DEVICE(0x4348, 0x5523) },
-	{ USB_DEVICE(0x1a86, 0x7523) },
-	{ USB_DEVICE(0x1a86, 0x5523) },
-	{ },
+#define DRIVER_DESC		"WCH CH34x USB to serial adaptor driver"
+#define DRIVER_AUTHOR	"WCH Tech Group <tech@winchiphead.com>"
+
+#define CH34x_VENDOR_ID        0x1A86
+#define CH340_PRODUCT_ID       0x7523
+#define CH341_PRODUCT_ID       0x5523
+
+#define CH34x_CLOSING_WAIT     (30 * HZ)
+
+#define CH34x_BUF_SIZE	1024
+#define CH34x_TMP_BUF_SIZE 1024
+
+#define VENDOR_WRITE_TYPE	0x40
+#define VENDOR_READ_TYPE	0xC0
+
+#define VENDOR_READ		0x95
+#define VENDOR_WRITE		0x9A
+#define VENDOR_SERIAL_INIT	0xA1
+#define VENDOR_MODEM_OUT	0xA4
+#define VENDOR_VERSION		0x5F
+
+/* for command 0xA4 */
+#define UART_CTS		0x01
+#define UART_DSR		0x02
+#define UART_RING		0x04
+#define UART_DCD		0x08
+#define CONTROL_OUT		0x10
+#define CONTROL_DTR		0x20
+#define CONTROL_RTS		0x40
+
+/* uart state */
+#define UART_STATE		0x00
+#define UART_OVERRUN_ERROR  0x01
+#define UART_BREAK_ERROR
+#define UART_PARITY_ERROR       0x02
+#define UART_FRAME_ERROR        0x06
+#define UART_RECV_ERROR		0x02
+#define UART_STATE_TRANSIENT_MASK 0x07
+
+/* port state */
+#define PORTA_STATE		0x01
+#define PORTB_STATE		0x02
+#define PORTC_STATE		0x03
+
+/* Baud Rate */
+#define CH34x_BAUDRATE_FACTOR	1532620800
+#define CH34x_BAUDRATE_DIVMAX	3
+
+static DECLARE_WAIT_QUEUE_HEAD(wq);
+static int wait_flag;
+
+struct ch34x_buf {
+	unsigned int buf_size;
+	char *buf_buf;
+	char *buf_get;
+	char *buf_put;
+};
+
+struct ch34x_private {
+	spinlock_t lock;       /* access lock */
+	struct ch34x_buf *buf;
+	int write_urb_in_use;
+	unsigned int baud_rate;
+	wait_queue_head_t delta_msr_wait;
+	u8 line_control;       /* set line control value RTS/DTR */
+	u8 line_status;	       /* active status of modem control inputs */
+	u8 termios_initialized;
 };
-MODULE_DEVICE_TABLE(usb, id_table);
 
-struct ch341_private {
-	spinlock_t lock; /* access lock */
-	unsigned baud_rate; /* set baud rate */
-	u8 line_control; /* set line control value RTS/DTR */
-	u8 line_status; /* active status of modem control inputs */
+static struct usb_device_id id_table[] = {
+	{ USB_DEVICE(CH34x_VENDOR_ID, CH340_PRODUCT_ID) },
+	{ USB_DEVICE(CH34x_VENDOR_ID, CH341_PRODUCT_ID) },
+	{ }
 };
+MODULE_DEVICE_TABLE(usb, id_table);
+
+static struct ch34x_buf *ch34x_buf_alloc(unsigned int size)
+{
+	struct ch34x_buf *pb;
+
+	if (size == 0)
+		return NULL;
+
+	pb = kmalloc(sizeof(struct ch34x_buf), GFP_KERNEL);
+	if (pb == NULL)
+		return NULL;
+
+	pb->buf_buf = kmalloc(size, GFP_KERNEL);
+	if (pb->buf_buf == NULL) {
+		kfree(pb);
+		return NULL;
+	}
+
+	pb->buf_size = size;
+	pb->buf_get = pb->buf_put = pb->buf_buf;
+
+	return pb;
+}
+
+static void ch34x_buf_free(struct ch34x_buf *pb)
+{
+	if (pb) {
+		kfree(pb->buf_buf);
+		kfree(pb);
+	}
+}
+
+static void ch34x_buf_clear(struct ch34x_buf *pb)
+{
+	if (pb != NULL)
+		pb->buf_get = pb->buf_put;
+}
+
+static unsigned int ch34x_buf_data_avail(struct ch34x_buf *pb)
+{
+	if (pb == NULL)
+		return 0;
+
+	return ((pb->buf_size + pb->buf_put - pb->buf_get) % pb->buf_size);
+}
+
+static unsigned int ch34x_buf_space_avail(struct ch34x_buf *pb)
+{
+	if (pb == NULL)
+		return 0;
+
+	return ((pb->buf_size + pb->buf_get - pb->buf_put - 1)
+			% pb->buf_size);
+}
+
+static unsigned int ch34x_buf_put(struct ch34x_buf *pb,
+		const char *buf, unsigned int count)
+{
+	unsigned int len;
+
+	if (pb == NULL)
+		return 0;
+
+	len = ch34x_buf_space_avail(pb);
+	if (count > len)
+		count = len;
+	else if (count == 0)
+		return 0;
+
+	len = pb->buf_buf + pb->buf_size - pb->buf_put;
+	if (count > len) {
+		memcpy(pb->buf_put, buf, len);
+		memcpy(pb->buf_buf, buf+len, count - len);
+		pb->buf_put = pb->buf_buf + count - len;
+	} else {
+		memcpy(pb->buf_put, buf, count);
+		if (count < len)
+			pb->buf_put += count;
+		else if (count == len)
+			pb->buf_put = pb->buf_buf;
+	}
 
-static void ch341_set_termios(struct tty_struct *tty,
-			      struct usb_serial_port *port,
-			      struct ktermios *old_termios);
+	return count;
+}
 
-static int ch341_control_out(struct usb_device *dev, u8 request,
-			     u16 value, u16 index)
+static unsigned int ch34x_buf_get(struct ch34x_buf *pb,
+		char *buf, unsigned int count)
 {
-	int r;
+	unsigned int len;
+
+	if (pb == NULL)
+		return 0;
+
+	len = ch34x_buf_data_avail(pb);
+	if (count > len)
+		count = len;
+	else if (count == 0)
+		return 0;
+
+	len = pb->buf_buf + pb->buf_size - pb->buf_get;
+	if (count > len) {
+		memcpy(buf, pb->buf_get, len);
+		memcpy(buf + len, pb->buf_buf, count - len);
+		pb->buf_get = pb->buf_buf + count - len;
+	} else {
+		memcpy(buf, pb->buf_get, count);
+		if (count < len)
+			pb->buf_get += count;
+		else if (count == len)
+			pb->buf_get = pb->buf_buf;
+	}
+
+	return count;
+}
 
-	dev_dbg(&dev->dev, "ch341_control_out(%02x,%02x,%04x,%04x)\n",
-		USB_DIR_OUT|0x40, (int)request, (int)value, (int)index);
+static int ch34x_vendor_read(__u8 request,
+		__u16 value,
+		__u16 index,
+		struct usb_serial *serial,
+		unsigned char *buf,
+		__u16 len)
+{
+	int retval;
 
-	r = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), request,
-			    USB_TYPE_VENDOR | USB_RECIP_DEVICE | USB_DIR_OUT,
-			    value, index, NULL, 0, DEFAULT_TIMEOUT);
+	retval = usb_control_msg(serial->dev,
+			usb_rcvctrlpipe(serial->dev, 0),
+			request,
+			VENDOR_READ_TYPE,
+			value, index, buf, len, 1000);
 
-	return r;
+	return retval;
 }
 
-static int ch341_control_in(struct usb_device *dev,
-			    u8 request, u16 value, u16 index,
-			    char *buf, unsigned bufsize)
+static int ch34x_vendor_write(__u8 request,
+		__u16 value,
+		__u16 index,
+		struct usb_serial *serial,
+		unsigned char *buf,
+		__u16 len)
 {
-	int r;
+	int retval;
 
-	dev_dbg(&dev->dev, "ch341_control_in(%02x,%02x,%04x,%04x,%p,%u)\n",
-		USB_DIR_IN|0x40, (int)request, (int)value, (int)index, buf,
-		(int)bufsize);
+	retval = usb_control_msg(serial->dev,
+			usb_sndctrlpipe(serial->dev, 0),
+			request,
+			VENDOR_WRITE_TYPE,
+			value, index, buf, len, 1000);
 
-	r = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), request,
-			    USB_TYPE_VENDOR | USB_RECIP_DEVICE | USB_DIR_IN,
-			    value, index, buf, bufsize, DEFAULT_TIMEOUT);
-	return r;
+	return retval;
 }
 
-static int ch341_init_set_baudrate(struct usb_device *dev,
-				   struct ch341_private *priv, unsigned ctrl)
+static int set_control_lines(struct usb_serial_port *port,
+		struct usb_serial *serial, u8 value)
 {
-	short a;
-	int r;
-	unsigned long factor;
-	short divisor;
+	int retval;
+
+	retval = ch34x_vendor_write(VENDOR_MODEM_OUT, (unsigned short)value,
+			0x0000, serial, NULL, 0x00);
+	dev_dbg(&port->dev, "%s - value=%d, retval=%d",
+		__func__, value, retval);
+
+	return retval;
+}
 
-	if (!priv->baud_rate)
+static int ch34x_get_baud_rate(unsigned int baud_rate,
+		unsigned char *a, unsigned char *b)
+{
+	unsigned long factor = 0;
+	short divisor = 0;
+
+	if (!baud_rate)
 		return -EINVAL;
-	factor = (CH341_BAUDBASE_FACTOR / priv->baud_rate);
-	divisor = CH341_BAUDBASE_DIVMAX;
+
+	factor = CH34x_BAUDRATE_FACTOR / baud_rate;
+	divisor = CH34x_BAUDRATE_DIVMAX;
 
 	while ((factor > 0xfff0) && divisor) {
 		factor >>= 3;
@@ -154,464 +294,692 @@ static int ch341_init_set_baudrate(struct usb_device *dev,
 		return -EINVAL;
 
 	factor = 0x10000 - factor;
-	a = (factor & 0xff00) | divisor;
-
-	/* 0x9c is "enable SFR_UART Control register and timer" */
-	r = ch341_control_out(dev, CH341_REQ_SERIAL_INIT,
-			      0x9c | (ctrl << 8), a | 0x80);
+	*a = (factor & 0xff00) >> 8;
+	*b = divisor;
 
-	return r;
+	return 0;
 }
 
-static int ch341_set_handshake(struct usb_device *dev, u8 control)
+static void ch34x_set_termios(struct tty_struct *tty,
+		struct usb_serial_port *port, struct ktermios *old_termios)
 {
-	return ch341_control_out(dev, CH341_REQ_MODEM_CTRL, ~control, 0);
-}
+	struct usb_serial *serial = port->serial;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
+	struct ktermios *termios = &tty->termios;
 
-static int ch341_get_status(struct usb_device *dev, struct ch341_private *priv)
-{
-	char *buffer;
-	int r;
-	const unsigned size = 8;
+	unsigned int baud_rate;
+	unsigned int cflag;
 	unsigned long flags;
+	u8 control;
 
-	buffer = kmalloc(size, GFP_KERNEL);
-	if (!buffer)
-		return -ENOMEM;
+	unsigned char divisor = 0;
+	unsigned char reg_count = 0;
+	unsigned char factor = 0;
+	unsigned char reg_value = 0;
+	unsigned short value = 0;
+	unsigned short index = 0;
 
-	r = ch341_control_in(dev, CH341_REQ_READ_REG, 0x0706, 0, buffer, size);
-	if (r < 0)
-		goto out;
+	dev_dbg(&port->dev, "%s - port:%d", __func__, port->port_number);
 
-	/* setup the private status if available */
-	if (r == 2) {
-		r = 0;
-		spin_lock_irqsave(&priv->lock, flags);
-		priv->line_status = (~(*buffer)) & CH341_BITS_MODEM_STAT;
-		spin_unlock_irqrestore(&priv->lock, flags);
-	} else
-		r = -EPROTO;
+	spin_lock_irqsave(&priv->lock, flags);
+	if (!priv->termios_initialized) {
+		*termios = tty_std_termios;
+		termios->c_cflag = B9600 | CS8 | CREAD | HUPCL | CLOCAL;
+		termios->c_ispeed = 9600;
+		termios->c_ospeed = 9600;
+		priv->termios_initialized = 1;
+	}
+	spin_unlock_irqrestore(&priv->lock, flags);
 
-out:	kfree(buffer);
-	return r;
-}
+	/*
+	 * The ch34x is reported to lose bytes if you change serial setting
+	 * even to the same vaules as before. Thus we actually need to filter
+	 * in this specific case.
+	 */
+	if (!tty_termios_hw_change(termios, old_termios))
+		return;
 
-/* -------------------------------------------------------------------------- */
+	cflag = termios->c_cflag;
 
-static int ch341_configure(struct usb_device *dev, struct ch341_private *priv)
-{
-	char *buffer;
-	int r;
-	const unsigned size = 8;
-
-	buffer = kmalloc(size, GFP_KERNEL);
-	if (!buffer)
-		return -ENOMEM;
-
-	/* expect two bytes 0x27 0x00 */
-	r = ch341_control_in(dev, CH341_REQ_READ_VERSION, 0, 0, buffer, size);
-	if (r < 0)
-		goto out;
-	dev_dbg(&dev->dev, "Chip version: 0x%02x\n", buffer[0]);
-
-	r = ch341_control_out(dev, CH341_REQ_SERIAL_INIT, 0, 0);
-	if (r < 0)
-		goto out;
-
-	/* expect two bytes 0x56 0x00 */
-	r = ch341_control_in(dev, CH341_REQ_READ_REG, 0x2518, 0, buffer, size);
-	if (r < 0)
-		goto out;
-
-	r = ch341_control_out(dev, CH341_REQ_WRITE_REG, 0x2518, 0x0050);
-	if (r < 0)
-		goto out;
-
-	/* expect 0xff 0xee */
-	r = ch341_get_status(dev, priv);
-	if (r < 0)
-		goto out;
-
-	r = ch341_init_set_baudrate(dev, priv, 0);
-	if (r < 0)
-		goto out;
-
-	r = ch341_set_handshake(dev, priv->line_control);
-	if (r < 0)
-		goto out;
-
-	/* expect 0x9f 0xee */
-	r = ch341_get_status(dev, priv);
-
-out:	kfree(buffer);
-	return r;
-}
+	dev_dbg(&port->dev, "%s(%d) cflag = 0x%x\n",
+		__func__, port->port_number, cflag);
 
-static int ch341_port_probe(struct usb_serial_port *port)
-{
-	struct ch341_private *priv;
-	int r;
+	/* Get the byte size */
+	switch (cflag & CSIZE) {
+	case CS5:
+		reg_value |= 0x00;
+		break;
+	case CS6:
+		reg_value |= 0x01;
+		break;
+	case CS7:
+		reg_value |= 0x02;
+		break;
+	case CS8:
+		reg_value |= 0x03;
+		break;
+	default:
+		reg_value |= 0x03;
+		break;
+	}
+	dev_dbg(&port->dev, "%s - data bits = %d", __func__, reg_value + 0x05);
 
-	priv = kzalloc(sizeof(struct ch341_private), GFP_KERNEL);
-	if (!priv)
-		return -ENOMEM;
+	if (cflag & CSTOPB) {
+		reg_value |= 0x04;
+		dev_dbg(&port->dev, "%s - stop bits = 2", __func__);
+	} else
+		dev_dbg(&port->dev, "%s - stop bits = 1", __func__);
+
+	if (cflag & PARENB) {
+		if (cflag & PARODD) {
+			reg_value |= 0x08 | 0x00;
+			dev_dbg(&port->dev, "%s - parity = odd", __func__);
+		} else {
+			reg_value |= 0x08 | 0x10;
+			dev_dbg(&port->dev, "%s - parity = even", __func__);
+		}
+	} else
+		dev_dbg(&port->dev, "%s - parity = none", __func__);
 
-	spin_lock_init(&priv->lock);
-	priv->baud_rate = DEFAULT_BAUD_RATE;
-	priv->line_control = CH341_BIT_RTS | CH341_BIT_DTR;
+	baud_rate = tty_get_baud_rate(tty);
+	dev_dbg(&port->dev, "%s = baud_rate = %d", __func__, baud_rate);
+	ch34x_get_baud_rate(baud_rate, &factor, &divisor);
+	dev_dbg(&port->dev, "----->>>> baud_rate = %d, factor:0x%x, divisor:0x%x",
+			baud_rate, factor, divisor);
+
+	/* enable SFR_UART RX and TX */
+	reg_value |= 0xc0;
+	/* enable SFR_UART Control register and timer */
+	reg_count |= 0x9c;
+
+	value |= reg_count;
+	value |= (unsigned short)reg_value << 8;
+	index |= 0x80 | divisor;
+	index |= (unsigned short)factor << 8;
+	ch34x_vendor_write(VENDOR_SERIAL_INIT, value, index, serial, NULL, 0);
+
+	/* change control lines if we are switching to or from B0 */
+	spin_lock_irqsave(&priv->lock, flags);
+	control = priv->line_control;
+	if ((cflag & CBAUD) == B0)
+		priv->line_control &= ~(CONTROL_DTR | CONTROL_RTS);
+	else
+		priv->line_control |= (CONTROL_DTR | CONTROL_RTS);
 
-	r = ch341_configure(port->serial->dev, priv);
-	if (r < 0)
-		goto error;
+	if (control != priv->line_control) {
+		control = priv->line_control;
+		spin_unlock_irqrestore(&priv->lock, flags);
+		set_control_lines(port, serial, control);
+	} else
+		spin_unlock_irqrestore(&priv->lock, flags);
 
-	usb_set_serial_port_data(port, priv);
-	return 0;
+	if (cflag & CRTSCTS)
+		ch34x_vendor_write(VENDOR_WRITE, 0x2727, 0x0101,
+						serial, NULL, 0);
 
-error:	kfree(priv);
-	return r;
+	/* FIXME: Need to read back resulting baud rate */
+	if (baud_rate)
+		tty_encode_baud_rate(tty, baud_rate, baud_rate);
 }
 
-static int ch341_port_remove(struct usb_serial_port *port)
+static int ch34x_tiocmget(struct tty_struct *tty)
 {
-	struct ch341_private *priv;
+	struct usb_serial_port *port = tty->driver_data;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
+	unsigned long flags;
+	unsigned int mcr;
+	unsigned int retval;
 
-	priv = usb_get_serial_port_data(port);
-	kfree(priv);
+	dev_dbg(&port->dev, "%s - port:%d", __func__, port->port_number);
+	if (!usb_get_intfdata(port->serial->interface))
+		return -ENODEV;
 
-	return 0;
-}
+	spin_lock_irqsave(&priv->lock, flags);
+	mcr = priv->line_control;
+	spin_unlock_irqrestore(&priv->lock, flags);
 
-static int ch341_carrier_raised(struct usb_serial_port *port)
-{
-	struct ch341_private *priv = usb_get_serial_port_data(port);
-	if (priv->line_status & CH341_BIT_DCD)
-		return 1;
-	return 0;
+	retval = ((mcr & CONTROL_DTR) ? TIOCM_DTR : 0) |
+		((mcr & CONTROL_RTS) ? TIOCM_RTS : 0) |
+		((mcr & UART_CTS) ? TIOCM_CTS : 0) |
+		((mcr & UART_DSR) ? TIOCM_DSR : 0) |
+		((mcr & UART_RING) ? TIOCM_RI : 0) |
+		((mcr & UART_DCD) ? TIOCM_CD : 0);
+
+	dev_dbg(&port->dev, "%s-retval = 0x%x", __func__, retval);
+
+	return retval;
 }
 
-static void ch341_dtr_rts(struct usb_serial_port *port, int on)
+static void ch34x_close(struct usb_serial_port *port)
 {
-	struct ch341_private *priv = usb_get_serial_port_data(port);
+	struct tty_struct *tty = port->port.tty;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
 	unsigned long flags;
+	unsigned int c_cflag;
 
-	/* drop DTR and RTS */
+	/* clear out any remaining data in the buffer */
 	spin_lock_irqsave(&priv->lock, flags);
-	if (on)
-		priv->line_control |= CH341_BIT_RTS | CH341_BIT_DTR;
-	else
-		priv->line_control &= ~(CH341_BIT_RTS | CH341_BIT_DTR);
+	ch34x_buf_clear(priv->buf);
 	spin_unlock_irqrestore(&priv->lock, flags);
-	ch341_set_handshake(port->serial->dev, priv->line_control);
-}
 
-static void ch341_close(struct usb_serial_port *port)
-{
-	usb_serial_generic_close(port);
+	/* kill our urbs */
 	usb_kill_urb(port->interrupt_in_urb);
+	usb_kill_urb(port->read_urb);
+	usb_kill_urb(port->write_urb);
+
+	if (tty) {
+		c_cflag = tty->termios.c_cflag;
+		if (c_cflag & HUPCL) {
+			/* drop DTR and RTS */
+			spin_lock_irqsave(&priv->lock, flags);
+			priv->line_control = 0;
+			spin_unlock_irqrestore(&priv->lock, flags);
+			set_control_lines(port, port->serial, 0);
+		}
+	}
 }
 
-
-/* open this device, set default parameters */
-static int ch341_open(struct tty_struct *tty, struct usb_serial_port *port)
+static int ch34x_open(struct tty_struct *tty,
+		struct usb_serial_port *port)
 {
+	struct ktermios tmp_termios;
 	struct usb_serial *serial = port->serial;
-	struct ch341_private *priv = usb_get_serial_port_data(port);
-	int r;
+	int retval;
+
+	dev_dbg(&port->dev, "%s - port:%d", __func__, port->port_number);
 
-	r = ch341_configure(serial->dev, priv);
-	if (r)
-		goto out;
+	usb_clear_halt(serial->dev, port->write_urb->pipe);
+	usb_clear_halt(serial->dev, port->read_urb->pipe);
 
 	if (tty)
-		ch341_set_termios(tty, port, NULL);
-
-	dev_dbg(&port->dev, "%s - submitting interrupt urb\n", __func__);
-	r = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
-	if (r) {
-		dev_err(&port->dev, "%s - failed to submit interrupt urb: %d\n",
-			__func__, r);
-		goto out;
+		ch34x_set_termios(tty, port, &tmp_termios);
+
+	dev_dbg(&port->dev, "%s - submit read urb", __func__);
+	port->read_urb->dev = serial->dev;
+	retval = usb_submit_urb(port->read_urb, GFP_KERNEL);
+	if (retval) {
+		dev_err(&port->dev, "%s - failed submit read urb,error %d\n",
+				__func__, retval);
+		ch34x_close(port);
+		goto err_out;
 	}
 
-	r = usb_serial_generic_open(tty, port);
+	dev_dbg(&port->dev, "%s - submit interrupt urb", __func__);
+	port->interrupt_in_urb->dev = serial->dev;
+	retval = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
+	if (retval) {
+		dev_err(&port->dev, "%s - failed submit interrupt urb,error %d\n",
+				__func__, retval);
+		ch34x_close(port);
+		goto err_out;
+	}
 
-out:	return r;
+err_out:
+	return retval;
 }
 
-/* Old_termios contains the original termios settings and
- * tty->termios contains the new setting to be used.
- */
-static void ch341_set_termios(struct tty_struct *tty,
-		struct usb_serial_port *port, struct ktermios *old_termios)
+static int ch34x_tiocmset(struct tty_struct *tty,
+		unsigned int set, unsigned int clear)
 {
-	struct ch341_private *priv = usb_get_serial_port_data(port);
-	unsigned baud_rate;
+	struct usb_serial_port *port = tty->driver_data;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
 	unsigned long flags;
-	unsigned char ctrl;
-	int r;
+	u8 control;
 
-	/* redundant changes may cause the chip to lose bytes */
-	if (old_termios && !tty_termios_hw_change(&tty->termios, old_termios))
-		return;
+	dev_dbg(&port->dev, "%s - port:%d", __func__, port->port_number);
 
-	baud_rate = tty_get_baud_rate(tty);
+	if (!usb_get_intfdata(port->serial->interface))
+		return -ENODEV;
 
-	priv->baud_rate = baud_rate;
-	ctrl = CH341_LCR_ENABLE_RX | CH341_LCR_ENABLE_TX;
+	spin_lock_irqsave(&priv->lock, flags);
+	if (set & TIOCM_RTS)
+		priv->line_control |= CONTROL_RTS;
+	if (set & TIOCM_DTR)
+		priv->line_control |= CONTROL_DTR;
+	if (clear & TIOCM_RTS)
+		priv->line_control &= ~CONTROL_RTS;
+	if (clear & TIOCM_DTR)
+		priv->line_control &= ~CONTROL_DTR;
+	control = priv->line_control;
+	spin_unlock_irqrestore(&priv->lock, flags);
 
-	switch (C_CSIZE(tty)) {
-	case CS5:
-		ctrl |= CH341_LCR_CS5;
-		break;
-	case CS6:
-		ctrl |= CH341_LCR_CS6;
-		break;
-	case CS7:
-		ctrl |= CH341_LCR_CS7;
-		break;
-	case CS8:
-		ctrl |= CH341_LCR_CS8;
-		break;
-	}
+	return set_control_lines(port, port->serial, control);
+}
 
-	if (C_PARENB(tty)) {
-		ctrl |= CH341_LCR_ENABLE_PAR;
-		if (C_PARODD(tty) == 0)
-			ctrl |= CH341_LCR_PAR_EVEN;
-		if (C_CMSPAR(tty))
-			ctrl |= CH341_LCR_MARK_SPACE;
-	}
+static int wait_modem_info(struct usb_serial_port *port,
+		unsigned int arg)
+{
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
+	unsigned long flags;
+	unsigned int prevstatus;
+	unsigned int status;
+	unsigned int changed;
 
-	if (C_CSTOPB(tty))
-		ctrl |= CH341_LCR_STOP_BITS_2;
+	dev_dbg(&port->dev, "%s -port:%d", __func__, port->port_number);
+
+	spin_lock_irqsave(&priv->lock, flags);
+	prevstatus = priv->line_status;
+	spin_unlock_irqrestore(&priv->lock, flags);
+
+	while (1) {
+		wait_event_interruptible(wq, wait_flag != 0);
+		wait_flag = 0;
+		/* see if a signal did it */
+		if (signal_pending(current))
+			return -ERESTARTSYS;
 
-	if (baud_rate) {
-		spin_lock_irqsave(&priv->lock, flags);
-		priv->line_control |= (CH341_BIT_DTR | CH341_BIT_RTS);
-		spin_unlock_irqrestore(&priv->lock, flags);
-		r = ch341_init_set_baudrate(port->serial->dev, priv, ctrl);
-		if (r < 0 && old_termios) {
-			priv->baud_rate = tty_termios_baud_rate(old_termios);
-			tty_termios_copy_hw(&tty->termios, old_termios);
-		}
-	} else {
 		spin_lock_irqsave(&priv->lock, flags);
-		priv->line_control &= ~(CH341_BIT_DTR | CH341_BIT_RTS);
+		status = priv->line_status;
 		spin_unlock_irqrestore(&priv->lock, flags);
-	}
 
-	ch341_set_handshake(port->serial->dev, priv->line_control);
+		changed = prevstatus ^ status;
+
+		if (((arg & TIOCM_RNG) && (changed & UART_RING)) ||
+			((arg & TIOCM_DSR) && (changed & UART_DSR))  ||
+			((arg & TIOCM_CD)  && (changed & UART_DCD))  ||
+			((arg & TIOCM_CTS) && (changed & UART_CTS)))
+			return 0;
 
+		prevstatus = status;
+	}
 }
 
-static void ch341_break_ctl(struct tty_struct *tty, int break_state)
+static int ch34x_ioctl(struct tty_struct *tty,
+		unsigned int cmd, unsigned long arg)
 {
-	const uint16_t ch341_break_reg =
-			((uint16_t) CH341_REG_LCR << 8) | CH341_REG_BREAK;
 	struct usb_serial_port *port = tty->driver_data;
-	int r;
-	uint16_t reg_contents;
-	uint8_t *break_reg;
 
-	break_reg = kmalloc(2, GFP_KERNEL);
-	if (!break_reg)
+	dev_dbg(&port->dev, "%s - port:%d, cmd=0x%04x",
+		__func__, port->port_number, cmd);
+
+	switch (cmd) {
+	case TIOCMIWAIT:
+		dev_dbg(&port->dev, "%s - port:%d TIOCMIWAIT",
+			__func__, port->port_number);
+		return wait_modem_info(port, arg);
+	default:
+		dev_dbg(&port->dev, "%s not supported=0x%04x", __func__, cmd);
+		break;
+	}
+	return -ENOIOCTLCMD;
+}
+
+static void ch34x_send(struct usb_serial_port *port)
+{
+	int count;
+	int retval;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
+	unsigned long flags;
+
+	dev_dbg(&port->dev, "%s - port:%d", __func__, port->port_number);
+
+	spin_lock_irqsave(&priv->lock, flags);
+	if (priv->write_urb_in_use) {
+		spin_unlock_irqrestore(&priv->lock, flags);
 		return;
+	}
 
-	r = ch341_control_in(port->serial->dev, CH341_REQ_READ_REG,
-			ch341_break_reg, 0, break_reg, 2);
-	if (r < 0) {
-		dev_err(&port->dev, "%s - USB control read error (%d)\n",
-				__func__, r);
-		goto out;
+	count = ch34x_buf_get(priv->buf, port->write_urb->transfer_buffer,
+			port->bulk_out_size);
+	if (count == 0) {
+		spin_unlock_irqrestore(&priv->lock, flags);
+		return;
 	}
-	dev_dbg(&port->dev, "%s - initial ch341 break register contents - reg1: %x, reg2: %x\n",
-		__func__, break_reg[0], break_reg[1]);
-	if (break_state != 0) {
-		dev_dbg(&port->dev, "%s - Enter break state requested\n", __func__);
-		break_reg[0] &= ~CH341_NBREAK_BITS;
-		break_reg[1] &= ~CH341_LCR_ENABLE_TX;
-	} else {
-		dev_dbg(&port->dev, "%s - Leave break state requested\n", __func__);
-		break_reg[0] |= CH341_NBREAK_BITS;
-		break_reg[1] |= CH341_LCR_ENABLE_TX;
+
+	priv->write_urb_in_use = 1;
+	spin_unlock_irqrestore(&priv->lock, flags);
+
+	usb_serial_debug_data(&port->dev, __func__, count,
+			port->write_urb->transfer_buffer);
+
+	port->write_urb->transfer_buffer_length = count;
+	port->write_urb->dev = port->serial->dev;
+	retval = usb_submit_urb(port->write_urb, GFP_ATOMIC);
+	if (retval) {
+		dev_err(&port->dev, "%s - failed submitting write urb,error %d\n"
+				, __func__, retval);
+		priv->write_urb_in_use = 0;
 	}
-	dev_dbg(&port->dev, "%s - New ch341 break register contents - reg1: %x, reg2: %x\n",
-		__func__, break_reg[0], break_reg[1]);
-	reg_contents = get_unaligned_le16(break_reg);
-	r = ch341_control_out(port->serial->dev, CH341_REQ_WRITE_REG,
-			ch341_break_reg, reg_contents);
-	if (r < 0)
-		dev_err(&port->dev, "%s - USB control write error (%d)\n",
-				__func__, r);
-out:
-	kfree(break_reg);
+
+	usb_serial_port_softint(port);
 }
 
-static int ch341_tiocmset(struct tty_struct *tty,
-			  unsigned int set, unsigned int clear)
+static int ch34x_write(struct tty_struct *tty,
+		struct usb_serial_port *port,
+		const unsigned char *buf,
+		int count)
 {
-	struct usb_serial_port *port = tty->driver_data;
-	struct ch341_private *priv = usb_get_serial_port_data(port);
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
 	unsigned long flags;
-	u8 control;
+
+	dev_dbg(&port->dev, "%s - port:%d, %d bytes",
+		__func__, port->port_number, count);
+
+	if (!count)
+		return count;
 
 	spin_lock_irqsave(&priv->lock, flags);
-	if (set & TIOCM_RTS)
-		priv->line_control |= CH341_BIT_RTS;
-	if (set & TIOCM_DTR)
-		priv->line_control |= CH341_BIT_DTR;
-	if (clear & TIOCM_RTS)
-		priv->line_control &= ~CH341_BIT_RTS;
-	if (clear & TIOCM_DTR)
-		priv->line_control &= ~CH341_BIT_DTR;
-	control = priv->line_control;
+	count = ch34x_buf_put(priv->buf, buf, count);
 	spin_unlock_irqrestore(&priv->lock, flags);
 
-	return ch341_set_handshake(port->serial->dev, control);
+	ch34x_send(port);
+
+	return count;
 }
 
-static void ch341_update_line_status(struct usb_serial_port *port,
-					unsigned char *data, size_t len)
+static int ch34x_write_room(struct tty_struct *tty)
 {
-	struct ch341_private *priv = usb_get_serial_port_data(port);
-	struct tty_struct *tty;
+	struct usb_serial_port *port = tty->driver_data;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
+	int room = 0;
 	unsigned long flags;
-	u8 status;
-	u8 delta;
 
-	if (len < 4)
-		return;
+	dev_dbg(&port->dev, "%s - port:%d", __func__, port->port_number);
 
-	status = ~data[2] & CH341_BITS_MODEM_STAT;
+	spin_lock_irqsave(&priv->lock, flags);
+	room = ch34x_buf_space_avail(priv->buf);
+	spin_unlock_irqrestore(&priv->lock, flags);
+
+	dev_dbg(&port->dev, "%s - room:%d", __func__, room);
+	return room;
+}
+
+static int ch34x_chars_in_buffer(struct tty_struct *tty)
+{
+	struct usb_serial_port *port = tty->driver_data;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
+	int chars = 0;
+	unsigned long flags;
+
+	dev_dbg(&port->dev, "%s - port:%d", __func__, port->port_number);
 
 	spin_lock_irqsave(&priv->lock, flags);
-	delta = status ^ priv->line_status;
-	priv->line_status = status;
+	chars = ch34x_buf_data_avail(priv->buf);
 	spin_unlock_irqrestore(&priv->lock, flags);
 
-	if (data[1] & CH341_MULT_STAT)
-		dev_dbg(&port->dev, "%s - multiple status change\n", __func__);
+	dev_dbg(&port->dev, "%s - chars:%d", __func__, chars);
 
-	if (!delta)
-		return;
+	return chars;
+}
 
-	if (delta & CH341_BIT_CTS)
-		port->icount.cts++;
-	if (delta & CH341_BIT_DSR)
-		port->icount.dsr++;
-	if (delta & CH341_BIT_RI)
-		port->icount.rng++;
-	if (delta & CH341_BIT_DCD) {
-		port->icount.dcd++;
-		tty = tty_port_tty_get(&port->port);
-		if (tty) {
-			usb_serial_handle_dcd_change(port, tty,
-						status & CH341_BIT_DCD);
-			tty_kref_put(tty);
+static int ch34x_attach(struct usb_serial *serial)
+{
+	struct ch34x_private *priv;
+	int i;
+	char buf[8];
+
+	dev_dbg(&serial->interface->dev, "%s", __func__);
+
+	for (i = 0; i < serial->num_ports; ++i) {
+		priv = kzalloc(sizeof(struct ch34x_private), GFP_KERNEL);
+		if (!priv)
+			goto cleanup;
+		spin_lock_init(&priv->lock);
+		priv->buf = ch34x_buf_alloc(CH34x_BUF_SIZE);
+		if (priv->buf == NULL) {
+			kfree(priv);
+			goto cleanup;
 		}
+		init_waitqueue_head(&priv->delta_msr_wait);
+		usb_set_serial_port_data(serial->port[i], priv);
+	}
+
+	ch34x_vendor_read(VENDOR_VERSION, 0x0000, 0x0000,
+			serial, buf, 0x02);
+	ch34x_vendor_write(VENDOR_SERIAL_INIT, 0x0000, 0x0000,
+			serial, NULL, 0x00);
+	ch34x_vendor_write(VENDOR_WRITE, 0x1312, 0xD982,
+			serial, NULL, 0x00);
+	ch34x_vendor_write(VENDOR_WRITE, 0x0F2C, 0x0004,
+			serial, NULL, 0x00);
+	ch34x_vendor_read(VENDOR_READ, 0x2518, 0x0000,
+			serial, buf, 0x02);
+	ch34x_vendor_write(VENDOR_WRITE, 0x2727, 0x0000,
+			serial, NULL, 0x00);
+	ch34x_vendor_write(VENDOR_MODEM_OUT, 0x009F, 0x0000,
+			serial, NULL, 0x00);
+
+	return 0;
+
+cleanup:
+	for (--i; i >= 0; --i) {
+		priv = usb_get_serial_port_data(serial->port[i]);
+		ch34x_buf_free(priv->buf);
+		kfree(priv);
+		usb_set_serial_port_data(serial->port[i], NULL);
 	}
 
-	wake_up_interruptible(&port->port.delta_msr_wait);
+	return -ENOMEM;
 }
 
-static void ch341_read_int_callback(struct urb *urb)
+static void ch34x_update_line_status(struct usb_serial_port *port,
+		unsigned char *data, unsigned int actual_length)
 {
-	struct usb_serial_port *port = urb->context;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
+	unsigned long flags;
+	u8 length = UART_STATE + 0x04;
+
+	if (actual_length < length)
+		return;
+
+	/* Save off the uart status for others to look up */
+	spin_lock_irqsave(&priv->lock, flags);
+	priv->line_status = data[UART_STATE];
+	priv->line_control = data[PORTB_STATE];
+	spin_unlock_irqrestore(&priv->lock, flags);
+	wait_flag = 1;
+	wake_up_interruptible(&priv->delta_msr_wait);
+}
+
+static void ch34x_read_int_callback(struct urb *urb)
+{
+	struct usb_serial_port *port = (struct usb_serial_port *)urb->context;
 	unsigned char *data = urb->transfer_buffer;
-	unsigned int len = urb->actual_length;
-	int status;
+	unsigned int actual_length = urb->actual_length;
+	int status = urb->status;
+	int retval;
+
+	dev_dbg(&port->dev, "%s port:%d", __func__, port->port_number);
 
-	switch (urb->status) {
+	switch (status) {
+	/* success */
 	case 0:
-		/* success */
 		break;
 	case -ECONNRESET:
 	case -ENOENT:
+	/* this urb is terminated, clean up */
 	case -ESHUTDOWN:
-		/* this urb is terminated, clean up */
-		dev_dbg(&urb->dev->dev, "%s - urb shutting down: %d\n",
-			__func__, urb->status);
+		dev_dbg(&port->dev, "%s - urb shutting down with status:%d",
+			__func__, status);
 		return;
 	default:
-		dev_dbg(&urb->dev->dev, "%s - nonzero urb status: %d\n",
-			__func__, urb->status);
+		dev_dbg(&port->dev, "%s - nonzero urb status received:%d",
+			__func__, status);
 		goto exit;
 	}
 
-	usb_serial_debug_data(&port->dev, __func__, len, data);
-	ch341_update_line_status(port, data, len);
+	usb_serial_debug_data(&port->dev, __func__,
+			urb->actual_length, urb->transfer_buffer);
+	ch34x_update_line_status(port, data, actual_length);
+
 exit:
-	status = usb_submit_urb(urb, GFP_ATOMIC);
-	if (status) {
-		dev_err(&urb->dev->dev, "%s - usb_submit_urb failed: %d\n",
-			__func__, status);
-	}
+	retval = usb_submit_urb(urb, GFP_ATOMIC);
+	if (retval)
+		dev_err(&urb->dev->dev, "%s - usb_submit_urb failed with result %d\n",
+			__func__, retval);
 }
 
-static int ch341_tiocmget(struct tty_struct *tty)
+static void ch34x_read_bulk_callback(struct urb *urb)
 {
-	struct usb_serial_port *port = tty->driver_data;
-	struct ch341_private *priv = usb_get_serial_port_data(port);
+	struct usb_serial_port *port = (struct usb_serial_port *)urb->context;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
+	struct tty_struct *tty;
+	unsigned char *data = urb->transfer_buffer;
 	unsigned long flags;
-	u8 mcr;
-	u8 status;
-	unsigned int result;
+	int i;
+	int retval;
+	int status = urb->status;
+	u8 line_status;
+	char tty_flag;
+
+	dev_dbg(&urb->dev->dev, "%s - port:%d", __func__, port->port_number);
+
+	if (status) {
+		dev_dbg(&urb->dev->dev, "%s - urb status=%d", __func__, status);
+		if (status == -EPROTO) {
+			/*
+			 * CH34x mysteriously fails with -EPROTO
+			 * reschedule the read
+			 */
+			dev_err(&urb->dev->dev, "%s - caught -EPROTO, \
+				resubmitting the urb", __func__);
+			urb->dev = port->serial->dev;
+			retval = usb_submit_urb(urb, GFP_ATOMIC);
+			if (retval) {
+				dev_err(&urb->dev->dev,
+						"%s - failed resubmitting read urb, error %d\n",
+						__func__, retval);
+				return;
+			}
+		}
+
+		dev_dbg(&urb->dev->dev, "%s - unable to \
+			handle the error", __func__);
+		return;
+	}
+
+	usb_serial_debug_data(&port->dev, __func__, urb->actual_length, data);
+
+	/* get tty_flag from status */
+	tty_flag = TTY_NORMAL;
 
 	spin_lock_irqsave(&priv->lock, flags);
-	mcr = priv->line_control;
-	status = priv->line_status;
+	line_status = priv->line_status;
+	priv->line_status &= ~UART_STATE_TRANSIENT_MASK;
 	spin_unlock_irqrestore(&priv->lock, flags);
+	wait_flag = 1;
+	wake_up_interruptible(&priv->delta_msr_wait);
+
+	/*
+	 * break takes precedence over parity,
+	 * which takes precedence over framing errors.
+	 */
+	if (line_status & UART_PARITY_ERROR)
+		tty_flag = TTY_PARITY;
+	else if (line_status & UART_OVERRUN_ERROR)
+		tty_flag = TTY_OVERRUN;
+	else if (line_status & UART_FRAME_ERROR)
+		tty_flag = TTY_FRAME;
+	dev_dbg(&urb->dev->dev, "%s - tty_flag=%d", __func__, tty_flag);
+
+	tty = port->port.tty;
+
+	if (tty && urb->actual_length) {
+		tty_buffer_request_room(tty->port, urb->actual_length + 1);
+
+		/* overrun is special, not associated with a char */
+		if (line_status & UART_OVERRUN_ERROR)
+			tty_insert_flip_char(tty->port, 0, TTY_OVERRUN);
+
+		for (i = 0; i < urb->actual_length; ++i)
+			tty_insert_flip_char(tty->port, data[i], tty_flag);
+
+		tty_flip_buffer_push(tty->port);
+	}
 
-	result = ((mcr & CH341_BIT_DTR)		? TIOCM_DTR : 0)
-		  | ((mcr & CH341_BIT_RTS)	? TIOCM_RTS : 0)
-		  | ((status & CH341_BIT_CTS)	? TIOCM_CTS : 0)
-		  | ((status & CH341_BIT_DSR)	? TIOCM_DSR : 0)
-		  | ((status & CH341_BIT_RI)	? TIOCM_RI  : 0)
-		  | ((status & CH341_BIT_DCD)	? TIOCM_CD  : 0);
-
-	dev_dbg(&port->dev, "%s - result = %x\n", __func__, result);
+	/* schedule the next read _if_ we are still open */
 
-	return result;
+	urb->dev = port->serial->dev;
+	retval = usb_submit_urb(urb, GFP_ATOMIC);
+	if (retval)
+		dev_err(&urb->dev->dev,
+				"%s - fialed resubmitting read urb, error %d\n",
+				__func__, retval);
 }
 
-static int ch341_reset_resume(struct usb_serial *serial)
+static void ch34x_write_bulk_callback(struct urb *urb)
 {
-	struct ch341_private *priv;
+	struct usb_serial_port *port = (struct usb_serial_port *)urb->context;
+	struct ch34x_private *priv = usb_get_serial_port_data(port);
+	int retval;
+	int status = urb->status;
 
-	priv = usb_get_serial_port_data(serial->port[0]);
+	dev_dbg(&port->dev, "%s - port:%d", __func__, port->port_number);
 
-	/* reconfigure ch341 serial port after bus-reset */
-	ch341_configure(serial->dev, priv);
+	switch (status) {
+	/* success */
+	case 0:
+		break;
+	case -ECONNRESET:
+	case -ENOENT:
+	case -ESHUTDOWN:
+		/* this urb is terminated, clean up */
+		dev_dbg(&port->dev, "%s - urb shutting \
+			down with status:%d", __func__, status);
+		priv->write_urb_in_use = 0;
+		return;
+	default:
+		/* error in the urb, so we have to resubmit it */
+		dev_dbg(&port->dev, "%s - Overflow in write", __func__);
+		dev_dbg(&port->dev, "%s - nonzero write bulk \
+			status received:%d", __func__, status);
+		port->write_urb->transfer_buffer_length = 1;
+		port->write_urb->dev = port->serial->dev;
+		retval = usb_submit_urb(port->write_urb, GFP_ATOMIC);
+		if (retval)
+			dev_err(&urb->dev->dev,
+					"%s - failed resubmitting write urv, error:%d\n",
+					__func__, retval);
+		else
+			return;
+	}
+	priv->write_urb_in_use = 0;
 
-	return 0;
+	/* send any buffered data */
+	ch34x_send(port);
 }
 
-static struct usb_serial_driver ch341_device = {
+static struct usb_serial_driver	ch34x_device = {
 	.driver = {
 		.owner	= THIS_MODULE,
-		.name	= "ch341-uart",
+		.name	= "ch34x",
 	},
-	.id_table          = id_table,
-	.num_ports         = 1,
-	.open              = ch341_open,
-	.dtr_rts	   = ch341_dtr_rts,
-	.carrier_raised	   = ch341_carrier_raised,
-	.close             = ch341_close,
-	.set_termios       = ch341_set_termios,
-	.break_ctl         = ch341_break_ctl,
-	.tiocmget          = ch341_tiocmget,
-	.tiocmset          = ch341_tiocmset,
-	.tiocmiwait        = usb_serial_generic_tiocmiwait,
-	.read_int_callback = ch341_read_int_callback,
-	.port_probe        = ch341_port_probe,
-	.port_remove       = ch341_port_remove,
-	.reset_resume      = ch341_reset_resume,
+	.id_table = id_table,
+	.num_ports		= 1,
+	.open			= ch34x_open,
+	.close			= ch34x_close,
+	.write			= ch34x_write,
+	.ioctl			= ch34x_ioctl,
+	.set_termios		= ch34x_set_termios,
+	.tiocmget		= ch34x_tiocmget,
+	.tiocmset		= ch34x_tiocmset,
+	.read_bulk_callback     = ch34x_read_bulk_callback,
+	.read_int_callback		= ch34x_read_int_callback,
+	.write_bulk_callback	= ch34x_write_bulk_callback,
+	.write_room		= ch34x_write_room,
+	.chars_in_buffer	= ch34x_chars_in_buffer,
+	.attach			= ch34x_attach,
 };
 
-static struct usb_serial_driver * const serial_drivers[] = {
-	&ch341_device, NULL
+static struct usb_serial_driver *const serial_driver[] = {
+	&ch34x_device, NULL
 };
 
-module_usb_serial_driver(serial_drivers, id_table);
+static int __init ch34x_init(void)
+{
+	return usb_serial_register_drivers(serial_driver,
+			KBUILD_MODNAME, id_table);
+}
 
+static void __exit ch34x_exit(void)
+{
+	usb_serial_deregister_drivers(serial_driver);
+}
+
+module_init(ch34x_init);
+module_exit(ch34x_exit);
+
+MODULE_DESCRIPTION(DRIVER_DESC);
+MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_LICENSE("GPL");
+
-- 
2.10.2

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Russell Senior]

> I'm not sure what device we're dealing with here, but it seems it would
> not be supported by the vendor (whose version of this driver also uses
> the init-command).
>
> Perhaps you could give the attached vendor driver a quick spin just to
> confirm that? It's a rebased version against usb-next.
>
> I've also pushed a commit that tries to dump the registers differently
> (reading together with register 0x25):
>
>         3baa1eff4245 ("dbg: ch341: dump registers differently")

00019-g3baa1ef:

Dec 20 04:30:50 willard kernel: usbcore: registered new interface driver ch341
Dec 20 04:30:50 willard kernel: usbserial: USB Serial support
registered for ch341-uart
Dec 20 04:31:14 willard kernel: usb 6-2: new full-speed USB device
number 11 using uhci_hcd
Dec 20 04:31:14 willard kernel: usb 6-2: New USB device found,
idVendor=1a86, idProduct=7523
Dec 20 04:31:14 willard kernel: usb 6-2: New USB device strings:
Mfr=0, Product=2, SerialNumber=0
Dec 20 04:31:14 willard kernel: usb 6-2: Product: USB2.0-Ser!
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: ch341-uart converter detected
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [00] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [01] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [02] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [03] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [04] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [05] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [06] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [07] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [08] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [09] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [10] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [11] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [12] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [13] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [14] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [15] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [16] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [17] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [18] = c3
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [19] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [20] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [21] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [22] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [23] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [24] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [25] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [26] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [27] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [28] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [29] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: init 0 0
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [00] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [01] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [02] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [03] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [04] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [05] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [06] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [07] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [08] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [09] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [10] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [11] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [12] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [13] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [14] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [15] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [16] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [17] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [18] = c3
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [19] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [20] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [21] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [22] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [23] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [24] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [25] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [26] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [27] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [28] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [29] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: write 0x31 0xb282
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [00] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [01] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [02] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [03] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [04] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [05] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [06] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [07] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [08] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [09] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [10] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [11] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [12] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [13] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [14] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [15] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [16] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [17] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [18] = f1
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [19] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [20] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [21] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [22] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [23] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [24] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [25] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [26] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [27] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [28] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [29] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2f] = 00
Dec 20 04:31:14 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (pre version)
Dec 20 04:31:14 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init-0)
Dec 20 04:31:14 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 9600, lcr = c3, a = b202
Dec 20 04:31:14 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [00] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [01] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [02] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [03] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [04] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [05] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [06] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [07] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [08] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [09] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [0f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [10] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [11] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [12] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [13] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [14] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [15] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [16] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [17] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [18] = f1
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [19] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [1f] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [20] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [21] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [22] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [23] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [24] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [25] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [26] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [27] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [28] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [29] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2a] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2b] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2c] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2d] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2e] = 00
Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [2f] = 00
Dec 20 04:31:14 willard kernel: usb 6-2: ch341-uart converter now
attached to ttyUSB0
Dec 20 04:31:25 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 19200, lcr = c3, a = d902
Dec 20 04:31:25 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 20 04:31:36 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 115200, lcr = c3, a = cc03
Dec 20 04:31:36 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 20 04:32:04 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 115200, lcr = c0, a = cc03
Dec 20 04:32:04 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 20 04:32:08 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 115200, lcr = c3, a = cc03
Dec 20 04:32:08 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 20 04:32:13 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 9600, lcr = c3, a = b202
Dec 20 04:32:13 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 20 04:32:18 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 115200, lcr = c3, a = cc03
Dec 20 04:32:18 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 20 04:32:24 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 115200, lcr = c3, a = cc03
Dec 20 04:32:24 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)
Dec 20 04:32:24 willard kernel: usb 6-2: ch341_set_baudrate_lcr -
speed = 19200, lcr = c3, a = d902
Dec 20 04:32:24 willard kernel: usb 6-2: ch341_dbg - [0x2518] = f1 00,
[0x1213] = 00 00 (post init - lcr reset)

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Tue, Dec 20, 2016 at 04:38:19AM -0800, Russell Senior wrote:
> > I'm not sure what device we're dealing with here, but it seems it would
> > not be supported by the vendor (whose version of this driver also uses
> > the init-command).
> >
> > Perhaps you could give the attached vendor driver a quick spin just to
> > confirm that? It's a rebased version against usb-next.
> >
> > I've also pushed a commit that tries to dump the registers differently
> > (reading together with register 0x25):
> >
> >         3baa1eff4245 ("dbg: ch341: dump registers differently")
> 
> 00019-g3baa1ef:
> 
> Dec 20 04:30:50 willard kernel: usbcore: registered new interface driver ch341
> Dec 20 04:30:50 willard kernel: usbserial: USB Serial support
> registered for ch341-uart
> Dec 20 04:31:14 willard kernel: usb 6-2: new full-speed USB device
> number 11 using uhci_hcd
> Dec 20 04:31:14 willard kernel: usb 6-2: New USB device found,
> idVendor=1a86, idProduct=7523
> Dec 20 04:31:14 willard kernel: usb 6-2: New USB device strings:
> Mfr=0, Product=2, SerialNumber=0
> Dec 20 04:31:14 willard kernel: usb 6-2: Product: USB2.0-Ser!
> Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: ch341-uart converter detected
> Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [00] = 00

> Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [17] = 00
> Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [18] = c3

Ok, so the device only returns the value of the LCR when read together
with 0x25. Otherwise all zero.

> Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: write 0x31 0xb282

> Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [18] = f1

And as before it it looks to be updated correctly through a direct
write, even though tx_en and rx_en is always set.

My guess is this is some CH341 clone that mimics the behaviour of some
version of the chip, especially as the vendor does not seem to bother to
support it (unless it's a new version?).

I think sticking to using the init command for all devices, except when
detecting a device that fails to read the divisor registers and then
fall back to direct writes might be the way forward. That way, we'd
have some minimal support for these devices at least.

Perhaps we should determine what else is working or broken first,
though.

Russel, could you test if break-signalling works, and if the
modem-control signals (DTR/RTS) are asserted at open? Do you get any
interrupts when the modem-status changes (e.g. remote end hangs up --
there should be debug messages)?

Any other suggestions?

Thanks,
Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Tue, Dec 20, 2016 at 05:07:48PM +0100, Johan Hovold wrote:
> On Tue, Dec 20, 2016 at 04:38:19AM -0800, Russell Senior wrote:
> > > I'm not sure what device we're dealing with here, but it seems it would
> > > not be supported by the vendor (whose version of this driver also uses
> > > the init-command).
> > >
> > > Perhaps you could give the attached vendor driver a quick spin just to
> > > confirm that? It's a rebased version against usb-next.
> > >
> > > I've also pushed a commit that tries to dump the registers differently
> > > (reading together with register 0x25):
> > >
> > >         3baa1eff4245 ("dbg: ch341: dump registers differently")
> > 
> > 00019-g3baa1ef:
> > 
> > Dec 20 04:30:50 willard kernel: usbcore: registered new interface driver ch341
> > Dec 20 04:30:50 willard kernel: usbserial: USB Serial support
> > registered for ch341-uart
> > Dec 20 04:31:14 willard kernel: usb 6-2: new full-speed USB device
> > number 11 using uhci_hcd
> > Dec 20 04:31:14 willard kernel: usb 6-2: New USB device found,
> > idVendor=1a86, idProduct=7523
> > Dec 20 04:31:14 willard kernel: usb 6-2: New USB device strings:
> > Mfr=0, Product=2, SerialNumber=0
> > Dec 20 04:31:14 willard kernel: usb 6-2: Product: USB2.0-Ser!
> > Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: ch341-uart converter detected
> > Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [00] = 00
> 
> > Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [17] = 00
> > Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [18] = c3
> 
> Ok, so the device only returns the value of the LCR when read together
> with 0x25. Otherwise all zero.
> 
> > Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: write 0x31 0xb282
> 
> > Dec 20 04:31:14 willard kernel: ch341 6-2:1.0: [18] = f1
> 
> And as before it it looks to be updated correctly through a direct
> write, even though tx_en and rx_en is always set.
> 
> My guess is this is some CH341 clone that mimics the behaviour of some
> version of the chip, especially as the vendor does not seem to bother to
> support it (unless it's a new version?).

Then again, if the vendor driver for another OS works, they at least do
care about those users. Perhaps someone can trace what a recent driver
does when encountering these devices.

> I think sticking to using the init command for all devices, except when
> detecting a device that fails to read the divisor registers and then
> fall back to direct writes might be the way forward. That way, we'd
> have some minimal support for these devices at least.
> 
> Perhaps we should determine what else is working or broken first,
> though.
> 
> Russel, could you test if break-signalling works, and if the
> modem-control signals (DTR/RTS) are asserted at open? Do you get any
> interrupts when the modem-status changes (e.g. remote end hangs up --
> there should be debug messages)?
> 
> Any other suggestions?
 
Thanks,
Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Russell Senior]

On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold <johan@kernel.org> wrote:

> Perhaps we should determine what else is working or broken first,
> though.
>
> Russel, could you test if break-signalling works, and if the
> modem-control signals (DTR/RTS) are asserted at open? Do you get any
> interrupts when the modem-status changes (e.g. remote end hangs up --
> there should be debug messages)?

Which version(s) would you like tested?

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Tue, Dec 20, 2016 at 12:09:55PM -0800, Russell Senior wrote:
> On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold <johan@kernel.org> wrote:
> 
> > Perhaps we should determine what else is working or broken first,
> > though.
> >
> > Russel, could you test if break-signalling works, and if the
> > modem-control signals (DTR/RTS) are asserted at open? Do you get any
> > interrupts when the modem-status changes (e.g. remote end hangs up --
> > there should be debug messages)?
> 
> Which version(s) would you like tested?

You can use c51087107e88 ("USB: serial: ch341: rename modem-status
register").

Thanks,
Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Tue, Dec 20, 2016 at 09:49:00PM +0100, Johan Hovold wrote:
> On Tue, Dec 20, 2016 at 12:09:55PM -0800, Russell Senior wrote:
> > On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold <johan@kernel.org> wrote:
> > 
> > > Perhaps we should determine what else is working or broken first,
> > > though.
> > >
> > > Russel, could you test if break-signalling works, and if the
> > > modem-control signals (DTR/RTS) are asserted at open? Do you get any
> > > interrupts when the modem-status changes (e.g. remote end hangs up --
> > > there should be debug messages)?
> > 
> > Which version(s) would you like tested?
> 
> You can use c51087107e88 ("USB: serial: ch341: rename modem-status
> register").

As you noticed, I decided to revert to using direct register writes to
avoid having the modem-control lines being toggled on open/set_termios.
So with a trivial patch changing the initial LCR settings your device
should now be supported.

It would still be interesting to know whether the features mentioned
above works. Testing that using the series I posted on Friday would be
preferred (but not required).

Thanks,
Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Mon, Jan 09, 2017 at 02:51:59PM +0100, Johan Hovold wrote:
> On Tue, Dec 20, 2016 at 09:49:00PM +0100, Johan Hovold wrote:
> > On Tue, Dec 20, 2016 at 12:09:55PM -0800, Russell Senior wrote:
> > > On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold <johan@kernel.org> wrote:
> > > 
> > > > Perhaps we should determine what else is working or broken first,
> > > > though.
> > > >
> > > > Russel, could you test if break-signalling works, and if the
> > > > modem-control signals (DTR/RTS) are asserted at open? Do you get any
> > > > interrupts when the modem-status changes (e.g. remote end hangs up --
> > > > there should be debug messages)?
> > > 
> > > Which version(s) would you like tested?
> > 
> > You can use c51087107e88 ("USB: serial: ch341: rename modem-status
> > register").
> 
> As you noticed, I decided to revert to using direct register writes to
> avoid having the modem-control lines being toggled on open/set_termios.
> So with a trivial patch changing the initial LCR settings your device
> should now be supported.

I received one of these quirky devices today and discovered that the
partial revert to using direct register writes should be sufficient for
basic support for these devices.

Changing baud rate and line settings (e.g. 6E2) works with my fixes for
4.10-rc4.

> It would still be interesting to know whether the features mentioned
> above works. Testing that using the series I posted on Friday would be
> preferred (but not required).

I did a quick test of this as well, and it seems break control is not
supported and no interrupts are received on modem-status changes. DTR
and RTS appear to work at least.

Johan

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Russell Senior]

On Tue, Dec 20, 2016 at 1:13 AM, Johan Hovold <johan@kernel.org> wrote:
> Perhaps you could give the attached vendor driver a quick spin just to
> confirm that? It's a rebased version against usb-next.

This is plain jane usb-next with your vendor patch, which I applied in
a local branch:

 00001-gfadd29d:

Dec 20 07:18:36 willard kernel: PKCS#7 signature not signed with a trusted key
Dec 20 07:18:36 willard kernel: ch341: module verification failed:
signature and/or required key missing - tainting kernel
Dec 20 07:18:36 willard kernel: usbcore: registered new interface driver ch341
Dec 20 07:18:36 willard kernel: usbserial: USB Serial support
registered for ch34x
Dec 20 07:18:44 willard kernel: usb 6-2: new full-speed USB device
number 12 using uhci_hcd
Dec 20 07:18:44 willard kernel: usb 6-2: New USB device found,
idVendor=1a86, idProduct=7523
Dec 20 07:18:44 willard kernel: usb 6-2: New USB device strings:
Mfr=0, Product=2, SerialNumber=0
Dec 20 07:18:44 willard kernel: usb 6-2: Product: USB2.0-Ser!
Dec 20 07:18:44 willard kernel: ch341 6-2:1.0: ch34x converter detected
Dec 20 07:18:44 willard kernel: ------------[ cut here ]------------
Dec 20 07:18:44 willard kernel: WARNING: CPU: 1 PID: 30168 at
/home/russell/src/usb-serial/drivers/usb/core/hcd.c:1584
usb_hcd_map_urb_for_dma+0x382/0x560
Dec 20 07:18:44 willard kernel: transfer buffer not dma capable
Dec 20 07:18:44 willard kernel: Modules linked in: ch341(E) ntfs msdos
pl2303 usbserial bnep arc4 iwldvm mac80211 btusb btrtl btbcm btintel
bluetooth snd_hda_codec_hdmi uvcvideo snd_hda_codec_conexant
snd_hda_codec_generic videobuf2_vmalloc videobuf2_memops
videobuf2_v4l2 videobuf2_core videodev iwlwifi snd_hda_inte
l coretemp media kvm_intel snd_hda_codec snd_hda_core kvm
thinkpad_acpi snd_hwdep mei_me mei nvram cfg80211 snd_pcm snd_seq_midi
snd_seq_midi_event snd_rawmidi snd_seq snd_seq_device
Dec 20 07:18:44 willard kernel:  snd_timer irqbypass snd joydev input_leds
Dec 20 07:18:44 willard kernel:  serio_raw
Dec 20 07:18:44 willard kernel:  lpc_ich soundcore autofs4 amdkfd
amd_iommu_v2 radeon i915 i2c_algo_bit ttm e1000e drm_kms_helper
psmouse syscopyarea firewire_ohci sysfillrect sysimgblt fb_sys_fops
ahci libahci firewire_core drm crc_itu_t ptp wmi video pps_core [last
unloaded: ch341]
Dec 20 07:18:44 willard kernel: CPU: 1 PID: 30168 Comm: kworker/1:0
Tainted: G            E   4.9.0-rc2-2016-12-16-00013-gc510871 #1
Dec 20 07:18:44 willard kernel: Hardware name: LENOVO 406227U/406227U,
BIOS 7VET66WW (2.16 ) 04/22/2009
Dec 20 07:18:44 willard kernel: Workqueue: usb_hub_wq hub_event
Dec 20 07:18:44 willard kernel:  ffffa51f89e4f3a8 ffffffffae3e8ec3
ffffa51f89e4f3f8 0000000000000000
Dec 20 07:18:44 willard kernel:  ffffa51f89e4f3e8 ffffffffae07f90b
0000063033791ae0 ffff8ae139fe23c0
Dec 20 07:18:44 willard kernel:  0000000000000000 0000000002400000
0000000000000002 ffff8ae11a80a800
Dec 20 07:18:44 willard kernel: Call Trace:
Dec 20 07:18:44 willard kernel:  [<ffffffffae3e8ec3>] dump_stack+0x63/0x90
Dec 20 07:18:44 willard kernel:  [<ffffffffae07f90b>] __warn+0xcb/0xf0
Dec 20 07:18:44 willard kernel:  [<ffffffffae07f98f>]
warn_slowpath_fmt+0x5f/0x80
Dec 20 07:18:44 willard kernel:  [<ffffffffae60f392>]
usb_hcd_map_urb_for_dma+0x382/0x560
Dec 20 07:18:44 willard kernel:  [<ffffffffae6106e2>]
usb_hcd_submit_urb+0x1d2/0xac0
Dec 20 07:18:44 willard kernel:  [<ffffffffae0da37a>] ? vprintk_emit+0x2ea/0x4d0
Dec 20 07:18:44 willard kernel:  [<ffffffffae61213b>] usb_submit_urb+0x2eb/0x570
Dec 20 07:18:44 willard kernel:  [<ffffffffae612abe>]
usb_start_wait_urb+0x6e/0x170
Dec 20 07:18:44 willard kernel:  [<ffffffffae612c9c>] usb_control_msg+0xdc/0x130
Dec 20 07:18:44 willard kernel:  [<ffffffffc0877fd7>]
ch34x_attach+0x1d7/0x2b0 [ch341]
Dec 20 07:18:44 willard kernel:  [<ffffffffc0930410>]
usb_serial_probe+0xf10/0x1170 [usbserial]
Dec 20 07:18:44 willard kernel:  [<ffffffffae3eac48>] ?
ida_simple_get+0x98/0x100
Dec 20 07:18:44 willard kernel:  [<ffffffffae2adffa>] ?
kernfs_activate+0x7a/0xe0
Dec 20 07:18:44 willard kernel:  [<ffffffffae55d580>] ?
__pm_runtime_set_status+0x1e0/0x2a0
Dec 20 07:18:44 willard kernel:  [<ffffffffae617453>]
usb_probe_interface+0x153/0x2f0
Dec 20 07:18:44 willard kernel:  [<ffffffffae5519b4>]
driver_probe_device+0x224/0x430
Dec 20 07:18:44 willard kernel:  [<ffffffffae551d3c>]
__device_attach_driver+0x8c/0x100
Dec 20 07:18:44 willard kernel:  [<ffffffffae551cb0>] ?
__driver_attach+0xf0/0xf0
Dec 20 07:18:44 willard kernel:  [<ffffffffae54f5c7>] bus_for_each_drv+0x67/0xb0
Dec 20 07:18:44 willard kernel:  [<ffffffffae55161d>] __device_attach+0xdd/0x160
Dec 20 07:18:44 willard kernel:  [<ffffffffae551df3>]
device_initial_probe+0x13/0x20
Dec 20 07:18:44 willard kernel:  [<ffffffffae550832>] bus_probe_device+0x92/0xa0
Dec 20 07:18:44 willard kernel:  [<ffffffffae54e3ad>] device_add+0x3fd/0x670
Dec 20 07:18:44 willard kernel:  [<ffffffffae615359>]
usb_set_configuration+0x529/0x8d0
Dec 20 07:18:44 willard kernel:  [<ffffffffae6204ae>] generic_probe+0x2e/0x80
Dec 20 07:18:44 willard kernel:  [<ffffffffae6172be>] usb_probe_device+0x2e/0x70
Dec 20 07:18:44 willard kernel:  [<ffffffffae5519b4>]
driver_probe_device+0x224/0x430
Dec 20 07:18:44 willard kernel:  [<ffffffffae551d3c>]
__device_attach_driver+0x8c/0x100
Dec 20 07:18:44 willard kernel:  [<ffffffffae551cb0>] ?
__driver_attach+0xf0/0xf0
Dec 20 07:18:44 willard kernel:  [<ffffffffae54f5c7>] bus_for_each_drv+0x67/0xb0
Dec 20 07:18:44 willard kernel:  [<ffffffffae55161d>] __device_attach+0xdd/0x160
Dec 20 07:18:44 willard kernel:  [<ffffffffae551df3>]
device_initial_probe+0x13/0x20
Dec 20 07:18:44 willard kernel:  [<ffffffffae550832>] bus_probe_device+0x92/0xa0
Dec 20 07:18:44 willard kernel:  [<ffffffffae54e3ad>] device_add+0x3fd/0x670
Dec 20 07:18:44 willard kernel:  [<ffffffffae516e00>] ? random_poll+0x80/0x80
Dec 20 07:18:44 willard kernel:  [<ffffffffae60a63f>] usb_new_device+0x26f/0x4b0
Dec 20 07:18:44 willard kernel:  [<ffffffffae60c71e>] hub_event+0xf8e/0x1540
Dec 20 07:18:44 willard kernel:  [<ffffffffae09a65b>]
process_one_work+0x16b/0x480
Dec 20 07:18:44 willard kernel:  [<ffffffffae09a9bb>] worker_thread+0x4b/0x500
Dec 20 07:18:44 willard kernel:  [<ffffffffae09a970>] ?
process_one_work+0x480/0x480
Dec 20 07:18:44 willard kernel:  [<ffffffffae09a970>] ?
process_one_work+0x480/0x480
Dec 20 07:18:44 willard kernel:  [<ffffffffae0a0c19>] kthread+0xd9/0xf0
Dec 20 07:18:44 willard kernel:  [<ffffffffae0a0b40>] ? kthread_park+0x60/0x60
Dec 20 07:18:44 willard kernel:  [<ffffffffae8274b5>] ret_from_fork+0x25/0x30
Dec 20 07:18:44 willard kernel: ---[ end trace a6d2a2beec5e73c1 ]---
Dec 20 07:18:44 willard kernel: usb 6-2: ch34x converter now attached to ttyUSB0

and, it didn't work.  Got 0xff's out on the pl2303, got nothing
visible when characters sent in the other direction after setting
115200 8N1 on both sides.  And, fwiw, I've been rmmod ch341 ; insmod
$path/ch341.ko, where $path is the kernel module tree for the commit
build, all from a 00013-gc510871 base kernel without rebooting.

Not sure what the complaint about keys is about, I had not seen that before.

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Tue, Dec 20, 2016 at 07:31:55AM -0800, Russell Senior wrote:
> On Tue, Dec 20, 2016 at 1:13 AM, Johan Hovold <johan@kernel.org> wrote:
> > Perhaps you could give the attached vendor driver a quick spin just to
> > confirm that? It's a rebased version against usb-next.
> 
> This is plain jane usb-next with your vendor patch, which I applied in
> a local branch:
> 
>  00001-gfadd29d:
> 
> Dec 20 07:18:36 willard kernel: PKCS#7 signature not signed with a trusted key
> Dec 20 07:18:36 willard kernel: ch341: module verification failed:
> signature and/or required key missing - tainting kernel
> Dec 20 07:18:36 willard kernel: usbcore: registered new interface driver ch341
> Dec 20 07:18:36 willard kernel: usbserial: USB Serial support
> registered for ch34x
> Dec 20 07:18:44 willard kernel: usb 6-2: new full-speed USB device
> number 12 using uhci_hcd
> Dec 20 07:18:44 willard kernel: usb 6-2: New USB device found,
> idVendor=1a86, idProduct=7523
> Dec 20 07:18:44 willard kernel: usb 6-2: New USB device strings:
> Mfr=0, Product=2, SerialNumber=0
> Dec 20 07:18:44 willard kernel: usb 6-2: Product: USB2.0-Ser!
> Dec 20 07:18:44 willard kernel: ch341 6-2:1.0: ch34x converter detected
> Dec 20 07:18:44 willard kernel: ------------[ cut here ]------------
> Dec 20 07:18:44 willard kernel: WARNING: CPU: 1 PID: 30168 at
> /home/russell/src/usb-serial/drivers/usb/core/hcd.c:1584
> usb_hcd_map_urb_for_dma+0x382/0x560
> Dec 20 07:18:44 willard kernel: transfer buffer not dma capable

Yeah, you would get that with 4.9 and x86 as the driver is using a
buffer on stack for to control transfers (reads) at probe. Should not
affect device behaviour, but if you want you can kzalloc buf in
ch34x_attach() (patch below) and try again.
 
> and, it didn't work.  Got 0xff's out on the pl2303, got nothing
> visible when characters sent in the other direction after setting
> 115200 8N1 on both sides.

Ok, so that sounds like the same behaviour you see when using usb-next
with the initial LCR write removed. This device does not seem to support
using the init-vendor command to change line settings.

> And, fwiw, I've been rmmod ch341 ; insmod
> $path/ch341.ko, where $path is the kernel module tree for the commit
> build, all from a 00013-gc510871 base kernel without rebooting.

That should be fine, but you probably want to reboot when you're done
testing the vendor driver.

> Not sure what the complaint about keys is about, I had not seen that
> before.

Related to module signing, not sure why you only see it with the vendor
driver. Did you apply it to my usb-next branch or Greg's?

Thanks,
Johan


>From 7779ac8871d36d48a0ee3d41f148ca046523f556 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Tue, 20 Dec 2016 16:48:52 +0100
Subject: [PATCH] tmp: ch341: fix DMA to stack

---
 drivers/usb/serial/ch341.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index b193b78c27bb..cd128e99843d 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -706,7 +706,7 @@ static int ch34x_attach(struct usb_serial *serial)
 {
 	struct ch34x_private *priv;
 	int i;
-	char buf[8];
+	char *buf;
 
 	dev_dbg(&serial->interface->dev, "%s", __func__);
 
@@ -724,6 +724,10 @@ static int ch34x_attach(struct usb_serial *serial)
 		usb_set_serial_port_data(serial->port[i], priv);
 	}
 
+	buf = kzalloc(8, GFP_KERNEL);
+	if (!buf)
+		goto cleanup;
+
 	ch34x_vendor_read(VENDOR_VERSION, 0x0000, 0x0000,
 			serial, buf, 0x02);
 	ch34x_vendor_write(VENDOR_SERIAL_INIT, 0x0000, 0x0000,
@@ -739,6 +743,8 @@ static int ch34x_attach(struct usb_serial *serial)
 	ch34x_vendor_write(VENDOR_MODEM_OUT, 0x009F, 0x0000,
 			serial, NULL, 0x00);
 
+	kfree(buf);
+
 	return 0;
 
 cleanup:
-- 
2.10.2

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Russell Senior]

On Tue, Dec 20, 2016 at 7:52 AM, Johan Hovold <johan@kernel.org> wrote:
> On Tue, Dec 20, 2016 at 07:31:55AM -0800, Russell Senior wrote:

>> Not sure what the complaint about keys is about, I had not seen that
>> before.
>
> Related to module signing, not sure why you only see it with the vendor
> driver. Did you apply it to my usb-next branch or Greg's?

Yours.

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

[Johan Hovold]

On Mon, Dec 19, 2016 at 08:40:53AM -0800, Russell Senior wrote:
> On Mon, Dec 19, 2016 at 2:58 AM, Johan Hovold <johan@kernel.org> wrote:
> > On Sat, Dec 17, 2016 at 03:27:43AM -0800, Russell Senior wrote:
> >> All testing is with minicom.
> >
> > Thanks for this through report.
> >
> >> Starting with 00013-gc510871:
> >>
> >>   In 8-bit mode, interoperates correctly with pl2303.  Switching to
> >> 5-bit mode on both sides (I get unicode boxes of indeterminate
> >> values).  Switching back to 8-bit mode on both sides, I get correct
> >> text out both sides.  Switching just the ch341 side back to 5-bit
> >> mode, I get 0xff's out on the pl2303 side (still in 8-bit mode).  This
> >> would seem to imply that byte-size changes are working on this
> >> version.  Changing baud rate also works.
> >
> > Can you verify also what comes through in 5-bit mode is indeed what's
> > expected (e.g. 'a' -> 0x01, 'b' -> 0x02, ...)?
> >
> > You can enable usb-serial debugging to get a log of what is received:
> >
> >         modprobe usbserial dyndbg==p
> >
> 
> Yes, it does seem that I'm getting the 5-bit truncation.  Here is an
> excerpt from the prodigious logs, in this case sending a 'Z' from
> pl2303 and receiving an 0x5a on the ch341.  The same sort of thing,
> e.g. 'A' (0x41) from the ch341 lands as an 0x01 on the pl2303, 0x42 ->
> 0x02, etc.

Thanks for confirming.

> > Ok, so the init command cannot be used to switch baud rate for these
> > devices.
> >
> > Could you see if you can communicate using 19200 baud (when using this
> > or the next commit), which is the default baud rate for the devices I
> > have (i.e. default settings are 19200 8N1).
> 
> 19200 8N1 on this commit does not work.

Ok.

Johan