* [PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN
@ 2016-12-16 16:36 Julien Fortin
2016-12-16 16:43 ` Phil Sutter
2016-12-22 0:05 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Julien Fortin @ 2016-12-16 16:36 UTC (permalink / raw)
To: stephen, netdev; +Cc: phil, Julien Fortin
From: Julien Fortin <julien@cumulusnetworks.com>
Fixes: 4fb4a10e120b1 ("ipaddress: Print IFLA_VF_QUERY_RSS_EN setting”)
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
---
ip/ipaddress.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index de64877..400ebb4 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -414,14 +414,6 @@ static void print_vfinfo(FILE *fp, struct rtattr *vfinfo)
fprintf(fp, ", query_rss %s",
rss_query->setting ? "on" : "off");
}
- if (vf[IFLA_VF_RSS_QUERY_EN]) {
- struct ifla_vf_rss_query_en *rss_query =
- RTA_DATA(vf[IFLA_VF_RSS_QUERY_EN]);
-
- if (rss_query->setting != -1)
- fprintf(fp, ", query_rss %s",
- rss_query->setting ? "on" : "off");
- }
if (vf[IFLA_VF_STATS] && show_stats)
print_vf_stats64(fp, vf[IFLA_VF_STATS]);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN
2016-12-16 16:36 [PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN Julien Fortin
@ 2016-12-16 16:43 ` Phil Sutter
2016-12-22 0:05 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Phil Sutter @ 2016-12-16 16:43 UTC (permalink / raw)
To: Julien Fortin; +Cc: stephen, netdev
On Fri, Dec 16, 2016 at 05:36:05PM +0100, Julien Fortin wrote:
> From: Julien Fortin <julien@cumulusnetworks.com>
>
> Fixes: 4fb4a10e120b1 ("ipaddress: Print IFLA_VF_QUERY_RSS_EN setting”)
>
> Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
Oh! Looks like Git messed up during a rebase and the obviously wrong
result was overlooked.
Acked-by: Phil Sutter <phil@nwl.cc>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN
2016-12-16 16:36 [PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN Julien Fortin
2016-12-16 16:43 ` Phil Sutter
@ 2016-12-22 0:05 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2016-12-22 0:05 UTC (permalink / raw)
To: Julien Fortin; +Cc: netdev, phil
On Fri, 16 Dec 2016 17:36:05 +0100
Julien Fortin <julien@cumulusnetworks.com> wrote:
> From: Julien Fortin <julien@cumulusnetworks.com>
>
> Fixes: 4fb4a10e120b1 ("ipaddress: Print IFLA_VF_QUERY_RSS_EN setting”)
>
> Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-22 0:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-16 16:36 [PATCH] ip: vfinfo: remove code duplication for IFLA_VF_RSS_QUERY_EN Julien Fortin
2016-12-16 16:43 ` Phil Sutter
2016-12-22 0:05 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.