From: Pavel Machek <pavel@ucw.cz> To: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Milo Kim <woogyom.kim@gmail.com>, "Luis R. Rodriguez" <mcgrof@kernel.org>, gregkh@linuxfoundation.org, ming.lei@canonical.com, daniel.wagner@bmw-carit.de, teg@jklm.no, mchehab@osg.samsung.com, zajec5@gmail.com, linux-kernel@vger.kernel.org, markivx@codeaurora.org, stephen.boyd@linaro.org, broonie@kernel.org, zohar@linux.vnet.ibm.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, luto@amacapital.net, fengguang.wu@intel.com, rpurdie@rpsys.net, j.anaszewski@samsung.com, Abhay_Salunke@dell.com, Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, dhowells@redhat.com, bjorn.andersson@linaro.orga Subject: Re: [PATCH 5/5] firmware: add DECLARE_FW_CUSTOM_FALLBACK() annotation Date: Wed, 21 Dec 2016 19:49:02 +0100 [thread overview] Message-ID: <20161221184902.GA21636@amd> (raw) In-Reply-To: <1e47fd1d-53e0-75c7-0c25-42f4c6ccd818@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2168 bytes --] Hi! > >>> Milo if sysfs is used can't the old userspace be mapped to use the new > >>> sysfs interface through a wrapper of some sort ? What exactly would be > >>> needed to ensure old userspace will not break? > >> > >> LP5521 and LP5523 have two ways to load hex code from the userspace - the > >> sysfs and firmware I/F. So user program supports both interfaces. Even if > >> the firmware I/F is not available, user can still run LED effect through the > >> sysfs. > >> > >> However, LP5562 and LP8501 support only single way which is the firmware > >> I/F. So user-space program for LP5562/8501 should be modified if lp55xx > >> removes the interface. My idea is > > > > Actually... it would be good to have some reasonable interface for RGB > > LEDs. This way, we need separate "firmware" for each LED > > controller. It would be good to have common format for LED effects. > > We still haven't tried trigger approach discussed over half a year ago. > If we used firmware approach we would still have to overcome the problem > of defining the LED class drivers affected by the firmware program. The firmware approach is in the tree today :-(. > >> Device manufactures in Asia & North America requested lp55xx drivers, but I > >> don't know how many vendors uses the firmware I/F. Some vendors embeds the > >> binary code inside the driver instead of using user-program. > > > > Nokia N900 uses lp55xx, and I have custom scripts interfacing sysfs. > > > > Maemo uses the LEDs, too, but maemo is not open source. > > > > So no, I don't think there's anything important that could be broken. > > We can't guarantee that. Is there any problem in just using the > currently introduced DECLARE_FW_CUSTOM_FALLBACK() in > drivers/leds/leds-lp55xx-common.c? Well, it would be good to get rid of the custom fallback functionality. And no, we don't need to "guarantee" that. Removing obscure functionality noone uses is far game... providing noone complains ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz> To: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Milo Kim <woogyom.kim@gmail.com>, "Luis R. Rodriguez" <mcgrof@kernel.org>, gregkh@linuxfoundation.org, ming.lei@canonical.com, daniel.wagner@bmw-carit.de, teg@jklm.no, mchehab@osg.samsung.com, zajec5@gmail.com, linux-kernel@vger.kernel.org, markivx@codeaurora.org, stephen.boyd@linaro.org, broonie@kernel.org, zohar@linux.vnet.ibm.com, tiwai@suse.de, johannes@sipsolutions.net, chunkeey@googlemail.com, hauke@hauke-m.de, jwboyer@fedoraproject.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com, torvalds@linux-foundation.org, luto@amacapital.net, fengguang.wu@intel.com, rpurdie@rpsys.net, j.anaszewski@samsung.com, Abhay_Salunke@dell.com, Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, dhowells@redhat.com, bjorn.andersson@linaro.org, arend.vanspriel@broadcom.com, kvalo@codeaurora.org, linux-leds@vger.kernel.org Subject: Re: [PATCH 5/5] firmware: add DECLARE_FW_CUSTOM_FALLBACK() annotation Date: Wed, 21 Dec 2016 19:49:02 +0100 [thread overview] Message-ID: <20161221184902.GA21636@amd> (raw) In-Reply-To: <1e47fd1d-53e0-75c7-0c25-42f4c6ccd818@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2168 bytes --] Hi! > >>> Milo if sysfs is used can't the old userspace be mapped to use the new > >>> sysfs interface through a wrapper of some sort ? What exactly would be > >>> needed to ensure old userspace will not break? > >> > >> LP5521 and LP5523 have two ways to load hex code from the userspace - the > >> sysfs and firmware I/F. So user program supports both interfaces. Even if > >> the firmware I/F is not available, user can still run LED effect through the > >> sysfs. > >> > >> However, LP5562 and LP8501 support only single way which is the firmware > >> I/F. So user-space program for LP5562/8501 should be modified if lp55xx > >> removes the interface. My idea is > > > > Actually... it would be good to have some reasonable interface for RGB > > LEDs. This way, we need separate "firmware" for each LED > > controller. It would be good to have common format for LED effects. > > We still haven't tried trigger approach discussed over half a year ago. > If we used firmware approach we would still have to overcome the problem > of defining the LED class drivers affected by the firmware program. The firmware approach is in the tree today :-(. > >> Device manufactures in Asia & North America requested lp55xx drivers, but I > >> don't know how many vendors uses the firmware I/F. Some vendors embeds the > >> binary code inside the driver instead of using user-program. > > > > Nokia N900 uses lp55xx, and I have custom scripts interfacing sysfs. > > > > Maemo uses the LEDs, too, but maemo is not open source. > > > > So no, I don't think there's anything important that could be broken. > > We can't guarantee that. Is there any problem in just using the > currently introduced DECLARE_FW_CUSTOM_FALLBACK() in > drivers/leds/leds-lp55xx-common.c? Well, it would be good to get rid of the custom fallback functionality. And no, we don't need to "guarantee" that. Removing obscure functionality noone uses is far game... providing noone complains ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-12-21 18:49 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-13 3:08 [PATCH 0/5] firmware: doc revamp Luis R. Rodriguez 2016-12-13 3:08 ` [PATCH 1/5] selftests: firmware: only modprobe if driver is missing Luis R. Rodriguez 2016-12-13 3:08 ` [PATCH 2/5] selftests: firmware: send expected errors to /dev/null Luis R. Rodriguez 2016-12-13 3:08 ` [PATCH 3/5] firmware: revamp firmware documentation Luis R. Rodriguez 2016-12-13 7:26 ` Rafał Miłecki 2016-12-16 9:09 ` Luis R. Rodriguez 2016-12-13 13:26 ` Daniel Wagner 2016-12-13 13:30 ` Rafał Miłecki 2016-12-16 9:18 ` Luis R. Rodriguez 2016-12-16 9:34 ` Johannes Berg 2016-12-16 9:16 ` Luis R. Rodriguez 2017-01-12 14:42 ` [PATCH v4 0/2] firmware: fw doc revamp follow up Luis R. Rodriguez 2017-01-12 14:42 ` [PATCH v4 1/2] firmware: add SmPL report for custom fallback mechanism Luis R. Rodriguez 2017-01-12 14:42 ` [PATCH v4 2/2] firmware: add DECLARE_FW_CUSTOM_FALLBACK() annotation Luis R. Rodriguez 2017-01-19 11:31 ` Greg KH 2017-01-19 16:08 ` Luis R. Rodriguez 2017-01-19 16:08 ` Luis R. Rodriguez 2017-01-19 16:14 ` Greg KH 2017-01-19 21:38 ` Luis R. Rodriguez 2017-01-19 21:38 ` Luis R. Rodriguez 2016-12-13 3:08 ` [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism Luis R. Rodriguez 2016-12-13 6:13 ` Julia Lawall 2016-12-13 9:44 ` Jacek Anaszewski 2016-12-13 9:44 ` Jacek Anaszewski 2016-12-14 1:48 ` Milo Kim 2016-12-14 1:48 ` Milo Kim 2016-12-16 9:29 ` Luis R. Rodriguez 2016-12-16 9:29 ` Luis R. Rodriguez 2017-01-11 18:51 ` Luis R. Rodriguez 2016-12-13 3:08 ` [PATCH 5/5] firmware: add DECLARE_FW_CUSTOM_FALLBACK() annotation Luis R. Rodriguez 2016-12-13 19:04 ` Pavel Machek 2016-12-16 9:22 ` Luis R. Rodriguez 2016-12-16 9:22 ` Luis R. Rodriguez 2016-12-16 9:29 ` Pavel Machek 2016-12-16 9:59 ` Luis R. Rodriguez 2016-12-16 9:59 ` Luis R. Rodriguez 2016-12-16 10:14 ` Pavel Machek 2016-12-16 10:56 ` Luis R. Rodriguez 2016-12-16 10:56 ` Luis R. Rodriguez 2016-12-16 11:27 ` Pavel Machek 2016-12-16 15:19 ` Luis R. Rodriguez 2016-12-16 15:19 ` Luis R. Rodriguez 2016-12-16 16:10 ` Luis R. Rodriguez 2016-12-16 16:10 ` Luis R. Rodriguez 2016-12-16 16:14 ` Luis R. Rodriguez 2016-12-16 16:14 ` Luis R. Rodriguez 2016-12-18 3:50 ` Milo Kim 2016-12-18 3:50 ` Milo Kim 2016-12-19 20:08 ` Pavel Machek 2016-12-19 20:08 ` Pavel Machek 2016-12-19 20:46 ` Jacek Anaszewski 2016-12-19 20:46 ` Jacek Anaszewski 2016-12-21 18:49 ` Pavel Machek [this message] 2016-12-21 18:49 ` Pavel Machek 2016-12-21 20:33 ` Jacek Anaszewski 2016-12-21 20:33 ` Jacek Anaszewski 2016-12-15 9:32 ` Jacek Anaszewski 2016-12-16 9:26 ` Luis R. Rodriguez 2016-12-16 9:26 ` Luis R. Rodriguez 2016-12-13 12:58 ` [PATCH 0/5] firmware: doc revamp Daniel Wagner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161221184902.GA21636@amd \ --to=pavel@ucw.cz \ --cc=Abhay_Salunke@dell.com \ --cc=Gilles.Muller@lip6.fr \ --cc=Julia.Lawall@lip6.fr \ --cc=bjorn.andersson@linaro.orga \ --cc=broonie@kernel.org \ --cc=chunkeey@googlemail.com \ --cc=daniel.wagner@bmw-carit.de \ --cc=dhowells@redhat.com \ --cc=dmitry.torokhov@gmail.com \ --cc=dwmw2@infradead.org \ --cc=fengguang.wu@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=hauke@hauke-m.de \ --cc=j.anaszewski@samsung.com \ --cc=jacek.anaszewski@gmail.com \ --cc=johannes@sipsolutions.net \ --cc=jslaby@suse.com \ --cc=jwboyer@fedoraproject.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@amacapital.net \ --cc=markivx@codeaurora.org \ --cc=mcgrof@kernel.org \ --cc=mchehab@osg.samsung.com \ --cc=ming.lei@canonical.com \ --cc=nicolas.palix@imag.fr \ --cc=rpurdie@rpsys.net \ --cc=stephen.boyd@linaro.org \ --cc=teg@jklm.no \ --cc=tiwai@suse.de \ --cc=torvalds@linux-foundation.org \ --cc=woogyom.kim@gmail.com \ --cc=zajec5@gmail.com \ --cc=zohar@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.