* [PATCH] drm/i915: Break after walking all GGTT vma in bump_inactive_ggtt
@ 2016-12-22 13:58 Chris Wilson
2016-12-22 19:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-01-09 11:21 ` [PATCH] " Joonas Lahtinen
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2016-12-22 13:58 UTC (permalink / raw)
To: intel-gfx
Since commit db6c2b4151f2 ("drm/i915: Store the vma in an rbtree under
the object") the vma are once again sorted into GGTT first, then ppGTT
so that the typical case of walking the GGTT vma can stop as soon as we
find a non-ppGTT. Apply that optimisation.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index d51c9b209837..b18f184c4f8e 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -1517,7 +1517,7 @@ static void i915_gem_object_bump_inactive_ggtt(struct drm_i915_gem_object *obj)
list_for_each_entry(vma, &obj->vma_list, obj_link) {
if (!i915_vma_is_ggtt(vma))
- continue;
+ break;
if (i915_vma_is_active(vma))
continue;
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Break after walking all GGTT vma in bump_inactive_ggtt
2016-12-22 13:58 [PATCH] drm/i915: Break after walking all GGTT vma in bump_inactive_ggtt Chris Wilson
@ 2016-12-22 19:15 ` Patchwork
2017-01-09 11:21 ` [PATCH] " Joonas Lahtinen
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2016-12-22 19:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Break after walking all GGTT vma in bump_inactive_ggtt
URL : https://patchwork.freedesktop.org/series/17134/
State : success
== Summary ==
Series 17134v1 drm/i915: Break after walking all GGTT vma in bump_inactive_ggtt
https://patchwork.freedesktop.org/api/1.0/series/17134/revisions/1/mbox/
fi-bdw-5557u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
fi-bsw-n3050 total:246 pass:207 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
fi-byt-j1900 total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19
fi-hsw-4770r total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19
fi-ilk-650 total:246 pass:194 dwarn:0 dfail:0 fail:0 skip:52
fi-ivb-3520m total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
fi-ivb-3770 total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
fi-kbl-7500u total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21
fi-skl-6260u total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13
fi-skl-6700hq total:246 pass:226 dwarn:0 dfail:0 fail:0 skip:20
fi-skl-6700k total:246 pass:222 dwarn:3 dfail:0 fail:0 skip:21
fi-skl-6770hq total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13
fi-snb-2520m total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31
fi-snb-2600 total:246 pass:214 dwarn:0 dfail:0 fail:0 skip:32
5486838e15ec59a57aa9a62f049f383cc3968e3f drm-tip: 2016y-12m-22d-13h-47m-26s UTC integration manifest
0ba58fa drm/i915: Break after walking all GGTT vma in bump_inactive_ggtt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3375/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: Break after walking all GGTT vma in bump_inactive_ggtt
2016-12-22 13:58 [PATCH] drm/i915: Break after walking all GGTT vma in bump_inactive_ggtt Chris Wilson
2016-12-22 19:15 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-01-09 11:21 ` Joonas Lahtinen
1 sibling, 0 replies; 3+ messages in thread
From: Joonas Lahtinen @ 2017-01-09 11:21 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On to, 2016-12-22 at 13:58 +0000, Chris Wilson wrote:
> Since commit db6c2b4151f2 ("drm/i915: Store the vma in an rbtree under
> the object") the vma are once again sorted into GGTT first, then ppGTT
> so that the typical case of walking the GGTT vma can stop as soon as we
> find a non-ppGTT. Apply that optimisation.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
This got reviewed by me in IRC and seems to be merged.
Regards, joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-09 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-22 13:58 [PATCH] drm/i915: Break after walking all GGTT vma in bump_inactive_ggtt Chris Wilson
2016-12-22 19:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-01-09 11:21 ` [PATCH] " Joonas Lahtinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.