* [PATCH] drm: Fix O= out-of-tree builds for selftests
@ 2016-12-28 9:41 Daniel Vetter
2016-12-28 10:06 ` Chris Wilson
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2016-12-28 9:41 UTC (permalink / raw)
To: DRI Development
Cc: Daniel Vetter, Daniel Vetter,
Joonas Lahtinen # Please enter the commit message for your
changes . Lines starting, Christian König
Kbuild really doesn't like non-recursive Makefiles, but they do work
as long as you build without O=
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 50f0033d1a0f ("drm: Add some kselftests for the DRM range manager (struct drm_mm)")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Christian König <christian.koenig@amd.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com># Please enter the commit message for your changes. Lines starting
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/Makefile | 2 +-
drivers/gpu/drm/selftests/Makefile | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
create mode 100644 drivers/gpu/drm/selftests/Makefile
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index c0d1aed8588b..d00c389f24bf 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -38,7 +38,7 @@ drm_kms_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o
drm_kms_helper-$(CONFIG_DRM_DP_AUX_CHARDEV) += drm_dp_aux_dev.o
obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o
-obj-$(CONFIG_DRM_DEBUG_MM_SELFTEST) += selftests/test-drm_mm.o
+obj-$(CONFIG_DRM_DEBUG_MM_SELFTEST) += selftests/
CFLAGS_drm_trace_points.o := -I$(src)
diff --git a/drivers/gpu/drm/selftests/Makefile b/drivers/gpu/drm/selftests/Makefile
new file mode 100644
index 000000000000..4aebfc7f27d4
--- /dev/null
+++ b/drivers/gpu/drm/selftests/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_DRM_DEBUG_MM_SELFTEST) += test-drm_mm.o
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Fix O= out-of-tree builds for selftests
2016-12-28 9:41 [PATCH] drm: Fix O= out-of-tree builds for selftests Daniel Vetter
@ 2016-12-28 10:06 ` Chris Wilson
2016-12-28 10:09 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Chris Wilson @ 2016-12-28 10:06 UTC (permalink / raw)
To: Daniel Vetter
Cc: Daniel Vetter,
Joonas Lahtinen # Please enter the commit message for your
changes . Lines starting, Christian König, DRI Development
On Wed, Dec 28, 2016 at 10:41:17AM +0100, Daniel Vetter wrote:
> Kbuild really doesn't like non-recursive Makefiles, but they do work
> as long as you build without O=
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 50f0033d1a0f ("drm: Add some kselftests for the DRM range manager (struct drm_mm)")
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com># Please enter the commit message for your changes. Lines starting
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
That's a shame, but it gets us over the breakage so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/Makefile | 2 +-
> drivers/gpu/drm/selftests/Makefile | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
> create mode 100644 drivers/gpu/drm/selftests/Makefile
>
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index c0d1aed8588b..d00c389f24bf 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -38,7 +38,7 @@ drm_kms_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o
> drm_kms_helper-$(CONFIG_DRM_DP_AUX_CHARDEV) += drm_dp_aux_dev.o
>
> obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o
> -obj-$(CONFIG_DRM_DEBUG_MM_SELFTEST) += selftests/test-drm_mm.o
> +obj-$(CONFIG_DRM_DEBUG_MM_SELFTEST) += selftests/
For the next set of selftests we should add a common
CONFIG_DRM_SELFTESTS.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Fix O= out-of-tree builds for selftests
2016-12-28 10:06 ` Chris Wilson
@ 2016-12-28 10:09 ` Daniel Vetter
2016-12-28 11:27 ` Eric Engestrom
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2016-12-28 10:09 UTC (permalink / raw)
To: Chris Wilson, Daniel Vetter, DRI Development,
Christian König,
Joonas Lahtinen # Please enter the commit message for your
changes . Lines starting, Daniel Vetter
On Wed, Dec 28, 2016 at 10:06:00AM +0000, Chris Wilson wrote:
> On Wed, Dec 28, 2016 at 10:41:17AM +0100, Daniel Vetter wrote:
> > Kbuild really doesn't like non-recursive Makefiles, but they do work
> > as long as you build without O=
> >
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Fixes: 50f0033d1a0f ("drm: Add some kselftests for the DRM range manager (struct drm_mm)")
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Christian König <christian.koenig@amd.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com># Please enter the commit message for your changes. Lines starting
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> That's a shame, but it gets us over the breakage so
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thx for the review, applied.
> For the next set of selftests we should add a common
> CONFIG_DRM_SELFTESTS.
Yeah, one for all of them is probably enough.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: Fix O= out-of-tree builds for selftests
2016-12-28 10:09 ` Daniel Vetter
@ 2016-12-28 11:27 ` Eric Engestrom
0 siblings, 0 replies; 4+ messages in thread
From: Eric Engestrom @ 2016-12-28 11:27 UTC (permalink / raw)
To: Daniel Vetter
Cc: Daniel Vetter,
Joonas Lahtinen # Please enter the commit message for your
changes . Lines starting, DRI Development, Daniel Vetter,
Christian König
On Wednesday, 2016-12-28 11:09:59 +0100, Daniel Vetter wrote:
> On Wed, Dec 28, 2016 at 10:06:00AM +0000, Chris Wilson wrote:
> > On Wed, Dec 28, 2016 at 10:41:17AM +0100, Daniel Vetter wrote:
> > > Kbuild really doesn't like non-recursive Makefiles, but they do work
> > > as long as you build without O=
> > >
> > > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > > Fixes: 50f0033d1a0f ("drm: Add some kselftests for the DRM range manager (struct drm_mm)")
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Christian König <christian.koenig@amd.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com># Please enter the commit message for your changes. Lines starting
In case you haven't pushed it yet, the line above could be fixed :)
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> >
> > That's a shame, but it gets us over the breakage so
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Thx for the review, applied.
>
> > For the next set of selftests we should add a common
> > CONFIG_DRM_SELFTESTS.
>
> Yeah, one for all of them is probably enough.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-28 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-28 9:41 [PATCH] drm: Fix O= out-of-tree builds for selftests Daniel Vetter
2016-12-28 10:06 ` Chris Wilson
2016-12-28 10:09 ` Daniel Vetter
2016-12-28 11:27 ` Eric Engestrom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.