* [Qemu-devel] [PATCH] doc/pcie: correct command line examples
@ 2016-12-27 7:40 Cao jin
2016-12-28 13:24 ` Marcel Apfelbaum
0 siblings, 1 reply; 4+ messages in thread
From: Cao jin @ 2016-12-27 7:40 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, marcel
Nit picking: Multi-function PCI Express Root Ports should mean that
'addr' property is mandatory, and slot is optional because it is default
to 0, and 'chassis' is mandatory for 2nd & 3rd root port because it is
default to 0 too.
Bonus: fix a typo(2->3)
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
docs/pcie.txt | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/docs/pcie.txt b/docs/pcie.txt
index 9fb20aaed9f4..54f05eaa71dc 100644
--- a/docs/pcie.txt
+++ b/docs/pcie.txt
@@ -110,18 +110,18 @@ Plug only PCI Express devices into PCI Express Ports.
-device ioh3420,id=root_port1,chassis=x,slot=y[,bus=pcie.0][,addr=z] \
-device <dev>,bus=root_port1
2.2.2 Using multi-function PCI Express Root Ports:
- -device ioh3420,id=root_port1,multifunction=on,chassis=x,slot=y[,bus=pcie.0][,addr=z.0] \
- -device ioh3420,id=root_port2,chassis=x1,slot=y1[,bus=pcie.0][,addr=z.1] \
- -device ioh3420,id=root_port3,chassis=x2,slot=y2[,bus=pcie.0][,addr=z.2] \
-2.2.2 Plugging a PCI Express device into a Switch:
+ -device ioh3420,id=root_port1,multifunction=on,chassis=x,addr=z.0[,slot=y][,bus=pcie.0] \
+ -device ioh3420,id=root_port2,chassis=x1,addr=z.1[,slot=y1][,bus=pcie.0] \
+ -device ioh3420,id=root_port3,chassis=x2,addr=z.2[,slot=y2][,bus=pcie.0] \
+2.2.3 Plugging a PCI Express device into a Switch:
-device ioh3420,id=root_port1,chassis=x,slot=y[,bus=pcie.0][,addr=z] \
-device x3130-upstream,id=upstream_port1,bus=root_port1[,addr=x] \
-device xio3130-downstream,id=downstream_port1,bus=upstream_port1,chassis=x1,slot=y1[,addr=z1]] \
-device <dev>,bus=downstream_port1
Notes:
- - (slot, chassis) pair is mandatory and must be
- unique for each PCI Express Root Port.
+ - (slot, chassis) pair is mandatory and must be unique for each
+ PCI Express Root Port. slot is default to 0 when doesn't specify it.
- 'addr' parameter can be 0 for all the examples above.
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] doc/pcie: correct command line examples
2016-12-27 7:40 [Qemu-devel] [PATCH] doc/pcie: correct command line examples Cao jin
@ 2016-12-28 13:24 ` Marcel Apfelbaum
2016-12-28 15:21 ` Andrew Jones
0 siblings, 1 reply; 4+ messages in thread
From: Marcel Apfelbaum @ 2016-12-28 13:24 UTC (permalink / raw)
To: Cao jin, qemu-devel; +Cc: mst
On 12/27/2016 09:40 AM, Cao jin wrote:
> Nit picking: Multi-function PCI Express Root Ports should mean that
> 'addr' property is mandatory, and slot is optional because it is default
> to 0, and 'chassis' is mandatory for 2nd & 3rd root port because it is
> default to 0 too.
>
> Bonus: fix a typo(2->3)
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> docs/pcie.txt | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/docs/pcie.txt b/docs/pcie.txt
> index 9fb20aaed9f4..54f05eaa71dc 100644
> --- a/docs/pcie.txt
> +++ b/docs/pcie.txt
> @@ -110,18 +110,18 @@ Plug only PCI Express devices into PCI Express Ports.
> -device ioh3420,id=root_port1,chassis=x,slot=y[,bus=pcie.0][,addr=z] \
> -device <dev>,bus=root_port1
> 2.2.2 Using multi-function PCI Express Root Ports:
> - -device ioh3420,id=root_port1,multifunction=on,chassis=x,slot=y[,bus=pcie.0][,addr=z.0] \
> - -device ioh3420,id=root_port2,chassis=x1,slot=y1[,bus=pcie.0][,addr=z.1] \
> - -device ioh3420,id=root_port3,chassis=x2,slot=y2[,bus=pcie.0][,addr=z.2] \
> -2.2.2 Plugging a PCI Express device into a Switch:
> + -device ioh3420,id=root_port1,multifunction=on,chassis=x,addr=z.0[,slot=y][,bus=pcie.0] \
> + -device ioh3420,id=root_port2,chassis=x1,addr=z.1[,slot=y1][,bus=pcie.0] \
> + -device ioh3420,id=root_port3,chassis=x2,addr=z.2[,slot=y2][,bus=pcie.0] \
> +2.2.3 Plugging a PCI Express device into a Switch:
> -device ioh3420,id=root_port1,chassis=x,slot=y[,bus=pcie.0][,addr=z] \
> -device x3130-upstream,id=upstream_port1,bus=root_port1[,addr=x] \
> -device xio3130-downstream,id=downstream_port1,bus=upstream_port1,chassis=x1,slot=y1[,addr=z1]] \
> -device <dev>,bus=downstream_port1
>
> Notes:
> - - (slot, chassis) pair is mandatory and must be
> - unique for each PCI Express Root Port.
> + - (slot, chassis) pair is mandatory and must be unique for each
> + PCI Express Root Port. slot is default to 0 when doesn't specify it.
> - 'addr' parameter can be 0 for all the examples above.
>
>
>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Thanks,
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] doc/pcie: correct command line examples
2016-12-28 13:24 ` Marcel Apfelbaum
@ 2016-12-28 15:21 ` Andrew Jones
2016-12-29 1:12 ` Cao jin
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Jones @ 2016-12-28 15:21 UTC (permalink / raw)
To: Marcel Apfelbaum; +Cc: Cao jin, qemu-devel, mst
On Wed, Dec 28, 2016 at 03:24:30PM +0200, Marcel Apfelbaum wrote:
> On 12/27/2016 09:40 AM, Cao jin wrote:
> > Nit picking: Multi-function PCI Express Root Ports should mean that
> > 'addr' property is mandatory, and slot is optional because it is default
> > to 0, and 'chassis' is mandatory for 2nd & 3rd root port because it is
> > default to 0 too.
> >
> > Bonus: fix a typo(2->3)
> > Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> > ---
> > docs/pcie.txt | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/docs/pcie.txt b/docs/pcie.txt
> > index 9fb20aaed9f4..54f05eaa71dc 100644
> > --- a/docs/pcie.txt
> > +++ b/docs/pcie.txt
> > @@ -110,18 +110,18 @@ Plug only PCI Express devices into PCI Express Ports.
> > -device ioh3420,id=root_port1,chassis=x,slot=y[,bus=pcie.0][,addr=z] \
> > -device <dev>,bus=root_port1
> > 2.2.2 Using multi-function PCI Express Root Ports:
> > - -device ioh3420,id=root_port1,multifunction=on,chassis=x,slot=y[,bus=pcie.0][,addr=z.0] \
> > - -device ioh3420,id=root_port2,chassis=x1,slot=y1[,bus=pcie.0][,addr=z.1] \
> > - -device ioh3420,id=root_port3,chassis=x2,slot=y2[,bus=pcie.0][,addr=z.2] \
> > -2.2.2 Plugging a PCI Express device into a Switch:
> > + -device ioh3420,id=root_port1,multifunction=on,chassis=x,addr=z.0[,slot=y][,bus=pcie.0] \
> > + -device ioh3420,id=root_port2,chassis=x1,addr=z.1[,slot=y1][,bus=pcie.0] \
> > + -device ioh3420,id=root_port3,chassis=x2,addr=z.2[,slot=y2][,bus=pcie.0] \
> > +2.2.3 Plugging a PCI Express device into a Switch:
> > -device ioh3420,id=root_port1,chassis=x,slot=y[,bus=pcie.0][,addr=z] \
> > -device x3130-upstream,id=upstream_port1,bus=root_port1[,addr=x] \
> > -device xio3130-downstream,id=downstream_port1,bus=upstream_port1,chassis=x1,slot=y1[,addr=z1]] \
> > -device <dev>,bus=downstream_port1
> >
> > Notes:
> > - - (slot, chassis) pair is mandatory and must be
> > - unique for each PCI Express Root Port.
> > + - (slot, chassis) pair is mandatory and must be unique for each
> > + PCI Express Root Port. slot is default to 0 when doesn't specify it.
Please rewrite last sentence as
slot defaults to 0 when not specified.
> > - 'addr' parameter can be 0 for all the examples above.
> >
> >
> >
>
> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
>
> Thanks,
> Marcel
>
Thanks,
drew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] doc/pcie: correct command line examples
2016-12-28 15:21 ` Andrew Jones
@ 2016-12-29 1:12 ` Cao jin
0 siblings, 0 replies; 4+ messages in thread
From: Cao jin @ 2016-12-29 1:12 UTC (permalink / raw)
To: Andrew Jones, Marcel Apfelbaum; +Cc: qemu-devel, mst
On 12/28/2016 11:21 PM, Andrew Jones wrote:
> On Wed, Dec 28, 2016 at 03:24:30PM +0200, Marcel Apfelbaum wrote:
>> On 12/27/2016 09:40 AM, Cao jin wrote:
>>> Nit picking: Multi-function PCI Express Root Ports should mean that
>>> 'addr' property is mandatory, and slot is optional because it is default
>>> to 0, and 'chassis' is mandatory for 2nd & 3rd root port because it is
>>> default to 0 too.
>>>
>>> Bonus: fix a typo(2->3)
>>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>>> ---
>>> docs/pcie.txt | 12 ++++++------
>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/docs/pcie.txt b/docs/pcie.txt
>>> index 9fb20aaed9f4..54f05eaa71dc 100644
>>> --- a/docs/pcie.txt
>>> +++ b/docs/pcie.txt
>>> @@ -110,18 +110,18 @@ Plug only PCI Express devices into PCI Express Ports.
>>> -device ioh3420,id=root_port1,chassis=x,slot=y[,bus=pcie.0][,addr=z] \
>>> -device <dev>,bus=root_port1
>>> 2.2.2 Using multi-function PCI Express Root Ports:
>>> - -device ioh3420,id=root_port1,multifunction=on,chassis=x,slot=y[,bus=pcie.0][,addr=z.0] \
>>> - -device ioh3420,id=root_port2,chassis=x1,slot=y1[,bus=pcie.0][,addr=z.1] \
>>> - -device ioh3420,id=root_port3,chassis=x2,slot=y2[,bus=pcie.0][,addr=z.2] \
>>> -2.2.2 Plugging a PCI Express device into a Switch:
>>> + -device ioh3420,id=root_port1,multifunction=on,chassis=x,addr=z.0[,slot=y][,bus=pcie.0] \
>>> + -device ioh3420,id=root_port2,chassis=x1,addr=z.1[,slot=y1][,bus=pcie.0] \
>>> + -device ioh3420,id=root_port3,chassis=x2,addr=z.2[,slot=y2][,bus=pcie.0] \
>>> +2.2.3 Plugging a PCI Express device into a Switch:
>>> -device ioh3420,id=root_port1,chassis=x,slot=y[,bus=pcie.0][,addr=z] \
>>> -device x3130-upstream,id=upstream_port1,bus=root_port1[,addr=x] \
>>> -device xio3130-downstream,id=downstream_port1,bus=upstream_port1,chassis=x1,slot=y1[,addr=z1]] \
>>> -device <dev>,bus=downstream_port1
>>>
>>> Notes:
>>> - - (slot, chassis) pair is mandatory and must be
>>> - unique for each PCI Express Root Port.
>>> + - (slot, chassis) pair is mandatory and must be unique for each
>>> + PCI Express Root Port. slot is default to 0 when doesn't specify it.
>
> Please rewrite last sentence as
>
> slot defaults to 0 when not specified.
Thanks for pointing it out, v2 is on the way.
--
Sincerely,
Cao jin
>
>>> - 'addr' parameter can be 0 for all the examples above.
>>>
>>>
>>>
>>
>> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
>>
>> Thanks,
>> Marcel
>>
>
> Thanks,
> drew
>
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-29 1:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-27 7:40 [Qemu-devel] [PATCH] doc/pcie: correct command line examples Cao jin
2016-12-28 13:24 ` Marcel Apfelbaum
2016-12-28 15:21 ` Andrew Jones
2016-12-29 1:12 ` Cao jin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.