From: Shawn Guo <shawnguo@kernel.org> To: Martin Kaiser <martin@kaiser.cx> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>, Sascha Hauer <kernel@pengutronix.de>, Juergen Borleis <jbe@pengutronix.de>, Lucas Stach <l.stach@pengutronix.de>, Fabio Estevam <fabio.estevam@nxp.com>, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com> Subject: Re: [PATCH 2/2 v2] ARM: i.MX25: add the optional security violation irq Date: Fri, 30 Dec 2016 10:44:10 +0800 [thread overview] Message-ID: <20161230024409.GK6177@dragon> (raw) In-Reply-To: <1482361276-12475-1-git-send-email-martin@kaiser.cx> On Thu, Dec 22, 2016 at 12:01:16AM +0100, Martin Kaiser wrote: > Add the security violation irq as an optional entry to rtc-imxdi's > device tree bindings and to i.MX25's dtsi file. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > --- > v2: > - clarify that the security violation interrupt is optional > - use the same syntax as everwhere else for lists of interrupt numbers > > Documentation/devicetree/bindings/rtc/imxdi-rtc.txt | 5 ++++- > arch/arm/boot/dts/imx25.dtsi | 2 +- I take DTS changes only. Please make the bindings doc change a separate patch, and have it go together with driver patch. And I apply DTS patch only after driver and bindings changes get accepted by RTC maintainer. Shawn > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt > index c9d80d7..323cf26 100644 > --- a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt > +++ b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt > @@ -8,10 +8,13 @@ Required properties: > region. > - interrupts: rtc alarm interrupt > > +Optional properties: > +- interrupts: dryice security violation interrupt > + > Example: > > rtc@80056000 { > compatible = "fsl,imx53-rtc", "fsl,imx25-rtc"; > reg = <0x80056000 2000>; > - interrupts = <29>; > + interrupts = <29 56>; > }; > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 831d09a..331d1e1 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -560,7 +560,7 @@ > reg = <0x53ffc000 0x4000>; > clocks = <&clks 81>; > clock-names = "ipg"; > - interrupts = <25>; > + interrupts = <25 56>; > }; > }; > > -- > 1.7.10.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org> To: Martin Kaiser <martin@kaiser.cx> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>, Sascha Hauer <kernel@pengutronix.de>, Juergen Borleis <jbe@pengutronix.de>, Lucas Stach <l.stach@pengutronix.de>, Fabio Estevam <fabio.estevam@nxp.com>, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com> Subject: [rtc-linux] Re: [PATCH 2/2 v2] ARM: i.MX25: add the optional security violation irq Date: Fri, 30 Dec 2016 10:44:10 +0800 [thread overview] Message-ID: <20161230024409.GK6177@dragon> (raw) In-Reply-To: <1482361276-12475-1-git-send-email-martin@kaiser.cx> On Thu, Dec 22, 2016 at 12:01:16AM +0100, Martin Kaiser wrote: > Add the security violation irq as an optional entry to rtc-imxdi's > device tree bindings and to i.MX25's dtsi file. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > --- > v2: > - clarify that the security violation interrupt is optional > - use the same syntax as everwhere else for lists of interrupt numbers > > Documentation/devicetree/bindings/rtc/imxdi-rtc.txt | 5 ++++- > arch/arm/boot/dts/imx25.dtsi | 2 +- I take DTS changes only. Please make the bindings doc change a separate patch, and have it go together with driver patch. And I apply DTS patch only after driver and bindings changes get accepted by RTC maintainer. Shawn > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt > index c9d80d7..323cf26 100644 > --- a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt > +++ b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt > @@ -8,10 +8,13 @@ Required properties: > region. > - interrupts: rtc alarm interrupt > > +Optional properties: > +- interrupts: dryice security violation interrupt > + > Example: > > rtc@80056000 { > compatible = "fsl,imx53-rtc", "fsl,imx25-rtc"; > reg = <0x80056000 2000>; > - interrupts = <29>; > + interrupts = <29 56>; > }; > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 831d09a..331d1e1 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -560,7 +560,7 @@ > reg = <0x53ffc000 0x4000>; > clocks = <&clks 81>; > clock-names = "ipg"; > - interrupts = <25>; > + interrupts = <25 56>; > }; > }; > > -- > 1.7.10.4 > -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-12-30 2:44 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-19 13:03 [PATCH 1/2] rtc: imxdi: (trivial) fix a typo Martin Kaiser 2016-11-19 13:03 ` [rtc-linux] " Martin Kaiser 2016-11-19 13:03 ` [PATCH 2/2] rtc: imxdi: use the security violation interrupt Martin Kaiser 2016-11-19 13:03 ` [rtc-linux] " Martin Kaiser 2016-12-07 15:47 ` Alexandre Belloni 2016-12-07 15:47 ` [rtc-linux] " Alexandre Belloni 2016-12-07 15:48 ` [PATCH 1/2] rtc: imxdi: (trivial) fix a typo Alexandre Belloni 2016-12-07 15:48 ` [rtc-linux] " Alexandre Belloni 2016-12-19 22:41 ` [PATCH v2] rtc: imxdi: use the security violation interrupt Martin Kaiser 2016-12-19 22:41 ` [rtc-linux] " Martin Kaiser 2016-12-20 9:23 ` Lucas Stach 2016-12-20 9:23 ` [rtc-linux] " Lucas Stach 2016-12-21 23:06 ` Martin Kaiser 2016-12-21 23:06 ` [rtc-linux] " Martin Kaiser 2016-12-21 22:56 ` [PATCH 1/2 v3] " Martin Kaiser 2016-12-21 22:56 ` [rtc-linux] " Martin Kaiser 2016-12-21 23:01 ` [PATCH 2/2 v2] ARM: i.MX25: add the optional security violation irq Martin Kaiser 2016-12-21 23:01 ` [rtc-linux] " Martin Kaiser 2016-12-30 2:44 ` Shawn Guo [this message] 2016-12-30 2:44 ` [rtc-linux] " Shawn Guo 2017-01-03 18:49 ` [PATCH 1/3 v4] rtc: imxdi: use the security violation interrupt Martin Kaiser 2017-01-03 18:49 ` [rtc-linux] " Martin Kaiser 2017-01-10 23:46 ` Alexandre Belloni 2017-01-10 23:46 ` [rtc-linux] " Alexandre Belloni 2017-01-03 18:50 ` [PATCH 2/3] ARM: dts: imx25.dtsi: DryIce " Martin Kaiser 2017-01-03 18:50 ` [rtc-linux] " Martin Kaiser 2017-01-10 1:53 ` Shawn Guo 2017-01-10 1:53 ` [rtc-linux] " Shawn Guo 2017-01-03 18:51 ` [PATCH 3/3] Documentation: dt: rtc-imxdi: " Martin Kaiser 2017-01-03 18:51 ` [rtc-linux] " Martin Kaiser 2017-01-10 23:47 ` Alexandre Belloni 2017-01-10 23:47 ` [rtc-linux] " Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161230024409.GK6177@dragon \ --to=shawnguo@kernel.org \ --cc=alexandre.belloni@free-electrons.com \ --cc=fabio.estevam@nxp.com \ --cc=jbe@pengutronix.de \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=martin@kaiser.cx \ --cc=robh+dt@kernel.org \ --cc=rtc-linux@googlegroups.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.