All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtd: fix nand.h kernel-doc warnings
@ 2016-11-22  2:32 Randy Dunlap
  2016-11-22  8:40 ` Boris Brezillon
  2017-01-03 10:56 ` Boris Brezillon
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2016-11-22  2:32 UTC (permalink / raw)
  To: linux-mtd, Boris BREZILLON, Richard Weinberger

From: Randy Dunlap <rdunlap@infradead.org>

Fix kernel-doc warnings in <linux/mtd/nand.h>:

..//include/linux/mtd/nand.h:658: warning: No description found for parameter 'tCEH_min'
..//include/linux/mtd/nand.h:877: warning: No description found for parameter 'data_interface'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 include/linux/mtd/nand.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

I haven't been able to find tCEH_min in any NAND datasheets (yet).

--- lnx-49-rc6.orig/include/linux/mtd/nand.h
+++ lnx-49-rc6/include/linux/mtd/nand.h
@@ -589,7 +589,7 @@ struct nand_buffers {
  * @tALS_min: ALE setup time
  * @tAR_min: ALE to RE# delay
  * @tCEA_max: CE# access time
- * @tCEH_min:
+ * @tCEH_min: CE# XXX time
  * @tCH_min:  CE# hold time
  * @tCHZ_max: CE# high to output hi-Z
  * @tCLH_min: CLE hold time
@@ -771,6 +771,7 @@ nand_get_sdr_timings(const struct nand_d
  *			supported, 0 otherwise.
  * @jedec_params:	[INTERN] holds the JEDEC parameter page when JEDEC is
  *			supported, 0 otherwise.
+ * @data_interface:	[INTERN] NAND interface timing information
  * @read_retries:	[INTERN] the number of read retry modes supported
  * @onfi_set_features:	[REPLACEABLE] set the features for ONFI nand
  * @onfi_get_features:	[REPLACEABLE] get the features for ONFI nand

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: fix nand.h kernel-doc warnings
  2016-11-22  2:32 [PATCH] mtd: fix nand.h kernel-doc warnings Randy Dunlap
@ 2016-11-22  8:40 ` Boris Brezillon
  2017-01-03 10:56 ` Boris Brezillon
  1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2016-11-22  8:40 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-mtd, Richard Weinberger

On Mon, 21 Nov 2016 18:32:08 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix kernel-doc warnings in <linux/mtd/nand.h>:
> 
> ..//include/linux/mtd/nand.h:658: warning: No description found for parameter 'tCEH_min'
> ..//include/linux/mtd/nand.h:877: warning: No description found for parameter 'data_interface'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
>  include/linux/mtd/nand.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I haven't been able to find tCEH_min in any NAND datasheets (yet).
> 
> --- lnx-49-rc6.orig/include/linux/mtd/nand.h
> +++ lnx-49-rc6/include/linux/mtd/nand.h
> @@ -589,7 +589,7 @@ struct nand_buffers {
>   * @tALS_min: ALE setup time
>   * @tAR_min: ALE to RE# delay
>   * @tCEA_max: CE# access time
> - * @tCEH_min:
> + * @tCEH_min: CE# XXX time

		 CE# high hold time

I'll fix it when applying the patch.

Thanks,

Boris

>   * @tCH_min:  CE# hold time
>   * @tCHZ_max: CE# high to output hi-Z
>   * @tCLH_min: CLE hold time
> @@ -771,6 +771,7 @@ nand_get_sdr_timings(const struct nand_d
>   *			supported, 0 otherwise.
>   * @jedec_params:	[INTERN] holds the JEDEC parameter page when JEDEC is
>   *			supported, 0 otherwise.
> + * @data_interface:	[INTERN] NAND interface timing information
>   * @read_retries:	[INTERN] the number of read retry modes supported
>   * @onfi_set_features:	[REPLACEABLE] set the features for ONFI nand
>   * @onfi_get_features:	[REPLACEABLE] get the features for ONFI nand

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: fix nand.h kernel-doc warnings
  2016-11-22  2:32 [PATCH] mtd: fix nand.h kernel-doc warnings Randy Dunlap
  2016-11-22  8:40 ` Boris Brezillon
@ 2017-01-03 10:56 ` Boris Brezillon
  1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2017-01-03 10:56 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-mtd, Richard Weinberger

On Mon, 21 Nov 2016 18:32:08 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix kernel-doc warnings in <linux/mtd/nand.h>:
> 
> ..//include/linux/mtd/nand.h:658: warning: No description found for parameter 'tCEH_min'
> ..//include/linux/mtd/nand.h:877: warning: No description found for parameter 'data_interface'
> 

Applied.

Thanks,

Boris

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
>  include/linux/mtd/nand.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I haven't been able to find tCEH_min in any NAND datasheets (yet).
> 
> --- lnx-49-rc6.orig/include/linux/mtd/nand.h
> +++ lnx-49-rc6/include/linux/mtd/nand.h
> @@ -589,7 +589,7 @@ struct nand_buffers {
>   * @tALS_min: ALE setup time
>   * @tAR_min: ALE to RE# delay
>   * @tCEA_max: CE# access time
> - * @tCEH_min:
> + * @tCEH_min: CE# XXX time
>   * @tCH_min:  CE# hold time
>   * @tCHZ_max: CE# high to output hi-Z
>   * @tCLH_min: CLE hold time
> @@ -771,6 +771,7 @@ nand_get_sdr_timings(const struct nand_d
>   *			supported, 0 otherwise.
>   * @jedec_params:	[INTERN] holds the JEDEC parameter page when JEDEC is
>   *			supported, 0 otherwise.
> + * @data_interface:	[INTERN] NAND interface timing information
>   * @read_retries:	[INTERN] the number of read retry modes supported
>   * @onfi_set_features:	[REPLACEABLE] set the features for ONFI nand
>   * @onfi_get_features:	[REPLACEABLE] get the features for ONFI nand
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-03 10:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-22  2:32 [PATCH] mtd: fix nand.h kernel-doc warnings Randy Dunlap
2016-11-22  8:40 ` Boris Brezillon
2017-01-03 10:56 ` Boris Brezillon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.