All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: zhongjiang <zhongjiang@huawei.com>
Cc: will.deacon@arm.com, rrichter@cavium.com, mark.rutland@arm.com,
	arnd@arndb.de, ard.biesheuvel@linaro.org, robh+dt@kernel.org,
	dwoods@ezchip.com, jeremy.linton@arm.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH 1/2] arm64: change from CONT_PMD_SHIFT to CONT_PTE_SHIFT
Date: Tue, 3 Jan 2017 12:31:20 +0000	[thread overview]
Message-ID: <20170103123120.GA1244@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1481725151-20549-2-git-send-email-zhongjiang@huawei.com>

On Wed, Dec 14, 2016 at 10:19:10PM +0800, zhongjiang wrote:
> From: zhong jiang <zhongjiang@huawei.com>
> 
> I think that CONT_PTE_SHIFT is more reasonable even if they are some
> value. and the patch is not any functional change.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  arch/arm64/mm/hugetlbpage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
> index 2e49bd2..0a4c97b 100644
> --- a/arch/arm64/mm/hugetlbpage.c
> +++ b/arch/arm64/mm/hugetlbpage.c
> @@ -323,7 +323,7 @@ static __init int setup_hugepagesz(char *opt)
>  static __init int add_default_hugepagesz(void)
>  {
>  	if (size_to_hstate(CONT_PTES * PAGE_SIZE) == NULL)
> -		hugetlb_add_hstate(CONT_PMD_SHIFT);
> +		hugetlb_add_hstate(CONT_PTE_SHIFT);
>  	return 0;
>  }
>  arch_initcall(add_default_hugepagesz);

It looks like I fixed this already when I merged some other hugetlb
patches. See commit 6ed0038d5ecb ("arm64: Fix typo in
add_default_hugepagesz() for 64K pages").

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/2] arm64: change from CONT_PMD_SHIFT to CONT_PTE_SHIFT
Date: Tue, 3 Jan 2017 12:31:20 +0000	[thread overview]
Message-ID: <20170103123120.GA1244@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1481725151-20549-2-git-send-email-zhongjiang@huawei.com>

On Wed, Dec 14, 2016 at 10:19:10PM +0800, zhongjiang wrote:
> From: zhong jiang <zhongjiang@huawei.com>
> 
> I think that CONT_PTE_SHIFT is more reasonable even if they are some
> value. and the patch is not any functional change.
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  arch/arm64/mm/hugetlbpage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
> index 2e49bd2..0a4c97b 100644
> --- a/arch/arm64/mm/hugetlbpage.c
> +++ b/arch/arm64/mm/hugetlbpage.c
> @@ -323,7 +323,7 @@ static __init int setup_hugepagesz(char *opt)
>  static __init int add_default_hugepagesz(void)
>  {
>  	if (size_to_hstate(CONT_PTES * PAGE_SIZE) == NULL)
> -		hugetlb_add_hstate(CONT_PMD_SHIFT);
> +		hugetlb_add_hstate(CONT_PTE_SHIFT);
>  	return 0;
>  }
>  arch_initcall(add_default_hugepagesz);

It looks like I fixed this already when I merged some other hugetlb
patches. See commit 6ed0038d5ecb ("arm64: Fix typo in
add_default_hugepagesz() for 64K pages").

-- 
Catalin

  parent reply	other threads:[~2017-01-03 12:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14 14:19 [RESEND PATCH 0/2] fix some trivial bug involving the contiguous bit zhongjiang
2016-12-14 14:19 ` zhongjiang
2016-12-14 14:19 ` [RESEND PATCH 1/2] arm64: change from CONT_PMD_SHIFT to CONT_PTE_SHIFT zhongjiang
2016-12-14 14:19   ` zhongjiang
2016-12-14 14:45   ` Ard Biesheuvel
2016-12-14 14:45     ` Ard Biesheuvel
2016-12-15  2:59     ` zhong jiang
2016-12-15  2:59       ` zhong jiang
2017-01-03 12:31   ` Catalin Marinas [this message]
2017-01-03 12:31     ` Catalin Marinas
2016-12-14 14:19 ` [RESEND PATCH 2/2] arm64: make WANT_HUGE_PMD_SHARE depends on HUGETLB_PAGE zhongjiang
2016-12-14 14:19   ` zhongjiang
2016-12-16  9:10   ` zhong jiang
2016-12-16  9:10     ` zhong jiang
2016-12-16 12:35     ` Will Deacon
2016-12-16 12:35       ` Will Deacon
2016-12-16 12:56       ` zhong jiang
2016-12-16 12:56         ` zhong jiang
2016-12-16 14:08       ` zhong jiang
2016-12-16 14:08         ` zhong jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170103123120.GA1244@e104818-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=dwoods@ezchip.com \
    --cc=jeremy.linton@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rrichter@cavium.com \
    --cc=will.deacon@arm.com \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.