[PATCH] Tolerate modprobe failures in multipathd.service

[PATCH] Tolerate modprobe failures in multipathd.service

[Anthony Ryan]

When these modules are built statically into the kernel, modprobe
will fail and prevent the service from being started. By making this
line non-fatal, on such systems the service is still able to be
started.
---
 multipathd/multipathd.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
index e3d6f91..d26577f 100644
--- a/multipathd/multipathd.service
+++ b/multipathd/multipathd.service
@@ -11,7 +11,7 @@ Conflicts=shutdown.target
 Type=notify
 NotifyAccess=main
 LimitCORE=infinity
-ExecStartPre=/sbin/modprobe -a scsi_dh_alua scsi_dh_emc scsi_dh_rdac
dm-multipath
+ExecStartPre=-/sbin/modprobe -a scsi_dh_alua scsi_dh_emc scsi_dh_rdac
dm-multipath
 ExecStart=/sbin/multipathd -d -s
 ExecReload=/sbin/multipathd reconfigure

-- 
2.11.0

Re: [PATCH] Tolerate modprobe failures in multipathd.service

[Benjamin Marzinski]

On Thu, Jan 05, 2017 at 08:33:10AM -0500, Anthony Ryan wrote:
> When these modules are built statically into the kernel, modprobe
> will fail and prevent the service from being started. By making this
> line non-fatal, on such systems the service is still able to be
> started.

ACK

-Ben

> ---
>  multipathd/multipathd.service | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
> index e3d6f91..d26577f 100644
> --- a/multipathd/multipathd.service
> +++ b/multipathd/multipathd.service
> @@ -11,7 +11,7 @@ Conflicts=shutdown.target
>  Type=notify
>  NotifyAccess=main
>  LimitCORE=infinity
> -ExecStartPre=/sbin/modprobe -a scsi_dh_alua scsi_dh_emc scsi_dh_rdac
> dm-multipath
> +ExecStartPre=-/sbin/modprobe -a scsi_dh_alua scsi_dh_emc scsi_dh_rdac
> dm-multipath
>  ExecStart=/sbin/multipathd -d -s
>  ExecReload=/sbin/multipathd reconfigure
> 
> -- 
> 2.11.0
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

Re: [PATCH] Tolerate modprobe failures in multipathd.service

[Christophe Varoqui]

[-- Attachment #1.1: Type: text/plain, Size: 1327 bytes --]

Applied.
Thanks.

On Thu, Jan 5, 2017 at 4:30 PM, Benjamin Marzinski <bmarzins@redhat.com>
wrote:

> On Thu, Jan 05, 2017 at 08:33:10AM -0500, Anthony Ryan wrote:
> > When these modules are built statically into the kernel, modprobe
> > will fail and prevent the service from being started. By making this
> > line non-fatal, on such systems the service is still able to be
> > started.
>
> ACK
>
> -Ben
>
> > ---
> >  multipathd/multipathd.service | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/multipathd/multipathd.service b/multipathd/multipathd.
> service
> > index e3d6f91..d26577f 100644
> > --- a/multipathd/multipathd.service
> > +++ b/multipathd/multipathd.service
> > @@ -11,7 +11,7 @@ Conflicts=shutdown.target
> >  Type=notify
> >  NotifyAccess=main
> >  LimitCORE=infinity
> > -ExecStartPre=/sbin/modprobe -a scsi_dh_alua scsi_dh_emc scsi_dh_rdac
> > dm-multipath
> > +ExecStartPre=-/sbin/modprobe -a scsi_dh_alua scsi_dh_emc scsi_dh_rdac
> > dm-multipath
> >  ExecStart=/sbin/multipathd -d -s
> >  ExecReload=/sbin/multipathd reconfigure
> >
> > --
> > 2.11.0
> >
> > --
> > dm-devel mailing list
> > dm-devel@redhat.com
> > https://www.redhat.com/mailman/listinfo/dm-devel
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
>

[-- Attachment #1.2: Type: text/html, Size: 2224 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]