All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] treewide: fix semicolon.cocci warnings
  2017-01-07  3:26 [memcg:cleanups/kvmalloc 2/5] net/netfilter/x_tables.c:716:59-60: Unneeded semicolon kbuild test robot
@ 2017-01-07  3:26   ` kbuild test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2017-01-07  3:26 UTC (permalink / raw)
  To: Michal Hocko
  Cc: kbuild-all, linux-mm, Pablo Neira Ayuso, Patrick McHardy,
	Jozsef Kadlecsik, netfilter-devel, coreteam, netdev,
	linux-kernel

net/netfilter/x_tables.c:716:59-60: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 x_tables.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/netfilter/x_tables.c
+++ b/net/netfilter/x_tables.c
@@ -713,7 +713,7 @@ EXPORT_SYMBOL(xt_check_entry_offsets);
 unsigned int *xt_alloc_entry_offsets(unsigned int size)
 {
 	if (size < (SIZE_MAX / sizeof(unsigned int)))
-		return kvmalloc(size * sizeof(unsigned int), GFP_KERNEL);;
+		return kvmalloc(size * sizeof(unsigned int), GFP_KERNEL);
 
 	return NULL;
 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] treewide: fix semicolon.cocci warnings
@ 2017-01-07  3:26   ` kbuild test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2017-01-07  3:26 UTC (permalink / raw)
  To: Michal Hocko
  Cc: kbuild-all, linux-mm, Pablo Neira Ayuso, Patrick McHardy,
	Jozsef Kadlecsik, netfilter-devel, coreteam, netdev,
	linux-kernel

net/netfilter/x_tables.c:716:59-60: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 x_tables.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/netfilter/x_tables.c
+++ b/net/netfilter/x_tables.c
@@ -713,7 +713,7 @@ EXPORT_SYMBOL(xt_check_entry_offsets);
 unsigned int *xt_alloc_entry_offsets(unsigned int size)
 {
 	if (size < (SIZE_MAX / sizeof(unsigned int)))
-		return kvmalloc(size * sizeof(unsigned int), GFP_KERNEL);;
+		return kvmalloc(size * sizeof(unsigned int), GFP_KERNEL);
 
 	return NULL;
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [memcg:cleanups/kvmalloc 2/5] net/netfilter/x_tables.c:716:59-60: Unneeded semicolon
@ 2017-01-07  3:26 kbuild test robot
  2017-01-07  3:26   ` kbuild test robot
  0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2017-01-07  3:26 UTC (permalink / raw)
  To: Michal Hocko; +Cc: kbuild-all, linux-mm

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git cleanups/kvmalloc
head:   351a752d1cd188fbe199f7a42094af72ee90fd63
commit: e853c5eda9c6b8fa6c01f7e76cba3ff41aa13764 [2/5] treewide: use kv[mz]alloc* rather than opencoded variants


coccinelle warnings: (new ones prefixed by >>)

>> net/netfilter/x_tables.c:716:59-60: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] treewide: fix semicolon.cocci warnings
  2017-01-07  3:26   ` kbuild test robot
@ 2017-01-07  9:23     ` Michal Hocko
  -1 siblings, 0 replies; 5+ messages in thread
From: Michal Hocko @ 2017-01-07  9:23 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, linux-mm, Pablo Neira Ayuso, Patrick McHardy,
	Jozsef Kadlecsik, netfilter-devel, coreteam, netdev,
	linux-kernel

On Sat 07-01-17 11:26:42, Wu Fengguang wrote:
> net/netfilter/x_tables.c:716:59-60: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Thanks, I will fold this into the original patch.

> ---
> 
>  x_tables.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/net/netfilter/x_tables.c
> +++ b/net/netfilter/x_tables.c
> @@ -713,7 +713,7 @@ EXPORT_SYMBOL(xt_check_entry_offsets);
>  unsigned int *xt_alloc_entry_offsets(unsigned int size)
>  {
>  	if (size < (SIZE_MAX / sizeof(unsigned int)))
> -		return kvmalloc(size * sizeof(unsigned int), GFP_KERNEL);;
> +		return kvmalloc(size * sizeof(unsigned int), GFP_KERNEL);
>  
>  	return NULL;
>  

-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] treewide: fix semicolon.cocci warnings
@ 2017-01-07  9:23     ` Michal Hocko
  0 siblings, 0 replies; 5+ messages in thread
From: Michal Hocko @ 2017-01-07  9:23 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, linux-mm, Pablo Neira Ayuso, Patrick McHardy,
	Jozsef Kadlecsik, netfilter-devel, coreteam, netdev,
	linux-kernel

On Sat 07-01-17 11:26:42, Wu Fengguang wrote:
> net/netfilter/x_tables.c:716:59-60: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Thanks, I will fold this into the original patch.

> ---
> 
>  x_tables.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/net/netfilter/x_tables.c
> +++ b/net/netfilter/x_tables.c
> @@ -713,7 +713,7 @@ EXPORT_SYMBOL(xt_check_entry_offsets);
>  unsigned int *xt_alloc_entry_offsets(unsigned int size)
>  {
>  	if (size < (SIZE_MAX / sizeof(unsigned int)))
> -		return kvmalloc(size * sizeof(unsigned int), GFP_KERNEL);;
> +		return kvmalloc(size * sizeof(unsigned int), GFP_KERNEL);
>  
>  	return NULL;
>  

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-07  9:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-07  3:26 [memcg:cleanups/kvmalloc 2/5] net/netfilter/x_tables.c:716:59-60: Unneeded semicolon kbuild test robot
2017-01-07  3:26 ` [PATCH] treewide: fix semicolon.cocci warnings kbuild test robot
2017-01-07  3:26   ` kbuild test robot
2017-01-07  9:23   ` Michal Hocko
2017-01-07  9:23     ` Michal Hocko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.