From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Jan Beulich <jbeulich@suse.com>,
Anthony PERARD <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] get_maintainer.pl: Teach brace expansion
Date: Tue, 10 Jan 2017 10:29:13 +0000 [thread overview]
Message-ID: <20170110102913.GC16406@citrix.com> (raw)
In-Reply-To: <22643.48153.345281.936196@mariner.uk.xensource.com>
On Mon, Jan 09, 2017 at 04:36:41PM +0000, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH v2] get_maintainer.pl: Teach brace expansion"):
> > It is done by using two different regex, the first one will take care of
> > converting ',' inside '{}' to a '|', one by one, as long as there is at
> > least two commas. The second regex will do the final convertion of '{,}'
> > to '(|)'.
>
> What a palaver.
>
> I don't want to nitpick your Perl code. I'm basically fine with
> anything here so long as it currently gives right answers.
>
> But I wondered if you know about the /x and /e modifiers on perl
> regexps.
>
> Anyway,
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-01-10 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 15:22 [PATCH v2] get_maintainer.pl: Teach brace expansion Anthony PERARD
2017-01-09 15:36 ` Doug Goldstein
2017-01-09 16:36 ` Ian Jackson
2017-01-10 10:29 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110102913.GC16406@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.