From: Doug Goldstein <cardoe@cardoe.com>
To: Anthony PERARD <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2] get_maintainer.pl: Teach brace expansion
Date: Mon, 9 Jan 2017 09:36:59 -0600 [thread overview]
Message-ID: <2e69618f-5aba-beee-647a-3e3ed144c7f1@cardoe.com> (raw)
In-Reply-To: <20170109152232.13012-1-anthony.perard@citrix.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1341 bytes --]
On 1/9/17 9:22 AM, Anthony PERARD wrote:
> Simpler non-nested brace expansion.
>
> Some entries in the MAINTAINER are not understood by the script, the
> ones that contain {,}. This patch fixes it.
>
> This will convert brace expansion style use in MAINTAINER into a regex
> that get_maintainer.pl can use to match a path again a maintainer
> section.
>
> It is done by using two different regex, the first one will take care of
> converting ',' inside '{}' to a '|', one by one, as long as there is at
> least two commas. The second regex will do the final convertion of '{,}'
> to '(|)'.
>
> With the patch, the right maintainers are displayed, instead of "THE
> REST" maintainers, when using the following command for e.g.
> $ ./scripts/get_maintainer.pl -f docs/misc/kconfig.txt
>
> The patch also get rid of the warnings, with recent perl:
> Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/^docs/misc/kconfig{ <-- HERE ,-language}\.txt/ at ./scripts/get_maintainer.pl line 731.
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Tested-by: Doug Goldstein <cardoe@cardoe.com>
I won't pretend to say I know Perl so I didn't read the changes but I
did test them and all is well and it gets rid of warnings on my machine.
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-09 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 15:22 [PATCH v2] get_maintainer.pl: Teach brace expansion Anthony PERARD
2017-01-09 15:36 ` Doug Goldstein [this message]
2017-01-09 16:36 ` Ian Jackson
2017-01-10 10:29 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e69618f-5aba-beee-647a-3e3ed144c7f1@cardoe.com \
--to=cardoe@cardoe.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.