All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Matt Fleming <matt@codeblueprint.co.uk>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, Nicolai Stange <nicstange@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	hpa@zytor.com, Dan Williams <dan.j.williams@intel.com>,
	mika.penttila@nextfour.com, bhsharma@redhat.com
Subject: Re: [PATCH 2/4] efi/x86: move efi bgrt init code to early init code
Date: Thu, 12 Jan 2017 17:56:49 +0800	[thread overview]
Message-ID: <20170112095649.GA5045@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20170112094214.909117564@redhat.com>

[snip]
> --- linux-x86.orig/drivers/acpi/bgrt.c
> +++ linux-x86/drivers/acpi/bgrt.c

[snip]
>  
> @@ -84,9 +85,17 @@ static int __init bgrt_init(void)
>  {
>  	int ret;
>  
> -	if (!bgrt_image)
> +	if (!bgrt_tab.image_address)
>  		return -ENODEV;
>  
> +	bgrt_image = memremap(bgrt_tab.image_address, bgrt_image_size,
> +			      MEMREMAP_WB);
> +	if (!bgrt_image) {
> +		pr_notice("Ignoring BGRT: failed to map image memory\n");
> +		bgrt_image = NULL;
> +		return -ENOMEM;
> +	}
> +

Oops, later error path need unmap bgrt_image, will update in next
version after collecting more comments.

Also bgrt_image = NULL is useless, will drop it.

>  	bin_attr_image.private = bgrt_image;
>  	bin_attr_image.size = bgrt_image_size;
>  

Thanks
Dave

  reply	other threads:[~2017-01-12  9:57 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12  9:41 [PATCH 0/4] efi/x86: move efi bgrt init code to early init Dave Young
2017-01-12  9:41 ` [PATCH 1/4] efi/x86: make efi_memmap_reserve only insert into boot mem areas Dave Young
2017-01-12  9:41   ` Dave Young
2017-01-12 11:15   ` Nicolai Stange
2017-01-12 11:15     ` Nicolai Stange
2017-01-12 21:29     ` Dave Young
2017-01-12 21:29       ` Dave Young
2017-01-27 14:48       ` Matt Fleming
2017-01-27 17:04         ` Ard Biesheuvel
2017-01-27 17:04           ` Ard Biesheuvel
2017-01-27 22:13           ` Matt Fleming
2017-01-27 22:13             ` Matt Fleming
2017-01-27 22:15             ` Ard Biesheuvel
2017-01-27 22:15               ` Ard Biesheuvel
2017-01-12 16:15   ` Ard Biesheuvel
2017-01-12 16:15     ` Ard Biesheuvel
2017-01-12 21:20     ` Dave Young
2017-01-12 21:20       ` Dave Young
2017-01-13  8:10       ` Dave Young
2017-01-12  9:41 ` [PATCH 2/4] efi/x86: move efi bgrt init code to early init code Dave Young
2017-01-12  9:56   ` Dave Young [this message]
2017-01-12 11:54   ` Nicolai Stange
2017-01-12 11:54     ` Nicolai Stange
2017-01-12 21:39     ` Dave Young
2017-01-12 23:11       ` Nicolai Stange
2017-01-12 23:11         ` Nicolai Stange
2017-01-13  2:21         ` Dave Young
2017-01-13  3:04           ` Dave Young
2017-01-13  3:04             ` Dave Young
2017-01-13 12:21             ` Nicolai Stange
2017-01-13 12:21               ` Nicolai Stange
2017-01-16  2:55               ` Dave Young
2017-01-16  2:55                 ` Dave Young
2017-01-12 16:20   ` Ard Biesheuvel
2017-01-12 16:20     ` Ard Biesheuvel
2017-01-12 21:33     ` Dave Young
2017-01-12 21:33       ` Dave Young
2017-01-16 15:15       ` Bhupesh Sharma
2017-01-17 17:00         ` Ard Biesheuvel
2017-01-12  9:41 ` [PATCH 3/4] efi/x86: move efi_print_memmap to drivers/firmware/efi/memmap.c Dave Young
2017-01-12  9:41   ` Dave Young
2017-01-12 12:08   ` Nicolai Stange
2017-01-12 21:40     ` Dave Young
2017-01-12  9:41 ` [PATCH 4/4] efi/x86: add debug code to print cooked memmap Dave Young
2017-01-12 16:18   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170112095649.GA5045@dhcp-128-65.nay.redhat.com \
    --to=dyoung@redhat.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bhsharma@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mika.penttila@nextfour.com \
    --cc=mingo@kernel.org \
    --cc=nicstange@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.