From: Nicolai Stange <nicstange@gmail.com> To: Dave Young <dyoung@redhat.com> Cc: Matt Fleming <matt@codeblueprint.co.uk>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Nicolai Stange <nicstange@gmail.com>, Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, hpa@zytor.com, Dan Williams <dan.j.williams@intel.com>, mika.penttila@nextfour.com, bhsharma@redhat.com Subject: Re: [PATCH 1/4] efi/x86: make efi_memmap_reserve only insert into boot mem areas Date: Thu, 12 Jan 2017 12:15:50 +0100 [thread overview] Message-ID: <87r348r0k9.fsf@gmail.com> (raw) In-Reply-To: <20170112094214.860924858@redhat.com> (Dave Young's message of "Thu, 12 Jan 2017 17:41:19 +0800") Hi Dave, On Thu, Jan 12 2017, Dave Young wrote: > efi_mem_reserve cares only about boot services regions and maybe loader areas. > So add a new argument to efi_memmap_insert for this purpose. Please see below. > --- linux-x86.orig/drivers/firmware/efi/memmap.c > +++ linux-x86/drivers/firmware/efi/memmap.c > @@ -213,7 +213,7 @@ int __init efi_memmap_split_count(efi_me > * to see how large @buf needs to be. > */ > void __init efi_memmap_insert(struct efi_memory_map *old_memmap, void *buf, > - struct efi_mem_range *mem) > + struct efi_mem_range *mem, bool boot_only) > { > u64 m_start, m_end, m_attr; > efi_memory_desc_t *md; > @@ -246,6 +246,12 @@ void __init efi_memmap_insert(struct efi > start = md->phys_addr; > end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1; > > + if (boot_only && !(md->type == EFI_LOADER_DATA || > + md->type == EFI_LOADER_CODE || > + md->type == EFI_BOOT_SERVICES_CODE || > + md->type == EFI_BOOT_SERVICES_DATA)) > + continue; > + Actually, the efi_mem_desc_lookup() called from efi_arch_memmap_reserve() will only return mds not satisfying the following condition: if (!(md->attribute & EFI_MEMORY_RUNTIME) && md->type != EFI_BOOT_SERVICES_DATA && md->type != EFI_RUNTIME_SERVICES_DATA) { continue; } Furthermore, efi_arch_mem_reserve() will only accept ranges fully contained within such a region. I think we can make efi_arch_mem_reserve() return early if EFI_MEMORY_RUNTIME has been set already and thus, neglect this case in efi_memmap_insert(). I suppose that we don't want to reserve within EFI_RUNTIME_SERVICES_DATA regions in efi_mem_reserve() either -- these won't ever get made available as general memory anyway [1]. So efi_arch_mem_reserve() should return early here as well imo. So, what would remain to be handled from efi_memmap_insert() in case of boot_only would be EFI_BOOT_SERVICES_DATA only? (As a sidenote, Matt pointed out at [1] that the EFI_LOADER_* regions should be reserved early through memblock_reserve() and not through efi_mem_reserve()). Thanks, Nicolai [1] http://lkml.kernel.org/r/20170109130702.GI16838@codeblueprint.co.uk
WARNING: multiple messages have this Message-ID (diff)
From: Nicolai Stange <nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>, Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Nicolai Stange <nicstange-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, mika.penttila-MRsr7dthA9VWk0Htik3J/w@public.gmane.org, bhsharma-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Subject: Re: [PATCH 1/4] efi/x86: make efi_memmap_reserve only insert into boot mem areas Date: Thu, 12 Jan 2017 12:15:50 +0100 [thread overview] Message-ID: <87r348r0k9.fsf@gmail.com> (raw) In-Reply-To: <20170112094214.860924858-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> (Dave Young's message of "Thu, 12 Jan 2017 17:41:19 +0800") Hi Dave, On Thu, Jan 12 2017, Dave Young wrote: > efi_mem_reserve cares only about boot services regions and maybe loader areas. > So add a new argument to efi_memmap_insert for this purpose. Please see below. > --- linux-x86.orig/drivers/firmware/efi/memmap.c > +++ linux-x86/drivers/firmware/efi/memmap.c > @@ -213,7 +213,7 @@ int __init efi_memmap_split_count(efi_me > * to see how large @buf needs to be. > */ > void __init efi_memmap_insert(struct efi_memory_map *old_memmap, void *buf, > - struct efi_mem_range *mem) > + struct efi_mem_range *mem, bool boot_only) > { > u64 m_start, m_end, m_attr; > efi_memory_desc_t *md; > @@ -246,6 +246,12 @@ void __init efi_memmap_insert(struct efi > start = md->phys_addr; > end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1; > > + if (boot_only && !(md->type == EFI_LOADER_DATA || > + md->type == EFI_LOADER_CODE || > + md->type == EFI_BOOT_SERVICES_CODE || > + md->type == EFI_BOOT_SERVICES_DATA)) > + continue; > + Actually, the efi_mem_desc_lookup() called from efi_arch_memmap_reserve() will only return mds not satisfying the following condition: if (!(md->attribute & EFI_MEMORY_RUNTIME) && md->type != EFI_BOOT_SERVICES_DATA && md->type != EFI_RUNTIME_SERVICES_DATA) { continue; } Furthermore, efi_arch_mem_reserve() will only accept ranges fully contained within such a region. I think we can make efi_arch_mem_reserve() return early if EFI_MEMORY_RUNTIME has been set already and thus, neglect this case in efi_memmap_insert(). I suppose that we don't want to reserve within EFI_RUNTIME_SERVICES_DATA regions in efi_mem_reserve() either -- these won't ever get made available as general memory anyway [1]. So efi_arch_mem_reserve() should return early here as well imo. So, what would remain to be handled from efi_memmap_insert() in case of boot_only would be EFI_BOOT_SERVICES_DATA only? (As a sidenote, Matt pointed out at [1] that the EFI_LOADER_* regions should be reserved early through memblock_reserve() and not through efi_mem_reserve()). Thanks, Nicolai [1] http://lkml.kernel.org/r/20170109130702.GI16838-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org
next prev parent reply other threads:[~2017-01-12 11:15 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-12 9:41 [PATCH 0/4] efi/x86: move efi bgrt init code to early init Dave Young 2017-01-12 9:41 ` [PATCH 1/4] efi/x86: make efi_memmap_reserve only insert into boot mem areas Dave Young 2017-01-12 9:41 ` Dave Young 2017-01-12 11:15 ` Nicolai Stange [this message] 2017-01-12 11:15 ` Nicolai Stange 2017-01-12 21:29 ` Dave Young 2017-01-12 21:29 ` Dave Young 2017-01-27 14:48 ` Matt Fleming 2017-01-27 17:04 ` Ard Biesheuvel 2017-01-27 17:04 ` Ard Biesheuvel 2017-01-27 22:13 ` Matt Fleming 2017-01-27 22:13 ` Matt Fleming 2017-01-27 22:15 ` Ard Biesheuvel 2017-01-27 22:15 ` Ard Biesheuvel 2017-01-12 16:15 ` Ard Biesheuvel 2017-01-12 16:15 ` Ard Biesheuvel 2017-01-12 21:20 ` Dave Young 2017-01-12 21:20 ` Dave Young 2017-01-13 8:10 ` Dave Young 2017-01-12 9:41 ` [PATCH 2/4] efi/x86: move efi bgrt init code to early init code Dave Young 2017-01-12 9:56 ` Dave Young 2017-01-12 11:54 ` Nicolai Stange 2017-01-12 11:54 ` Nicolai Stange 2017-01-12 21:39 ` Dave Young 2017-01-12 23:11 ` Nicolai Stange 2017-01-12 23:11 ` Nicolai Stange 2017-01-13 2:21 ` Dave Young 2017-01-13 3:04 ` Dave Young 2017-01-13 3:04 ` Dave Young 2017-01-13 12:21 ` Nicolai Stange 2017-01-13 12:21 ` Nicolai Stange 2017-01-16 2:55 ` Dave Young 2017-01-16 2:55 ` Dave Young 2017-01-12 16:20 ` Ard Biesheuvel 2017-01-12 16:20 ` Ard Biesheuvel 2017-01-12 21:33 ` Dave Young 2017-01-12 21:33 ` Dave Young 2017-01-16 15:15 ` Bhupesh Sharma 2017-01-17 17:00 ` Ard Biesheuvel 2017-01-12 9:41 ` [PATCH 3/4] efi/x86: move efi_print_memmap to drivers/firmware/efi/memmap.c Dave Young 2017-01-12 9:41 ` Dave Young 2017-01-12 12:08 ` Nicolai Stange 2017-01-12 21:40 ` Dave Young 2017-01-12 9:41 ` [PATCH 4/4] efi/x86: add debug code to print cooked memmap Dave Young 2017-01-12 16:18 ` Ard Biesheuvel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87r348r0k9.fsf@gmail.com \ --to=nicstange@gmail.com \ --cc=ard.biesheuvel@linaro.org \ --cc=bhsharma@redhat.com \ --cc=dan.j.williams@intel.com \ --cc=dyoung@redhat.com \ --cc=hpa@zytor.com \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=matt@codeblueprint.co.uk \ --cc=mika.penttila@nextfour.com \ --cc=mingo@kernel.org \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.