* [PATCH -next] soc: ti: wkup_m3_ipc: Fix error return code in wkup_m3_ipc_probe()
@ 2017-01-12 14:53 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2017-01-12 14:53 UTC (permalink / raw)
To: Santosh Shilimkar, Dave Gerlach, Tony Lindgren
Cc: Wei Yongjun, linux-kernel, linux-arm-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return a negative error code from the kthread_run() error
handling case instead of 0, as done elsewhere in this function.
Fixes: cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/soc/ti/wkup_m3_ipc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index 8bfa44b..369aef5 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -457,6 +457,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
if (IS_ERR(task)) {
dev_err(dev, "can't create rproc_boot thread\n");
+ ret = PTR_ERR(task);
goto err_put_rproc;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] soc: ti: wkup_m3_ipc: Fix error return code in wkup_m3_ipc_probe()
@ 2017-01-12 14:53 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2017-01-12 14:53 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return a negative error code from the kthread_run() error
handling case instead of 0, as done elsewhere in this function.
Fixes: cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/soc/ti/wkup_m3_ipc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index 8bfa44b..369aef5 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -457,6 +457,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
if (IS_ERR(task)) {
dev_err(dev, "can't create rproc_boot thread\n");
+ ret = PTR_ERR(task);
goto err_put_rproc;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] soc: ti: wkup_m3_ipc: Fix error return code in wkup_m3_ipc_probe()
2017-01-12 14:53 ` Wei Yongjun
@ 2017-01-12 21:38 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2017-01-12 21:38 UTC (permalink / raw)
To: Wei Yongjun
Cc: Santosh Shilimkar, Dave Gerlach, Wei Yongjun, linux-kernel,
linux-arm-kernel
* Wei Yongjun <weiyj.lk@gmail.com> [170112 06:55]:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the kthread_run() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/soc/ti/wkup_m3_ipc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8bfa44b..369aef5 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -457,6 +457,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
>
> if (IS_ERR(task)) {
> dev_err(dev, "can't create rproc_boot thread\n");
> + ret = PTR_ERR(task);
> goto err_put_rproc;
> }
>
>
Applying into omap-for-v4.10/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] soc: ti: wkup_m3_ipc: Fix error return code in wkup_m3_ipc_probe()
@ 2017-01-12 21:38 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2017-01-12 21:38 UTC (permalink / raw)
To: linux-arm-kernel
* Wei Yongjun <weiyj.lk@gmail.com> [170112 06:55]:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the kthread_run() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/soc/ti/wkup_m3_ipc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8bfa44b..369aef5 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -457,6 +457,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
>
> if (IS_ERR(task)) {
> dev_err(dev, "can't create rproc_boot thread\n");
> + ret = PTR_ERR(task);
> goto err_put_rproc;
> }
>
>
Applying into omap-for-v4.10/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-12 21:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-12 14:53 [PATCH -next] soc: ti: wkup_m3_ipc: Fix error return code in wkup_m3_ipc_probe() Wei Yongjun
2017-01-12 14:53 ` Wei Yongjun
2017-01-12 21:38 ` Tony Lindgren
2017-01-12 21:38 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.