* [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int
@ 2017-01-13 21:06 Colin King
2017-01-14 16:48 ` Nishanth Menon
2017-01-16 15:45 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Colin King @ 2017-01-13 21:06 UTC (permalink / raw)
To: Linus Walleij, Nishanth Menon, Lokesh Vutla, Rob Herring, linux-gpio
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
pin is an unsigned int and therefore can never be < 0 so
this check is redundant. Remove the check and the associated
dev_err error message.
Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
index 3b86d3d..a345166 100644
--- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
+++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
@@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
r = iod->reg_data;
offset = ti_iodelay_pin_to_offset(iod, pin);
- if (pin < 0) {
- dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
-
- return;
- }
-
pd = &iod->pa[pin];
cfg = pd->drv_data;
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int
2017-01-13 21:06 [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int Colin King
@ 2017-01-14 16:48 ` Nishanth Menon
2017-01-16 15:45 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2017-01-14 16:48 UTC (permalink / raw)
To: Colin King, Linus Walleij, Lokesh Vutla, Rob Herring, linux-gpio
Cc: linux-kernel
On 01/13/2017 03:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> pin is an unsigned int and therefore can never be < 0 so
> this check is redundant. Remove the check and the associated
> dev_err error message.
>
> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> index 3b86d3d..a345166 100644
> --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> @@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
> r = iod->reg_data;
>
> offset = ti_iodelay_pin_to_offset(iod, pin);
> - if (pin < 0) {
> - dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
> -
> - return;
> - }
> -
> pd = &iod->pa[pin];
> cfg = pd->drv_data;
>
>
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int
@ 2017-01-14 16:48 ` Nishanth Menon
0 siblings, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2017-01-14 16:48 UTC (permalink / raw)
To: Colin King, Linus Walleij, Lokesh Vutla, Rob Herring, linux-gpio
Cc: linux-kernel
On 01/13/2017 03:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> pin is an unsigned int and therefore can never be < 0 so
> this check is redundant. Remove the check and the associated
> dev_err error message.
>
> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> index 3b86d3d..a345166 100644
> --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> @@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
> r = iod->reg_data;
>
> offset = ti_iodelay_pin_to_offset(iod, pin);
> - if (pin < 0) {
> - dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
> -
> - return;
> - }
> -
> pd = &iod->pa[pin];
> cfg = pd->drv_data;
>
>
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int
2017-01-13 21:06 [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int Colin King
2017-01-14 16:48 ` Nishanth Menon
@ 2017-01-16 15:45 ` Rob Herring
2017-01-16 15:52 ` Colin Ian King
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2017-01-16 15:45 UTC (permalink / raw)
To: Colin King
Cc: Linus Walleij, Nishanth Menon, Lokesh Vutla, linux-gpio, linux-kernel
On Fri, Jan 13, 2017 at 3:06 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> pin is an unsigned int and therefore can never be < 0 so
> this check is redundant. Remove the check and the associated
> dev_err error message.
Not sure why I got copied on this...
> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------
This file doesn't exist in mainline.
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> index 3b86d3d..a345166 100644
> --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> @@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
> r = iod->reg_data;
>
> offset = ti_iodelay_pin_to_offset(iod, pin);
> - if (pin < 0) {
Shouldn't this be "if (offset < 0)"?
> - dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
> -
> - return;
> - }
> -
> pd = &iod->pa[pin];
> cfg = pd->drv_data;
>
> --
> 2.10.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int
2017-01-16 15:45 ` Rob Herring
@ 2017-01-16 15:52 ` Colin Ian King
0 siblings, 0 replies; 5+ messages in thread
From: Colin Ian King @ 2017-01-16 15:52 UTC (permalink / raw)
To: Rob Herring
Cc: Linus Walleij, Nishanth Menon, Lokesh Vutla, linux-gpio, linux-kernel
On 16/01/17 15:45, Rob Herring wrote:
> On Fri, Jan 13, 2017 at 3:06 PM, Colin King <colin.king@canonical.com> wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> pin is an unsigned int and therefore can never be < 0 so
>> this check is redundant. Remove the check and the associated
>> dev_err error message.
>
> Not sure why I got copied on this...
>
>> Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------
>
> This file doesn't exist in mainline.
>
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
>> index 3b86d3d..a345166 100644
>> --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
>> +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
>> @@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
>> r = iod->reg_data;
>>
>> offset = ti_iodelay_pin_to_offset(iod, pin);
>> - if (pin < 0) {
>
> Shouldn't this be "if (offset < 0)"?
Yep. However if the code was correct and using offset:
if (offset < 0) {
...
then we still get the same issue, that is, offset is unsigned so that
comparison is redundant since it can't be < 0. Perhaps I should re-send
a V3 with an updated commit message.
>
>
>> - dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
>> -
>> - return;
>> - }
>> -
>> pd = &iod->pa[pin];
>> cfg = pd->drv_data;
>>
>> --
>> 2.10.2
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-16 15:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-13 21:06 [PATCH][V2] pinctrl: ti-iodelay: remove redundant pin < 0 check on unsigned int Colin King
2017-01-14 16:48 ` Nishanth Menon
2017-01-14 16:48 ` Nishanth Menon
2017-01-16 15:45 ` Rob Herring
2017-01-16 15:52 ` Colin Ian King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.