From: Michal Hocko <mhocko@kernel.org> To: Borislav Petkov <bp@alien8.de> Cc: Vlastimil Babka <vbabka@suse.cz>, Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Date: Mon, 16 Jan 2017 10:38:47 +0100 [thread overview] Message-ID: <20170116093846.GD13641@dhcp22.suse.cz> (raw) In-Reply-To: <20170116091643.15260-1-bp@alien8.de> [Let's add Andrew] On Mon 16-01-17 10:16:43, Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > We wanna know who's doing such a thing. Like slab.c does that. Yes this was an omission on my side in 72baeef0c271 ("slab: do not panic on invalid gfp_mask"). > > Signed-off-by: Borislav Petkov <bp@suse.de> Acked-by: Michal Hocko <mhocko@suse.com> Thanks! > --- > mm/slub.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/slub.c b/mm/slub.c > index 067598a00849..1b0fa7625d6d 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1623,6 +1623,7 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node) > flags &= ~GFP_SLAB_BUG_MASK; > pr_warn("Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n", > invalid_mask, &invalid_mask, flags, &flags); > + dump_stack(); > } > > return allocate_slab(s, > -- > 2.11.0 -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Borislav Petkov <bp@alien8.de> Cc: Vlastimil Babka <vbabka@suse.cz>, Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Date: Mon, 16 Jan 2017 10:38:47 +0100 [thread overview] Message-ID: <20170116093846.GD13641@dhcp22.suse.cz> (raw) In-Reply-To: <20170116091643.15260-1-bp@alien8.de> [Let's add Andrew] On Mon 16-01-17 10:16:43, Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > We wanna know who's doing such a thing. Like slab.c does that. Yes this was an omission on my side in 72baeef0c271 ("slab: do not panic on invalid gfp_mask"). > > Signed-off-by: Borislav Petkov <bp@suse.de> Acked-by: Michal Hocko <mhocko@suse.com> Thanks! > --- > mm/slub.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/slub.c b/mm/slub.c > index 067598a00849..1b0fa7625d6d 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1623,6 +1623,7 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node) > flags &= ~GFP_SLAB_BUG_MASK; > pr_warn("Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n", > invalid_mask, &invalid_mask, flags, &flags); > + dump_stack(); > } > > return allocate_slab(s, > -- > 2.11.0 -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-16 9:38 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-16 9:16 [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Borislav Petkov 2017-01-16 9:28 ` Leon Romanovsky 2017-01-16 9:37 ` Borislav Petkov 2017-01-16 9:48 ` Leon Romanovsky 2017-01-16 9:55 ` Borislav Petkov 2017-01-16 10:09 ` Leon Romanovsky 2017-01-16 10:13 ` Borislav Petkov 2017-01-16 10:18 ` Leon Romanovsky 2017-01-16 9:59 ` Michal Hocko 2017-01-16 9:59 ` Michal Hocko 2017-01-16 9:38 ` Michal Hocko [this message] 2017-01-16 9:38 ` Michal Hocko 2017-01-16 10:08 ` Vlastimil Babka 2017-01-16 10:08 ` Vlastimil Babka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170116093846.GD13641@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.