From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Ken Goldman <kgoldman@us.ibm.com>
Cc: linux-security-module@vger.kernel.org,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces
Date: Mon, 16 Jan 2017 11:52:36 +0200 [thread overview]
Message-ID: <20170116095236.dlhqf4ghv2xv2sas@intel.com> (raw)
In-Reply-To: <o5dohv$60l$1@blaine.gmane.org>
On Sat, Jan 14, 2017 at 12:53:15PM -0500, Ken Goldman wrote:
> On 1/13/2017 11:28 AM, Jarkko Sakkinen wrote:
>
> > > > +
> > > > + if (!tpm2_find_cc_attrs(chip, cc, &attrs)) {
> > > > + /* should never happen */
> > > > + dev_err(&chip->dev, "TPM returned a different CC:
> > > > 0x%04x\n",
> > > > + cc);
> > > > + rc = -EFAULT;
> > > > + goto out_err;
> > > > + }
>
> Something is strange here. Is "CC" command code?
>
> The TPM does not return a command code. The mapping should use the
> command code from the command.
>
> It could be the code is correct - the command code mapped OK in the command
> but then failed in the response. But the error message is strange.
Thanks. I'll update that message.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Ken Goldman <kgoldman-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces
Date: Mon, 16 Jan 2017 11:52:36 +0200 [thread overview]
Message-ID: <20170116095236.dlhqf4ghv2xv2sas@intel.com> (raw)
In-Reply-To: <o5dohv$60l$1@blaine.gmane.org>
On Sat, Jan 14, 2017 at 12:53:15PM -0500, Ken Goldman wrote:
> On 1/13/2017 11:28 AM, Jarkko Sakkinen wrote:
>
> > > > +
> > > > + if (!tpm2_find_cc_attrs(chip, cc, &attrs)) {
> > > > + /* should never happen */
> > > > + dev_err(&chip->dev, "TPM returned a different CC:
> > > > 0x%04x\n",
> > > > + cc);
> > > > + rc = -EFAULT;
> > > > + goto out_err;
> > > > + }
>
> Something is strange here. Is "CC" command code?
>
> The TPM does not return a command code. The mapping should use the
> command code from the command.
>
> It could be the code is correct - the command code mapped OK in the command
> but then failed in the response. But the error message is strange.
Thanks. I'll update that message.
/Jarkko
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
next prev parent reply other threads:[~2017-01-16 9:52 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 17:46 [PATCH RFC v2 0/5] RFC: in-kernel resource manager Jarkko Sakkinen
2017-01-12 17:46 ` Jarkko Sakkinen
2017-01-12 17:46 ` [PATCH RFC v2 1/5] tpm: validate TPM 2.0 commands Jarkko Sakkinen
2017-01-12 17:46 ` Jarkko Sakkinen
2017-01-12 20:34 ` Jarkko Sakkinen
2017-01-12 17:46 ` [PATCH RFC v2 2/5] tpm: export tpm2_flush_context_cmd Jarkko Sakkinen
2017-01-12 17:46 ` Jarkko Sakkinen
2017-01-12 17:46 ` [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces Jarkko Sakkinen
2017-01-12 17:46 ` Jarkko Sakkinen
2017-01-12 18:38 ` [tpmdd-devel] " James Bottomley
2017-01-12 18:38 ` James Bottomley
2017-01-12 20:31 ` [tpmdd-devel] " Jarkko Sakkinen
2017-01-12 20:31 ` Jarkko Sakkinen
2017-01-12 20:38 ` [tpmdd-devel] " James Bottomley
2017-01-13 16:28 ` Jarkko Sakkinen
2017-01-14 17:53 ` Ken Goldman
2017-01-16 9:52 ` Jarkko Sakkinen [this message]
2017-01-16 9:52 ` Jarkko Sakkinen
2017-01-12 20:50 ` Jarkko Sakkinen
2017-01-12 20:50 ` Jarkko Sakkinen
2017-01-13 1:17 ` [tpmdd-devel] " James Bottomley
2017-01-13 16:31 ` Jarkko Sakkinen
2017-01-16 9:09 ` Jarkko Sakkinen
2017-01-16 14:24 ` James Bottomley
2017-01-16 14:48 ` Jarkko Sakkinen
2017-01-16 14:58 ` James Bottomley
2017-01-16 16:52 ` Jarkko Sakkinen
2017-01-12 17:46 ` [PATCH RFC v2 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c Jarkko Sakkinen
2017-01-12 17:46 ` Jarkko Sakkinen
2017-01-13 19:18 ` [tpmdd-devel] " James Bottomley
2017-01-12 17:46 ` [PATCH RFC v2 5/5] tpm2: expose resource manager via a device link /dev/tpms<n> Jarkko Sakkinen
2017-01-12 17:46 ` Jarkko Sakkinen
2017-01-12 18:39 ` Jason Gunthorpe
2017-01-12 18:39 ` Jason Gunthorpe
2017-01-13 19:20 ` [tpmdd-devel] " James Bottomley
2017-01-13 19:47 ` Jason Gunthorpe
2017-01-13 19:47 ` Jason Gunthorpe
2017-01-13 20:02 ` [tpmdd-devel] " James Bottomley
2017-01-13 20:02 ` James Bottomley
2017-01-13 21:23 ` [tpmdd-devel] " Jason Gunthorpe
2017-01-14 1:10 ` James Bottomley
2017-01-16 16:54 ` Jason Gunthorpe
2017-01-12 19:46 ` James Bottomley
2017-01-12 19:46 ` James Bottomley
2017-01-12 20:56 ` Jarkko Sakkinen
2017-01-13 17:25 ` Jason Gunthorpe
2017-01-13 17:40 ` [tpmdd-devel] " James Bottomley
2017-01-13 17:40 ` James Bottomley
2017-01-13 18:01 ` [tpmdd-devel] " Jason Gunthorpe
2017-01-13 18:11 ` James Bottomley
2017-01-16 9:45 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116095236.dlhqf4ghv2xv2sas@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=kgoldman@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.