* [PATCH v1] edac: i82975x_edac :- Handle return NULL error from ioremap_nocache
@ 2017-01-16 6:44 Arvind Yadav
2017-01-16 10:47 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-01-16 6:44 UTC (permalink / raw)
To: ravi, arvino55; +Cc: bp, mchehab, linux-edac, linux-kernel
Here, If ioremap_nocache will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference.
This error check will avoid NULL pointer dereference.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/edac/i82975x_edac.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
index 7baa8ac..e747d82 100644
--- a/drivers/edac/i82975x_edac.c
+++ b/drivers/edac/i82975x_edac.c
@@ -494,6 +494,10 @@ static int i82975x_probe1(struct pci_dev *pdev, int dev_idx)
}
mchbar &= 0xffffc000; /* bits 31:14 used for 16K window */
mch_window = ioremap_nocache(mchbar, 0x1000);
+ if (!mch_window) {
+ edac_dbg(3, "failed to memory map!\n");
+ goto fail0;
+ }
#ifdef i82975x_DEBUG_IOMEM
i82975x_printk(KERN_INFO, "MCHBAR real = %0x, remapped = %p\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] edac: i82975x_edac :- Handle return NULL error from ioremap_nocache
2017-01-16 6:44 [PATCH v1] edac: i82975x_edac :- Handle return NULL error from ioremap_nocache Arvind Yadav
@ 2017-01-16 10:47 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2017-01-16 10:47 UTC (permalink / raw)
To: Arvind Yadav; +Cc: ravi, arvino55, mchehab, linux-edac, linux-kernel
On Mon, Jan 16, 2017 at 12:14:52PM +0530, Arvind Yadav wrote:
> Here, If ioremap_nocache will fail. It will return NULL.
> Kernel can run into a NULL-pointer dereference.
> This error check will avoid NULL pointer dereference.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/edac/i82975x_edac.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c
> index 7baa8ac..e747d82 100644
> --- a/drivers/edac/i82975x_edac.c
> +++ b/drivers/edac/i82975x_edac.c
> @@ -494,6 +494,10 @@ static int i82975x_probe1(struct pci_dev *pdev, int dev_idx)
> }
> mchbar &= 0xffffc000; /* bits 31:14 used for 16K window */
> mch_window = ioremap_nocache(mchbar, 0x1000);
> + if (!mch_window) {
> + edac_dbg(3, "failed to memory map!\n");
> + goto fail0;
> + }
>
> #ifdef i82975x_DEBUG_IOMEM
> i82975x_printk(KERN_INFO, "MCHBAR real = %0x, remapped = %p\n",
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-16 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-16 6:44 [PATCH v1] edac: i82975x_edac :- Handle return NULL error from ioremap_nocache Arvind Yadav
2017-01-16 10:47 ` Borislav Petkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.