* [PATCH] net/mlx5: lift Rx RSS indirection table size limit
@ 2017-01-17 2:06 Yongseok Koh
2017-01-18 0:39 ` [PATCH v2] " Yongseok Koh
0 siblings, 1 reply; 4+ messages in thread
From: Yongseok Koh @ 2017-01-17 2:06 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, adrien.mazarguil, Yongseok Koh
The size of Rx RSS indirection table was limited by 256, but it is not
needed anymore.
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 4 ----
drivers/net/mlx5/mlx5_defs.h | 3 ---
2 files changed, 7 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index d936e7215..414646b66 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -552,10 +552,6 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
(priv->hw_csum_l2tun ? "" : "not "));
priv->ind_table_max_size = exp_device_attr.rx_hash_caps.max_rwq_indirection_table_size;
- /* Remove this check once DPDK supports larger/variable
- * indirection tables. */
- if (priv->ind_table_max_size > (unsigned int)RSS_INDIRECTION_TABLE_SIZE)
- priv->ind_table_max_size = RSS_INDIRECTION_TABLE_SIZE;
DEBUG("maximum RX indirection table size is %u",
priv->ind_table_max_size);
priv->hw_vlan_strip = !!(exp_device_attr.wq_vlan_offloads_cap &
diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
index b32816e6d..5e36c8035 100644
--- a/drivers/net/mlx5/mlx5_defs.h
+++ b/drivers/net/mlx5/mlx5_defs.h
@@ -54,9 +54,6 @@
*/
#define MLX5_TX_COMP_THRESH 32
-/* RSS Indirection table size. */
-#define RSS_INDIRECTION_TABLE_SIZE 256
-
/*
* Maximum number of cached Memory Pools (MPs) per TX queue. Each RTE MP
* from which buffers are to be transmitted will have to be mapped by this
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] net/mlx5: lift Rx RSS indirection table size limit
2017-01-17 2:06 [PATCH] net/mlx5: lift Rx RSS indirection table size limit Yongseok Koh
@ 2017-01-18 0:39 ` Yongseok Koh
2017-01-20 16:57 ` Adrien Mazarguil
0 siblings, 1 reply; 4+ messages in thread
From: Yongseok Koh @ 2017-01-18 0:39 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, adrien.mazarguil, Yongseok Koh
The size of Rx RSS indirection table was limited by 256, but it is not
required anymore for all Mellanox NICs. However, the librte_ether still
limits the size by 512.
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 5 +++--
drivers/net/mlx5/mlx5_defs.h | 3 ---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 7d40b2445..109d9572d 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -557,8 +557,9 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
priv->ind_table_max_size = exp_device_attr.rx_hash_caps.max_rwq_indirection_table_size;
/* Remove this check once DPDK supports larger/variable
* indirection tables. */
- if (priv->ind_table_max_size > (unsigned int)RSS_INDIRECTION_TABLE_SIZE)
- priv->ind_table_max_size = RSS_INDIRECTION_TABLE_SIZE;
+ if (priv->ind_table_max_size >
+ (unsigned int)ETH_RSS_RETA_SIZE_512)
+ priv->ind_table_max_size = ETH_RSS_RETA_SIZE_512;
DEBUG("maximum RX indirection table size is %u",
priv->ind_table_max_size);
priv->hw_vlan_strip = !!(exp_device_attr.wq_vlan_offloads_cap &
diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
index beabb7037..e91d2454a 100644
--- a/drivers/net/mlx5/mlx5_defs.h
+++ b/drivers/net/mlx5/mlx5_defs.h
@@ -54,9 +54,6 @@
*/
#define MLX5_TX_COMP_THRESH 32
-/* RSS Indirection table size. */
-#define RSS_INDIRECTION_TABLE_SIZE 256
-
/*
* Maximum number of cached Memory Pools (MPs) per TX queue. Each RTE MP
* from which buffers are to be transmitted will have to be mapped by this
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net/mlx5: lift Rx RSS indirection table size limit
2017-01-18 0:39 ` [PATCH v2] " Yongseok Koh
@ 2017-01-20 16:57 ` Adrien Mazarguil
2017-01-20 18:42 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Adrien Mazarguil @ 2017-01-20 16:57 UTC (permalink / raw)
To: Yongseok Koh; +Cc: ferruh.yigit, dev
On Tue, Jan 17, 2017 at 04:39:29PM -0800, Yongseok Koh wrote:
> The size of Rx RSS indirection table was limited by 256, but it is not
> required anymore for all Mellanox NICs. However, the librte_ether still
> limits the size by 512.
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.c | 5 +++--
> drivers/net/mlx5/mlx5_defs.h | 3 ---
> 2 files changed, 3 insertions(+), 5 deletions(-)
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net/mlx5: lift Rx RSS indirection table size limit
2017-01-20 16:57 ` Adrien Mazarguil
@ 2017-01-20 18:42 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-01-20 18:42 UTC (permalink / raw)
To: Adrien Mazarguil, Yongseok Koh; +Cc: dev
On 1/20/2017 4:57 PM, Adrien Mazarguil wrote:
> On Tue, Jan 17, 2017 at 04:39:29PM -0800, Yongseok Koh wrote:
>> The size of Rx RSS indirection table was limited by 256, but it is not
>> required anymore for all Mellanox NICs. However, the librte_ether still
>> limits the size by 512.
>>
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>> ---
>> drivers/net/mlx5/mlx5.c | 5 +++--
>> drivers/net/mlx5/mlx5_defs.h | 3 ---
>> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-20 18:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-17 2:06 [PATCH] net/mlx5: lift Rx RSS indirection table size limit Yongseok Koh
2017-01-18 0:39 ` [PATCH v2] " Yongseok Koh
2017-01-20 16:57 ` Adrien Mazarguil
2017-01-20 18:42 ` Ferruh Yigit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.