[U-Boot] [PATCH 0/2] Update configs for the firefly-rk3288

[U-Boot] [PATCH 0/2] Update configs for the firefly-rk3288

[Romain Perier]

This set of patches enables SPL_BACK_TO_BROM feature that has been
tested on this board. That is preferable if all rk3288-based boards use
the same configuration and boot in the same way. Then, it enables
ethernet address randomization.

Romain Perier (2):
  Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board
  rockchip: Enable ETH address randomization for the firefly-rk3288

 configs/firefly-rk3288_defconfig | 3 +++
 include/configs/firefly-rk3288.h | 9 +++++++++
 2 files changed, 12 insertions(+)

-- 
2.9.3

[U-Boot] [PATCH 1/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

[Romain Perier]

Like the rock2, this board has been tested with back to brom feature.
This commits adjusts environment offset regarding if back_to_brom is
enabled or not and uses this feature by default.

Signed-off-by: Romain Perier <romain.perier@collabora.com>
---
 configs/firefly-rk3288_defconfig | 2 ++
 include/configs/firefly-rk3288.h | 9 +++++++++
 2 files changed, 11 insertions(+)

diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
index 3ed17b4..3aa8bcf 100644
--- a/configs/firefly-rk3288_defconfig
+++ b/configs/firefly-rk3288_defconfig
@@ -2,6 +2,8 @@ CONFIG_ARM=y
 CONFIG_ARCH_ROCKCHIP=y
 CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_ROCKCHIP_RK3288=y
+# CONFIG_SPL_MMC_SUPPORT is not set
+CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y
 CONFIG_TARGET_FIREFLY_RK3288=y
 CONFIG_SPL_STACK_R_ADDR=0x80000
 CONFIG_DEFAULT_DEVICE_TREE="rk3288-firefly"
diff --git a/include/configs/firefly-rk3288.h b/include/configs/firefly-rk3288.h
index 14fdead..b9c2290 100644
--- a/include/configs/firefly-rk3288.h
+++ b/include/configs/firefly-rk3288.h
@@ -16,11 +16,20 @@
 
 #define CONFIG_ENV_IS_IN_MMC
 #define CONFIG_SYS_MMC_ENV_DEV 0
+
+#ifdef CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
+/* SPL @ 32k for 34k
+ * u-boot directly after @ 68k for 400k or so
+ * ENV @ 992k
+ */
+#define CONFIG_ENV_OFFSET ((1024-32) * 1024)
+#else
 /* SPL @ 32k for ~36k
  * ENV @ 96k
  * u-boot @ 128K
  */
 #define CONFIG_ENV_OFFSET (96 * 1024)
+#endif
 
 #define CONFIG_SYS_WHITE_ON_BLACK
 
-- 
2.9.3

[U-Boot] [PATCH 2/2] rockchip: Enable ETH address randomization for the firefly-rk3288

[Romain Perier]

This commit enables ethernet MAC address randomization on the
firefly-rk3288. It removes the error at startup 'ethernet at ff290000
address not set'.

Signed-off-by: Romain Perier <romain.perier@collabora.com>
---
 configs/firefly-rk3288_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
index 3aa8bcf..3fe7add 100644
--- a/configs/firefly-rk3288_defconfig
+++ b/configs/firefly-rk3288_defconfig
@@ -34,6 +34,7 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
 CONFIG_SPL_OF_PLATDATA=y
+CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_REGMAP=y
 CONFIG_SPL_REGMAP=y
 CONFIG_SYSCON=y
-- 
2.9.3

[U-Boot] [PATCH 1/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

[Simon Glass]

On 17 January 2017 at 02:32, Romain Perier <romain.perier@collabora.com> wrote:
> Like the rock2, this board has been tested with back to brom feature.
> This commits adjusts environment offset regarding if back_to_brom is
> enabled or not and uses this feature by default.
>
> Signed-off-by: Romain Perier <romain.perier@collabora.com>
> ---
>  configs/firefly-rk3288_defconfig | 2 ++
>  include/configs/firefly-rk3288.h | 9 +++++++++
>  2 files changed, 11 insertions(+)

We need at least one board that does not use this option. Also,
doesn't this mean that we need to change how the image is written to
the board?

Should we use binman to create a suitable image?

Regards,
Simon

[U-Boot] [PATCH 2/2] rockchip: Enable ETH address randomization for the firefly-rk3288

[Simon Glass]

On 17 January 2017 at 02:32, Romain Perier <romain.perier@collabora.com> wrote:
> This commit enables ethernet MAC address randomization on the
> firefly-rk3288. It removes the error at startup 'ethernet at ff290000
> address not set'.
>
> Signed-off-by: Romain Perier <romain.perier@collabora.com>
> ---
>  configs/firefly-rk3288_defconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH 1/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

[Romain Perier]

Hi,


Le 21/01/2017 ? 04:51, Simon Glass a ?crit :
> On 17 January 2017 at 02:32, Romain Perier <romain.perier@collabora.com> wrote:
>> Like the rock2, this board has been tested with back to brom feature.
>> This commits adjusts environment offset regarding if back_to_brom is
>> enabled or not and uses this feature by default.
>>
>> Signed-off-by: Romain Perier <romain.perier@collabora.com>
>> ---
>>  configs/firefly-rk3288_defconfig | 2 ++
>>  include/configs/firefly-rk3288.h | 9 +++++++++
>>  2 files changed, 11 insertions(+)
> We need at least one board that does not use this option. Also,
> doesn't this mean that we need to change how the image is written to
> the board?
>
> Should we use binman to create a suitable image?
>
> Regards,
> Simon
Why do you want at least one board without this option ? for testing
that it's still working without back_to_brom ? That's weird because all
rk3288-based board has the same limitations regarding the SPL, no ?


Regards,
Romain

[U-Boot] [PATCH 1/2] Enable ROCKCHIP_SPL_BACK_TO_BROM for firefly-rk3288 board

[Simon Glass]

Hi Romain,

On 21 January 2017 at 00:51, Romain Perier <romain.perier@collabora.com> wrote:
> Hi,
>
>
> Le 21/01/2017 ? 04:51, Simon Glass a ?crit :
>> On 17 January 2017 at 02:32, Romain Perier <romain.perier@collabora.com> wrote:
>>> Like the rock2, this board has been tested with back to brom feature.
>>> This commits adjusts environment offset regarding if back_to_brom is
>>> enabled or not and uses this feature by default.
>>>
>>> Signed-off-by: Romain Perier <romain.perier@collabora.com>
>>> ---
>>>  configs/firefly-rk3288_defconfig | 2 ++
>>>  include/configs/firefly-rk3288.h | 9 +++++++++
>>>  2 files changed, 11 insertions(+)
>> We need at least one board that does not use this option. Also,
>> doesn't this mean that we need to change how the image is written to
>> the board?
>>
>> Should we use binman to create a suitable image?
>>
>> Regards,
>> Simon
> Why do you want at least one board without this option ? for testing
> that it's still working without back_to_brom ? That's weird because all
> rk3288-based board has the same limitations regarding the SPL, no ?

Yes, but remember this is a non-standard booting mechanism, and one
that I hope we can move away from in future. Also firefly does not
*need* this mechanism. If we don't have one board that uses the
standard mechanism then it might stop working.

Regards,
Simon

[U-Boot] [PATCH 2/2] rockchip: Enable ETH address randomization for the firefly-rk3288

[Simon Glass]

On 20 January 2017 at 19:51, Simon Glass <sjg@chromium.org> wrote:
> On 17 January 2017 at 02:32, Romain Perier <romain.perier@collabora.com> wrote:
>> This commit enables ethernet MAC address randomization on the
>> firefly-rk3288. It removes the error at startup 'ethernet at ff290000
>> address not set'.
>>
>> Signed-off-by: Romain Perier <romain.perier@collabora.com>
>> ---
>>  configs/firefly-rk3288_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip, thanks!