[PATCH igt 1/2] intel-ci: Do module reload last

[PATCH igt 1/2] intel-ci: Do module reload last

[Chris Wilson]

We want to run the initial set of tests under "pristine startup"
conditions - so that our tests see the hardware as close to the
condition we normally would after booting. This means that we want to
avoid reloading the module until the very last set of tests.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 42042f18..a6b56f35 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -3,9 +3,6 @@ igt@core_prop_blob@basic
 igt@drv_getparams_basic@basic-eu-total
 igt@drv_getparams_basic@basic-subslice-total
 igt@drv_hangman@error-state-basic
-igt@drv_module_reload@basic-reload
-igt@drv_module_reload@basic-reload-inject
-igt@drv_module_reload@basic-reload-final
 igt@gem_basic@bad-close
 igt@gem_basic@create-close
 igt@gem_basic@create-fd-close
@@ -244,3 +241,6 @@ igt@vgem_basic@mmap
 igt@vgem_basic@second-client
 igt@vgem_basic@sysfs
 igt@vgem_basic@unload
+igt@drv_module_reload@basic-reload
+igt@drv_module_reload@basic-reload-inject
+igt@drv_module_reload@basic-reload-final
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH igt 2/2] intel-ci: Add reloading module without any display

[Chris Wilson]

A quick test to exercise one module paramter that should disable a chunk
of code usually run at startup and shutdown.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index a6b56f35..f9beabe5 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -242,5 +242,6 @@ igt@vgem_basic@second-client
 igt@vgem_basic@sysfs
 igt@vgem_basic@unload
 igt@drv_module_reload@basic-reload
+igt@drv_module_reload@basic-no-display
 igt@drv_module_reload@basic-reload-inject
 igt@drv_module_reload@basic-reload-final
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt 2/2] intel-ci: Add reloading module without any display

[Jani Nikula]

On Wed, 18 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> A quick test to exercise one module paramter that should disable a chunk
> of code usually run at startup and shutdown.

Going for test driven development, are we? The BAT test list is not the
place to add tests that will break. We should get tests to be added to
the list passing first.

BR,
Jani.


>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
>  tests/intel-ci/fast-feedback.testlist | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index a6b56f35..f9beabe5 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -242,5 +242,6 @@ igt@vgem_basic@second-client
>  igt@vgem_basic@sysfs
>  igt@vgem_basic@unload
>  igt@drv_module_reload@basic-reload
> +igt@drv_module_reload@basic-no-display
>  igt@drv_module_reload@basic-reload-inject
>  igt@drv_module_reload@basic-reload-final

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt 1/2] intel-ci: Do module reload last

[Petri Latvala]

Thanks for the reminder about this ordering change.

The crash from disable_display use will cause $stuff in CI, its
ability to recover and resume is not quite there yet. But as it's at
the end, we can live with it until a fix lands.

Series is
Acked-by: Petri Latvala <petri.latvala@intel.com>


On Wed, Jan 18, 2017 at 09:58:12AM +0000, Chris Wilson wrote:
> We want to run the initial set of tests under "pristine startup"
> conditions - so that our tests see the hardware as close to the
> condition we normally would after booting. This means that we want to
> avoid reloading the module until the very last set of tests.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
>  tests/intel-ci/fast-feedback.testlist | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 42042f18..a6b56f35 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -3,9 +3,6 @@ igt@core_prop_blob@basic
>  igt@drv_getparams_basic@basic-eu-total
>  igt@drv_getparams_basic@basic-subslice-total
>  igt@drv_hangman@error-state-basic
> -igt@drv_module_reload@basic-reload
> -igt@drv_module_reload@basic-reload-inject
> -igt@drv_module_reload@basic-reload-final
>  igt@gem_basic@bad-close
>  igt@gem_basic@create-close
>  igt@gem_basic@create-fd-close
> @@ -244,3 +241,6 @@ igt@vgem_basic@mmap
>  igt@vgem_basic@second-client
>  igt@vgem_basic@sysfs
>  igt@vgem_basic@unload
> +igt@drv_module_reload@basic-reload
> +igt@drv_module_reload@basic-reload-inject
> +igt@drv_module_reload@basic-reload-final
> -- 
> 2.11.0
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt 2/2] intel-ci: Add reloading module without any display

[Chris Wilson]

On Wed, Jan 18, 2017 at 12:07:17PM +0200, Jani Nikula wrote:
> On Wed, 18 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > A quick test to exercise one module paramter that should disable a chunk
> > of code usually run at startup and shutdown.
> 
> Going for test driven development, are we? The BAT test list is not the
> place to add tests that will break. We should get tests to be added to
> the list passing first.

I think it's a bit late to claim this is test-driven. Just responding to
that a supported parameter has been broken for about 6 months.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt 2/2] intel-ci: Add reloading module without any display

[Jani Nikula]

On Wed, 18 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Jan 18, 2017 at 12:07:17PM +0200, Jani Nikula wrote:
>> On Wed, 18 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > A quick test to exercise one module paramter that should disable a chunk
>> > of code usually run at startup and shutdown.
>> 
>> Going for test driven development, are we? The BAT test list is not the
>> place to add tests that will break. We should get tests to be added to
>> the list passing first.
>
> I think it's a bit late to claim this is test-driven. Just responding to
> that a supported parameter has been broken for about 6 months.

I'm sure there are tons of tests in igt that fail for a bunch of our
supported features. But I thought we were in agreement we would not add
stuff to BAT that fail off the, uh, bat.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt 1/2] intel-ci: Do module reload last

[Chris Wilson]

On Wed, Jan 18, 2017 at 12:14:00PM +0200, Petri Latvala wrote:
> Thanks for the reminder about this ordering change.
> 
> The crash from disable_display use will cause $stuff in CI, its
> ability to recover and resume is not quite there yet. But as it's at
> the end, we can live with it until a fix lands.

I was going to hold off until the fix landed and you were happy with it,
since apparently I'm the only one who likes tests finding bugs.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt 1/2] intel-ci: Do module reload last

[Petri Latvala]

On Wed, Jan 18, 2017 at 10:21:47AM +0000, Chris Wilson wrote:
> On Wed, Jan 18, 2017 at 12:14:00PM +0200, Petri Latvala wrote:
> > Thanks for the reminder about this ordering change.
> > 
> > The crash from disable_display use will cause $stuff in CI, its
> > ability to recover and resume is not quite there yet. But as it's at
> > the end, we can live with it until a fix lands.
> 
> I was going to hold off until the fix landed and you were happy with it,
> since apparently I'm the only one who likes tests finding bugs.


Sure, hold on to 2/2 until a fix lands. That should make more people happy.


--
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx