From: Mel Gorman <mgorman@techsingularity.net>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Ganapatrao Kulkarni <gpkulkarni@gmail.com>,
Michal Hocko <mhocko@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to slowpath
Date: Wed, 18 Jan 2017 10:03:41 +0000 [thread overview]
Message-ID: <20170118100341.liydtsdqovmlgys4@techsingularity.net> (raw)
In-Reply-To: <20170117221610.22505-4-vbabka@suse.cz>
On Tue, Jan 17, 2017 at 11:16:09PM +0100, Vlastimil Babka wrote:
> This is a preparation for the following patch to make review simpler. While
> the primary motivation is a bug fix, this could also save some cycles in the
> fast path.
>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
To be clear, the fast path savings will be when cpusets are active even
though that is still a good thing. Most of the time, they are disabled
static branches. I see there were concerns raised that this would retry
the kswapd paths but I don't really see the issue. The same wakeup could
occur due to a cpuset switch with the existing retry. Even a potentially
spurious wakeup of kswapd is ok if the slow paths were being hit anyway
as kswapd is probably still awake from the first wakeup. If anything,
the fact that kswapd wakeups ignore cpusets and potentially wakes kswapd
on forbidden nodes is more problematic but not worth fixing. If kswapd
needs to wake on a node outside the cpuset then it's going to be by some
active process outside the cpuset some time in the future so;
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Ganapatrao Kulkarni <gpkulkarni@gmail.com>,
Michal Hocko <mhocko@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to slowpath
Date: Wed, 18 Jan 2017 10:03:41 +0000 [thread overview]
Message-ID: <20170118100341.liydtsdqovmlgys4@techsingularity.net> (raw)
In-Reply-To: <20170117221610.22505-4-vbabka@suse.cz>
On Tue, Jan 17, 2017 at 11:16:09PM +0100, Vlastimil Babka wrote:
> This is a preparation for the following patch to make review simpler. While
> the primary motivation is a bug fix, this could also save some cycles in the
> fast path.
>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
To be clear, the fast path savings will be when cpusets are active even
though that is still a good thing. Most of the time, they are disabled
static branches. I see there were concerns raised that this would retry
the kswapd paths but I don't really see the issue. The same wakeup could
occur due to a cpuset switch with the existing retry. Even a potentially
spurious wakeup of kswapd is ok if the slow paths were being hit anyway
as kswapd is probably still awake from the first wakeup. If anything,
the fact that kswapd wakeups ignore cpusets and potentially wakes kswapd
on forbidden nodes is more problematic but not worth fixing. If kswapd
needs to wake on a node outside the cpuset then it's going to be by some
active process outside the cpuset some time in the future so;
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-18 10:04 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 22:16 [RFC 0/4] fix premature OOM due to cpuset races Vlastimil Babka
2017-01-17 22:16 ` Vlastimil Babka
2017-01-17 22:16 ` [RFC 1/4] mm, page_alloc: fix check for NULL preferred_zone Vlastimil Babka
2017-01-17 22:16 ` Vlastimil Babka
2017-01-18 9:31 ` Michal Hocko
2017-01-18 9:31 ` Michal Hocko
2017-01-18 9:45 ` Vlastimil Babka
2017-01-18 9:45 ` Vlastimil Babka
2017-01-18 9:53 ` Michal Hocko
2017-01-18 9:53 ` Michal Hocko
2017-01-18 9:45 ` Mel Gorman
2017-01-18 9:45 ` Mel Gorman
2017-01-17 22:16 ` [RFC 2/4] mm, page_alloc: fix fast-path race with cpuset update or removal Vlastimil Babka
2017-01-17 22:16 ` Vlastimil Babka
2017-01-18 9:34 ` Michal Hocko
2017-01-18 9:34 ` Michal Hocko
2017-01-18 9:46 ` Mel Gorman
2017-01-18 9:46 ` Mel Gorman
2017-01-17 22:16 ` [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to slowpath Vlastimil Babka
2017-01-17 22:16 ` Vlastimil Babka
2017-01-18 7:22 ` Hillf Danton
2017-01-18 7:22 ` Hillf Danton
2017-01-18 9:26 ` Vlastimil Babka
2017-01-18 9:26 ` Vlastimil Babka
2017-01-18 9:40 ` Michal Hocko
2017-01-18 9:40 ` Michal Hocko
2017-01-18 9:48 ` Vlastimil Babka
2017-01-18 9:48 ` Vlastimil Babka
2017-01-18 9:55 ` Michal Hocko
2017-01-18 9:55 ` Michal Hocko
2017-01-18 10:03 ` Mel Gorman [this message]
2017-01-18 10:03 ` Mel Gorman
2017-01-17 22:16 ` [RFC 4/4] mm, page_alloc: fix premature OOM when racing with cpuset mems update Vlastimil Babka
2017-01-17 22:16 ` Vlastimil Babka
2017-01-18 7:12 ` Hillf Danton
2017-01-18 7:12 ` Hillf Danton
2017-01-18 9:32 ` Vlastimil Babka
2017-01-18 9:32 ` Vlastimil Babka
2017-01-18 10:08 ` Mel Gorman
2017-01-18 10:08 ` Mel Gorman
2017-01-18 9:19 ` [RFC 0/4] fix premature OOM due to cpuset races Michal Hocko
2017-01-18 9:19 ` Michal Hocko
2017-01-18 16:20 ` [RFC 5/4] mm, page_alloc: fix premature OOM due to vma mempolicy update Vlastimil Babka
2017-01-18 16:20 ` Vlastimil Babka
2017-01-18 16:23 ` Vlastimil Babka
2017-01-18 16:23 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118100341.liydtsdqovmlgys4@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=gpkulkarni@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.